GNU bug report logs - #40788
28.0.50; Error running timer ‘custom-magic-reset’

Previous Next

Full log

Message #11 received at 40788 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: David PONCE <da_vid <at> orange.fr>
Cc: 40788 <at> debbugs.gnu.org
Subject: Re: bug#40788: 28.0.50; Error running timer ‘custom-magic-reset’
Date: Fri, 24 Apr 2020 13:56:10 +0200

>>>>> On Thu, 23 Apr 2020 19:39:26 +0200 (CEST), David PONCE <da_vid <at> orange.fr> said:

    David> Hello again,
    David> Below is a possible patch that seems to have fixed the issue for me.
    David> But I am not sure the approach is correct 

Rather than defining a new function, you can add an argument to the
existing one. Something like (untested)

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d3d17fda7a..93012b134f 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -2102,11 +2102,12 @@ custom-magic-value-create
 	(insert " "))
       (widget-put widget :children children))))
 
-(defun custom-magic-reset (widget)
+(defun custom-magic-reset (widget &optional buffer)
   "Redraw the :custom-magic property of WIDGET."
-  (let ((magic (widget-get widget :custom-magic)))
-    (when magic
-      (widget-value-set magic (widget-value magic)))))
+  (with-current-buffer (or buffer (current-buffer))
+    (let ((magic (widget-get widget :custom-magic)))
+      (when magic
+        (widget-value-set magic (widget-value magic))))))
 
 ;;; The `custom' Widget.
 
@@ -2217,7 +2218,7 @@ custom-notify
       ;; commands like `M-u' (that work on a region in the buffer)
       ;; will upcase the wrong part of the buffer, since more text has
       ;; been inserted before point.
-      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget)
+      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget (current-buffer))
       (apply 'widget-default-notify widget args))))
 
 (defun custom-redraw (widget)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.