Subject: Re: New package: r-rserve

From: Ricardo Wurmus <[email-masked]>
Date: Thu, 30 Apr 2020 00:31:42 +0200

Hi Eric,

> Please see attached diff for Rserve.

Thank you for this patch!

> +(define-public r-rserve
> +  (package
> +    (name "r-rserve")
> +    (version "1.8-6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri "http://www.rforge.net/Rserve/snapshot/Rserve_1.8-6.tar.gz")

Please use (string-append … version …).

> +       (sha256
> +        (base32
> +         "1imz78wa9rphz9ly1wbz4ahdlzcc9hcfbfgdd2pbnpmipbrpg233"))))

I got a different hash here.  Are we sure this URL is stable?

> +    (propagated-inputs
> +     `(("r" ,r)

This is unusual.  Why should R itself be propagated?

> +       ("r-checkmate" ,r-checkmate)
> +       ("r-mime" ,r-mime)
> +       ("r-jsonlite" ,r-jsonlite)
> +       ("r-knitr" ,r-knitr)
> +       ("r-r6" ,r-r6)
> +       ("r-rcpp" ,r-rcpp)
> +       ("r-uuid" ,r-uuid)))
> +    (inputs `(("openssl" ,openssl)
> +              ("zlib" ,zlib)))
> +    (build-system r-build-system)
> +    (home-page "https://github.com/s-u/Rserve")
> +    (synopsis
> +     "Server providing access to R from many languages and systems")
> +    (description
> +     "Rserve acts as a socket server (TCP/IP or local sockets) which
> +allows binary requests to be sent to R. Every connection has a
> +separate workspace and working directory. Client-side implementations
> +are available for popular languages such as C/C++ and Java, allowing
> +any application to use facilities of R without the need of linking to
> +R code. Rserve supports remote connection, user authentication and
> +file transfer. A simple R client is included in this package as
> +well.")

Please use two spaces after each sentence.

Attached is an updated version of your patch.

-- 
Ricardo

>From 747c18d32f2469757cd9ddf75f9cc56b1fb371dc Mon Sep 17 00:00:00 2001
From: Eric Brown <[email-masked]>
Date: Wed, 22 Apr 2020 06:04:59 -0500
Subject: [PATCH] gnu: Add r-rserve.

* gnu/packages/cran.scm (r-rserve): New variable.

Signed-off-by: Ricardo Wurmus <[email-masked]>
---
 gnu/packages/cran.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index baf1e0c18a..18829537e8 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -21633,3 +21633,40 @@ infinite-precision rational arithmetic.")
 Archive Toolkit.  Rxnat uses the XNAT REST API to perform data queries and
 download images.")
     (license license:gpl2)))
+
+(define-public r-rserve
+  (package
+    (name "r-rserve")
+    (version "1.8-6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.rforge.net/Rserve/snapshot/Rserve_"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "017kkzv9lxlz9qhg3gprrf1wcyflxrif6wjk27x9b4bdzylw6bsx"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-checkmate" ,r-checkmate)
+       ("r-mime" ,r-mime)
+       ("r-jsonlite" ,r-jsonlite)
+       ("r-knitr" ,r-knitr)
+       ("r-r6" ,r-r6)
+       ("r-rcpp" ,r-rcpp)
+       ("r-uuid" ,r-uuid)))
+    (inputs
+     `(("openssl" ,openssl)
+       ("zlib" ,zlib)))
+    (home-page "https://github.com/s-u/Rserve")
+    (synopsis
+     "Server providing access to R from many languages and systems")
+    (description
+     "Rserve acts as a socket server (TCP/IP or local sockets) which allows
+binary requests to be sent to R.  Every connection has a separate workspace
+and working directory.  Client-side implementations are available for popular
+languages such as C/C++ and Java, allowing any application to use facilities
+of R without the need of linking to R code.  Rserve supports remote
+connection, user authentication and file transfer.  A simple R client is
+included in this package as well.")
+    (license license:gpl2)))
-- 
2.25.1