GNU bug report logs - #40759
26.3; Update Leuven-theme in Emacs dev trunk

Previous Next

Package: emacs;

Reported by: Fab Rice <posh18 <at> pirilampo.be>

Date: Wed, 22 Apr 2020 05:55:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 40759 <at> debbugs.gnu.org, posh18 <at> pirilampo.be, monnier <at> iro.umontreal.ca, egrep <at> protonmail.ch, dgutov <at> yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Mon, 04 May 2020 17:58:24 +0300
> From: Stefan Kangas <stefan <at> marxist.se>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Fab Rice <posh18 <at> pirilampo.be>,
>   40759 <at> debbugs.gnu.org,  Stefan Monnier <monnier <at> iro.umontreal.ca>,
>   egrep <at> protonmail.ch
> Date: Mon, 04 May 2020 14:35:34 +0200
> 
> > I don't think it's a major problem, personally: these variables serve a purpose,
> > and they don't hurt anybody by remaining defined.
> >
> > Same with functions.
> 
> I agree with that conclusion, too.  I think it's fine that a theme
> does this.  Maybe we could file a wishlist level request to add the
> makunbound functionality if we think it's worth working on.
> 
> Is there anything left to discuss, or should I go ahead and push this?
> 
> Also, I think we would need Eli to decide if this should go to
> emacs-27 or master.  Thanks.

Frankly, I'm a bit afraid that such a significant deviation from the
practice of themes should be added to the release branch now.
Stefan's opinion notwithstanding, there can always be something we are
overlooking.




This bug report was last modified 4 years and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.