GNU bug report logs - #40759
26.3; Update Leuven-theme in Emacs dev trunk

Previous Next

Package: emacs;

Reported by: Fab Rice <posh18 <at> pirilampo.be>

Date: Wed, 22 Apr 2020 05:55:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: Fab Rice <posh18 <at> pirilampo.be>
Cc: 40759 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, dgutov <at> yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Thu, 23 Apr 2020 20:47:37 +0200

Fab Rice <posh18 <at> pirilampo.be> writes:

> BTW, could this go to the "emacs-27" branch, please?

I think the emacs-27 branch is closed for anything that is not
urgent.  Eli, what do you think?

A few more nitpicks:

> +(defcustom leuven-scale-org-agenda-structure t
> +  "Scale Org agenda structure lines, like dates.
> +This can be nil for unscaled, t for using the theme default, or a scaling number."

The last line should be reformatted to less than 80 characters, see:
(info "(elisp) Documentation Tips")

> +  :group 'leuven)

You don't need ":group 'leuven" here since it defaults to the previous
defgroup.

Best regards,
Stefan Kangas
This bug report was last modified 4 years and 288 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.