From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 21 22:05:30 2020 Received: (at submit) by debbugs.gnu.org; 22 Apr 2020 02:05:30 +0000 Received: from localhost ([127.0.0.1]:51008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR4lV-0003l4-9n for submit@debbugs.gnu.org; Tue, 21 Apr 2020 22:05:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:49223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR3bt-0001z6-Nk for submit@debbugs.gnu.org; Tue, 21 Apr 2020 20:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR3br-0004ec-He for guix-patches@gnu.org; Tue, 21 Apr 2020 20:51:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jR3bn-0005Bp-5n for guix-patches@gnu.org; Tue, 21 Apr 2020 20:51:26 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:61739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jR3bk-0004uI-03 for guix-patches@gnu.org; Tue, 21 Apr 2020 20:51:21 -0400 Date: Wed, 22 Apr 2020 00:51:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1587516674; bh=y1HIOSzRaOXpDpWpiHUKL0Y2rogbheHLCK2KZGlui4o=; h=Date:To:From:Reply-To:Subject:From; b=iQdj5MCVl+yeUV0KwevkngWAnQDQnUU6F82IkpkXjt6FybEmnW3nmbnkwkIXDoVCj UBWuahb3Foo/gfw5SEu+0MLn5ofsQCYJcSiOfGbiTL3G5PVANB98Q4XYxqKQ4YJZpN AwMhv16agBorFZVQvv8MKX5u5FEy/RtpzNQpuBuY= To: "guix-patches@gnu.org" From: Ryan Prior Subject: New package: VisiData Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_72476412513947347ac08237b0192dcc" Received-SPF: pass client-ip=185.70.40.18; envelope-from=rprior@protonmail.com; helo=mail1.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/21 20:51:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.18 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Guix! This patch adds a package for VisiData. VisiData is an interactive multitool for tabular data. It combines the clarity of a spreadsheet, the efficiency of the terminal, and the power of Python, into a lightweight utility which can handle mi [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: circleci.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rprior[at]protonmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 21 Apr 2020 22:05:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ryan Prior Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --b1_72476412513947347ac08237b0192dcc Content-Type: multipart/alternative; boundary="b2_72476412513947347ac08237b0192dcc" --b2_72476412513947347ac08237b0192dcc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 SGkgR3VpeCEgVGhpcyBwYXRjaCBhZGRzIGEgcGFja2FnZSBmb3IgVmlzaURhdGEuCgpWaXNpRGF0 YSBpcyBhbiBpbnRlcmFjdGl2ZSBtdWx0aXRvb2wgZm9yIHRhYnVsYXIgZGF0YS4gSXQgY29tYmlu ZXMgdGhlIGNsYXJpdHkgb2YgYSBzcHJlYWRzaGVldCwgdGhlIGVmZmljaWVuY3kgb2YgdGhlIHRl cm1pbmFsLCBhbmQgdGhlIHBvd2VyIG9mIFB5dGhvbiwgaW50byBhIGxpZ2h0d2VpZ2h0IHV0aWxp dHkgd2hpY2ggY2FuIGhhbmRsZSBtaWxsaW9ucyBvZiByb3dzIHdpdGggZWFzZS4gaHR0cHM6Ly93 d3cudmlzaWRhdGEub3JnLywgR1BMdjMKClRlc3RzIGFyZSBkaXNhYmxlZCBiZWNhdXNlIHRoZXkg YXJlIG5vdCBwYWNrYWdlZCB3aXRoIHRoZSBzb3VyY2UgdGFyYmFsbC4KWW91IGNhbiB2aWV3IHRl c3Qgc3RhdHVzIGhlcmU6IGh0dHBzOi8vY2lyY2xlY2kuY29tL2doL3NhdWxwdy92aXNpZGF0YS90 cmVlL3N0YWJsZQpVcHN0cmVhbSBzdWdnZXN0cyB0ZXN0cyB3aWxsIGJlIHBhY2thZ2VkIHdpdGgg dGhlaXIgc291cmNlIHRhcmJhbGwgYXJvdW5kIHRoZWlyIDIuMCByZWxlYXNlLgoKQ2hlZXJzLApS eWFuIFByaW9y --b2_72476412513947347ac08237b0192dcc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj5IaSBHdWl4ISBUaGlzIHBhdGNoIGFkZHMgYSBwYWNrYWdlIGZvciBWaXNpRGF0YS48YnI+ PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5WaXNpRGF0YSBpcyBhbiBpbnRlcmFjdGl2ZSBtdWx0 aXRvb2wgZm9yIHRhYnVsYXIgZGF0YS4gSXQgY29tYmluZXMgdGhlIGNsYXJpdHkgb2YgYSBzcHJl YWRzaGVldCwgdGhlIGVmZmljaWVuY3kgb2YgdGhlIHRlcm1pbmFsLCBhbmQgdGhlIHBvd2VyIG9m IFB5dGhvbiwgaW50byBhIGxpZ2h0d2VpZ2h0IHV0aWxpdHkgd2hpY2ggY2FuIGhhbmRsZSBtaWxs aW9ucyBvZiByb3dzIHdpdGggZWFzZS4gPGEgaHJlZj0iaHR0cHM6Ly93d3cudmlzaWRhdGEub3Jn LyI+aHR0cHM6Ly93d3cudmlzaWRhdGEub3JnLzwvYT4sIEdQTHYzPGJyPjwvZGl2PjxkaXY+PGJy PjwvZGl2PjxkaXY+VGVzdHMgYXJlIGRpc2FibGVkIGJlY2F1c2UgdGhleSBhcmUgbm90IHBhY2th Z2VkIHdpdGggdGhlIHNvdXJjZSB0YXJiYWxsLjxicj48L2Rpdj48ZGl2PllvdSBjYW4gdmlldyB0 ZXN0IHN0YXR1cyBoZXJlOiA8YSBocmVmPSJodHRwczovL2NpcmNsZWNpLmNvbS9naC9zYXVscHcv dmlzaWRhdGEvdHJlZS9zdGFibGUiPmh0dHBzOi8vY2lyY2xlY2kuY29tL2doL3NhdWxwdy92aXNp ZGF0YS90cmVlL3N0YWJsZTwvYT48YnI+PC9kaXY+PGRpdj5VcHN0cmVhbSBzdWdnZXN0cyB0ZXN0 cyB3aWxsIGJlIHBhY2thZ2VkIHdpdGggdGhlaXIgc291cmNlIHRhcmJhbGwgYXJvdW5kIHRoZWly IDIuMCByZWxlYXNlLjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PkNoZWVycyw8YnI+PC9k aXY+PGRpdj5SeWFuIFByaW9yPGJyPjwvZGl2Pg== --b2_72476412513947347ac08237b0192dcc-- --b1_72476412513947347ac08237b0192dcc Content-Type: text/x-patch; name="0001-gnu-Add-visidata.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-visidata.patch RnJvbSBhODZlMDAyY2QxMzMzNzFlYWZiZDFhZGJmMTM1NGFmZDM3OTZjOWViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIFByaW9yIDxycHJpb3JAcHJvdG9ubWFpbC5jb20+CkRh dGU6IFR1ZSwgMjEgQXByIDIwMjAgMTY6NTY6NDIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBnbnU6 IEFkZCB2aXNpZGF0YS4KCiogZ251L3BhY2thZ2VzL3Zpc2lkYXRhLnNjbSAodmlzaWRhdGEpOiBO ZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3Zpc2lkYXRhLnNjbSB8IDYxICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYxIGluc2Vy dGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnbnUvcGFja2FnZXMvdmlzaWRhdGEuc2NtCgpk aWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3Zpc2lkYXRhLnNjbSBiL2dudS9wYWNrYWdlcy92aXNp ZGF0YS5zY20KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uZDlkZjk0ZGM5 YgotLS0gL2Rldi9udWxsCisrKyBiL2dudS9wYWNrYWdlcy92aXNpZGF0YS5zY20KQEAgLTAsMCAr MSw2MSBAQAorOzs7IEdOVSBHdWl4IC0tLSBGdW5jdGlvbmFsIHBhY2thZ2UgbWFuYWdlbWVudCBm b3IgR05VCis7OzsgQ29weXJpZ2h0IMKpIDIwMjAgUnlhbiBQcmlvciA8cnByaW9yQHByb3Rvbm1h aWwuY29tPgorOzs7Cis7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCis7OzsKKzs7 OyBHTlUgR3VpeCBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IgbW9kaWZ5IGl0Cis7OzsgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0cmlidXRl ZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQKKzs7OyBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OzsgTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo ZQorOzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCis7OzsK Kzs7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZQorOzs7IGFsb25nIHdpdGggR05VIEd1aXguICBJZiBub3QsIHNlZSA8aHR0 cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKyhkZWZpbmUtbW9kdWxlICh2aXNpZGF0YSkK KyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZGF0YWJhc2VzKQorICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBweXRob24tc2NpZW5jZSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgcHl0aG9uLXdlYikKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcHl0aG9uLXh5eikK KyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGltZSkKKyAgIzp1c2UtbW9kdWxlIChnbnUg cGFja2FnZXMgeG1sKQorICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIHB5dGhvbikK KyAgIzp1c2UtbW9kdWxlIChndWl4IGRvd25sb2FkKQorICAjOnVzZS1tb2R1bGUgKGd1aXggbGlj ZW5zZXMpCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBwYWNrYWdlcykpCisKKyhkZWZpbmUtcHVibGlj IHZpc2lkYXRhCisgIChwYWNrYWdlCisgICAobmFtZSAidmlzaWRhdGEiKQorICAgKHZlcnNpb24g IjEuNS4yIikKKyAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgKG1ldGhvZCB1cmwtZmV0 Y2gpCisgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20v c2F1bHB3L3Zpc2lkYXRhL2FyY2hpdmUvdiIgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgICAg ICAgKHNoYTI1NiAoYmFzZTMyICIwaDdocTZibmM4c3ZrY2M5OTk1a2ttZ2NiOW41cWdtODVyc3No enpkaWNtZzlyZzN5bWhpIikpKSkKKyAgIChidWlsZC1zeXN0ZW0gcHl0aG9uLWJ1aWxkLXN5c3Rl bSkKKyAgIChhcmd1bWVudHMgJygjOnRlc3RzPyAjZikpCisgICA7OyBUZXN0cyBkaXNhYmxlZCBi ZWNhdXNlIHRoZXkgYXJlIG5vdCBwYWNrYWdlZCB3aXRoIHRoZSBzb3VyY2UgdGFyYmFsbC4KKyAg IDs7IFZpZXcgdGVzdCBzdGF0dXMgaGVyZTogaHR0cHM6Ly9jaXJjbGVjaS5jb20vZ2gvc2F1bHB3 L3Zpc2lkYXRhL3RyZWUvc3RhYmxlCisgICA7OyBVcHN0cmVhbSBzdWdnZXN0cyB0ZXN0cyB3aWxs IGJlIHBhY2thZ2VkIHdpdGggdGFyYmFsbCBhcm91bmQgMi4wIHJlbGVhc2UuCisgICAobmF0aXZl LWlucHV0cworICAgIGAoKCJweXRob24tZGF0ZXV0aWwiICxweXRob24tZGF0ZXV0aWwpCisgICAg ICAoInB5dGhvbi1mb250dG9vbHMiICxweXRob24tZm9udHRvb2xzKQorICAgICAgKCJweXRob24t aDVweSIgLHB5dGhvbi1oNXB5KQorICAgICAgKCJweXRob24tbHhtbCIgLHB5dGhvbi1seG1sKQor ICAgICAgKCJweXRob24tb3BlbnB5eGwiICxweXRob24tb3BlbnB5eGwpCisgICAgICAoInB5dGhv bi1wc3ljb3BnMiIgLHB5dGhvbi1wc3ljb3BnMikKKyAgICAgICgicHl0aG9uLXB5eWFtbCIgLHB5 dGhvbi1weXlhbWwpCisgICAgICAoInB5dGhvbi1yZXF1ZXN0cyIgLHB5dGhvbi1yZXF1ZXN0cykK KyAgICAgICgicHl0aG9uLXhscmQiICxweXRob24teGxyZCkKKyAgICAgICgicHl0aG9uLXBhbmRh cyIgLHB5dGhvbi1wYW5kYXMpKSkKKyAgIChzeW5vcHNpcyAiVmlzaWRhdGE6IEEgdGVybWluYWwg c3ByZWFkc2hlZXQgbXVsdGl0b29sIGZvciBkaXNjb3ZlcmluZyBhbmQgYXJyYW5naW5nIGRhdGEi KQorICAgKGRlc2NyaXB0aW9uCisgICAgIlZpc2lEYXRhIGlzIGFuIGludGVyYWN0aXZlIG11bHRp dG9vbCBmb3IgdGFidWxhciBkYXRhLiBJdCBjb21iaW5lcyB0aGUKK2NsYXJpdHkgb2YgYSBzcHJl YWRzaGVldCwgdGhlIGVmZmljaWVuY3kgb2YgdGhlIHRlcm1pbmFsLCBhbmQgdGhlIHBvd2VyIG9m CitQeXRob24sIGludG8gYSBsaWdodHdlaWdodCB1dGlsaXR5IHdoaWNoIGNhbiBoYW5kbGUgbWls bGlvbnMgb2Ygcm93cyB3aXRoIGVhc2UuIikKKyAgIChob21lLXBhZ2UgImh0dHBzOi8vd3d3LnZp c2lkYXRhLm9yZy8iKQorICAgKGxpY2Vuc2UgZ3BsMykpKQotLSAKMi4xNy4xCgo= --b1_72476412513947347ac08237b0192dcc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 11:53:32 2020 Received: (at 40757) by debbugs.gnu.org; 22 Apr 2020 15:53:32 +0000 Received: from localhost ([127.0.0.1]:52988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRHgm-0004Mt-TU for submit@debbugs.gnu.org; Wed, 22 Apr 2020 11:53:32 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:44592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRHgi-0004MX-FW for 40757@debbugs.gnu.org; Wed, 22 Apr 2020 11:53:27 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRHgc-0004BK-Ew; Wed, 22 Apr 2020 11:53:18 -0400 Date: Wed, 22 Apr 2020 11:53:18 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Ryan Prior Subject: Re: [bug#40757] New package: VisiData In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40757 Cc: 40757@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ryan, On Wed, 22 Apr 2020, Ryan Prior via Guix-patches via wrote: > Hi Guix! This patch adds a package for VisiData. > > VisiData is an interactive multitool for tabular data. It combines the clarity of a > spreadsheet, the efficiency of the terminal, and the power of Python, into a > lightweight utility which can handle millions of rows with ease. > https://www.visidata.org/, GPLv3 Thanks for the patch! This looks like some cool software. I'm not an expert reviewer, but I'd like to try to help by offering the following suggestions for improvement. >diff --git a/gnu/packages/visidata.scm b/gnu/packages/visidata.scm >new file mode 100644 >index 0000000000..d9df94dc9b >--- /dev/null >+++ b/gnu/packages/visidata.scm When adding new modules, please also add the file to gnu/local.mk >+(define-module (visidata) The module name should be (gnu packages visidata) to match the filesystem path. It might be helpful to catch problems like this to try to apply your patch apply your patch to a guix source checkout, and try building your package from there. The manual has some documentation about that, , but I can answer questions as well. >+(define-public visidata >+ (package >+ (name "visidata") >+ (version "1.5.2") >+ (source (origin >+ (method url-fetch) >+ (uri (string-append "https://github.com/saulpw/visidata/archive/v" version ".tar.gz")) The GitHub archive URIs are not stable and could result in a different hash in the future. Often in these cases we use git-fetch, but since visidata is available on pypi, I would recommend (uri (pypi-uri "visidata" version)) >+ (sha256 (base32 "0h7hq6bnc8svkcc9995kkmgcb9n5qgm85rsshzzdicmg9rg3ymhi")))) >+ (build-system python-build-system) >+ (arguments '(#:tests? #f)) >+ ;; Tests disabled because they are not packaged with the source tarball. >+ ;; View test status here: https://circleci.com/gh/saulpw/visidata/tree/stable >+ ;; Upstream suggests tests will be packaged with tarball around 2.0 release. Nitpick: I would prefer to have the comment before the code. I think the line about circleci could be removed, but the other two seem good. >+ (native-inputs >+ `(("python-dateutil" ,python-dateutil) >+ ("python-fonttools" ,python-fonttools) >+ ("python-h5py" ,python-h5py) >+ ("python-lxml" ,python-lxml) >+ ("python-openpyxl" ,python-openpyxl) >+ ("python-psycopg2" ,python-psycopg2) >+ ("python-pyyaml" ,python-pyyaml) >+ ("python-requests" ,python-requests) >+ ("python-xlrd" ,python-xlrd) >+ ("python-pandas" ,python-pandas))) Are these all native inputs (required to make the build system run)? I expect that some of them could be moved to inputs (run-tine dependencies). >+ (synopsis "Visidata: A terminal spreadsheet multitool for discovering and arranging data") guix lint reports that the synopsis should not start with the package name. In this case, I think it could be changed to, "Terminal spreadsheet for discovering and arranging data". >+ (description >+ "VisiData is an interactive multitool for tabular data. It combines the Please use two spaces between sentences in the description. >+clarity of a spreadsheet, the efficiency of the terminal, and the power of >+Python, into a lightweight utility which can handle millions of rows with ease.") Nitpick: "with ease" sounds like a marketing term, and I believe we can leave it out here. >+ (home-page "https://www.visidata.org/") >+ (license gpl3))) In other modules, we import licenses with the license: prefix, so we can refer to licenses as like license:gpl3. It might be nice to do that here for consistency as well. The vdtui.py file is under the expat license, so we should record that here. With these changes the license field would become something like: (license (list license:gpl3 license:expat)) ; visidata/vdtui.py Thanks and all the best, Jack From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 16:55:27 2020 Received: (at 40757) by debbugs.gnu.org; 22 Apr 2020 20:55:27 +0000 Received: from localhost ([127.0.0.1]:53424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRMOy-0008Bq-7B for submit@debbugs.gnu.org; Wed, 22 Apr 2020 16:55:27 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:16971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRLvE-0007QO-7i for 40757@debbugs.gnu.org; Wed, 22 Apr 2020 16:24:43 -0400 Date: Wed, 22 Apr 2020 20:24:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1587587072; bh=TAduBbTfN3VsJfvZMn1q4K0LKAtjGqMaypbN2qVJC8Y=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Qu8k9BleNMr1N5yKXJrlTmzlC6KeBuCYospWuO14rROqceQXnp86oaeivdrBgsEXD +eYzNcig3w83GTr+wzxiOSAMC1iC22VzBYAvCZY2DJmyZEChFnoYilR77bQB/huSQb aMnhMH6RLmIT5MngqzrDq8NPNIfuC3YwdUeOGh0s= To: Jack Hill From: Ryan Prior Subject: Re: [bug#40757] New package: VisiData Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_b5c578feec0687136cb5da514b49ab11" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Jack, ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, April 22, 2020 3:53 PM, Jack Hill wrote: > I'm not an expert reviewer, but I'd like to try to help by offering the > following suggestions for improvement. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [185.70.40.18 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [185.70.40.18 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: nixo.xyz (xyz)] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rprior[at]protonmail.com) -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 40757 X-Mailman-Approved-At: Wed, 22 Apr 2020 16:55:22 -0400 Cc: "40757@debbugs.gnu.org" <40757@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ryan Prior Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) This is a multi-part message in MIME format. --b1_b5c578feec0687136cb5da514b49ab11 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jack, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Wednesday, April 22, 2020 3:53 PM, Jack Hill wrot= e: > I'm not an expert reviewer, but I'd like to try to help by offering the > following suggestions for improvement. Thank you for these suggestions! I've attached an updated version of the pa= tch. Ryan --b1_b5c578feec0687136cb5da514b49ab11 Content-Type: text/x-patch; name="0001-gnu-Add-visidata.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-visidata.patch RnJvbSA1NjQ5ZWMyMjA5NzI3ODE5MzQyNjQ3NGI5YTJmNDYwY2MzYTkzMWUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIFByaW9yIDxycHJpb3JAcHJvdG9ubWFpbC5jb20+CkRh dGU6IFR1ZSwgMjEgQXByIDIwMjAgMTY6NTY6NDIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBnbnU6 IEFkZCB2aXNpZGF0YS4KCiogZ251L3BhY2thZ2VzL3Zpc2lkYXRhLnNjbSAodmlzaWRhdGEpOiBO ZXcgdmFyaWFibGUuCi0tLQogZ251L2xvY2FsLm1rICAgICAgICAgICAgICB8ICAyICsrCiBnbnUv cGFja2FnZXMvdmlzaWRhdGEuc2NtIHwgNjEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2Rl IDEwMDY0NCBnbnUvcGFja2FnZXMvdmlzaWRhdGEuc2NtCgpkaWZmIC0tZ2l0IGEvZ251L2xvY2Fs Lm1rIGIvZ251L2xvY2FsLm1rCmluZGV4IGU3MDcxNTAwMGEuLjBjZjY0MDYzYzggMTAwNjQ0Ci0t LSBhL2dudS9sb2NhbC5taworKysgYi9nbnUvbG9jYWwubWsKQEAgLTMxLDYgKzMxLDcgQEAKICMg Q29weXJpZ2h0IMKpIDIwMjAgUiBWZWVyYSBLdW1hciA8dmtvckB2a3Rlbi5pbj4KICMgQ29weXJp Z2h0IMKpIDIwMjAgTmljb2zDsiBCYWx6YXJvdHRpIDxuaWNvbG9Abml4by54eXo+CiAjIENvcHly aWdodCDCqSAyMDIwIE1pY2hhZWwgUm9obGVkZXIgPG1pa2VAcm9obGVkZXIuZGU+CisjIENvcHly aWdodCDCqSAyMDIwIFJ5YW4gUHJpb3IgPHJwcmlvckBwcm90b25tYWlsLmNvbT4KICMKICMgVGhp cyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiAjCkBAIC01MjEsNiArNTIyLDcgQEAgR05VX1NZ U1RFTV9NT0RVTEVTID0JCQkJXAogICAlRCUvcGFja2FnZXMvdmlkZW8uc2NtCQkJXAogICAlRCUv cGFja2FnZXMvdmltLnNjbQkJCQlcCiAgICVEJS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20J CVwKKyAgJUQlL3BhY2thZ2VzL3Zpc2lkYXRhLnNjbSAgICAgICAgICAgICAgICAgICAgIFwKICAg JUQlL3BhY2thZ2VzL3ZuYy5zY20JCQkJXAogICAlRCUvcGFja2FnZXMvdnBuLnNjbQkJCQlcCiAg ICVEJS9wYWNrYWdlcy92dWxrYW4uc2NtCQkJXApkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3Zp c2lkYXRhLnNjbSBiL2dudS9wYWNrYWdlcy92aXNpZGF0YS5zY20KbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMC4uOTY0N2I0OTI4OQotLS0gL2Rldi9udWxsCisrKyBiL2dudS9w YWNrYWdlcy92aXNpZGF0YS5zY20KQEAgLTAsMCArMSw2MSBAQAorOzs7IEdOVSBHdWl4IC0tLSBG dW5jdGlvbmFsIHBhY2thZ2UgbWFuYWdlbWVudCBmb3IgR05VCis7OzsgQ29weXJpZ2h0IMKpIDIw MjAgUnlhbiBQcmlvciA8cnByaW9yQHByb3Rvbm1haWwuY29tPgorOzs7Cis7OzsgVGhpcyBmaWxl IGlzIHBhcnQgb2YgR05VIEd1aXguCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5IGl0Cis7OzsgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkK Kzs7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRo ZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCis7 OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwg YmUgdXNlZnVsLCBidXQKKzs7OyBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9S IEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCis7OzsKKzs7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2 ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorOzs7IGFsb25nIHdp dGggR05VIEd1aXguICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4u CisKKyhkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMgdmlzaWRhdGEpCisgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGRhdGFiYXNlcykKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMg cHl0aG9uLXNjaWVuY2UpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbi13ZWIp CisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbi14eXopCisgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIHRpbWUpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHhtbCkK KyAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBweXRob24pCisgICM6dXNlLW1vZHVs ZSAoZ3VpeCBkb3dubG9hZCkKKyAgIzp1c2UtbW9kdWxlICgoZ3VpeCBsaWNlbnNlcykgIzpwcmVm aXggbGljZW5zZTopCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBwYWNrYWdlcykpCisKKyhkZWZpbmUt cHVibGljIHZpc2lkYXRhCisgIChwYWNrYWdlCisgICAobmFtZSAidmlzaWRhdGEiKQorICAgKHZl cnNpb24gIjEuNS4yIikKKyAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgKG1ldGhvZCB1 cmwtZmV0Y2gpCisgICAgICAgICAgICAodXJpIChweXBpLXVyaSAidmlzaWRhdGEiIHZlcnNpb24p KQorICAgICAgICAgICAgKHNoYTI1NiAoYmFzZTMyICIxMGFkZnluNGdraXN2Y2lxYXdnaDJsYWtr aGhuamp4aXlwN216Ymdjd2txMWIzc2lncGYxIikpKSkKKyAgIChidWlsZC1zeXN0ZW0gcHl0aG9u LWJ1aWxkLXN5c3RlbSkKKyAgIDs7IFRlc3RzIGRpc2FibGVkIGJlY2F1c2UgdGhleSBhcmUgbm90 IHBhY2thZ2VkIHdpdGggdGhlIHNvdXJjZSB0YXJiYWxsLgorICAgOzsgVXBzdHJlYW0gc3VnZ2Vz dHMgdGVzdHMgd2lsbCBiZSBwYWNrYWdlZCB3aXRoIHRhcmJhbGwgYXJvdW5kIDIuMCByZWxlYXNl LgorICAgKGFyZ3VtZW50cyAnKCM6dGVzdHM/ICNmKSkKKyAgIChpbnB1dHMKKyAgICBgKCgicHl0 aG9uLWRhdGV1dGlsIiAscHl0aG9uLWRhdGV1dGlsKQorICAgICAgKCJweXRob24tZm9udHRvb2xz IiAscHl0aG9uLWZvbnR0b29scykKKyAgICAgICgicHl0aG9uLWg1cHkiICxweXRob24taDVweSkK KyAgICAgICgicHl0aG9uLWx4bWwiICxweXRob24tbHhtbCkKKyAgICAgICgicHl0aG9uLW9wZW5w eXhsIiAscHl0aG9uLW9wZW5weXhsKQorICAgICAgKCJweXRob24tcHN5Y29wZzIiICxweXRob24t cHN5Y29wZzIpCisgICAgICAoInB5dGhvbi1weXlhbWwiICxweXRob24tcHl5YW1sKQorICAgICAg KCJweXRob24tcmVxdWVzdHMiICxweXRob24tcmVxdWVzdHMpCisgICAgICAoInB5dGhvbi14bHJk IiAscHl0aG9uLXhscmQpCisgICAgICAoInB5dGhvbi1wYW5kYXMiICxweXRob24tcGFuZGFzKSkp CisgICAoc3lub3BzaXMgIlRlcm1pbmFsIHNwcmVhZHNoZWV0IG11bHRpdG9vbCBmb3IgZGlzY292 ZXJpbmcgYW5kIGFycmFuZ2luZyBkYXRhIikKKyAgIChkZXNjcmlwdGlvbgorICAgICJWaXNpRGF0 YSBpcyBhbiBpbnRlcmFjdGl2ZSBtdWx0aXRvb2wgZm9yIHRhYnVsYXIgZGF0YS4gIEl0IGNvbWJp bmVzIHRoZQorY2xhcml0eSBvZiBhIHNwcmVhZHNoZWV0LCB0aGUgZWZmaWNpZW5jeSBvZiB0aGUg dGVybWluYWwsIGFuZCB0aGUgcG93ZXIgb2YKK1B5dGhvbiwgaW50byBhIGxpZ2h0d2VpZ2h0IHV0 aWxpdHkgd2hpY2ggY2FuIGhhbmRsZSBtaWxsaW9ucyBvZiByb3dzLiIpCisgICAoaG9tZS1wYWdl ICJodHRwczovL3d3dy52aXNpZGF0YS5vcmcvIikKKyAgIChsaWNlbnNlIChsaXN0IGxpY2Vuc2U6 Z3BsMworICAgICAgICAgICAgICAgICAgbGljZW5zZTpleHBhdCkpKSkgOzsgdmlzaWRhdGEvdmR0 dWkucHkKLS0gCjIuMTcuMQoK --b1_b5c578feec0687136cb5da514b49ab11-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 17:03:11 2020 Received: (at 40757) by debbugs.gnu.org; 22 Apr 2020 21:03:11 +0000 Received: from localhost ([127.0.0.1]:53435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRMWV-0008QE-JE for submit@debbugs.gnu.org; Wed, 22 Apr 2020 17:03:11 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:47604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRMWT-0008Pz-Bq for 40757@debbugs.gnu.org; Wed, 22 Apr 2020 17:03:09 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRMWN-0001kD-FP; Wed, 22 Apr 2020 17:03:03 -0400 Date: Wed, 22 Apr 2020 17:03:00 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Ryan Prior Subject: Re: [bug#40757] New package: VisiData In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="925712948-2080551414-1587589383=:5735" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40757 Cc: "40757@debbugs.gnu.org" <40757@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-2080551414-1587589383=:5735 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 22 Apr 2020, Ryan Prior via Guix-patches via wrote: > Hi Jack, > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Wednesday, April 22, 2020 3:53 PM, Jack Hill wrote: > > >> I'm not an expert reviewer, but I'd like to try to help by offering the >> following suggestions for improvement. > > Thank you for these suggestions! I've attached an updated version of the patch. You're welcome, and thanks for sending the updated patch. I think now we're waiting on a more experienced reviewer to see if I missed anything, and if it looks good a committer to push your patch. Best, Jack --925712948-2080551414-1587589383=:5735-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 01:24:27 2020 Received: (at submit) by debbugs.gnu.org; 23 Apr 2020 05:24:27 +0000 Received: from localhost ([127.0.0.1]:53825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRULa-00049J-Tk for submit@debbugs.gnu.org; Thu, 23 Apr 2020 01:24:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:47734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRULa-000497-5R for submit@debbugs.gnu.org; Thu, 23 Apr 2020 01:24:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRULZ-0002VS-Nr for guix-patches@gnu.org; Thu, 23 Apr 2020 01:24:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRULX-0000wl-Fp for guix-patches@gnu.org; Thu, 23 Apr 2020 01:24:25 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jRULW-0000pY-PZ for guix-patches@gnu.org; Thu, 23 Apr 2020 01:24:23 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1587619447; cv=none; d=zohomail.com; s=zohoarc; b=SIGZFNW9yykFN2Ds4IQV6ZUYn6oK/llC70NljdVCq4+fpXtcDCy/J6IVuLFXaMnsH5cHaRjqSaT/ntXSogOjPrQCiDnQjUSq0cnHVvoAg9IAgQPxO02MFTYJQHMzN3h4LyPQAsngzWLs9hAVvVnhrnl10MxOTOIPjfY0zBtWZgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587619447; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Sir1QjJtkmu1xZCyYJuWhBedoH2Zxm/G986+ISoG3Ho=; b=R9UDAP+51cBU5Hbq+3xV0lNtNd3HnPn2G8L7TsnonKCHAYrBla3F6Z5nb1LdOm5J5h7Yc5AnaJJu8f7CEUBRtnKUY2goCJf7epjbcBb/vJMCkEA7Z8wcRy6GvrtMuGlKPhBJzIDEWvD9FPim/Mx0lg2+uiSo6aCnZXctxCBUxlo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1587619447; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Sir1QjJtkmu1xZCyYJuWhBedoH2Zxm/G986+ISoG3Ho=; b=frOfSViD7X2KZLkywRFjWI9O6+t1D02pbSi44ooQCJ+PECKvZy+S0cGCBbKAdWYR OHzAYg2PaDUyUJJQW8PlGYNcBHmnQ3mIr04F44bX+FfUkrQtk/BuFkg/B49cgkmxITP YkgB5GYooOWwGHfpwiqcXToCXcbyoD4TVD5Bm0fA= Received: from localhost (p54AD4E51.dip0.t-ipconnect.de [84.173.78.81]) by mx.zohomail.com with SMTPS id 1587619446078767.5673561919601; Wed, 22 Apr 2020 22:24:06 -0700 (PDT) References: User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ryan Prior , Ryan Prior via Guix-patches Subject: Re: [bug#40757] New package: VisiData In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 23 Apr 2020 07:24:02 +0200 Message-ID: <878simlqq5.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.53; envelope-from=rekado@elephly.net; helo=sender4-of-o53.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/22 23:25:22 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 136.143.188.53 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: 40757-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ryan, I=E2=80=99ve adjusted the patch to gnu/local.mk which no longer applied, ch= anged spaces to tabs in gnu/local.mk, fixed the indentation of visidata.scm, ran =E2=80=9Cguix lint=E2=80=9D, built it and tested it (didn=E2=80=99t kno= w how to exit, so I just did ^Zkill %1) =E2=80=A6 and pushed it to the master branch with commit c47f48d972. Thank you for your patch! -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 01:25:44 2020 Received: (at 40757) by debbugs.gnu.org; 23 Apr 2020 05:25:44 +0000 Received: from localhost ([127.0.0.1]:53835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRUMq-0004C7-HS for submit@debbugs.gnu.org; Thu, 23 Apr 2020 01:25:44 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRUMp-0004C0-38 for 40757@debbugs.gnu.org; Thu, 23 Apr 2020 01:25:43 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1587619538; cv=none; d=zohomail.com; s=zohoarc; b=IGdKDsL0brZJIXFqVti/efwNaK0WRKM49LGD8CtjPkkBRK6yC+x4e4gpzQZW5bx5sE3B5ztnv3SZVt+UfeQo2hRA6aHs5limU9a5yersM/pTijnlUlhq6PYgAoxIVxi0l93VFmU3WAhf+dXF76b0sc3Ptu1u0RgKr7fpXj1RxMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587619538; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=dNB6PwlPJnua/Kx/LxSM1dlhYjn2LLve2BhgMMhyaOc=; b=j04hwjSLzIm0GgIURG2rJ1TqeKulHteuvLid3Rkl5GXZLHOHT9osaOxU65Dm2lh6TR7tQ4Rw/9zkxFUqiQ+lomZkD4wD48HjhJnN/v2EEF7U9GyamwHGapV+lFOnUTTznzXFdJ6UIr+dnV+os68tUJv7tlbqOSlBwzXIIR5znBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1587619538; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=dNB6PwlPJnua/Kx/LxSM1dlhYjn2LLve2BhgMMhyaOc=; b=DBEvl1Y0XgX7OplvrSpTqFgnJQSYGFWhwOQ4eTtz8NWwkjUsOKZkHNZAqC7tScqS Ci3ABHj20HuTCsP11VWU9Yu0OJAWPVV17pS+Q+4/PJ9begw4ffrGS3IEWWLzyNnjRjt 7QQEo4tBr8mVKbyHou8kNYB/RuCaotiCTvXBYz1s= Received: from localhost (p54AD4E51.dip0.t-ipconnect.de [84.173.78.81]) by mx.zohomail.com with SMTPS id 1587619536374762.461188090392; Wed, 22 Apr 2020 22:25:36 -0700 (PDT) References: User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Jack Hill Subject: Re: [bug#40757] New package: VisiData In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 23 Apr 2020 07:25:32 +0200 Message-ID: <877dy6lqnn.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40757 Cc: Ryan Prior , 40757@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Jack, thanks to your review and Ryan=E2=80=99s response to it I only had to perfo= rm minimal changes to apply the patch. Thank you very much! -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 11:29:22 2020 Received: (at 40757) by debbugs.gnu.org; 23 Apr 2020 15:29:22 +0000 Received: from localhost ([127.0.0.1]:55739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRdn0-0000lE-IJ for submit@debbugs.gnu.org; Thu, 23 Apr 2020 11:29:22 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:54584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRdmz-0000l1-KV for 40757@debbugs.gnu.org; Thu, 23 Apr 2020 11:29:21 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRdmq-0001YP-VE; Thu, 23 Apr 2020 11:29:12 -0400 Date: Thu, 23 Apr 2020 11:29:12 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Ricardo Wurmus Subject: Re: [bug#40757] New package: VisiData In-Reply-To: <877dy6lqnn.fsf@elephly.net> Message-ID: References: <877dy6lqnn.fsf@elephly.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="925712948-1003785806-1587655752=:5735" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40757 Cc: Ryan Prior , 40757@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1003785806-1587655752=:5735 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 23 Apr 2020, Ricardo Wurmus wrote: > > Hey Jack, > > thanks to your review and Ryan’s response to it I only had to perform > minimal changes to apply the patch. Thank you very much! You're welcome. It makes me happy to help where I can. I 💚 Guix --925712948-1003785806-1587655752=:5735-- From unknown Mon Aug 18 11:16:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 May 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator