GNU bug report logs - #40753
gnu: spacefm: Add missing dependencies.

Previous Next

Full log

View this message in rfc822 format

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40753 <at> debbugs.gnu.org
Subject: [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
Date: Sun, 26 Apr 2020 16:00:57 +0200

Raghav Gururajan writes:

Hello Raghav,

>> Pushed to master with small cosmetic change below.
>> 
>> Thanks for the patch!
>
> I accidentally sent the wrong patch that missed some things. So sorry. I have
> attached a patch with this email to append the previous. Could you please push
> it as new commit. Thanks!

Don't worry, we all make mistakes.

> From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 25 Apr 2020 21:43:25 -0400
> Subject: [PATCH] gnu: spacefm: Fix privilege management and icons.

>>>HERE<<<

> * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons.

Please move this remark:

> This commit contains changes that were accidentally left out in
> commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8.

beteen subject and "* gnu/packages/lxde", so to >>>HERE<<<

>      (arguments
> -     `(#:configure-flags (list (string-append "--with-bash-path="
> -                                              (assoc-ref %build-inputs "bash")
> -                                              "/bin/bash")
> -                               (string-append "--sysconfdir="
> -                                              (assoc-ref %outputs "out")
> -                                              "/etc"))))
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-spacefm-conf
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "etc/spacefm.conf"
> +               (("#terminal_su=/bin/su")
> +                (string-append "terminal_su="
> +                               (string-append (assoc-ref inputs "sudo")
> +                                              "/bin/sudo"))))

Does this work; SU is not SUDO?  Also, I don't see how <sudo>/bin/sudo
would work.  When I run this

    $(guix build sudo)/bin/sudo 

I get

    sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sudo must be owned by uid 0 and have the setuid bit set

Am I missing something?

> +             (substitute* "etc/spacefm.conf"
> +               (("#graphical_su=/usr/bin/gksu")
> +                (string-append "graphical_su="
> +                               (string-append (assoc-ref inputs "ktsuss")
> +                                              "/bin/ktsuss"))))
> +             #t)))

Changing the default configurations does not seem to work for me.  When
I select

    /File/Root Window

there is a pop-up that says: Please configure a valid Terminal SU
command.  Does it work for You?

> +       #:configure-flags (list 
                                 ^
Trailing space.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.