From unknown Fri Aug 15 18:07:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40753 <40753@debbugs.gnu.org> To: bug#40753 <40753@debbugs.gnu.org> Subject: Status: gnu: spacefm: Add missing dependencies. Reply-To: bug#40753 <40753@debbugs.gnu.org> Date: Sat, 16 Aug 2025 01:07:48 +0000 retitle 40753 gnu: spacefm: Add missing dependencies. reassign 40753 guix-patches submitter 40753 Raghav Gururajan severity 40753 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 21 17:28:44 2020 Received: (at submit) by debbugs.gnu.org; 21 Apr 2020 21:28:44 +0000 Received: from localhost ([127.0.0.1]:50860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR0Rf-0005TQ-Qw for submit@debbugs.gnu.org; Tue, 21 Apr 2020 17:28:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:33408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR0Re-0005TH-Nz for submit@debbugs.gnu.org; Tue, 21 Apr 2020 17:28:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46740) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR0Rd-0004ut-1x for guix-patches@gnu.org; Tue, 21 Apr 2020 17:28:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jR0RV-00005w-PR for guix-patches@gnu.org; Tue, 21 Apr 2020 17:28:40 -0400 Received: from knopi.disroot.org ([178.21.23.139]:40200) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1jR0RV-0008VN-1c for guix-patches@gnu.org; Tue, 21 Apr 2020 17:28:33 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A7B652611B for ; Tue, 21 Apr 2020 23:28:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8cxd6sBlfrEi for ; Tue, 21 Apr 2020 23:28:29 +0200 (CEST) Date: Tue, 21 Apr 2020 17:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587504509; bh=QkL9tg3FW6jGg/g3jJmuclcjHhxFkoJhRBn9Pw0wr1A=; h=Date:From:To:Subject; b=mbE3zl6qWkjgDm871mGrx52whOFiTz2bTeKjsaorJt2WIduQ6hM2mbktUp9MFCCoH IQ/2qU+/WUHX/OJrIkZWv/7+yXPX89zZonmYbo+JI/4xTTr8opogWsXZPVqyDOV/3r 6Ui8WjH2WUx7R16BTwtvTLtcx75q09rhmgIg8bg9eVphloYWsU1WPlANOodh4id3XJ rBj/CXCt7Th63aYgwQ+2LSnCCGfgeOL4j4F3EnHJqW338Mis50M8yuK4kzUNamFPhQ xRT8pPklxurq6slTNxH3kdZp9y+OAL2x6X4iIoOw/Ol7W5K8grJnSmFig0zMjiEvm+ 2tjn9/r6LaljQ== From: Raghav Gururajan To: guix-patches@gnu.org Subject: gnu: spacefm: Add missing dependencies. Message-ID: <20200421172812.6227b2eb.raghavgururajan@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/gnAYHyQH_L4rbHVtJZ2NlWk" Received-SPF: pass client-ip=178.21.23.139; envelope-from=raghavgururajan@disroot.org; helo=knopi.disroot.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/21 16:22:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 178.21.23.139 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --MP_/gnAYHyQH_L4rbHVtJZ2NlWk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline BLOCKERS: #40630 and #40752. --MP_/gnAYHyQH_L4rbHVtJZ2NlWk Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0003-gnu-spacefm-Add-missing-dependencies.patch >From fac881e2820c08e09c8f3e42699ba25b8b9f4004 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Tue, 21 Apr 2020 17:23:21 -0400 Subject: [PATCH 3/3] gnu: spacefm: Add missing dependencies. * gnu/packages/lxde.scm (spacefm): Add missing dependencies. --- gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index f5dc027e03..eeb9feb745 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -29,13 +29,16 @@ #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) + #:use-module (gnu packages disk) #:use-module (gnu packages docbook) + #:use-module (gnu packages file-systems) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages image-viewers) + #:use-module (gnu packages libusb) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages openbox) @@ -43,9 +46,12 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages text-editors) #:use-module (gnu packages video) + #:use-module (gnu packages wget) #:use-module (gnu packages wm) #:use-module (gnu packages xml) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xorg) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system trivial) #:use-module (guix download) @@ -249,8 +255,8 @@ with freedesktop.org standard.") "https://github.com/IgnorantGuru/spacefm/archive/" version ".tar.gz")) (sha256 - (base32 - "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) + (base32 + "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) (modules '((guix build utils))) (snippet '(begin @@ -262,18 +268,34 @@ with freedesktop.org standard.") "#include \n"))) #t)) (file-name (string-append name "-" version ".tar.gz")))) - (build-system gnu-build-system) - (native-inputs `(("pkg-config" ,pkg-config) - ("desktop-file-utils" ,desktop-file-utils) - ("intltool" ,intltool))) - (inputs `(("bash" ,bash) - ("gtk+" ,gtk+) - ("eudev" ,eudev) - ("shared-mime-info" ,shared-mime-info) - ("ffmpegthumbnailer" ,ffmpegthumbnailer) - ("jmtpfs" ,jmtpfs) - ("lsof" ,lsof) - ("udisks" ,udisks))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") + ("intltool" ,intltool) + ("pkg-config" ,pkg-config))) + (inputs + `(("bash" ,bash) + ("cairo" ,cairo) + ("curlftpfs" ,curlftpfs) + ("dbus" ,dbus) + ("eject" ,eject) + ("eudev" ,eudev) + ("fakeroot" ,fakeroot) + ("ffmpegthumbnailer" ,ffmpegthumbnailer) + ("fuseiso" ,fuseiso) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("ifuse" ,ifuse) + ("jmtpfs" ,jmtpfs) + ("libx11" ,libx11) + ("lsof" ,lsof) + ("pango" ,pango) + ("shared-mime-info" ,shared-mime-info) + ("startup-notification" ,startup-notification) + ("udevil" ,udevil) + ("wget" ,wget))) (arguments `(#:configure-flags (list (string-append "--with-bash-path=" (assoc-ref %build-inputs "bash") -- 2.26.1 --MP_/gnAYHyQH_L4rbHVtJZ2NlWk-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 21 20:16:21 2020 Received: (at 40753) by debbugs.gnu.org; 22 Apr 2020 00:16:21 +0000 Received: from localhost ([127.0.0.1]:50953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR33s-00017U-6O for submit@debbugs.gnu.org; Tue, 21 Apr 2020 20:16:20 -0400 Received: from knopi.disroot.org ([178.21.23.139]:38148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR33i-000179-UW for 40753@debbugs.gnu.org; Tue, 21 Apr 2020 20:16:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8E2162626B for <40753@debbugs.gnu.org>; Wed, 22 Apr 2020 02:16:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0HWkoAap2Wuc for <40753@debbugs.gnu.org>; Wed, 22 Apr 2020 02:16:08 +0200 (CEST) Date: Tue, 21 Apr 2020 20:15:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587514568; bh=3GarK2+e2ODegZvt/vPMqpCQNjRKvOmvrFXccx/D00E=; h=Date:From:To:Subject; b=PjEoy/y6VAc4d88CB+VxvMtXqbodS/gcMprpVIfZHdeiK5L3WH6l4O2WuuWXXgzBt ucaMKg1c7OEmYuWUSLbwIXW36MscNs8pdVZlMdX9IlSkj3uI5ItwbHuUX3f2zYSWhK LjuQrG48BTlWkW6phLMyVw8I/OOyM0ZXY736pj9UBv00X2KkaywTk/54eRLh2ZAsI1 N6slabHB9sGq/A0/svjDdk+vw6CCZvxtaT1SnzkvyFdhsqURGDDs/FB4jwG0xanHQD S1acGUBKld8foQwQmsI5ibLTY5rFii6TG45aeFc2AsNbdpFYoyngQ336MZRramhv6N fmmH7Yq8TadOw== From: Raghav Gururajan To: 40753@debbugs.gnu.org Subject: gnu: spacefm: Add and configure missing dependencies. (v2) Message-ID: <20200421201550.5133dd86.raghavgururajan@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/8mcUiKTBlVfa9lJPlabFD4T" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/8mcUiKTBlVfa9lJPlabFD4T Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline BLOCKERS: #40630, #40752 and #40756. --MP_/8mcUiKTBlVfa9lJPlabFD4T Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0004-gnu-spacefm-Add-and-configure-missing-dependencies.patch >From 43cd81fdbe7522cd5ed7f638e49438bfd1a2ccff Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Tue, 21 Apr 2020 20:10:50 -0400 Subject: [PATCH 4/4] gnu: spacefm: Add and configure missing dependencies. * gnu/packages/lxde.scm (spacefm): Add and configure missing dependencies. --- gnu/packages/lxde.scm | 81 ++++++++++++++++++++++++++++++++----------- 1 file changed, 61 insertions(+), 20 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index f5dc027e03..e6fc5b14c8 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -27,15 +27,19 @@ (define-module (gnu packages lxde) #:use-module (gnu packages) + #:use-module (gnu packages admin) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) + #:use-module (gnu packages disk) #:use-module (gnu packages docbook) + #:use-module (gnu packages file-systems) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages image-viewers) + #:use-module (gnu packages libusb) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages openbox) @@ -43,9 +47,12 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages text-editors) #:use-module (gnu packages video) + #:use-module (gnu packages wget) #:use-module (gnu packages wm) #:use-module (gnu packages xml) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xorg) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system trivial) #:use-module (guix download) @@ -249,8 +256,8 @@ with freedesktop.org standard.") "https://github.com/IgnorantGuru/spacefm/archive/" version ".tar.gz")) (sha256 - (base32 - "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) + (base32 + "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) (modules '((guix build utils))) (snippet '(begin @@ -262,25 +269,59 @@ with freedesktop.org standard.") "#include \n"))) #t)) (file-name (string-append name "-" version ".tar.gz")))) - (build-system gnu-build-system) - (native-inputs `(("pkg-config" ,pkg-config) - ("desktop-file-utils" ,desktop-file-utils) - ("intltool" ,intltool))) - (inputs `(("bash" ,bash) - ("gtk+" ,gtk+) - ("eudev" ,eudev) - ("shared-mime-info" ,shared-mime-info) - ("ffmpegthumbnailer" ,ffmpegthumbnailer) - ("jmtpfs" ,jmtpfs) - ("lsof" ,lsof) - ("udisks" ,udisks))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") + ("intltool" ,intltool) + ("pkg-config" ,pkg-config))) + (inputs + `(("bash" ,bash) + ("cairo" ,cairo) + ("curlftpfs" ,curlftpfs) + ("dbus" ,dbus) + ("eject" ,eject) + ("eudev" ,eudev) + ("fakeroot" ,fakeroot) + ("ffmpegthumbnailer" ,ffmpegthumbnailer) + ("fuseiso" ,fuseiso) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("ifuse" ,ifuse) + ("jmtpfs" ,jmtpfs) + ("ktsuss" ,ktsuss) + ("libx11" ,libx11) + ("lsof" ,lsof) + ("pango" ,pango) + ("shared-mime-info" ,shared-mime-info) + ("startup-notification" ,startup-notification) + ("sudo" ,sudo) + ("udevil" ,udevil) + ("wget" ,wget))) (arguments - `(#:configure-flags (list (string-append "--with-bash-path=" - (assoc-ref %build-inputs "bash") - "/bin/bash") - (string-append "--sysconfdir=" - (assoc-ref %outputs "out") - "/etc")))) + `(#:configure-flags (list + (string-append "--with-bash-path=" + (assoc-ref %build-inputs "bash") + "/bin/bash") + (string-append "--sysconfdir=" + (assoc-ref %outputs "out") + "/etc")) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch + (lambda _ + (substitute* "etc/spacefm.conf" + (("#terminal_su=/bin/su") + (string-append "terminal_su=" + (string-append (assoc-ref %build-inputs "sudo") + "/bin/sudo")))) + (substitute* "etc/spacefm.conf" + (("#graphical_su=/usr/bin/gksu") + (string-append "graphical_su=" + (string-append (assoc-ref %build-inputs "ktsuss") + "/bin/ktsuss")))) + #t))))) (home-page "https://ignorantguru.github.io/spacefm/") (synopsis "Multi-panel tabbed file manager") (description "SpaceFM is a graphical, multi-panel, tabbed file manager -- 2.26.1 --MP_/8mcUiKTBlVfa9lJPlabFD4T-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 02:46:56 2020 Received: (at 40753) by debbugs.gnu.org; 22 Apr 2020 06:46:56 +0000 Received: from localhost ([127.0.0.1]:51152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR99o-0002a3-H9 for submit@debbugs.gnu.org; Wed, 22 Apr 2020 02:46:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jR99l-0002Zl-Fd for 40753@debbugs.gnu.org; Wed, 22 Apr 2020 02:46:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54334) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR99e-0003fB-Kl; Wed, 22 Apr 2020 02:46:42 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=46510 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jR99e-0003vM-7h; Wed, 22 Apr 2020 02:46:42 -0400 From: Jan Nieuwenhuizen To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add missing dependencies. References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> Date: Wed, 22 Apr 2020 08:46:38 +0200 In-Reply-To: <20200421172812.6227b2eb.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Tue, 21 Apr 2020 17:28:12 -0400") Message-ID: <87ftcw81bl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Raghav Gururajan writes: Hello! > BLOCKERS: #40630 and #40752. ...what does this mean? >>>From fac881e2820c08e09c8f3e42699ba25b8b9f4004 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Tue, 21 Apr 2020 17:23:21 -0400 > Subject: [PATCH 3/3] gnu: spacefm: Add missing dependencies. > * gnu/packages/lxde.scm (spacefm): Add missing dependencies. It builds OK without this patch; it does not seem that any dependencies are missing. Could it be that these dependencies change or amend its behaviour? After applying this patch, spacefm does not build for me, I get --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build spacefm ice-9/eval.scm:223:20: In procedure proc: error: eject: unbound variable hint: Did you forget a `use-modules' form? --8<---------------cut here---------------end--------------->8--- I am feeling a bit uncomfortable about the fact that you pinged me to "push" this patch, it seems it needs a bit more attention than that. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 12:28:53 2020 Received: (at 40753) by debbugs.gnu.org; 22 Apr 2020 16:28:53 +0000 Received: from localhost ([127.0.0.1]:53047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRIF2-0007fU-Ph for submit@debbugs.gnu.org; Wed, 22 Apr 2020 12:28:53 -0400 Received: from knopi.disroot.org ([178.21.23.139]:43808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRIF0-0007fI-Uv for 40753@debbugs.gnu.org; Wed, 22 Apr 2020 12:28:52 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2B09726344; Wed, 22 Apr 2020 18:28:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6e_0aPATqGkc; Wed, 22 Apr 2020 18:28:48 +0200 (CEST) Date: Wed, 22 Apr 2020 12:28:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587572928; bh=8jrCFt1DUqg+zNwqDiAXcQMKyzLLluX/0BHisb464A4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=W1KCEDXSIV2eqAceQafSLNXCjcV37aOJDQcdgpJZOi+p5YHTIQp/BdcjuSzYYET9w uwsWyUQGMqNHaSHdp9Ve/4CsBlhb408xKXDcqtcVVPy4V7B1Tp+y4RCGRaT9/NdIE6 y9tFvv+qDOZ1WWRXuYGxOPuBdlCZPjt4P0LoVSu7VvhgVAaT/+Ztx8r8oEb5TWeY6Z mojoyThEdKVijUO/PKb4ayBJv3z984oinHl+puvP/pf2+RZTP2VIciDzfxnq/L2THE c0bpYofog00AqpFLQV7LhAlegwxWWns629+3C2IwCgUJE7zfVQhUVc8Xsq5kpREWvo 5DS6II/yLMdoQ== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add missing dependencies. Message-ID: <20200422122833.076c8a60.raghavgururajan@disroot.org> In-Reply-To: <87ftcw81bl.fsf@gnu.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <87ftcw81bl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jan! > > BLOCKERS: #40630 and #40752. > > ...what does this mean? They are dependencies of this patch, that needs to be pushed before this patch. > It builds OK without this patch; it does not seem that any dependencies > are missing. Could it be that these dependencies change or amend its > behaviour? It is to change and amend the behaviour. It adds missing features and fixes icons+privilege-management+disk-management. > After applying this patch, spacefm does not build for me, I get > > --8<---------------cut here---------------start------------->8--- > $ ./pre-inst-env guix build spacefm > ice-9/eval.scm:223:20: In procedure proc: > error: eject: unbound variable > hint: Did you forget a `use-modules' form? > --8<---------------cut here---------------end--------------->8--- That's correct. Eject is provided by one of the blockers. > I am feeling a bit uncomfortable about the fact that you pinged me to > "push" this patch, it seems it needs a bit more attention than that. I apologize. I spent whole day to create these patches and throughly testing them. If I missed anything, please understand it would not have been intentional. Also, there is a v2 patch in #40753 thread that has 3 blockers. Thank you for considering my request. Regards, RG. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 13:59:55 2020 Received: (at 40753) by debbugs.gnu.org; 22 Apr 2020 17:59:55 +0000 Received: from localhost ([127.0.0.1]:53173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRJf9-0001Wt-9k for submit@debbugs.gnu.org; Wed, 22 Apr 2020 13:59:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRJf7-0001Wf-Jr for 40753@debbugs.gnu.org; Wed, 22 Apr 2020 13:59:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34342) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRJf1-0005eS-Lk; Wed, 22 Apr 2020 13:59:47 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=47120 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jRJez-0007S5-Fg; Wed, 22 Apr 2020 13:59:45 -0400 From: Jan Nieuwenhuizen To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add missing dependencies. Organization: AvatarAcademy.nl References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <87ftcw81bl.fsf@gnu.org> <20200422122833.076c8a60.raghavgururajan@disroot.org> X-Url: http://AvatarAcademy.nl Date: Wed, 22 Apr 2020 19:59:41 +0200 In-Reply-To: <20200422122833.076c8a60.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Wed, 22 Apr 2020 12:28:33 -0400") Message-ID: <87k127o0z6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Raghav Gururajan writes: Hello Raghav, >> > BLOCKERS: #40630 and #40752.=20=20 >>=20 >> ...what does this mean? > > They are dependencies of this patch, that needs to be pushed before > this patch. Right. So we'll have to wait for those then, right? >> It builds OK without this patch; it does not seem that any dependencies >> are missing. Could it be that these dependencies change or amend its >> behaviour? > > It is to change and amend the behaviour. It adds missing features and fix= es > icons+privilege-management+disk-management. Okay, it would be nice to say something about that in the commit message. What about gnu: spacefm: Add dependencies for extra functionality. Adding these inputs provides adds icons, privilege-management and disk-management. Other than that, LGTM (assuming that it builds). I'm not really able to test it, I assume it works for you as you expected? >> I am feeling a bit uncomfortable about the fact that you pinged me to >> "push" this patch, it seems it needs a bit more attention than that. > > I apologize. I spent whole day to create these patches and throughly test= ing > them. If I missed anything, please understand it would not have been > intentional. Also, there is a v2 patch in #40753 thread that has 3 blocke= rs. > > Thank you for considering my request. No worries! I did not have much time this morning and from your ping assumed a trivial task. Teaches me not to assume things. I would suggest that when you get an OK on the last dependency for this one, you mention this patch again. Please consider sending patches that depend on eachother in one bug report if that makes sense. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 16:23:02 2020 Received: (at 40753) by debbugs.gnu.org; 22 Apr 2020 20:23:02 +0000 Received: from localhost ([127.0.0.1]:53402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRLtd-0007O1-Vx for submit@debbugs.gnu.org; Wed, 22 Apr 2020 16:23:02 -0400 Received: from knopi.disroot.org ([178.21.23.139]:45088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRLta-0007NY-M6 for 40753@debbugs.gnu.org; Wed, 22 Apr 2020 16:23:00 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 36D5A265AC; Wed, 22 Apr 2020 22:22:56 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K7q-DROF0Azz; Wed, 22 Apr 2020 22:22:54 +0200 (CEST) Date: Wed, 22 Apr 2020 16:22:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587586974; bh=kRt9OIj61es0lPVZBCGwkPWa58xE5PLL8KlGhGtGxeE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=UUnFuUco+F3XeLDzsD59RR6TsweuNWV3PSxByIoz1HdaXQaZuAH50wStYtABrsUnU sxfXKhjhJNXHZs+y9v6MbCJF2rRENKnv/oRm0D1lJNZfgN2QwXn71tg7niahmqaXRr fk11b44E6+5EHC29OUIiTgTFSNhtefqg81g+JZ8OpH0z33K40HRorAXAmQbtytKzAf WjQLXKlRlGGIYnI2XlW9Xf3lzBP+a0ihmUSLjWX8ASplv7im2O6O0gmtaDlMaeL0X+ aOFkHZAdf+pEtcNXXMOlXRWhOpwAaEzIgPwGNoBtPBLL9tJT0aq+2xmUgCGMr+9eUG ZLiTYKaaGPJUg== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add missing dependencies. (v3) Message-ID: <20200422162239.0a98a5c3.raghavgururajan@disroot.org> In-Reply-To: <87k127o0z6.fsf@gnu.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <87ftcw81bl.fsf@gnu.org> <20200422122833.076c8a60.raghavgururajan@disroot.org> <87k127o0z6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/uA/zOP09tfWCRuyugc21HJj" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/uA/zOP09tfWCRuyugc21HJj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Jan! > Right. So we'll have to wait for those then, right? Pardon me, I should have communicated better. I was asking to push including the blockers. Would you be able to please? If not, that's okay. > Okay, it would be nice to say something about that in the commit > message. What about > > gnu: spacefm: Add dependencies for extra functionality. > > Adding these inputs provides adds icons, privilege-management and > disk-management. Thanks. Please find the revised patch attached with this email. > Other than that, LGTM (assuming that it builds). I'm not really able > to test it, I assume it works for you as you expected? Yes, all works good. :-) > No worries! I did not have much time this morning and from your ping > assumed a trivial task. Teaches me not to assume things. No, you did not do anything wrong. I should have communicated better. > I would suggest that when you get an OK on the last dependency for this > one, you mention this patch again. Sure. But let me know if you would be able to process the blockers as well. > Please consider sending patches that depend on eachother in one bug > report if that makes sense. Sorry, I did not plan on fixing spacefm. I came across the issues with spacefm after sending those other patches. Regards, RG. --MP_/uA/zOP09tfWCRuyugc21HJj Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0004-gnu-spacefm-Add-dependencies-for-extra-functionality.patch >From b4f659e7c43eebb4f27f5c1d208a0326d7f2e6a6 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Wed, 22 Apr 2020 16:15:34 -0400 Subject: [PATCH 4/4] gnu: spacefm: Add dependencies for extra functionality. * gnu/packages/lxde.scm (spacefm): Add dependencies for extra functionality. Adding these inputs and making required changes to build-system+arguments; provides icons, privilege-management and disk-management. --- gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index f5dc027e03..eeb9feb745 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -29,13 +29,16 @@ #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) + #:use-module (gnu packages disk) #:use-module (gnu packages docbook) + #:use-module (gnu packages file-systems) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages image-viewers) + #:use-module (gnu packages libusb) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages openbox) @@ -43,9 +46,12 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages text-editors) #:use-module (gnu packages video) + #:use-module (gnu packages wget) #:use-module (gnu packages wm) #:use-module (gnu packages xml) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xorg) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system trivial) #:use-module (guix download) @@ -249,8 +255,8 @@ with freedesktop.org standard.") "https://github.com/IgnorantGuru/spacefm/archive/" version ".tar.gz")) (sha256 - (base32 - "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) + (base32 + "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) (modules '((guix build utils))) (snippet '(begin @@ -262,18 +268,34 @@ with freedesktop.org standard.") "#include \n"))) #t)) (file-name (string-append name "-" version ".tar.gz")))) - (build-system gnu-build-system) - (native-inputs `(("pkg-config" ,pkg-config) - ("desktop-file-utils" ,desktop-file-utils) - ("intltool" ,intltool))) - (inputs `(("bash" ,bash) - ("gtk+" ,gtk+) - ("eudev" ,eudev) - ("shared-mime-info" ,shared-mime-info) - ("ffmpegthumbnailer" ,ffmpegthumbnailer) - ("jmtpfs" ,jmtpfs) - ("lsof" ,lsof) - ("udisks" ,udisks))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") + ("intltool" ,intltool) + ("pkg-config" ,pkg-config))) + (inputs + `(("bash" ,bash) + ("cairo" ,cairo) + ("curlftpfs" ,curlftpfs) + ("dbus" ,dbus) + ("eject" ,eject) + ("eudev" ,eudev) + ("fakeroot" ,fakeroot) + ("ffmpegthumbnailer" ,ffmpegthumbnailer) + ("fuseiso" ,fuseiso) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("ifuse" ,ifuse) + ("jmtpfs" ,jmtpfs) + ("libx11" ,libx11) + ("lsof" ,lsof) + ("pango" ,pango) + ("shared-mime-info" ,shared-mime-info) + ("startup-notification" ,startup-notification) + ("udevil" ,udevil) + ("wget" ,wget))) (arguments `(#:configure-flags (list (string-append "--with-bash-path=" (assoc-ref %build-inputs "bash") -- 2.26.1 --MP_/uA/zOP09tfWCRuyugc21HJj-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 24 15:36:21 2020 Received: (at 40753) by debbugs.gnu.org; 24 Apr 2020 19:36:21 +0000 Received: from localhost ([127.0.0.1]:57980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS47Z-0005Uo-5Y for submit@debbugs.gnu.org; Fri, 24 Apr 2020 15:36:21 -0400 Received: from knopi.disroot.org ([178.21.23.139]:57508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS47W-0005Ue-2t for 40753@debbugs.gnu.org; Fri, 24 Apr 2020 15:36:19 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6A91226F11 for <40753@debbugs.gnu.org>; Fri, 24 Apr 2020 21:36:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 04o-SJb8v35O for <40753@debbugs.gnu.org>; Fri, 24 Apr 2020 21:36:14 +0200 (CEST) Date: Fri, 24 Apr 2020 15:35:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587756972; bh=NbT7oLGBZZo5R8kZi4qFBnVf6ugpUC7PvAVR1c6fn5c=; h=Date:From:To:Subject; b=Pi2ix0nOWENoVY4JD+ZxzxGXxmDzoNAeMTXE6TupXzK9P0dPisyxmkqIgWMrqFhzb 76pQ42S0NHKKUGTX/zOzKrVJeORwYA80MqVpxENXcPEYxBkbKvsEqCDt5/qhGkRjpW Mvqe38tntr86HTg9QHp+3gzgn0ELS/LOPpZ8A6CbMYxcO7FjeJd3OSP7H1sJsww49r v8rncOmno1KtJb7eDhwWQ7kwwZEFsfCwO5UfKiwgAZv0uM4u9rZD3lFv4UizH9uN/y ShSwb4MVn1Yrhpb9MArXwerpL6WPkQtCgVh1nQX0GIXdUY+2tsNh0ELT/qyvez0aJN em5hO4P3JA91w== From: Raghav Gururajan To: 40753@debbugs.gnu.org Subject: gnu: spacefm: Add dependencies for extra functionality. (v3) Message-ID: <20200424153558.2aa79ef0.raghavgururajan@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/t8XQlUsSKDkdq6XSf/Hbto_" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/t8XQlUsSKDkdq6XSf/Hbto_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline --MP_/t8XQlUsSKDkdq6XSf/Hbto_ Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0002-gnu-spacefm-Add-dependencies-for-extra-functionality.patch >From c8ffa0953bd26a4ce22cae17b55d0392908b0f71 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Fri, 24 Apr 2020 15:33:15 -0400 Subject: [PATCH 2/2] gnu: spacefm: Add dependencies for extra functionality. * gnu/packages/lxde.scm (spacefm): Add dependencies for extra functionality. Adding these inputs and making required changes to build-system+arguments; provides icons, privilege-management and disk-management. --- gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index f5dc027e03..1ddac97dee 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -29,13 +29,16 @@ #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) + #:use-module (gnu packages disk) #:use-module (gnu packages docbook) + #:use-module (gnu packages file-systems) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages image-viewers) + #:use-module (gnu packages libusb) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages openbox) @@ -43,9 +46,12 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages text-editors) #:use-module (gnu packages video) + #:use-module (gnu packages wget) #:use-module (gnu packages wm) #:use-module (gnu packages xml) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xorg) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system trivial) #:use-module (guix download) @@ -249,8 +255,8 @@ with freedesktop.org standard.") "https://github.com/IgnorantGuru/spacefm/archive/" version ".tar.gz")) (sha256 - (base32 - "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) + (base32 + "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy")) (modules '((guix build utils))) (snippet '(begin @@ -262,18 +268,34 @@ with freedesktop.org standard.") "#include \n"))) #t)) (file-name (string-append name "-" version ".tar.gz")))) - (build-system gnu-build-system) - (native-inputs `(("pkg-config" ,pkg-config) - ("desktop-file-utils" ,desktop-file-utils) - ("intltool" ,intltool))) - (inputs `(("bash" ,bash) - ("gtk+" ,gtk+) - ("eudev" ,eudev) - ("shared-mime-info" ,shared-mime-info) - ("ffmpegthumbnailer" ,ffmpegthumbnailer) - ("jmtpfs" ,jmtpfs) - ("lsof" ,lsof) - ("udisks" ,udisks))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") + ("intltool" ,intltool) + ("pkg-config" ,pkg-config))) + (inputs + `(("bash" ,bash) + ("cairo" ,cairo) + ("curlftpfs" ,curlftpfs) + ("dbus" ,dbus) + ("eudev" ,eudev) + ("fakeroot" ,fakeroot) + ("ffmpegthumbnailer" ,ffmpegthumbnailer) + ("fuseiso" ,fuseiso) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("ifuse" ,ifuse) + ("jmtpfs" ,jmtpfs) + ("libx11" ,libx11) + ("lsof" ,lsof) + ("pango" ,pango) + ("shared-mime-info" ,shared-mime-info) + ("startup-notification" ,startup-notification) + ("udevil" ,udevil) + ("util-linux" ,util-linux) + ("wget" ,wget))) (arguments `(#:configure-flags (list (string-append "--with-bash-path=" (assoc-ref %build-inputs "bash") -- 2.26.1 --MP_/t8XQlUsSKDkdq6XSf/Hbto_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 24 16:09:35 2020 Received: (at 40753) by debbugs.gnu.org; 24 Apr 2020 20:09:35 +0000 Received: from localhost ([127.0.0.1]:58021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS4df-0006ID-Cx for submit@debbugs.gnu.org; Fri, 24 Apr 2020 16:09:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS4da-0006Hx-Bm for 40753@debbugs.gnu.org; Fri, 24 Apr 2020 16:09:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38308) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS4dV-0005KF-3p; Fri, 24 Apr 2020 16:09:21 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=56728 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jS4dT-0000ZQ-HL; Fri, 24 Apr 2020 16:09:20 -0400 From: Jan Nieuwenhuizen To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> Date: Fri, 24 Apr 2020 22:09:15 +0200 In-Reply-To: <20200424153558.2aa79ef0.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Fri, 24 Apr 2020 15:35:58 -0400") Message-ID: <87h7x8wsr8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Raghav Gururajan writes: Hi Raghav, Pushed to master with small cosmetic change below. Thanks for the patch! janneke >>>From c8ffa0953bd26a4ce22cae17b55d0392908b0f71 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Fri, 24 Apr 2020 15:33:15 -0400 > Subject: [PATCH 2/2] gnu: spacefm: Add dependencies for extra functionali= ty. > #:use-module (gnu packages wm) > #:use-module (gnu packages xml) > + #:use-module (gnu packages xdisorg) > #:use-module (gnu packages xorg) Changed this to #:use-module (gnu packages wm) #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 22:12:13 2020 Received: (at 40753) by debbugs.gnu.org; 26 Apr 2020 02:12:13 +0000 Received: from localhost ([127.0.0.1]:60617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSWmD-0000Mn-6p for submit@debbugs.gnu.org; Sat, 25 Apr 2020 22:12:13 -0400 Received: from knopi.disroot.org ([178.21.23.139]:35132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSWmA-0000Mc-Np for 40753@debbugs.gnu.org; Sat, 25 Apr 2020 22:12:12 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7E8B425EE5; Sun, 26 Apr 2020 04:12:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S-bDnJbR64wS; Sun, 26 Apr 2020 04:12:08 +0200 (CEST) Date: Sat, 25 Apr 2020 22:11:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587867128; bh=7qwaaMLm8Odyxr3VrMZeCUxu3LfJFSQbwDgsY5cMAUs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=JPFM7/WGk4xb6eMQokzlbWumz6XIVDAocPqh1lSBq+wnxDZ5LUp9gWTBwpCi68Xek PMdEMu7MfoNkuyu7WXsFbEbldEq3N3OQSZS78e7VMNXLGNwetZujy2llOp9+ivTTHv biBc4ytLpwtEE5EdgyuytNu2dmBtql+l/eCRuU3yJtQ0CCQZM6FEKkSyeN/EhFA87U KHcFzjtHkk1H23dZ5BZVWpjJpqP5VIPZDwOQYd/rx3kvQJe96Dvjd/A8g7OTrUeKkV msTfaxzij9pZHaKEm73Tk0W73iKFXdMR5yn3JwIGf47+CqWF1VQQ+hiQoOJ0UTYyKe 6HhYQ1xytE79A== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Message-ID: <20200425221143.1a587483.raghavgururajan@disroot.org> In-Reply-To: <87h7x8wsr8.fsf@gnu.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/J+O37bNj2nWX/jB4kTgGpdY" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/J+O37bNj2nWX/jB4kTgGpdY Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Jan! > Pushed to master with small cosmetic change below. > > Thanks for the patch! I accidentally sent the wrong patch that missed some things. So sorry. I have attached a patch with this email to append the previous. Could you please push it as new commit. Thanks! Regards, RG. --MP_/J+O37bNj2nWX/jB4kTgGpdY Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-spacefm-Fix-privilege-management-and-icons.patch >From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sat, 25 Apr 2020 21:43:25 -0400 Subject: [PATCH] gnu: spacefm: Fix privilege management and icons. * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons. This commit contains changes that were accidentally left out in commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8. --- gnu/packages/lxde.scm | 37 ++++++++++++++++++++++++++++++------- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 9de96a21cb..3fd2eaff69 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -27,6 +27,7 @@ (define-module (gnu packages lxde) #:use-module (gnu packages) + #:use-module (gnu packages admin) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) #:use-module (gnu packages disk) @@ -276,7 +277,8 @@ with freedesktop.org standard.") ("intltool" ,intltool) ("pkg-config" ,pkg-config))) (inputs - `(("bash" ,bash) + `(("adwaita-icon-theme" ,adwaita-icon-theme) ; Hard-coded theme + ("bash" ,bash) ("cairo" ,cairo) ("curlftpfs" ,curlftpfs) ("dbus" ,dbus) @@ -288,21 +290,42 @@ with freedesktop.org standard.") ("gtk+" ,gtk+) ("ifuse" ,ifuse) ("jmtpfs" ,jmtpfs) + ("ktsuss" ,ktsuss) ("libx11" ,libx11) ("lsof" ,lsof) ("pango" ,pango) ("shared-mime-info" ,shared-mime-info) ("startup-notification" ,startup-notification) + ("sudo" ,sudo) ("udevil" ,udevil) ("util-linux" ,util-linux) ("wget" ,wget))) (arguments - `(#:configure-flags (list (string-append "--with-bash-path=" - (assoc-ref %build-inputs "bash") - "/bin/bash") - (string-append "--sysconfdir=" - (assoc-ref %outputs "out") - "/etc")))) + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-spacefm-conf + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "etc/spacefm.conf" + (("#terminal_su=/bin/su") + (string-append "terminal_su=" + (string-append (assoc-ref inputs "sudo") + "/bin/sudo")))) + (substitute* "etc/spacefm.conf" + (("#graphical_su=/usr/bin/gksu") + (string-append "graphical_su=" + (string-append (assoc-ref inputs "ktsuss") + "/bin/ktsuss")))) + #t))) + #:configure-flags (list + (string-append "--with-preferable-sudo=" + (assoc-ref %build-inputs "ktsuss") + "/bin/ktsuss") + (string-append "--with-bash-path=" + (assoc-ref %build-inputs "bash") + "/bin/bash") + (string-append "--sysconfdir=" + (assoc-ref %outputs "out") + "/etc")))) (home-page "https://ignorantguru.github.io/spacefm/") (synopsis "Multi-panel tabbed file manager") (description "SpaceFM is a graphical, multi-panel, tabbed file manager -- 2.26.1 --MP_/J+O37bNj2nWX/jB4kTgGpdY-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 10:01:14 2020 Received: (at 40753) by debbugs.gnu.org; 26 Apr 2020 14:01:14 +0000 Received: from localhost ([127.0.0.1]:33837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShqI-0005yJ-Mk for submit@debbugs.gnu.org; Sun, 26 Apr 2020 10:01:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShqF-0005y5-Hy for 40753@debbugs.gnu.org; Sun, 26 Apr 2020 10:01:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43572) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jShq9-0002Sk-UM; Sun, 26 Apr 2020 10:01:01 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=42168 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jShq7-00009d-OK; Sun, 26 Apr 2020 10:01:01 -0400 From: Jan Nieuwenhuizen To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Organization: AvatarAcademy.nl References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> X-Url: http://AvatarAcademy.nl Date: Sun, 26 Apr 2020 16:00:57 +0200 In-Reply-To: <20200425221143.1a587483.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Sat, 25 Apr 2020 22:11:43 -0400") Message-ID: <87lfmis5wm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Raghav Gururajan writes: Hello Raghav, >> Pushed to master with small cosmetic change below. >>=20 >> Thanks for the patch! > > I accidentally sent the wrong patch that missed some things. So sorry. I = have > attached a patch with this email to append the previous. Could you please= push > it as new commit. Thanks! Don't worry, we all make mistakes. > From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 25 Apr 2020 21:43:25 -0400 > Subject: [PATCH] gnu: spacefm: Fix privilege management and icons. >>>HERE<<< > * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons. Please move this remark: > This commit contains changes that were accidentally left out in > commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8. beteen subject and "* gnu/packages/lxde", so to >>>HERE<<< > (arguments > - `(#:configure-flags (list (string-append "--with-bash-path=3D" > - (assoc-ref %build-inputs "= bash") > - "/bin/bash") > - (string-append "--sysconfdir=3D" > - (assoc-ref %outputs "out") > - "/etc")))) > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-spacefm-conf > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "etc/spacefm.conf" > + (("#terminal_su=3D/bin/su") > + (string-append "terminal_su=3D" > + (string-append (assoc-ref inputs "sudo") > + "/bin/sudo")))) Does this work; SU is not SUDO? Also, I don't see how /bin/sudo would work. When I run this $(guix build sudo)/bin/sudo=20 I get sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sud= o must be owned by uid 0 and have the setuid bit set Am I missing something? > + (substitute* "etc/spacefm.conf" > + (("#graphical_su=3D/usr/bin/gksu") > + (string-append "graphical_su=3D" > + (string-append (assoc-ref inputs "ktsuss") > + "/bin/ktsuss")))) > + #t))) Changing the default configurations does not seem to work for me. When I select /File/Root Window there is a pop-up that says: Please configure a valid Terminal SU command. Does it work for You? > + #:configure-flags (list=20 ^ Trailing space. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 02:30:27 2020 Received: (at 40753) by debbugs.gnu.org; 27 Apr 2020 06:30:27 +0000 Received: from localhost ([127.0.0.1]:35387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSxHf-0003T1-B5 for submit@debbugs.gnu.org; Mon, 27 Apr 2020 02:30:27 -0400 Received: from knopi.disroot.org ([178.21.23.139]:46246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSxHZ-0003So-Ex for 40753@debbugs.gnu.org; Mon, 27 Apr 2020 02:30:26 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 32D0125F77; Mon, 27 Apr 2020 08:30:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id RyTs4RMXOgtS; Mon, 27 Apr 2020 08:30:18 +0200 (CEST) Date: Mon, 27 Apr 2020 02:29:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587969016; bh=OXwKdAFYKk1s3y8FdyruFs99w8PwRQSx6AX1osJ9iYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=AjqKmcmdVGOfPHiLek8NC9hYZWgf4dQ+wOrpnuibQwzBP2JXxhE+u7Ph0UVoXLOvq MFuumb5p1Hr13m8D3uh92wV08cD2opjNTFKlDHqc9oFwb3m4IV0s6eDdBfZylK9H+h E70TTg+e0Dv4QQUNZb0xkM8yqhKt4ZNLQxVpg6BvXYvHFveD5Zwk2gQduSiJ0eSLn9 Ueux6yqlvQmJtGmVIDnYZiO5iBvh1qQekYaARdPXXGkzans3BbZuIkcrpmtJsWFCx3 NIR0/sS1FYnFnaJltlGrzlzgcCZNEoMwWdp/KT3F5f32A1rNjOyyRH7jay1jBOQOZ7 wm/9wsoHEqPgQ== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Message-ID: <20200427022956.7c7d7263.raghavgururajan@disroot.org> In-Reply-To: <87lfmis5wm.fsf@gnu.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/IShoMinPHhDPE_btyV5L32e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/IShoMinPHhDPE_btyV5L32e Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Jan! > >>>HERE<<< > > > * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons. > > Please move this remark: > > > This commit contains changes that were accidentally left out in > > commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8. > > beteen subject and "* gnu/packages/lxde", so to >>>HERE<<< Sure. > > (arguments > > - `(#:configure-flags (list (string-append "--with-bash-path=" > > - (assoc-ref %build-inputs > > "bash") > > - "/bin/bash") > > - (string-append "--sysconfdir=" > > - (assoc-ref %outputs "out") > > - "/etc")))) > > + `(#:phases > > + (modify-phases %standard-phases > > + (add-after 'unpack 'patch-spacefm-conf > > + (lambda* (#:key inputs #:allow-other-keys) > > + (substitute* "etc/spacefm.conf" > > + (("#terminal_su=/bin/su") > > + (string-append "terminal_su=" > > + (string-append (assoc-ref inputs "sudo") > > + "/bin/sudo")))) > > Does this work; SU is not SUDO? Also, I don't see how /bin/sudo > would work. When I run this > > $(guix build sudo)/bin/sudo > > I get > > sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sudo > must be owned by uid 0 and have the setuid bit set > > Am I missing something? The option just has the name "su". It can be sudo too. I wouldn't worry about this terminal_su option. This is just has to be set, so that spacefm doesn't throw "no valid program found" error, now and then, because of default FHS path. SpaceFM primarily uses graphical_su, which has been set to 'ktsuss'. > > + (substitute* "etc/spacefm.conf" > > + (("#graphical_su=/usr/bin/gksu") > > + (string-append "graphical_su=" > > + (string-append (assoc-ref inputs "ktsuss") > > + "/bin/ktsuss")))) > > + #t))) > > Changing the default configurations does not seem to work for me. When > I select > > /File/Root Window > > there is a pop-up that says: Please configure a valid Terminal SU > command. Does it work for You? This is exactly the error I was talking about above. Once we apply this patch, the error appearing stops and ktsuss will pop right up. > > > + #:configure-flags (list > ^ > Trailing space. Thanks! I have attached revised patch with this email. Regards, RG. --MP_/IShoMinPHhDPE_btyV5L32e Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-spacefm-Fix-privilege-management.patch >From 636d358dc3290433b929ebd72ad087dbfa50c8a5 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Mon, 27 Apr 2020 02:27:16 -0400 Subject: [PATCH] gnu: spacefm: Fix privilege management. * gnu/packages/lxde.scm (spacefm): Fix privilege management. --- gnu/packages/lxde.scm | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 9de96a21cb..8b9759bc9c 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -27,6 +27,7 @@ (define-module (gnu packages lxde) #:use-module (gnu packages) + #:use-module (gnu packages admin) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) #:use-module (gnu packages disk) @@ -288,21 +289,42 @@ with freedesktop.org standard.") ("gtk+" ,gtk+) ("ifuse" ,ifuse) ("jmtpfs" ,jmtpfs) + ("ktsuss" ,ktsuss) ("libx11" ,libx11) ("lsof" ,lsof) ("pango" ,pango) ("shared-mime-info" ,shared-mime-info) ("startup-notification" ,startup-notification) + ("sudo" ,sudo) ("udevil" ,udevil) ("util-linux" ,util-linux) ("wget" ,wget))) (arguments - `(#:configure-flags (list (string-append "--with-bash-path=" - (assoc-ref %build-inputs "bash") - "/bin/bash") - (string-append "--sysconfdir=" - (assoc-ref %outputs "out") - "/etc")))) + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-spacefm-conf + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "etc/spacefm.conf" + (("#terminal_su=/bin/su") + (string-append "terminal_su=" + (string-append (assoc-ref inputs "sudo") + "/bin/sudo")))) + (substitute* "etc/spacefm.conf" + (("#graphical_su=/usr/bin/gksu") + (string-append "graphical_su=" + (string-append (assoc-ref inputs "ktsuss") + "/bin/ktsuss")))) + #t))) + #:configure-flags (list + (string-append "--with-preferable-sudo=" + (assoc-ref %build-inputs "ktsuss") + "/bin/ktsuss") + (string-append "--with-bash-path=" + (assoc-ref %build-inputs "bash") + "/bin/bash") + (string-append "--sysconfdir=" + (assoc-ref %outputs "out") + "/etc")))) (home-page "https://ignorantguru.github.io/spacefm/") (synopsis "Multi-panel tabbed file manager") (description "SpaceFM is a graphical, multi-panel, tabbed file manager -- 2.26.2 --MP_/IShoMinPHhDPE_btyV5L32e-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 02:38:52 2020 Received: (at 40753) by debbugs.gnu.org; 27 Apr 2020 06:38:52 +0000 Received: from localhost ([127.0.0.1]:35400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSxPn-0003fg-Nz for submit@debbugs.gnu.org; Mon, 27 Apr 2020 02:38:51 -0400 Received: from flashner.co.il ([178.62.234.194]:47846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSxPm-0003fU-Gt for 40753@debbugs.gnu.org; Mon, 27 Apr 2020 02:38:50 -0400 Received: from localhost (unknown [31.210.177.209]) by flashner.co.il (Postfix) with ESMTPSA id A514040337; Mon, 27 Apr 2020 06:38:44 +0000 (UTC) Date: Mon, 27 Apr 2020 09:38:12 +0300 From: Efraim Flashner To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Message-ID: <20200427063812.GH5243@E5400> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FUaywKC54iCcLzqT" Content-Disposition: inline In-Reply-To: <20200427022956.7c7d7263.raghavgururajan@disroot.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org, Jan Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --FUaywKC54iCcLzqT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Guix System $(guix build sudo)/bin/sudo isn't setuid, we'd need the one from /run/setuid-programs. (ins)efraim@E5400 ~$ which sudo /run/setuid-programs/sudo --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --FUaywKC54iCcLzqT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6mfdQACgkQQarn3Mo9 g1Gx6A/+N+NOEUUxNdyK8zVBxErqHud6Au9Qka3C2pimb1JcNnWL/2j0NzzZZe7c D0OXnqARwcxGiNEbgmrz4HMOGTNz/17FGoJsYO1KbRJyrDRQnOPSPF7ztqsPto6i 2vTCpF4RbuXTLssQA4/R7ynwCGELIB+9/m88C1uZzvwI3gv/Ot+PrBjzzcP4hq54 Nciwldkqc8i5sFFebpXODh35yvH4Yu0rmIRjp/a8Mo5ZnuImfoH6JnzESNtHRz8C Xe5T+P5SpsCuVAo71WBd/1pXBRymlB7brNi3xi5ibSrp0qiIbL/HYKEeyi2w+y3a KIanwHHBhmmKvhwmLlX6mKiGT5xUf2k/36vS5GVhfA+SzxnOpq74Mc53ez8Ls9mb RmZUqmu3NEKT80GXqC0+xtzTiTz1fh3b9mwhtf0mUGDB2B79YsVnGDyOzcCIuVJz LMkCo/WNwJSsJYVnmRi5hWPO7uHB38Og6bAvKX0uFGFIDhcLhCoSWkEzu/CQ1DW4 HZHLmvc2oH9T85sKbNX7k++dFZSNTSHook2p/SprKd0AXbuRAUDJTatJAAstp/pV IWjWmoFy8lUCxEIs7Lhzd1TZOuIXag5YQdOJpHGwpzf7MyWp0HG8XuKxbzeT8AtU YHNQ3uxsjqgqxh1M5a+8hlkCj+DQQ1aWwLNAYPl1BqoNUOQcNns= =1qa7 -----END PGP SIGNATURE----- --FUaywKC54iCcLzqT-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 04:38:19 2020 Received: (at 40753) by debbugs.gnu.org; 27 Apr 2020 08:38:19 +0000 Received: from localhost ([127.0.0.1]:35608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSzHO-0000PQ-Md for submit@debbugs.gnu.org; Mon, 27 Apr 2020 04:38:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSzH8-0000Oi-BR for 40753@debbugs.gnu.org; Mon, 27 Apr 2020 04:38:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58555) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSzH1-0001nF-DV; Mon, 27 Apr 2020 04:37:55 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=46220 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSzH0-0006WS-7d; Mon, 27 Apr 2020 04:37:54 -0400 From: Jan Nieuwenhuizen To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Organization: AvatarAcademy.nl References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> X-Url: http://AvatarAcademy.nl Date: Mon, 27 Apr 2020 10:37:52 +0200 In-Reply-To: <20200427022956.7c7d7263.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Mon, 27 Apr 2020 02:29:56 -0400") Message-ID: <87368p5nof.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Raghav Gururajan writes: Hello Raghav, >> Does this work; SU is not SUDO? Also, I don't see how /bin/sudo >> would work. When I run this >>=20 >> $(guix build sudo)/bin/sudo=20 >>=20 >> I get >>=20 >> sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/= sudo >> must be owned by uid 0 and have the setuid bit set >>=20 >> Am I missing something? > > The option just has the name "su". It can be sudo too. I wouldn't worry a= bout > this terminal_su option. That's okay, I'm not really worried :-) When I read a patch, and I cannot imagine how that would work, I would like to learn more to understand it beter, or remove it. I do not like adding code that I do not understand, and also does not work. > This is just has to be set, so that spacefm doesn't throw "no valid > program found" error, now and then, because of default FHS path. > SpaceFM primarily uses graphical_su, which has been set to 'ktsuss'. Okay, that would explain something. So, TERMINAL_SU just needs to be set to "some" existing executable, but is not used? What about `(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch-spacefm-conf (lambda _ ;; If terminal_su is unset, users get a popup: ;; "Please configure a valid Terminal SU command." (substitute* "etc/spacefm.conf" (("#terminal_su=3D/bin/su") "terminal_su=3D/run/current-system/profile/bin/false")) #t))) I tested this, and it hase the same, partially functional result, as using sudo and setting #graphical_su. WDYT? >> > + (substitute* "etc/spacefm.conf" >> > + (("#graphical_su=3D/usr/bin/gksu") >> > + (string-append "graphical_su=3D" >> > + (string-append (assoc-ref inputs "ktsu= ss") >> > + "/bin/ktsuss")))) >> > + #t)))=20=20 >>=20 >> Changing the default configurations does not seem to work for me. When >> I select >>=20 >> /File/Root Window >>=20 >> there is a pop-up that says: Please configure a valid Terminal SU >> command. Does it work for You? > > This is exactly the error I was talking about above. Once we apply this p= atch, > the error appearing stops and ktsuss will pop right up. Hmm. Can you double check? I tested your patch again today it (still) does not work. I get Please configure a valid Terminal SU command. Only when I manually point spacefm to it's configuration file, like so /gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/bin/spacefm -= c /gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/etc/spacefm/ then the popup disappears. So now I am wondering, is the problem with your setup or with mine? What do you think? By the way, the KTSUSS popup (when I see it) does not work for me. Have you tested KTSUSS? Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 04:42:54 2020 Received: (at 40753) by debbugs.gnu.org; 27 Apr 2020 08:42:54 +0000 Received: from localhost ([127.0.0.1]:35631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSzLq-0000Wh-8j for submit@debbugs.gnu.org; Mon, 27 Apr 2020 04:42:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSzLp-0000WV-FS for 40753@debbugs.gnu.org; Mon, 27 Apr 2020 04:42:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58647) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSzLj-0006X4-Hq; Mon, 27 Apr 2020 04:42:47 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=55598 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSzLj-000746-4D; Mon, 27 Apr 2020 04:42:47 -0400 From: Jan Nieuwenhuizen To: Efraim Flashner Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Organization: AvatarAcademy.nl References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> <20200427063812.GH5243@E5400> X-Url: http://AvatarAcademy.nl Date: Mon, 27 Apr 2020 10:42:45 +0200 In-Reply-To: <20200427063812.GH5243@E5400> (Efraim Flashner's message of "Mon, 27 Apr 2020 09:38:12 +0300") Message-ID: <87y2qh48vu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org, Raghav Gururajan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner writes: > On Guix System $(guix build sudo)/bin/sudo isn't setuid, we'd need the > one from /run/setuid-programs. > > (ins)efraim@E5400 ~$ which sudo > /run/setuid-programs/sudo Yes, that's what I wanted to suggest...but then I saw that the setting is called TERMINAL_SU (not SUDO). That got me thinking: this is possibly not used at all...could be dead code? janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 05:11:35 2020 Received: (at 40753) by debbugs.gnu.org; 28 Apr 2020 09:11:35 +0000 Received: from localhost ([127.0.0.1]:38907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTMH9-0000Xe-Ak for submit@debbugs.gnu.org; Tue, 28 Apr 2020 05:11:35 -0400 Received: from knopi.disroot.org ([178.21.23.139]:37580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTMH7-0000XW-KE for 40753@debbugs.gnu.org; Tue, 28 Apr 2020 05:11:34 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 554FF2807A; Tue, 28 Apr 2020 11:11:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ajx9rl7GCszl; Tue, 28 Apr 2020 11:11:30 +0200 (CEST) Date: Tue, 28 Apr 2020 05:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1588065090; bh=TLTYJRkTAoTXNiItCJMBTbMYKzaG+rUkJrQpfaGE6lk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Dg3P4j8Cmu56mTQI1GaTPNE2s/fn7eBsayNCE5DCXHGU3FTzh49A1CwBBGPYUlT95 wc/iQakO4pLxz/ztBt3OUKY8x6kLpc0keu6qKa5zrMcO7B0vi8PoVoYTb0rLwu79tV wukABogpssmR1Twg4u5V3b+SDntqu7z20zPd/VQKDakOHHmTxOvdKMZmp1uM5VpFwZ 9CUrLJ4vSAw/p46HXUZTIC2n6P+7gxjaXUm+qcu19JlmbdL0auqn6DgDwMBmp+esrL g64YKKGLCu+8DKa/t256AZ2MjWRL/B43VJtrIQZOnsiDqqFF0n7gAVZjKRYCL0lAWe dK8PkUPfbzfmA== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Message-ID: <20200428051108.7dee10d7.raghavgururajan@disroot.org> In-Reply-To: <87y2qh48vu.fsf@gnu.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> <20200427063812.GH5243@E5400> <87y2qh48vu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/7PzNt4OOqRT0YxgM5j.mq7u" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/7PzNt4OOqRT0YxgM5j.mq7u Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Jan! Sorry again for messing this up. I have attached revised patch with this email. This, along with #40922 and new patch at #40901, makes SpaceFM to work perfectly. :-) Regards, RG. --MP_/7PzNt4OOqRT0YxgM5j.mq7u Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0003-gnu-spacefm-Fix-privilege-and-disk-management.patch >From b623508a4e673e53e63336ee5d97c39e85b52b75 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Tue, 28 Apr 2020 05:02:06 -0400 Subject: [PATCH 3/3] gnu: spacefm: Fix privilege and disk management. * gnu/packages/lxde.scm (spacefm): Fix privilege and disk management. Patched references to su, ktsuss and udevil; to load them correctly. --- gnu/packages/lxde.scm | 34 +++++++++++++++++++++++++++------- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 9de96a21cb..d152f6f79d 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -27,6 +27,7 @@ (define-module (gnu packages lxde) #:use-module (gnu packages) + #:use-module (gnu packages admin) #:use-module (gnu packages autotools) #:use-module (gnu packages bash) #:use-module (gnu packages disk) @@ -279,7 +280,6 @@ with freedesktop.org standard.") `(("bash" ,bash) ("cairo" ,cairo) ("curlftpfs" ,curlftpfs) - ("dbus" ,dbus) ("eudev" ,eudev) ("fakeroot" ,fakeroot) ("ffmpegthumbnailer" ,ffmpegthumbnailer) @@ -288,6 +288,7 @@ with freedesktop.org standard.") ("gtk+" ,gtk+) ("ifuse" ,ifuse) ("jmtpfs" ,jmtpfs) + ("ktsuss" ,ktsuss) ("libx11" ,libx11) ("lsof" ,lsof) ("pango" ,pango) @@ -297,12 +298,31 @@ with freedesktop.org standard.") ("util-linux" ,util-linux) ("wget" ,wget))) (arguments - `(#:configure-flags (list (string-append "--with-bash-path=" - (assoc-ref %build-inputs "bash") - "/bin/bash") - (string-append "--sysconfdir=" - (assoc-ref %outputs "out") - "/etc")))) + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-source-files + (lambda* (#:key inputs #:allow-other-keys) + ;; Patch config file to load programs correctly. + (substitute* "etc/spacefm.conf" + (("#terminal_su=/bin/su") + "terminal_su=/run/setuid-programs/su") + (("#graphical_su=/usr/bin/gksu") + (string-append "graphical_su=" + (string-append (assoc-ref inputs "ktsuss") + "/bin/ktsuss")))) + ;; SpaceFM expects udevil to have uid set to root. + ;; User has to manually add udevil to setuid-programs. + (substitute* "src/settings.c" + (("/usr/bin/udevil") + "/run/setuid-programs/udevil")) + #t))) + #:configure-flags (list + (string-append "--with-bash-path=" + (assoc-ref %build-inputs "bash") + "/bin/bash") + (string-append "--sysconfdir=" + (assoc-ref %outputs "out") + "/etc")))) (home-page "https://ignorantguru.github.io/spacefm/") (synopsis "Multi-panel tabbed file manager") (description "SpaceFM is a graphical, multi-panel, tabbed file manager -- 2.26.2 --MP_/7PzNt4OOqRT0YxgM5j.mq7u-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 30 09:57:30 2020 Received: (at 40753) by debbugs.gnu.org; 30 Apr 2020 13:57:30 +0000 Received: from localhost ([127.0.0.1]:47399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU9gw-0004tg-Cc for submit@debbugs.gnu.org; Thu, 30 Apr 2020 09:57:30 -0400 Received: from knopi.disroot.org ([178.21.23.139]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU9gu-0004tW-Ka for 40753@debbugs.gnu.org; Thu, 30 Apr 2020 09:57:28 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D19D52B2F5; Thu, 30 Apr 2020 15:57:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yLu-kKLbVOLj; Thu, 30 Apr 2020 15:57:26 +0200 (CEST) Date: Thu, 30 Apr 2020 09:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1588255046; bh=HxM7neXoi7HzNbhyNOzB0fAJC6zmVs+b4iLDlnWNv5w=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=PEj3i7UVO7zbceDJWwwWhMpcJlLI+HyB8+oNippN1qanyF2au0LXIbpeObbWWNeNi LLiwsSsC1A2LaeOd8n67WJOMzn3soyEedTqQlIMrNWIxCaeP6doLpZ0MnKtajIa7vU NDJWq3M/PO2qOm+KmTDa72E8RzGaZpPTHlzhSlrDpd/+w5KEZUyZiM+CjLfHoON03A Ah/s8wkE/sHAZb3t2Ti3MHwBVfpoFtkwTQeT9s1JSWMxEcqfhafmTggG3b7baHwqnr ZlvcgOYq2j4zecSIrUue/CALggkaFKilsWm55r3xHk7GrbT6LPvYf2/eYNhcEAUamE sTtxp+8H/rCuA== From: Raghav Gururajan To: Jan Nieuwenhuizen Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Message-ID: <20200430095707.02a4eaad.raghavgururajan@disroot.org> In-Reply-To: <20200428051108.7dee10d7.raghavgururajan@disroot.org> References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> <20200427063812.GH5243@E5400> <87y2qh48vu.fsf@gnu.org> <20200428051108.7dee10d7.raghavgururajan@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753 Cc: 40753@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jan! Since #40753 is already closed. I have sent revised patch as #40982. So #40982 and #40922, should fix current spacefm disk issues. Regards, RG. From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 01:08:56 2020 Received: (at 40753-done) by debbugs.gnu.org; 30 May 2020 05:08:57 +0000 Received: from localhost ([127.0.0.1]:56693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jetjs-000432-Ob for submit@debbugs.gnu.org; Sat, 30 May 2020 01:08:56 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:44643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jetjq-00042n-Ca for 40753-done@debbugs.gnu.org; Sat, 30 May 2020 01:08:56 -0400 Received: by mail-qt1-f180.google.com with SMTP id c12so3746874qtq.11 for <40753-done@debbugs.gnu.org>; Fri, 29 May 2020 22:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=LL/3T7RZ+RAxpcjpDme5gcMB9N2G/56H5rMcjBCAq2U=; b=vN7kGwExkBSQN8z87Gu0gR41jqt6hkI5ASpwsNVLg9kVHwf22JoAihkF/x/75nVfi4 pkoZwMQzHQIVrTf8RNNNFpzCNTWMLrrCPY1bTZeKM5Usv8N0+VbE9WnFMSMgmebOtrcF TDqsPAwjqGcPMS22m6Ld8C7NV80haofuZ1EgyBT0F7b7zd5gzYg3vjoTfkT8jjtP6AJ3 pwRvxDzNJVBpVQuMg9uaJU+cLF3ID8vLNwfTBp84plWRShXis4DaDmF0wxGUjbBe76Di 1jp/HVks0yCRR4fzL2A312q/2MAHVwp1M+1oEJOlhQgf3mC7qTdxYkmpx0pv9QWJcKl+ Xv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=LL/3T7RZ+RAxpcjpDme5gcMB9N2G/56H5rMcjBCAq2U=; b=GhILEYHsUY+ZTFbh3kiiUAfM0rJiZRbyC4ic1QR75Y5/2RGn9EP6x1pljXHrcQmQYi 9fAxaTBYUEuFtnfYcsIRDkeq11aNW8CLqyI7h/azplOjma0Rp2kMhiEN4i83HfMXI515 Wyio0C1deJaLnu3WVgBlhQxdLR3OFBhUnW8MNFcIq38alhsjNvo9duFcW6Owbs08wqEK mhstLYK867dDrwacaiNsL1oUM25YQ16bldAmCKsV9hTHvBT/ZWrYY3FoUNXXAOAQ2wHf 7EEHDhoV+j4eT7rAQq3A4kqONjID0ZLALNhl1fJkmZCfgNF32jJNnUE8qqHK0Xe8FQkt QUmw== X-Gm-Message-State: AOAM532MttOl5k6yGD4ZntJT292HBod7kc0Xof7zj+VtMWJwtKWLt6ow nZlLXa8JOqtpbhJ75thhdrs= X-Google-Smtp-Source: ABdhPJxXnzEj4+Hq7vpfJdHgHHjikARGeib9x4vyINmXE8HWutrHhQ6W1wcmwZhJTw0oAF6zYkAbzA== X-Received: by 2002:ac8:4d4d:: with SMTP id x13mr11961734qtv.289.1590815328943; Fri, 29 May 2020 22:08:48 -0700 (PDT) Received: from hurd (dsl-10-141-140.b2b2c.ca. [72.10.141.140]) by smtp.gmail.com with ESMTPSA id x205sm9399517qka.12.2020.05.29.22.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 22:08:48 -0700 (PDT) From: Maxim Cournoyer To: Raghav Gururajan Subject: Re: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. In-Reply-To: <20200430095707.02a4eaad.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Thu, 30 Apr 2020 09:57:07 -0400") References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> <20200427063812.GH5243@E5400> <87y2qh48vu.fsf@gnu.org> <20200428051108.7dee10d7.raghavgururajan@disroot.org> <20200430095707.02a4eaad.raghavgururajan@disroot.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Sat, 30 May 2020 01:08:47 -0400 Message-ID: <877dwuxb4w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40753-done Cc: 40753-done@debbugs.gnu.org, Efraim Flashner , Jan Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Raghav Gururajan writes: > Hi Jan! > > Since #40753 is already closed. I have sent revised patch as #40982. > > So #40982 and #40922, should fix current spacefm disk issues. > > Regards, > RG. Alright, I'm closing this one then, by sending a reply to 40753-done@debbugs.gnu.org (that is, simply add the '-done' suffix to the bug number in the debbugs email). Thank you, Maxim From unknown Fri Aug 15 18:07:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Jun 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator