From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Apr 2020 08:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 40728@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158737087232487 (code B ref -1); Mon, 20 Apr 2020 08:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Apr 2020 08:21:12 +0000 Received: from localhost ([127.0.0.1]:46578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQRfz-0008Ru-MF for submit@debbugs.gnu.org; Mon, 20 Apr 2020 04:21:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:50854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQRfx-0008Rn-TC for submit@debbugs.gnu.org; Mon, 20 Apr 2020 04:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54464 helo=eggs1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQRfx-0000Wa-9j for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2020 04:21:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs1p.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jQRfv-0005KY-FU for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2020 04:21:08 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:51169) by eggs1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jQRfv-0005Im-1U for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2020 04:21:07 -0400 Received: by mail-wm1-x334.google.com with SMTP id x25so9958840wmc.0 for ; Mon, 20 Apr 2020 01:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=LmUnJoxYjmIoWy9FJohHVV2+Ad4M7kdLXH1x1nwSd+I=; b=ZKDSvrwjPWRAmkET4ukfYYb+twy3LKYIdR9YM0smAh9psB+d0gfmXQlRW0GSuvuJVr /k0kmJy0NqvazsGN4k43aeo1INrVBqITiGfpy8PF7+Ql2lHwnVlKkffNDzV2hhPjySAh ddo+lsUS5DKJr/p7V8D+v28FVyZnm8N9jAjiItJV7Be4AU+KWCDmytQby25gQi4oViY4 MrqVtARucrMmvaxdi2prsFCSlMd8gjcbb+N5xLwUvrbhb6wKyDyXj9SNJE38wUPvQgLY 2QPqwCVVGn3JflWm/hK+NMdwf5VjzWvLsjoJKmPCeu5n6NXIqTqIJqB2AvQ99XHbuUQe Mnnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=LmUnJoxYjmIoWy9FJohHVV2+Ad4M7kdLXH1x1nwSd+I=; b=NTkLx5skd4JBjQV9zJHIPIq6X5Lz3MY6r8wVfICRNZd7c29ByoOZv+VLSw4fCDo/G7 241ETGe2MwnAD5Y81SPkVarA3ThrsUnEwhewJ5AAY9fHfuzWFxfPciY3NTGDMBvggUDS b11T33/DLILPF4h1+77QIrDJXQaHwTcPpTSwu3MQp1ubQF/4KqfDI377CLq/ElIeXxUS HcgJfNGrHz2w/d3YRe3vWiY9+6n89aNI1O6QcCwxxKuD5brOEr0FYrTfkdTBGF2+rm/i SaRhWd9X70FGsja8nwXrg0IbGNBypBK59q5V+R0Gtx2oE+dFUchE2ff5eQpOrayUIwsd tVGg== X-Gm-Message-State: AGi0PuZcil8Mqnb2bnl0/K7kVq1pEEGeZWRsfJBvxPwevFhLR9A8/Yov bu/A5YW0SwmmIRvytxNY7XQZIZbSiv4= X-Google-Smtp-Source: APiQypKYWXmA0U6tHFgrOeyl9EGJPPuGfCp1v1vb/61L4ITjBi4NeCK85jOA9rROsjk/07OseQVj8Q== X-Received: by 2002:a1c:a7c2:: with SMTP id q185mr16594543wme.42.1587370865128; Mon, 20 Apr 2020 01:21:05 -0700 (PDT) Received: from phst1 ([2a02:2455:2a2:100:c351:ffcc:5d8e:4288]) by smtp.gmail.com with ESMTPSA id i5sm148438wrw.77.2020.04.20.01.21.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 01:21:04 -0700 (PDT) From: Philipp Stephani Date: Mon, 20 Apr 2020 10:21:03 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x334.google.com X-detected-operating-system: by eggs1p.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::334 X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: It looks like the following public functions were deleted from debugger.el between Emacs 26 and 27: debug-help-follow, debugger-insert-backtrace, debugger-toggle-locals. All three were public (didn't [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: x.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) It looks like the following public functions were deleted from debugger.el between Emacs 26 and 27: debug-help-follow, debugger-insert-backtrace, debugger-toggle-locals. All three were public (didn't contain a double hyphen) and documented, therefore meant for general use. I don't think we should remove such functions (and break users' workflows that rely on them) without a strong reason. Please consider restoring these functions for Emacs 27. In GNU Emacs 27.0.91 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.13) of 2020-04-20 Repository revision: a1040861f118881004f59866111f64cd0ae03b7a Repository branch: emacs-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux rodete Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --enable-checking=3Dall --enable-gtk-deprecation-warnings --enable-gcc-warnings=3Dwarn-only --enable-check-lisp-object-type --with-mailutils --without-pop 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-g3' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 63123 5515) (symbols 48 8435 1) (strings 32 22394 1817) (string-bytes 1 711568) (vectors 16 12506) (vector-slots 8 174130 5982) (floats 8 25 34) (intervals 56 201 0) (buffers 1000 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Apr 2020 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani , Gemini Lasswell Cc: 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.158739626716229 (code B ref 40728); Mon, 20 Apr 2020 15:25:02 +0000 Received: (at 40728) by debbugs.gnu.org; 20 Apr 2020 15:24:27 +0000 Received: from localhost ([127.0.0.1]:48275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQYHa-0004Dc-MK for submit@debbugs.gnu.org; Mon, 20 Apr 2020 11:24:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57526 helo=eggs1p.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQYHY-0004DM-9j for 40728@debbugs.gnu.org; Mon, 20 Apr 2020 11:24:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49246) by eggs1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQYHS-0000ZJ-D6; Mon, 20 Apr 2020 11:24:18 -0400 Received: from [176.228.60.248] (port=1923 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jQYHR-00075Y-P5; Mon, 20 Apr 2020 11:24:18 -0400 Date: Mon, 20 Apr 2020 18:24:13 +0300 Message-Id: <83imhugoyq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Philipp Stephani on Mon, 20 Apr 2020 10:21:03 +0200) References: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philipp Stephani > Date: Mon, 20 Apr 2020 10:21:03 +0200 > > > It looks like the following public functions were deleted from > debugger.el between Emacs 26 and 27: debug-help-follow, > debugger-insert-backtrace, debugger-toggle-locals. All three were > public (didn't contain a double hyphen) and documented, therefore meant > for general use. I don't think we should remove such functions (and > break users' workflows that rely on them) without a strong reason. > Please consider restoring these functions for Emacs 27. Gemini, could you please write replacements for the functions you removed, or defalias them to some equivalent replacements? I agree that public functions should not be removed, not without deprecating them first (if indeed they don't make sense). Thanks. From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2020 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Philipp Stephani , 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.1588020911476 (code B ref 40728); Mon, 27 Apr 2020 20:56:01 +0000 Received: (at 40728) by debbugs.gnu.org; 27 Apr 2020 20:55:11 +0000 Received: from localhost ([127.0.0.1]:38211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTAmU-00007c-Qr for submit@debbugs.gnu.org; Mon, 27 Apr 2020 16:55:11 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTAmS-00007T-PC for 40728@debbugs.gnu.org; Mon, 27 Apr 2020 16:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=j+0df09SJ/ts9OdC+PBX66XJicM081cDfeCLvsL7MzA=; b=JT4FHBikA5FM/DWa4tLrazPL/g fjk3T2I2HL9SUQQulgQmu3TP2B0ho0u1LrSKSIUBWr9To0kbxAnZerTcYFYnqdksoiv1z+dUfuo4s 2Ft6J0rYzuzEZnEb+UOZ0I9dGhOEyey9Pg18iTUYlmrutb2O6gX4oNAFNYalOg8a4dRt3pNBPGzsk Yojoo+FxtKD1Wsu+xwE2FpetusmnIofCZ8TYLTAVrXjvoZs7Xd4wrCz/MlZ10WabAYi4iEVbkLXiA +EDBvh6ZFsV6RuCsAaWcw+FgTHTHYj8qNDqhWDxOmsVRk43KPB6UjGfJxFvwgbOIbYJ7BDU7oV7n0 m4qSCcsw==; Received: from [10.9.9.204] (helo=mailfront22.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jTAmR-0004cH-3x; Mon, 27 Apr 2020 22:55:07 +0200 Received: by mailfront22.runbox with esmtpsa [Authenticated alias (696087)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jTAlw-0004Ht-2g; Mon, 27 Apr 2020 22:54:36 +0200 From: Gemini Lasswell References: <83imhugoyq.fsf@gnu.org> Date: Mon, 27 Apr 2020 13:54:27 -0700 In-Reply-To: <83imhugoyq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Apr 2020 18:24:13 +0300") Message-ID: <87h7x4zm2k.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Gemini, could you please write replacements for the functions you > removed, or defalias them to some equivalent replacements? I agree > that public functions should not be removed, not without deprecating > them first (if indeed they don't make sense). Here is a patch to bring those functions back. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Restore-some-public-functions-to-debug.el-Bug-40728.patch >From 6e1141592bc259bab9c61f3212351c92d0eb16e7 Mon Sep 17 00:00:00 2001 From: Gemini Lasswell Date: Sun, 26 Apr 2020 10:14:38 -0700 Subject: [PATCH] Restore some public functions to debug.el (Bug#40728) In "Add backtrace-mode and use it in the debugger, ERT and Edebug", on 19 June 2018, three public functions in debug.el were removed. Restore them so as not to break users' workflows. Since backtrace-mode now provides the functionality that used to come from the buttons created by debugger-insert-backtrace, it is now obsolete. * lisp/emacs-lisp/debug.el (debugger-insert-backtrace): New function. Mark it as obsolete. (debugger-toggle-locals, debug-help-follow): New aliases. * lisp/emacs-lisp/backtrace.el (backtrace--to-string): New function. (backtrace-to-string): Use it. Fix whitespace. --- lisp/emacs-lisp/backtrace.el | 11 +++++++---- lisp/emacs-lisp/debug.el | 15 +++++++++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/backtrace.el b/lisp/emacs-lisp/backtrace.el index 37dad8db16..5874ba72fc 100644 --- a/lisp/emacs-lisp/backtrace.el +++ b/lisp/emacs-lisp/backtrace.el @@ -922,11 +922,15 @@ backtrace (princ (backtrace-to-string (backtrace-get-frames 'backtrace))) nil) -(defun backtrace-to-string(&optional frames) +(defun backtrace-to-string (&optional frames) "Format FRAMES, a list of `backtrace-frame' objects, for output. Return the result as a string. If FRAMES is nil, use all function calls currently active." - (unless frames (setq frames (backtrace-get-frames 'backtrace-to-string))) + (substring-no-properties + (backtrace--to-string + (or frames (backtrace-get-frames 'backtrace-to-string))))) + +(defun backtrace--to-string (frames) (let ((backtrace-fontify nil)) (with-temp-buffer (backtrace-mode) @@ -934,8 +938,7 @@ backtrace-to-string backtrace-frames frames backtrace-print-function #'cl-prin1) (backtrace-print) - (substring-no-properties (filter-buffer-substring (point-min) - (point-max)))))) + (filter-buffer-substring (point-min) (point-max))))) (provide 'backtrace) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index ed28997292..14957eae0f 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -320,6 +320,17 @@ debugger--print (message "Error in debug printer: %S" err) (prin1 obj stream)))) +(make-obsolete 'debugger-insert-backtrace + "use a `backtrace-mode' buffer or `backtrace-to-string'." + "Emacs 27.1") + +(defun debugger-insert-backtrace (frames do-xrefs) + "Format and insert the backtrace FRAMES at point. +Make functions into cross-reference buttons if DO-XREFS is non-nil." + (insert (if do-xrefs + (backtrace--to-string frames) + (backtrace-to-string frames)))) + (defun debugger-setup-buffer (args) "Initialize the `*Backtrace*' buffer for entry to the debugger. That buffer should be current already and in debugger-mode." @@ -527,6 +538,8 @@ debugger-eval-expression (let ((str (eval-expression-print-format val))) (if str (princ str t)))))))) +(defalias 'debugger-toggle-locals 'backtrace-toggle-locals) + (defvar debugger-mode-map (let ((map (make-keymap))) @@ -621,6 +634,8 @@ debugger-record-expression (buffer-substring (line-beginning-position 0) (line-end-position 0))))) +(defalias 'debug-help-follow 'backtrace-help-follow-symbol) + ;; When you change this, you may also need to change the number of ;; frames that the debugger skips. -- 2.23.1 --=-=-=-- From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Apr 2020 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: p.stephani2@gmail.com, 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.158805557018632 (code B ref 40728); Tue, 28 Apr 2020 06:33:02 +0000 Received: (at 40728) by debbugs.gnu.org; 28 Apr 2020 06:32:50 +0000 Received: from localhost ([127.0.0.1]:38661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTJnW-0004qR-5L for submit@debbugs.gnu.org; Tue, 28 Apr 2020 02:32:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTJnV-0004qB-0S for 40728@debbugs.gnu.org; Tue, 28 Apr 2020 02:32:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52499) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTJnP-0001E7-C1; Tue, 28 Apr 2020 02:32:43 -0400 Received: from [176.228.60.248] (port=4500 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTJnN-0005Je-88; Tue, 28 Apr 2020 02:32:42 -0400 Date: Tue, 28 Apr 2020 09:32:20 +0300 Message-Id: <83v9lk2k97.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h7x4zm2k.fsf@runbox.com> (message from Gemini Lasswell on Mon, 27 Apr 2020 13:54:27 -0700) References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gemini Lasswell > Cc: Philipp Stephani , 40728@debbugs.gnu.org > Date: Mon, 27 Apr 2020 13:54:27 -0700 > > Eli Zaretskii writes: > > > Gemini, could you please write replacements for the functions you > > removed, or defalias them to some equivalent replacements? I agree > > that public functions should not be removed, not without deprecating > > them first (if indeed they don't make sense). > > Here is a patch to bring those functions back. Thanks! Philipp, any comments? If not, I'd like to install this on the release branch. From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Apr 2020 08:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Gemini Lasswell , 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.158806240030016 (code B ref 40728); Tue, 28 Apr 2020 08:27:01 +0000 Received: (at 40728) by debbugs.gnu.org; 28 Apr 2020 08:26:40 +0000 Received: from localhost ([127.0.0.1]:38803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTLZf-0007o4-T8 for submit@debbugs.gnu.org; Tue, 28 Apr 2020 04:26:40 -0400 Received: from mail-ot1-f42.google.com ([209.85.210.42]:40854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTLZf-0007ns-2s for 40728@debbugs.gnu.org; Tue, 28 Apr 2020 04:26:39 -0400 Received: by mail-ot1-f42.google.com with SMTP id i27so31208227ota.7 for <40728@debbugs.gnu.org>; Tue, 28 Apr 2020 01:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N81S1zLtZT0653qbkQnCq4MbE65A7ppznb0dyn2bnhI=; b=AqZJl/ZQBdC/Vx6/lAYV1E0uejTttAtVjIuc9xPrdkpT2OC8zP/S6YfnGJ+9soXsVU b6f3jmR2vdWBaq35iATZ3SzdKAqE/ucSB9fjIowZkYQn3QnW/+wZmNCEPpJF3OVaiAlN t0H6euCqA9jj5oUtAuWpq9ia7AeoQcQIDZGBsByx+ivbwZes/iv/5W3qYuuFXucCFEWh 2FPZjWubffmFRx7UWSgM3rNW/N31uzNfyZiOLSdYUy/+nL8pK26nmsnCj+BQbWgLccB0 KTn5bF2SYZGpWgv0G+S7oIBGskZuFaTc4aIHkcu/lwAtQE8ogB2TWsz9ecreqrYLPNwj QdGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N81S1zLtZT0653qbkQnCq4MbE65A7ppznb0dyn2bnhI=; b=hypweKHLdtxdDN+sn8oXtPF1JySSIWApAePURX5/ntLumjYlDBt2j17qocaiSAnAJk KLDoBrZ/x4SPG6Fes6T5x0RRoF/SKHO3QCghaWc3ttCjKZgojGlfsvHfw45+xkzoxteS mjKyaQG3tR9QrDN7Zk40Ev+qxObxwBqgbD83H98Gr2C+p/v1NuCmLqd0Qpv5mfOODcVI 6LIVoZbVl5+kI8ogaBTZK/wP8v0dkku84si7rURcM04DtdRVbpYtTz7/h89V+H7MuEdL Jd6dNNCUKKNg3/NvgpH5yvb6TUZ94GBycXiVlRpsFp0JnKeBc+2IzHOdw+Sd5PaO2Gz7 Rxmg== X-Gm-Message-State: AGi0PuYlta8trOjSAuLrwW0/ldyWPqOsFXnvGwThykIk4AR0uIK5XWqD OepRvpWdGP/lVTcK4aoQEykzJ16M6jd8xRFFsFkjm7Bm X-Google-Smtp-Source: APiQypLm1d6nVm01TS+VfmLTixWHgS0QftcKhuPRreayNDK3uH9unpQ6fiGBkHoWf+m8PJQifHZtf7WD4EnFn5Zrgm0= X-Received: by 2002:aca:f182:: with SMTP id p124mr2159843oih.170.1588062393408; Tue, 28 Apr 2020 01:26:33 -0700 (PDT) MIME-Version: 1.0 References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> <83v9lk2k97.fsf@gnu.org> In-Reply-To: <83v9lk2k97.fsf@gnu.org> From: Philipp Stephani Date: Tue, 28 Apr 2020 10:26:22 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Di., 28. Apr. 2020 um 08:32 Uhr schrieb Eli Zaretskii : > > > From: Gemini Lasswell > > Cc: Philipp Stephani , 40728@debbugs.gnu.org > > Date: Mon, 27 Apr 2020 13:54:27 -0700 > > > > Eli Zaretskii writes: > > > > > Gemini, could you please write replacements for the functions you > > > removed, or defalias them to some equivalent replacements? I agree > > > that public functions should not be removed, not without deprecating > > > them first (if indeed they don't make sense). > > > > Here is a patch to bring those functions back. > > Thanks! > > Philipp, any comments? If not, I'd like to install this on the > release branch. I haven't tested the patch in detail, but it looks fine, thanks. I guess you want to use `define-obsolete-function-alias' instead of `defalias' to mark the aliases as obsolete as well. The commit message should contain a magic string such as "Don't merge to master" to prevent reinstating the functions in Emacs 28. From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani Cc: Gemini Lasswell , Eli Zaretskii , 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.15982575945878 (code B ref 40728); Mon, 24 Aug 2020 08:27:02 +0000 Received: (at 40728) by debbugs.gnu.org; 24 Aug 2020 08:26:34 +0000 Received: from localhost ([127.0.0.1]:55948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7oI-0001Wk-1l for submit@debbugs.gnu.org; Mon, 24 Aug 2020 04:26:34 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:34316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7oG-0001WX-Mm for 40728@debbugs.gnu.org; Mon, 24 Aug 2020 04:26:33 -0400 Received: by mail-yb1-f182.google.com with SMTP id u6so4718582ybf.1 for <40728@debbugs.gnu.org>; Mon, 24 Aug 2020 01:26:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=ajbmk+iYUJDMI5OS8A21RXj9aoVzbXaDtKcOYTLbZmI=; b=o+LqL+q4qFge8B+F9ST18M5Wjcmm9BQ+TIHVIFFGe7gTKjTDGMv9SfYG/LfjHwwSjG 4mWd0tSGrLX783IGt6VGELXgxr6BNIxX21zcMKMI0sGewg5v95CNoySRdLHR8164jzdC D+/x1/3Lljx8jh9waR2XGxRr6PohbsrF+CB1KNt2f5YopmVMejn42MMg0I7qxaGTRW2a lK0wdLPu3PEDMgnhiKqIXJMvZKxD6nouEPxbPlStt3HzqaAqL5OeFzauOHKrgQ6yCTRc 7Oeh95Av28DpbovX9oBaQ3uN0iRNPQwVBbRcKztN2O4z7a5TjSrpXfRDoH/GAF499+Z5 eqHw== X-Gm-Message-State: AOAM531N62dl0bZ6aBAZhM1DRkIA7iX4VfTds8iWZe6my4LKNaykW4h3 luGvdIMMjf3VptmUBWSQWjZOZ7OmjM/XuKCo5GE= X-Google-Smtp-Source: ABdhPJwV1PLTpHqh0+kDZ6Vc4ggg4+nmRHEbwTSZ1m0bLyF7QsHQbie910EEkMFHtjU/Lb8tiY36ilanS1tRNY/Tw0E= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr6363095ybb.129.1598257586764; Mon, 24 Aug 2020 01:26:26 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 24 Aug 2020 04:26:26 -0400 From: Stefan Kangas In-Reply-To: (Philipp Stephani's message of "Tue, 28 Apr 2020 10:26:22 +0200") References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> <83v9lk2k97.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 24 Aug 2020 04:26:26 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Philipp Stephani writes: > Am Di., 28. Apr. 2020 um 08:32 Uhr schrieb Eli Zaretskii : >> >> > From: Gemini Lasswell >> > Cc: Philipp Stephani , 40728@debbugs.gnu.org >> > Date: Mon, 27 Apr 2020 13:54:27 -0700 >> > >> > Eli Zaretskii writes: >> > >> > > Gemini, could you please write replacements for the functions you >> > > removed, or defalias them to some equivalent replacements? I agree >> > > that public functions should not be removed, not without deprecating >> > > them first (if indeed they don't make sense). >> > >> > Here is a patch to bring those functions back. >> >> Thanks! >> >> Philipp, any comments? If not, I'd like to install this on the >> release branch. > > I haven't tested the patch in detail, but it looks fine, thanks. > I guess you want to use `define-obsolete-function-alias' instead of > `defalias' to mark the aliases as obsolete as well. > The commit message should contain a magic string such as "Don't merge > to master" to prevent reinstating the functions in Emacs 28. It seems like the patch here was never installed on the release branch. Should it be? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 08:40:17 2020 Received: (at control) by debbugs.gnu.org; 26 Aug 2020 12:40:18 +0000 Received: from localhost ([127.0.0.1]:37682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAuiv-0004OZ-M0 for submit@debbugs.gnu.org; Wed, 26 Aug 2020 08:40:17 -0400 Received: from mail-yb1-f177.google.com ([209.85.219.177]:40619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAuit-0004OK-VE for control@debbugs.gnu.org; Wed, 26 Aug 2020 08:40:16 -0400 Received: by mail-yb1-f177.google.com with SMTP id q3so868467ybp.7 for ; Wed, 26 Aug 2020 05:40:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=w0+rgm9YyIt6uFu7RNBlza5iWUkLncvJWp9OTi6Wyq8=; b=TrHnWZ8p6a+rovjkimqxB+vaIn/oG2Cdmg/CgzKb6VeqAe3bD5NNLr1J6pGXwjf4D1 FCYmCDsbI8BT3g/TJR/EDjM90hZzn7bsJn2LGi2kw5KHcCb7ZHSBmKH8FRhKi0SxP6WQ rGvKf3DawmjST2sl0J/wEbZiO2FlFK+YOEhH19Jo+YwOHO0V8PL1had76aR6s6ILouXI 9RWlz05Sd6wfxc7O6q5ZmlSjfBPp6AR6H/+e6NJ0Xps0O47507pfkv16oGbG68sXamww e6KmYRzCt4osZqFx7QtbCuqNWatT8OnS75P7i/AIpmEE+guGimAq57yaDgIqUT6WPeNl fLSg== X-Gm-Message-State: AOAM531NtvahV6au+XH2nbUVzQOD2UUeZufga5NZ2ih04rWjBNjQ9pja +cQeXE0/C2SRrxY6xcKQPxfmSfuGJj6zApaXMTmYiSQGwmU= X-Google-Smtp-Source: ABdhPJxSrutdKOqwdHaBNCCxEmE/FuHe9ohcjYl5J0poci2NVZKND222LSC/FVd95SZg+fIcaZohzRM20gbHXwV3gXw= X-Received: by 2002:a25:880e:: with SMTP id c14mr21412303ybl.181.1598445610423; Wed, 26 Aug 2020 05:40:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Aug 2020 05:40:10 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 26 Aug 2020 05:40:10 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 40728 + patch thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.177 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.177 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 40728 + patch thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.177 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.177 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines tags 40728 + patch thanks From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Gemini Lasswell , Philipp Stephani , Eli Zaretskii , 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.160157547411092 (code B ref 40728); Thu, 01 Oct 2020 18:05:01 +0000 Received: (at 40728) by debbugs.gnu.org; 1 Oct 2020 18:04:34 +0000 Received: from localhost ([127.0.0.1]:38238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2wT-0002sp-TV for submit@debbugs.gnu.org; Thu, 01 Oct 2020 14:04:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2wR-0002sb-TW for 40728@debbugs.gnu.org; Thu, 01 Oct 2020 14:04:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iro4lsfVTCZNTpYfwnY4OPXtRf80ehhxaG+z3zsPDDw=; b=c7bK3vTfG1hZnILUaf+RMO3jFp OD3WewjjEvmIDVj5GqH2gAPn7potahChJDrLImZr6eeTMwPykRw1AeryHura6jol6GRwtEir1MP5D drqtVhoRj5M5dKjD+W04+Wl2ubcMzzYc8zZlo7MMEpC3+h4Af5fXOnoaACRQJ8pdBWkI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO2wF-0001Oj-B9; Thu, 01 Oct 2020 20:04:24 +0200 From: Lars Ingebrigtsen References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> <83v9lk2k97.fsf@gnu.org> X-Now-Playing: Nanang Tatang's _Muki_: "On Me Forever" Date: Thu, 01 Oct 2020 20:04:17 +0200 In-Reply-To: (Stefan Kangas's message of "Mon, 24 Aug 2020 04:26:26 -0400") Message-ID: <877ds94yce.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: >> I haven't tested the patch in detail, but it looks fine, thanks. >> I guess you want to use `define-obsolete-function-alias' instead of >> `defalias' to mark the aliases as obsolete as well. >> The [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >> I haven't tested the patch in detail, but it looks fine, thanks. >> I guess you want to use `define-obsolete-function-alias' instead of >> `defalias' to mark the aliases as obsolete as well. >> The commit message should contain a magic string such as "Don't merge >> to master" to prevent reinstating the functions in Emacs 28. I applied the patch now, but I forgot about this bit... but... I think they should be merged to Emacs 28? They shouldn't disappear again between Emacs 27 and Emacs 28. I've made the aliases obsolete, though. > It seems like the patch here was never installed on the release branch. Done now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 01 14:04:38 2020 Received: (at control) by debbugs.gnu.org; 1 Oct 2020 18:04:38 +0000 Received: from localhost ([127.0.0.1]:38241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2wY-0002t5-4I for submit@debbugs.gnu.org; Thu, 01 Oct 2020 14:04:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO2wW-0002sh-To for control@debbugs.gnu.org; Thu, 01 Oct 2020 14:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YcZyqk7T1XYFzBGYWlByG863Nj4R4a+O7Gv4mFWU6Fk=; b=oMGLsDzefqyMt6re9X8gtSnGGS 2iety+nQJSQ9SV7ydoGSqPcS7KGA4U2k1cvLb57TFYFANm39V5f1A+qvvCjQUefFypuMWSxVm9QWV QEVvDfiBDdbSesNNbF5rviB7WvYB38ISeSYnGNbgF6Vzq+Oe1I6SEL/z56of9K74aL38=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO2wP-0001Ox-8u for control@debbugs.gnu.org; Thu, 01 Oct 2020 20:04:31 +0200 Date: Thu, 01 Oct 2020 20:04:28 +0200 Message-Id: <875z7t4yc3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40728 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 40728 fixed close 40728 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40728 fixed close 40728 28.1 quit From unknown Sat Aug 16 18:09:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen Cc: Gemini Lasswell , Eli Zaretskii , Stefan Kangas , 40728@debbugs.gnu.org Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.160183748528264 (code B ref 40728); Sun, 04 Oct 2020 18:52:02 +0000 Received: (at 40728) by debbugs.gnu.org; 4 Oct 2020 18:51:25 +0000 Received: from localhost ([127.0.0.1]:46771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP96T-0007Lo-0Y for submit@debbugs.gnu.org; Sun, 04 Oct 2020 14:51:25 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:45734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP96R-0007LX-CI for 40728@debbugs.gnu.org; Sun, 04 Oct 2020 14:51:23 -0400 Received: by mail-ot1-f48.google.com with SMTP id f37so2986216otf.12 for <40728@debbugs.gnu.org>; Sun, 04 Oct 2020 11:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EzNqoiOWnI8SQYfq+L27mEyCZUeRodahciCcm7joH70=; b=EhrTxzD/wcW8K9ipQd18mQ9fOxpX19Xr7UXwkRmJczTKPglCBsWaeYNwInV8uuNw0t m04JY1IzHrHnLqjBWJdmP+L6BmCU5Hpp4qOusP0ISboEPwYu1uTDyHCxDf3jFzmkBf8Y njblHTfzJBuN5Zyw9wvNr+UnG6I6uwEJ3ayvmhlrAHQmxfUw0Fue3cclTmWAnsNSDqAx qoEcVFs8Z5+JR2I0L5PLz8CiZhA1835oGQeSCDkY+Rbh7BBdJI1nltkMCb+ewOAQP4ca W7uFHIR0MasxNyslLiSxVPjYYXYSNQikMIRWiiiScdQyLXVyVwK4i4G126TALrHy+qqb mUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EzNqoiOWnI8SQYfq+L27mEyCZUeRodahciCcm7joH70=; b=uD7p1TeT0H3AqBMfWw2Qxr7ENMzaewzWwoSD7fO39DP5tqKulMutZgh2XxBrgEuu94 ux4Cfkx3wPA2CS6BEdHku9+HBKNAnP4AqT5tkf9w2d2CfkWgU0YhfPxioYc1j+oZ0dA3 7b4PqXbCjEzfIKmgSKKd2wCeOdgOl15hThWhcHRJD/cgMUeYYyE0XZPWpn12Kp0zTTMn exlQqxvUGAvuUL83To9GaG8xv0dQT1KfSraTn5/UZwROak6VX1H2U7BtbNIWyxi3NgU7 hpFfQCLrCALhXYS+DOyycOWzy7/Hy/lWN6EEFOioSV6WoUwxMFizpf+JWpHYjJ1/N+xs Hs1g== X-Gm-Message-State: AOAM5318AF9KORwvJr8pgxL3V9dha8pgbqqVIlnnTZ1H+oVUHUqaNTJq uATi3hvB1nMzWyNNNAmk1s/+TuspsK8Q3i4QRX8= X-Google-Smtp-Source: ABdhPJzaSwKgssxURNRitCpRAV1yIG+mOmtMEGxxaNSr6lGTNwjscVvdoLi5dwSGgYkeAhtxf+qTS0CqINlIhGHRJVk= X-Received: by 2002:a9d:6a8e:: with SMTP id l14mr8324646otq.174.1601837477664; Sun, 04 Oct 2020 11:51:17 -0700 (PDT) MIME-Version: 1.0 References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> <83v9lk2k97.fsf@gnu.org> <877ds94yce.fsf@gnus.org> In-Reply-To: <877ds94yce.fsf@gnus.org> From: Philipp Stephani Date: Sun, 4 Oct 2020 20:51:06 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Do., 1. Okt. 2020 um 20:04 Uhr schrieb Lars Ingebrigtsen : > > Stefan Kangas writes: > > >> I haven't tested the patch in detail, but it looks fine, thanks. > >> I guess you want to use `define-obsolete-function-alias' instead of > >> `defalias' to mark the aliases as obsolete as well. > >> The commit message should contain a magic string such as "Don't merge > >> to master" to prevent reinstating the functions in Emacs 28. > > I applied the patch now, but I forgot about this bit... but... I think > they should be merged to Emacs 28? They shouldn't disappear again > between Emacs 27 and Emacs 28. > > I've made the aliases obsolete, though. > > > It seems like the patch here was never installed on the release branch. > > Done now. Unfortunately I think this is now too late. Emacs 27.1 has been released, the incompatible change has been made, and package authors will need to cope with it.