GNU bug report logs - #40727
27.0.91; 'cl-loop ... across ... and' seems broken

Previous Next

Full log

Message #13 received at 40727 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 40727 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#40727: 27.0.91; 'cl-loop ... across ... and' seems broken
Date: Thu, 30 Apr 2020 19:40:43 -0400

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> writes:

> By the way, while adding the test case I found an additional regression
> involving loop termination by a 'var = ...' clause.  I'll open another
> bug about it soon.

Actually, it's very closely connected (only observable after fixing the
original bug, since otherwise the necessary conditions trigger the
--cl-vec-- is void error), so I'll keep it here.  When there is a
(cl-loop for VAR across ARRAY and VAR2 = ...) the array index would get
incremented twice per loop.  Fixed by the patch below (applies on top of
the patch in my previous message).

[0002-Don-t-increment-array-index-in-cl-loop-twice-Bug-407.patch (text/plain, attachment)]

[Message part 3 (text/plain, inline)]

Eli, is it okay to push both of these to emacs-27?  Alternatively,
reverting both fixes to Bug#29799 in addition to the Bug#29866 fix
works:

[0001-Revert-Refix-conditional-step-clauses-in-cl-loop.patch (text/plain, attachment)]

[0002-Revert-cl-loop-Add-missing-guard-condition.patch (text/plain, attachment)]

[0003-Revert-cl-loop-Calculate-the-array-length-just-once.patch (text/plain, attachment)]

[0004-Mark-Bug-29799-tests-as-failing-since-we-reverted-th.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.