GNU bug report logs - #40691
[PATCH 0/1] gnu: Add gromacs.

Previous Next

Full log

Message #71 received at 40691 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 40691 <at> debbugs.gnu.org
Subject: Re: [bug#40691] [PATCH 3/3] gnu: Add gromacs.
Date: Sun, 03 May 2020 12:46:36 +0200

Vincent Legoll <vincent.legoll <at> gmail.com> skribis:

> * gnu/packages/bioinformatics.scm (gromacs): New variable.
> * gnu/packages/patches/gromacs-tinyxml2.patch: New file...
> * gnu/local.mk (dist_patch_DATA): ...add it here.

I wonder if chemistry.scm would be more appropriate, WDYT?

> --- /dev/null
> +++ b/gnu/packages/patches/gromacs-tinyxml2.patch
> @@ -0,0 +1,50 @@

Could you add one or two sentences at the top of the file explaining
what it does and what its upstream status is?  It’s not obvious why the
reference data needs to be adjusted as a consequence of unbundling
tinyxml2.

That’s it!

Could you send updated patches?  I’ll be happy to commit them.  :-)

Thank you for all the work!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.