From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 17 06:38:00 2020 Received: (at submit) by debbugs.gnu.org; 17 Apr 2020 10:38:00 +0000 Received: from localhost ([127.0.0.1]:40032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPONk-0002Aj-6f for submit@debbugs.gnu.org; Fri, 17 Apr 2020 06:38:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:39906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPONi-0002Aa-5t for submit@debbugs.gnu.org; Fri, 17 Apr 2020 06:37:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPONg-0008V7-64 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 06:37:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPONe-0002nA-A3 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 06:37:56 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:44973) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPONd-0002lZ-CP for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 06:37:54 -0400 Received: by mail-ed1-x544.google.com with SMTP id r7so1090494edo.11 for ; Fri, 17 Apr 2020 03:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=fN/Prrwtqk0hV3kHpVP6XPcTf3eVnRqpesLq66P1XW4=; b=YCk4KuF5KIm+vBd/9Z8MvEZ0SIiCO7XhnTB/O8bqeDWiES7FUcF1gyIrXzUybZV3b3 KrDG3KPl7PAOrXhM14F93LYXwb6txk7aLWW9i5glvFcHGy++Salh9Iatm3i5wp6P/yY6 jWVKfw3GGV8Vs8Aj0bkjRAQyUoinXvUjKWr8kqJo+i+LhBwB45pw/hPmToaPD0f9oI79 UmS1wD32uKK+gcz5//Qq4CqZy49myXrX6jjiL0K1aoDoYG9mQO9DZzUNNoTQRm6gPh3d 1LR7R/yOndRLBCbdGTWYmzaiy967BfM3DsSCl/bhkWWAgwMzXzuOo5H6b6fdlUXe7Ox9 Gn+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=fN/Prrwtqk0hV3kHpVP6XPcTf3eVnRqpesLq66P1XW4=; b=afTZYeFDIbUXEHbCBJOuBHu/TLvoCrE2YssWefjihGkA7o6UYFF8iUAs8KGEH7i9bq hlGSGFGSgMa+f0FXUw3QrVRktBgwORVJbZv4DzOdC+MuSCtXYkjIhEKZ7UUgYrho7VBG YobNJ5L1kNC4CI5G+2yr2idvd7rusmAiWELPqc0GoR2stXiU/1fOaQp48y/oegJdqAIB TK0Ki/4GX05mLF/DertAsA8MzUpOp++W8VpKuYYvsb/pIRZrP7jM6ET0t/zldA8xjs2w EV8C7SikEv1m8ExgOoHWivSgl9kOp1U/hwnR3LH3OXQ/YlCHptbaW0jisX1/RjPJxaiA Zv1Q== X-Gm-Message-State: AGi0Pub1fKSguXAVPnWg5A0rbXKfGW17Svo1t2MT+aqVvv2Eldg/Qn2t Br0AT0LqHxYrJmGScpTy66MnKOsFyLE= X-Google-Smtp-Source: APiQypKfd7s9bfFviUWKIao9oTiFliLuTUKUi7f0aksieLqsg8C4SksbQIxbt4Ta1t4Tl8VhXKU4fQ== X-Received: by 2002:a05:6402:2025:: with SMTP id ay5mr2208646edb.315.1587119871379; Fri, 17 Apr 2020 03:37:51 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id dg9sm2964519edb.91.2020.04.17.03.37.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 03:37:50 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Multiple definitions of explicit-shell-file-name X-Debbugs-Cc: Stefan Monnier , Tino Calancha Date: Fri, 17 Apr 2020 11:37:49 +0100 Message-ID: <871rom5req.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Define-explicit-shell-file-name-only-in-shell.el.patch >From 0744d8d7c8a6a4b9cdddec8a8a39abef06559e17 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 17 Apr 2020 10:27:36 +0100 Subject: [PATCH] Define explicit-shell-file-name only in shell.el For discussion, see the following thread: https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg00880.html * doc/emacs/cmdargs.texi (General Variables): Mention shell-file-name in relation to SHELL. * doc/emacs/misc.texi (Interactive Shell): Move index entry for SHELL environment variable from here, where it is not mentioned... (Single Shell): ...to here, where it is discussed along with shell-file-name. * lisp/dired.el (dired-insert-directory): Use shell-file-name instead of explicit-shell-file-name when a shell is implicitly requested. * lisp/obsolete/terminal.el (explicit-shell-file-name): * lisp/term.el (explicit-shell-file-name): Remove duplicate defcustoms and load lisp/shell.el instead. * lisp/shell.el (explicit-shell-file-name): Clarify docstring. (shell): Simplify. --- doc/emacs/cmdargs.texi | 3 ++- doc/emacs/misc.texi | 2 +- lisp/dired.el | 3 +-- lisp/obsolete/terminal.el | 7 +------ lisp/shell.el | 24 ++++++++++++------------ lisp/term.el | 16 +++------------- 6 files changed, 20 insertions(+), 35 deletions(-) diff --git a/doc/emacs/cmdargs.texi b/doc/emacs/cmdargs.texi index 9303b0b8dd..936facbf28 100644 --- a/doc/emacs/cmdargs.texi +++ b/doc/emacs/cmdargs.texi @@ -647,7 +647,8 @@ General Variables @item SHELL @vindex SHELL@r{, environment variable} The name of an interpreter used to parse and execute programs run from -inside Emacs. +inside Emacs. This is used to initialize the variable +@code{shell-file-name} (@pxref{Single Shell}). @item SMTPSERVER @vindex SMTPSERVER@r{, environment variable} The name of the outgoing mail server. This is used to initialize the diff --git a/doc/emacs/misc.texi b/doc/emacs/misc.texi index d097f4ee7d..8e1b61815d 100644 --- a/doc/emacs/misc.texi +++ b/doc/emacs/misc.texi @@ -806,6 +806,7 @@ Single Shell @file{*Shell Command Output*} buffer. @vindex shell-file-name +@cindex @env{SHELL} environment variable The above commands use the shell specified by the variable @code{shell-file-name}. Its default value is determined by the @env{SHELL} environment variable when Emacs is started. If the file @@ -875,7 +876,6 @@ Interactive Shell @vindex explicit-shell-file-name @cindex environment variables for subshells @cindex @env{ESHELL} environment variable -@cindex @env{SHELL} environment variable To specify the shell file name used by @kbd{M-x shell}, customize the variable @code{explicit-shell-file-name}. If this is @code{nil} (the default), Emacs uses the environment variable @env{ESHELL} if it diff --git a/lisp/dired.el b/lisp/dired.el index 14bbb28db5..071597716c 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1448,8 +1448,7 @@ dired-insert-directory (script (format "ls %s %s" switches (cdr dir-wildcard))) (remotep (file-remote-p dir)) (sh (or (and remotep "/bin/sh") - (and (bound-and-true-p explicit-shell-file-name) - (executable-find explicit-shell-file-name)) + (executable-find shell-file-name) (executable-find "sh"))) (switch (if remotep "-c" shell-command-switch))) (unless diff --git a/lisp/obsolete/terminal.el b/lisp/obsolete/terminal.el index 6ee53af648..3d73c030c3 100644 --- a/lisp/obsolete/terminal.el +++ b/lisp/obsolete/terminal.el @@ -44,6 +44,7 @@ ;;>> more-processing enabled. (require 'ehelp) +(require 'shell) (defgroup terminal nil "Terminal emulator for Emacs." @@ -1056,12 +1057,6 @@ te-stty-string ;; This used to have `new' in it, but that loses outside BSD ;; and it's apparently not needed in BSD. -(defcustom explicit-shell-file-name nil - "If non-nil, is file name to use for explicitly requested inferior shell." - :type '(choice (const :tag "None" nil) - file) - :group 'terminal) - ;;;###autoload (defun terminal-emulator (buffer program args &optional width height) "Under a display-terminal emulator in BUFFER, run PROGRAM on arguments ARGS. diff --git a/lisp/shell.el b/lisp/shell.el index 1e2679f723..6688f9dcd9 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -268,10 +268,11 @@ shell-dirtrack-verbose :group 'shell-directories) (defcustom explicit-shell-file-name nil - "If non-nil, is file name to use for explicitly requested inferior shell. -When nil, such interactive shell sessions fallback to using either -the shell specified in $ESHELL or in `shell-file-name'." - :type '(choice (const :tag "None" nil) file) + "If non-nil, the file name to use for explicitly requested inferior shells. +When nil, such interactive shell sessions fall back to using the +shell specified in either the environment variable \"ESHELL\" or +`shell-file-name'." + :type '(choice (const :tag "Default" nil) file) :group 'shell) ;; Note: There are no explicit references to the variable `explicit-csh-args'. @@ -742,16 +743,15 @@ shell (with-connection-local-variables ;; On remote hosts, the local `shell-file-name' might be useless. - (when (file-remote-p default-directory) - (if (and (called-interactively-p 'any) + (when (and (file-remote-p default-directory) + (called-interactively-p 'any) (null explicit-shell-file-name) (null (getenv "ESHELL"))) - (set (make-local-variable 'explicit-shell-file-name) - (file-local-name - (expand-file-name - (read-file-name - "Remote shell path: " default-directory shell-file-name - t shell-file-name)))))) + (setq-local explicit-shell-file-name + (file-local-name + (expand-file-name + (read-file-name "Remote shell path: " default-directory + shell-file-name t shell-file-name))))) ;; Rain or shine, BUFFER must be current by now. (unless (comint-check-proc buffer) diff --git a/lisp/term.el b/lisp/term.el index b990c83cfc..373d23d2e2 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -302,15 +302,10 @@ term-protocol-version (eval-when-compile (require 'ange-ftp)) (eval-when-compile (require 'cl-lib)) -(require 'ring) -(require 'ehelp) (require 'comint) ; Password regexp. - -(declare-function ring-empty-p "ring" (ring)) -(declare-function ring-ref "ring" (ring index)) -(declare-function ring-insert-at-beginning "ring" (ring item)) -(declare-function ring-length "ring" (ring)) -(declare-function ring-insert "ring" (ring item)) +(require 'ehelp) +(require 'ring) +(require 'shell) (defgroup term nil "General command interpreter in a window." @@ -394,11 +389,6 @@ term-pager-old-filter (defvar-local term-line-mode-buffer-read-only nil "The `buffer-read-only' state to set in `term-line-mode'.") -(defcustom explicit-shell-file-name nil - "If non-nil, is file name to use for explicitly requested inferior shell." - :type '(choice (const nil) file) - :group 'term) - (defvar term-prompt-regexp "^" "Regexp to recognize prompts in the inferior process. Defaults to \"^\", the null string at BOL. -- 2.25.1 --=-=-= Content-Type: text/plain This is a followup to the following emacs-devel thread: https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg00880.html The user option explicit-shell-file-name has been defined in three different places and under three different custom groups since at least as far back as 1997: - lisp/shell.el - lisp/term.el - lisp/obsolete/terminal.el I think there should be only a single definition, and lisp/shell.el was suggested as the correct place in the aforementioned thread. I attach a patch which does this and also cleans up a couple of uses of explicit-shell-file-name. Tino, was there a particular reason for using explicit-shell-file-name instead of shell-file-name in dired-insert-directory[1], or is it safe to swap them? [1]: Don't assume /bin/sh as the 'sh' location in the local host e82c4f56e6 2017-08-02 16:50:44 +0900 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25 Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 17 07:21:31 2020 Received: (at control) by debbugs.gnu.org; 17 Apr 2020 11:21:31 +0000 Received: from localhost ([127.0.0.1]:40066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPP3r-0005Lk-Lm for submit@debbugs.gnu.org; Fri, 17 Apr 2020 07:21:31 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:34914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPP3p-0005LU-PF for control@debbugs.gnu.org; Fri, 17 Apr 2020 07:21:30 -0400 Received: by mail-ej1-f53.google.com with SMTP id q8so1319989eja.2 for ; Fri, 17 Apr 2020 04:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=AcYcWY0zVlAKmvCiykTy6LT/4gysqQI7G4F40QB7TFw=; b=U/lbeCMK/jU/m/X3+Ix2mM8Gin07Krl75anyp7t9f2fJQ9LVTfRXr8ERTpSwS1ASjK /4EWhsvh2/RFAy2rJH5+9RyzHw14aWoK5bkgkJ61hckNPjzEHYdWnn6z0nZuBSGywUOT XUOI71Dq9CU3/JP/Vei0Wgk8HQQcIQp3cqc1Zm5y8s6lIv4e3+V0qfy2GS3sO0NiGbE3 b+xuuyer+ssutNeJaHu8NsBzFDd2VKwbSmZNZyu+shFYWZsdc9yDqrM0RmQ77gn2qDOO C/sIUJp3dffFJAGJRwvD7uB8fJuoaCX1lGBSahYZM3qzSub17JjQsL/BCR8JEWCdhw3w /fww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=AcYcWY0zVlAKmvCiykTy6LT/4gysqQI7G4F40QB7TFw=; b=ku8/rhjdvB5Sq+tEuMBzTUCB41ed4V/cPZ6wx8KKqX1iT7aHczB3bGZMXfHBsjWnWE StSIQC96JX2hjGM2GbadkCm3n5IV9V3ABoj27KIcOMLYCcRQj78xuGXybeQx7HWEQGKg Xvpoieyi86/FuIvALA+b0tfQh6nH/IXzQyj/i7TopAUT4F3g3IFxDr4fltiYqgW/U3du ALmENN3n0Mx7wIUAqtAXqVt1lGdUMt0bc3aSxhZosMRheIlmRPwLvvBGuUxAr6xT4SOe 3jHlPCiZhBAy5SpM99Ml/TJhVxKvQgZonFRPWf0C3i5Vbbj7SeRbmz0ZQec82A2IKbpg EANA== X-Gm-Message-State: AGi0PuaSd04V8dCRNGBMiSg5HBkASyPKbDgn89JL89y1EmElC6IVjpAQ 6nHM2fAQuVAEDbowOl7YwFzh3jm13VY= X-Google-Smtp-Source: APiQypJEA8n0d6Lsm8RbUDnB1KO5G01CSXvCyBBCwICbTZ/mY4yrNqqjZntc3NSvWbdqU7Nd4oYwDQ== X-Received: by 2002:a17:906:4ecd:: with SMTP id i13mr2514021ejv.68.1587122483593; Fri, 17 Apr 2020 04:21:23 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id s9sm453879edy.33.2020.04.17.04.21.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 04:21:22 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #40679 Date: Fri, 17 Apr 2020 12:21:21 +0100 Message-ID: <87r1wm2w9a.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 40679 minor tags 40679 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 13 12:40:01 2020 Received: (at 40679) by debbugs.gnu.org; 13 Jun 2020 16:40:02 +0000 Received: from localhost ([127.0.0.1]:42438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk9CL-0005tQ-Kn for submit@debbugs.gnu.org; Sat, 13 Jun 2020 12:40:01 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:40499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk9CJ-0005t5-Eo for 40679@debbugs.gnu.org; Sat, 13 Jun 2020 12:39:59 -0400 Received: by mail-wm1-f46.google.com with SMTP id r15so10746820wmh.5 for <40679@debbugs.gnu.org>; Sat, 13 Jun 2020 09:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8Xjnlt0Amgo4EcVNpZRJPurGIlzgWhE2pIkKnH/0SjE=; b=ijP86qs4JA5cqfZ9wnEi/4X5aAeJm+YN7Euvz++nbyXwVQt42/DsWbWJ7Z4QMwN1ug kFZbbtllfXEdESZ9LLL/hS8ys9VJ/kutnLnXm0QzCOXEPrdT1tVxfcHQna8drnTZ9Nv2 U60E62JxqwJ8xgXCYUVzUGCXEM33hAthZC4p2tTGTBSPlrcX9WTci8SKVhH1VL48SQSM iud4/R6iNvVA05zDSuGIRfGy+uZaqIQhmCOyLbpgOq3SoLzIpkPTebP8DtGibj4RYloZ 9Zf5Gq2Z640+aY3SXRK4uB8TJBF4A3s7RVvZQGVydgzT1n6+YV8p2CD8a2ObnhTmgEh/ xVWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8Xjnlt0Amgo4EcVNpZRJPurGIlzgWhE2pIkKnH/0SjE=; b=YfoyMlLjxcmGlzvDFHtlD5A6y4aEMc8fauP++h5DL9nQ1BTejXg7A49hStifW7JN3a mvlYJkO9dYco2qMWs5vgob1qA/lAenvFq3X0dP/bmhddEgJODhoSvhgMI8Jlipqk92cR spOLc/EKcawrP3SvnPWkhaKyOzUIe8hk9QDXz1xc/yn1tXQ3zkZSPZEhOmaaIdQ8zMVf QbFz9R5VwA2xXPO72er5Ig7fFHFzRwlLZClFRSSVcJhiC2fvlw0zyFcbxWJ0sIO7EI3v PRnLRMzbHlDeoIaAG+1rwU4Deo8h80IBWcuhe1d+VOxS8Gm+m9eOSdLQwThFve/nU9MQ o4HQ== X-Gm-Message-State: AOAM532bwrj7z9rVZitlF1MNvrTtesGJZ5dSEf4d8kkgrrp1BgjRxNcp oT8so+V1N/Y6cRw4lDd2pVU8bg== X-Google-Smtp-Source: ABdhPJwF1vP1IzWQJjy7ahQ7fDKWNVo0zMuS6R7ZlyYw8EpSYf3QiLckZ9qepcyGOSxJpQRP0goi+Q== X-Received: by 2002:a1c:544d:: with SMTP id p13mr4801672wmi.25.1592066393625; Sat, 13 Jun 2020 09:39:53 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id b8sm16192671wrs.36.2020.06.13.09.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 09:39:52 -0700 (PDT) From: "Basil L. Contovounesios" To: Tino Calancha Subject: Re: bug#40679: 28.0.50; Multiple definitions of explicit-shell-file-name References: <871rom5req.fsf@tcd.ie> Date: Sat, 13 Jun 2020 17:39:51 +0100 In-Reply-To: <871rom5req.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 17 Apr 2020 11:37:49 +0100") Message-ID: <87366y538o.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40679 Cc: 40679@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Tino, was there a particular reason for using explicit-shell-file-name > instead of shell-file-name in dired-insert-directory[1], or is it safe > to swap them? > > [1]: Don't assume /bin/sh as the 'sh' location in the local host > e82c4f56e6 2017-08-02 16:50:44 +0900 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25 Ping. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 09:55:52 2020 Received: (at 40679) by debbugs.gnu.org; 18 Aug 2020 13:55:52 +0000 Received: from localhost ([127.0.0.1]:36528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k825f-0007pl-NI for submit@debbugs.gnu.org; Tue, 18 Aug 2020 09:55:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:32928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k825e-0007pb-6C for 40679@debbugs.gnu.org; Tue, 18 Aug 2020 09:55:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eCMxv8PgoUw/Ag6404Mr3gwz+aENyFBZWEknukVVDyg=; b=bZH7vS34Xs/I12Kkxepjk0IOsy p1DStZClpIBEFkfk+XB21dNxCb3drQmYjM+cY/qLpnnUFhy3De9pmqXuKEWQxkpqVNZLbWu7XIfhi v0RVjOVOPugnkxtZXM0Ras1Q7TQfQbJCYriUgtFQ9gr8Uw3jI9npjQ69qyz3U5b+0kZ4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k825U-0007b8-Dr; Tue, 18 Aug 2020 15:55:43 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#40679: 28.0.50; Multiple definitions of explicit-shell-file-name References: <871rom5req.fsf@tcd.ie> <87366y538o.fsf@tcd.ie> X-Now-Playing: Cocteau Twins's _Echoes in a Shallow Bay_: "Eggs and Their Shells" Date: Tue, 18 Aug 2020 15:55:39 +0200 In-Reply-To: <87366y538o.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 13 Jun 2020 17:39:51 +0100") Message-ID: <87pn7okqhw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > "Basil L. Contovounesios" writes: > >> Tino, was there a particular reason for using explicit-shell-file-name >> instead of shell-file-name in dired-insert-directory[1], or is it s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40679 Cc: 40679@debbugs.gnu.org, Stefan Monnier , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > "Basil L. Contovounesios" writes: > >> Tino, was there a particular reason for using explicit-shell-file-name >> instead of shell-file-name in dired-insert-directory[1], or is it safe >> to swap them? >> >> [1]: Don't assume /bin/sh as the 'sh' location in the local host >> e82c4f56e6 2017-08-02 16:50:44 +0900 >> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25 > > Ping. Tino, did you find time to have a look at Basil's patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 12:28:48 2020 Received: (at control) by debbugs.gnu.org; 3 Dec 2020 17:28:48 +0000 Received: from localhost ([127.0.0.1]:41675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kksPQ-0007iW-Hy for submit@debbugs.gnu.org; Thu, 03 Dec 2020 12:28:48 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:54584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kksPO-0007iF-42 for control@debbugs.gnu.org; Thu, 03 Dec 2020 12:28:46 -0500 Received: by mail-wm1-f52.google.com with SMTP id d3so3447029wmb.4 for ; Thu, 03 Dec 2020 09:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BeuGXBJhOJ18iB42KeWK1YpvsgwxNxsHsJrE/ux71cw=; b=b+ZGp9OwWwR4gVN1DwEooQVh8CAH2aySp7Zf49IJgjs6hKCRa2g8vUXUuAJDxXqTQu y8wEMZmyyybntVrvgiJ8ZkPaHvZJI7UPRsgdjrQ7kXXaSo3gsaFsI7AZTYmrWiYPUs6Z rX10tX/mgIzPR9O65aIlg8hswgCsM6gYBjL6xOQ284WVb6D7P5W5p9Kui/UoLGNSc8mY uCK8dIAIlOT2LzwNnasn21ZVubTqQuL0cOCzJOulvChkpamgPlBPs5YC+YPdioSILe5s g+rC1FsoTenFiwxZFhH8gNLW6ZJsBCbtqQAxEIDPDfEMr/6M0WmYqrUG7Hx+tuAgiLT8 0VVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BeuGXBJhOJ18iB42KeWK1YpvsgwxNxsHsJrE/ux71cw=; b=QVgR4B8/7tO9PPHJQ4E4hCEkvOpY4yftCGmouErvK1cV/Om/KlhieONiCI7XAfCNwE 2xW/OLJVO1+RQI1lhKf2Z5zM2OhxEyrdzjNr6G9ad23GCngMeVo9fE3w5zbdnHFDQ67p LaAsKpqIY1gv8/VBZDPZ8lIW1pK17/upPTsy6yexvIBPqfpKiopqgkTqAhL8/Eyj9JQ+ PGgZI6bMrmq2Tmq5kmn/kSpFh969OaVJxNXYXqI24DXNewoh/GeYXReget3HZTe4dAAd 83PQgtya+ndxyGHmW16x/meWo7zqs5zApucQ3cYQvLBXD/Ua9a7e1eE7ameVcBr0Epu7 EXFw== X-Gm-Message-State: AOAM530KesAMFEdsMdh+Yv6s0AoryPBfDKdF0VVmT1dGhGMyF4jvNn3e 484qM84kAVzCT5VvaRttG9TO3g== X-Google-Smtp-Source: ABdhPJylPKybtqDk6yiWzS+FzNr7N9JY+j7BOSW+E3nCEiJtISafVMEtFK4IJ8N0tlIAWFLSEa4pMQ== X-Received: by 2002:a1c:186:: with SMTP id 128mr193199wmb.176.1607016520025; Thu, 03 Dec 2020 09:28:40 -0800 (PST) Received: from localhost ([51.37.121.192]) by smtp.gmail.com with ESMTPSA id l24sm205444wrb.28.2020.12.03.09.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 09:28:39 -0800 (PST) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#40679: 28.0.50; Multiple definitions of explicit-shell-file-name References: <871rom5req.fsf@tcd.ie> <87366y538o.fsf@tcd.ie> <87pn7okqhw.fsf@gnus.org> Date: Thu, 03 Dec 2020 17:28:37 +0000 In-Reply-To: <87pn7okqhw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 18 Aug 2020 15:55:39 +0200") Message-ID: <87k0tyu7cq.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 40679-done@debbugs.gnu.org, Stefan Monnier , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40679 fixed close 40679 28.1 quit No comments/objections in 8 months, so I've now pushed this to master. Define explicit-shell-file-name only in shell.el 6ecec60966 2020-12-03 17:25:04 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6ecec6096697729491ba141e7650ad69de5f034e -- Basil From unknown Sun Jun 15 08:48:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Jan 2021 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator