GNU bug report logs - #40679
28.0.50; Multiple definitions of explicit-shell-file-name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40679 in the body.
You can then email your comments to 40679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Multiple definitions of explicit-shell-file-name
Date: Fri, 17 Apr 2020 11:37:49 +0100

[0001-Define-explicit-shell-file-name-only-in-shell.el.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

This is a followup to the following emacs-devel thread:
https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg00880.html

The user option explicit-shell-file-name has been defined in three
different places and under three different custom groups since at least
as far back as 1997:

- lisp/shell.el
- lisp/term.el
- lisp/obsolete/terminal.el

I think there should be only a single definition, and lisp/shell.el was
suggested as the correct place in the aforementioned thread.

I attach a patch which does this and also cleans up a couple of uses of
explicit-shell-file-name.  Tino, was there a particular reason for using
explicit-shell-file-name instead of shell-file-name in
dired-insert-directory[1], or is it safe to swap them?

[1]: Don't assume /bin/sh as the 'sh' location in the local host
e82c4f56e6 2017-08-02 16:50:44 +0900
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25

Thanks,

-- 
Basil

Message #12 received at 40679 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 40679 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#40679: 28.0.50; Multiple definitions of
 explicit-shell-file-name
Date: Sat, 13 Jun 2020 17:39:51 +0100

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Tino, was there a particular reason for using explicit-shell-file-name
> instead of shell-file-name in dired-insert-directory[1], or is it safe
> to swap them?
>
> [1]: Don't assume /bin/sh as the 'sh' location in the local host
> e82c4f56e6 2017-08-02 16:50:44 +0900
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25

Ping.

-- 
Basil

Message #15 received at 40679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 40679 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#40679: 28.0.50; Multiple definitions of
 explicit-shell-file-name
Date: Tue, 18 Aug 2020 15:55:39 +0200

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Tino, was there a particular reason for using explicit-shell-file-name
>> instead of shell-file-name in dired-insert-directory[1], or is it safe
>> to swap them?
>>
>> [1]: Don't assume /bin/sh as the 'sh' location in the local host
>> e82c4f56e6 2017-08-02 16:50:44 +0900
>> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25
>
> Ping.

Tino, did you find time to have a look at Basil's patch?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 40679-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 40679-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#40679: 28.0.50; Multiple definitions of
 explicit-shell-file-name
Date: Thu, 03 Dec 2020 17:28:37 +0000

tags 40679 fixed
close 40679 28.1
quit

No comments/objections in 8 months, so I've now pushed this to master.

Define explicit-shell-file-name only in shell.el
6ecec60966 2020-12-03 17:25:04 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6ecec6096697729491ba141e7650ad69de5f034e

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.