GNU bug report logs - #40677
Jami

Previous Next

Full log

Message #323 received at 40677 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
Cc: 40677 <at> debbugs.gnu.org
Subject: Re: [bug#40677] [PATCH V3 04/15] gnu: Add libnatpmp.
Date: Sat, 02 May 2020 10:22:48 +0200

Hello Jan,

Thanks for this v3! I applied this one with the following edits:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 603d8b8e3a..431b0fafd4 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -439,8 +439,6 @@ files contain direct mappings of the abstractions provided by the ØMQ C API.")
                (base32
                 "1c1n8n7mp0amsd6vkz32n8zj3vnsckv308bb7na0dg0r8969rap1"))))
     (build-system gnu-build-system)
-    (native-inputs
-     `(("pkg-config" ,pkg-config)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
@@ -448,16 +446,13 @@ files contain direct mappings of the abstractions provided by the ØMQ C API.")
          (delete 'check)) ; no tests
        #:make-flags
        (let* ((target ,(%current-target-system))
-              (gcc (if target (string-append target "-gcc") "gcc"))
-              (pkg-config (if target
-                              (string-append target "-pkg-config")
-                              "pkg-config")))
+              (gcc (if target
+                       (string-append target "-gcc")
+                       "gcc")))
          (list
           (string-append "CC=" gcc)
-          (string-append "PKG_CONFIG="
-                         (assoc-ref %build-inputs "pkg-config")
-                         "/bin/" pkg-config)
-          (string-append "PREFIX=" (assoc-ref %outputs "out"))))))
+          (string-append "INSTALLPREFIX=" (assoc-ref %outputs "out"))
+          (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib")))))
     (home-page "http://miniupnp.free.fr/libnatpmp.html")
     (synopsis "C library implementing NAT-PMP")
     (description
--8<---------------cut here---------------end--------------->8---

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.