GNU bug report logs - #40677
Jami

Previous Next

Package: guix-patches;

Reported by: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>

Date: Fri, 17 Apr 2020 00:02:01 UTC

Severity: normal

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
Cc: 40677 <at> debbugs.gnu.org
Subject: [bug#40677] [PATCH 18/18] gnu: pjproject-jami: Add the missing, linux-only "--enable-epoll" flag.
Date: Wed, 22 Apr 2020 11:44:24 +0200

> -             "--disable-l16-codec"
> -             "--disable-gsm-codec"
> -             "--disable-g722-codec"
> -             "--disable-g7221-codec"
> -             "--disable-speex-codec"

You should fix indentation in a separate commit, otherwise its hard to
see get what's going on here.

> +        ;; The following flag is linux specific
> +        ,@(if (hurd-triplet? (or (%current-system)
> +                                 (%current-target-system)))
> +              '("--enable-epoll")
> +              '())

Don't we want to add this flag only on Linux platform? I think you
should transpose the if branches.

Thanks,

Mathieu
This bug report was last modified 5 years and 7 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.