Subject: Re: [bug#40677] [PATCH 04/18] gnu: Add libnatpmp.

From: Jan <[email-masked]>
Date: Tue, 28 Apr 2020 00:55:00 +0200

On Wed, 22 Apr 2020 11:27:37 +0200
Mathieu Othacehe <[email-masked]> wrote:

> > +         (delete 'configure)
> > +         (delete 'check))  
> 
> Please add a ;no tests comment.
Done.

> I guess we are dealing with a raw Makefile here. This is bad news
> because it means that cross-compilation is almost always broken.
> 
> You can run:
> 
> --8<---------------cut here---------------start------------->8---
> guix build --target=aarch64-linux-gnu libnatpmp
> --8<---------------cut here---------------end--------------->8---

It was built successfully, it works then I guess.

> to check it. Then, you probably need to do something similar as what
> is done in package "iw" (set CC variable at least).
Where can I read about this CC thing more? Is it needed when
cross-compilation works? 
> 
> > +       #:make-flags
> > +       (list (string-append "PREFIX=" (assoc-ref %outputs
> > "out")))))
> > +    (home-page "http://miniupnp.free.fr/libnatpmp.html")
> > +    (synopsis "C library implementing NAT-PMP")
> > +    (description
> > +     "libnatpmp is a portable and asynchronous implementaiton of  
>            ^
>        @code{libnatpmp}                                    ^
>                                                           typo
Fixed.

> Thanks,
> Mathieu

Jan Wielkiewicz