Subject: Re: [bug#40677] [PATCH 03/18] gnu: jami.scm: Add and use a generalized procedure for applying patches made by Savoir-faire linux to Jami dependencies.

From: Mathieu Othacehe <[email-masked]>
Date: Wed, 22 Apr 2020 11:07:41 +0200

> +;; Savoir-Faire Linux modifies many libraries to add features
> +;; to Jami. This procedure makes applying patches to a given
> +;; package easy.
> +(define-public jami-apply-dependency-patches

This does not need to be public.

> -     `(("savoir-faire-linux-patches" ,(jami-source))
> +     `(("SFL-patches" ,(jami-source))

I do prefer the old version without upper case.

> +       #:modules ((guix build utils)
> +                  ,@(@@ (guix build-system gnu) %default-modules))

pjproject is using the gnu-build-system which should provide all those
modules, so I don't think you need this.

Thanks,

Mathieu