GNU bug report logs - #40671
[DOC] modify literal objects

Previous Next

Package: emacs;

Reported by: Kevin Vigouroux <ke.vigouroux <at> laposte.net>

Date: Thu, 16 Apr 2020 20:40:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #474 received at 40671 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: ke.vigouroux <at> laposte.net, Paul Eggert <eggert <at> cs.ucla.edu>,
 40671 <at> debbugs.gnu.org, Mattias EngdegÄrd <mattiase <at> acm.org>,
 Dmitry Gutov <dgutov <at> yandex.ru>, Richard Stallman <rms <at> gnu.org>
Subject: Re: bug#40671: [DOC] modify literal objects
Date: Tue, 12 May 2020 00:36:28 +0200
Noam Postavsky <npostavs <at> gmail.com> writes:

> Paul Eggert <eggert <at> cs.ucla.edu> writes:
>
> >  (defvar gnus-article-mode-line-format-alist
> > -  (nconc '((?w (gnus-article-wash-status) ?s)
> > -	   (?m (gnus-article-mime-part-status) ?s))
> > -	 gnus-summary-mode-line-format-alist))
> > +  (nconc `((?w (gnus-article-wash-status) ?s)
> > +	   (?m (gnus-article-mime-part-status) ?s)
> > +	   ,@gnus-summary-mode-line-format-alist)))
>
> You meant to remove the nconc call too, right?

That, and, the code still makes literal lists to alist entries.  If you
modify these associations, you modify these literal lists.

I wonder how many of such uses of backquote expressions used to
construct alists are scattered throughout the Emacs code.

Michael.




This bug report was last modified 5 years and 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.