GNU bug report logs - #40659
gnu: transmission: Fix icons for GUI.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40659 in the body.
You can then email your comments to 40659 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: transmission: Fix icons for GUI.
Date: Thu, 16 Apr 2020 09:00:23 -0400

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to fix icons for transmission's graphical user
interface.

Regards,
RG.

[0001-gnu-transmission-Fix-icons-for-GUI.patch (text/x-patch, attachment)]

Message #8 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI.
Date: Thu, 16 Apr 2020 12:21:05 -0400

> From 9ab623acb7f70a49f965202c475e18d70e9f8933 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Thu, 16 Apr 2020 08:57:46 -0400
> Subject: [PATCH] gnu: transmission: Fix icons for GUI.
> 
> * gnu/packages/bittorrent.scm (transmission): Fix icons for GUI.

In general, we let users install the icons into their profiles rather
than propagating them.

Does Transmission work for you if you do that?

Message #11 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI. (v2)
Date: Thu, 16 Apr 2020 12:35:23 -0400

Hi Leo!

> In general, we let users install the icons into their profiles rather
> than propagating them.
> 
> Does Transmission work for you if you do that?

Yes, it works.

Anyway, propagation is not reuired. Just as inputs works. Looks like missing
input. I have attached revised patch with this email.

Regards,
RG.

Message #14 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI. (v2)
Date: Thu, 16 Apr 2020 12:37:46 -0400

[Message part 1 (text/plain, inline)]

Attached file here.

[0001-gnu-transmission-Fix-icons-for-GUI.patch (text/x-patch, attachment)]

Message #17 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI. (v2)
Date: Thu, 16 Apr 2020 13:36:31 -0400

On Thu, Apr 16, 2020 at 12:35:23PM -0400, Raghav Gururajan wrote:
> Hi Leo!
> 
> > In general, we let users install the icons into their profiles rather
> > than propagating them.
> > 
> > Does Transmission work for you if you do that?
> 
> Yes, it works.

Okay, then I think we should stick with the status quo. We should only
add the icons as dependencies when necessary. Icons are something where
it's better to avoid a static binding, like the time zone database and
fonts.

Message #20 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI. (v2)
Date: Thu, 16 Apr 2020 14:24:19 -0400

Hi Leo!

> Okay, then I think we should stick with the status quo. We should only
> add the icons as dependencies when necessary. Icons are something where
> it's better to avoid a static binding, like the time zone database and
> fonts.

I understand.  I think icons should be added as dependencies, when the program
is looking for a 'specific' icon theme. If the situation is like, the program
accepts any user-chosen/user-installed icon theme, then I think icons should
not be added as dependency. But here, transmission is hard-coded to use adwaita
icons. So it is a required dependecy and not optional dependency. :-)

Regards,
RG.

Message #23 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40659 <at> debbugs.gnu.org
Subject: gnu: transmission: Fix icons for GUI. (v3)
Date: Fri, 24 Apr 2020 17:08:21 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-transmission-Fix-icons-for-GUI.patch (text/x-patch, attachment)]

Message #26 received at 40659 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40659 <at> debbugs.gnu.org
Subject: Re: [bug#40659] gnu: transmission: Fix icons for GUI. (v2)
Date: Sun, 26 Apr 2020 20:32:24 -0400

On Thu, Apr 16, 2020 at 02:24:19PM -0400, Raghav Gururajan wrote:
> I understand.  I think icons should be added as dependencies, when the program
> is looking for a 'specific' icon theme. If the situation is like, the program
> accepts any user-chosen/user-installed icon theme, then I think icons should
> not be added as dependency. But here, transmission is hard-coded to use adwaita
> icons. So it is a required dependecy and not optional dependency. :-)

I don't think that non-functional data (such as icons and fonts) should
be made dependencies of other packages unless necessary. Instead, they
should be installed alongside packages by users or system-level services
as on Guix System.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.