GNU bug report logs - #40657
gnu: liblinphone: Fix icons for legacy UI.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40657 in the body.
You can then email your comments to 40657 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: liblinphone: Fix icons for legacy UI.
Date: Thu, 16 Apr 2020 08:42:26 -0400

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to fix icons in legacy user-interface of
liblinphone.

Regards,
RG.

[0001-gnu-liblinphone-Fix-icons-for-legacy-UI.patch (text/x-patch, attachment)]

Message #8 received at 40657 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40657 <at> debbugs.gnu.org
Subject: gnu: liblinphone: Fix icons. (v2)
Date: Mon, 20 Apr 2020 01:50:36 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-liblinphone-Fix-icons.patch (text/x-patch, attachment)]

Message #13 received at 40657-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40657-done <at> debbugs.gnu.org
Subject: Re: [bug#40657] gnu: liblinphone: Fix icons. (v2)
Date: Mon, 20 Apr 2020 22:03:10 -0400

Hello Raghav,

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

>>From f9dcbb7c2756f960721cf7194b710de3c4ac22e1 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Mon, 20 Apr 2020 01:47:50 -0400
> Subject: [PATCH] gnu: liblinphone: Fix icons.
>
> * gnu/packages/linphone.scm (liblinphone): Fix icons.
> ---
>  gnu/packages/linphone.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index c9959d7d01..8962f2001e 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -49,6 +49,7 @@
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system gnu))
>  
>  (define-public bcunit
> @@ -428,8 +429,17 @@ decoding, and rendering.")
>                                        "/lib/glib-2.0/include"))
>          "-DENABLE_STATIC=NO"            ; Not required
>          "-DENABLE_GTK_UI=YES")          ; For Legacy UI
> +       #:imported-modules (,@%cmake-build-system-modules
> +                           (guix build glib-or-gtk-build-system))
> +       #:modules ((guix build cmake-build-system)
> +                  ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
> +                  (guix build utils))
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'install 'glib-or-gtk-compile-schemas
> +           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
> +         (add-after 'install 'glib-or-gtk-wrap
> +           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
>           (add-after 'unpack 'patch
>             (lambda _
>               (substitute* "gtk/main.c"
> @@ -449,6 +459,7 @@ decoding, and rendering.")
>         ("belcard" ,belcard)
>         ("bellesip" ,belle-sip)
>         ("bzrtp", bzrtp)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme) ; Hard-coded for GTK UI
>         ("glib" ,glib)
>         ("gtk2" ,gtk+-2)
>         ("mediastreamer2" ,mediastreamer2)

Tested and pushed as commit 41169f21e6.

Thank you,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.