GNU bug report logs - #40653
28.0.50; (fset 'yes-or-no-p 'y-or-n-p) has no effect in native-comp branch

Previous Next

Full log

View this message in rfc822 format

From: Andrey Orst <andreyorst <at> gmail.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 40653 <at> debbugs.gnu.org, luknax <at> sdf.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#40653: 28.0.50; (fset 'yes-or-no-p 'y-or-n-p) has no effect in native-comp branch
Date: Thu, 16 Apr 2020 12:58:23 +0300

[Message part 1 (text/plain, inline)]

>
> The issue is that here we are shadowing with an alias a primitive C
> subr.
>
> Compiling speed 2 the assumption is that these are not redefined or
> advised (the manual warns about doing that).  Function calls to C
> primitives at speed 2 are hardcoded for performance reasons in the
> generated code.



 We have a customize listing exceptions for that
> `comp-never-optimize-functions'.
>


You should solve the issue adding `yes-or-no-p' to this customize and
> recompiling.
>

 Ah I see now. This makes sense, although also makes it harder to
configure.

On the other hand customizing `comp-never-optimize-functions' will solve
>
the issue only for external packages because you likely already have
> compiled the whole Emacs with the default setting...
>

IIUC I may need to modify the source code of the `comp.el` file, because it
gets used when doing `make`?

-- 
Best regards,
Andrey Orst

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.