GNU bug report logs - #40646
gnu: Add blueman.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40646 in the body.
You can then email your comments to 40646 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: Add blueman.
Date: Wed, 15 Apr 2020 13:52:34 -0400

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to add 'blueman' package.

Regards,
RG.

[blueman.patch (text/x-patch, attachment)]

Message #8 received at 40646 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40646 <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman.
Date: Sun, 19 Apr 2020 13:22:42 +0200

Hi!

Raghav Gururajan <raghavgururajan <at> disroot.org> skribis:

> From 5f1a319c6b75b3eb28e8f80ea9b31fc5d6cf70df Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Wed, 15 Apr 2020 13:49:55 -0400
> Subject: [PATCH 2/2] gnu: Add blueman.
>
> * gnu/packages/networking.scm (blueman): New variable.

[...]

> +             (substitute* "apps/blueman-adapters.in"
> +               (("@PYTHON@") (string-append (assoc-ref inputs "python")
> +                                            "/bin/python3.7")))

Are you sure this is necessary?  If these are scripts, the
‘patch-shebangs’ phase should take care of it.  Perhaps it’s enough to
add ‘python-wrapper’ as an input (it provides a “python” executable) and
then you can remove all this?

Thanks,
Ludo’.

Message #11 received at 40646 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Ludovic Courtès" <ludo <at> gnu.org>
Cc: 40646 <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman.
Date: Sun, 19 Apr 2020 11:27:31 +0000

Hi Ludo!

>> + (substitute* "apps/blueman-adapters.in"
>> + (("@PYTHON@") (string-append (assoc-ref inputs "python")
>> + "/bin/python3.7")))
> 
> Are you sure this is necessary? If these are scripts, the
> ‘patch-shebangs’ phase should take care of it. Perhaps it’s enough to
> add ‘python-wrapper’ as an input (it provides a “python” executable) and
> then you can remove all this?

It is not necessary. Those scripts were not patched by 'patch-shebangs' phase, and received warnings during build. So corrected them manually. :-)

Regards,
RG.

Message #14 received at 40646 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40646 <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman.
Date: Mon, 20 Apr 2020 00:21:23 +0200

Hi,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> skribis:

>>> + (substitute* "apps/blueman-adapters.in"
>>> + (("@PYTHON@") (string-append (assoc-ref inputs "python")
>>> + "/bin/python3.7")))
>> 
>> Are you sure this is necessary? If these are scripts, the
>> ‘patch-shebangs’ phase should take care of it. Perhaps it’s enough to
>> add ‘python-wrapper’ as an input (it provides a “python” executable) and
>> then you can remove all this?
>
> It is not necessary. Those scripts were not patched by 'patch-shebangs' phase, and received warnings during build. So corrected them manually. :-)

I think you overlooked the rest of my comment: if you add
‘python-wrapper’ as an input, everything will be fine.

Could you check?

Thanks in advance!

Ludo’.

Message #17 received at 40646 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40646 <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman.
Date: Sun, 19 Apr 2020 20:25:57 -0400

[Message part 1 (text/plain, inline)]

Hi Ludo!

Yes yes, sorry, I did not over look. I was gonna try it and then goon let you know. :-)

Regards,
RG.

On April 19, 2020 6:21:23 p.m. EDT, "Ludovic Courtès" <ludo <at> gnu.org> wrote:
>Hi,
>
>"Raghav Gururajan" <raghavgururajan <at> disroot.org> skribis:
>
>>>> + (substitute* "apps/blueman-adapters.in"
>>>> + (("@PYTHON@") (string-append (assoc-ref inputs "python")
>>>> + "/bin/python3.7")))
>>> 
>>> Are you sure this is necessary? If these are scripts, the
>>> ‘patch-shebangs’ phase should take care of it. Perhaps it’s enough
>to
>>> add ‘python-wrapper’ as an input (it provides a “python” executable)
>and
>>> then you can remove all this?
>>
>> It is not necessary. Those scripts were not patched by
>'patch-shebangs' phase, and received warnings during build. So
>corrected them manually. :-)
>
>I think you overlooked the rest of my comment: if you add
>‘python-wrapper’ as an input, everything will be fine.
>
>Could you check?
>
>Thanks in advance!
>
>Ludo’.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Message part 2 (text/html, inline)]

Message #20 received at 40646 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40646 <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman. (v2)
Date: Mon, 20 Apr 2020 02:10:32 -0400

[Message part 1 (text/plain, inline)]

Hi Ludo!

> Yes yes, sorry, I did not over look. I was gonna try it and then goon let you
> know. :-)
> 
> Regards,
> RG.
> 
> On April 19, 2020 6:21:23 p.m. EDT, "Ludovic Courtès" <ludo <at> gnu.org> wrote:
> >Hi,
> >
> >"Raghav Gururajan" <raghavgururajan <at> disroot.org> skribis:
> >  
> >>>> + (substitute* "apps/blueman-adapters.in"
> >>>> + (("@PYTHON@") (string-append (assoc-ref inputs "python")
> >>>> + "/bin/python3.7")))  
> >>> 
> >>> Are you sure this is necessary? If these are scripts, the
> >>> ‘patch-shebangs’ phase should take care of it. Perhaps it’s enough  
> >to  
> >>> add ‘python-wrapper’ as an input (it provides a “python” executable)  
> >and  
> >>> then you can remove all this?  
> >>
> >> It is not necessary. Those scripts were not patched by  
> >'patch-shebangs' phase, and received warnings during build. So
> >corrected them manually. :-)
> >
> >I think you overlooked the rest of my comment: if you add
> >‘python-wrapper’ as an input, everything will be fine.
> >
> >Could you check?
> >
> >Thanks in advance!

Please find the revised patch attached with this email. I tried
'python-wrapper', but still getting warnings during build.

Regards,
RG.

[0001-gnu-Add-blueman.patch (text/x-patch, attachment)]

Message #25 received at 40646-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40646-done <at> debbugs.gnu.org
Subject: Re: [bug#40646] gnu: Add blueman. (v2)
Date: Wed, 22 Apr 2020 17:20:37 +0200

[Message part 1 (text/plain, inline)]

Hi,

Raghav Gururajan <raghavgururajan <at> disroot.org> skribis:

> From 8278afcea18d19324b790343e3a047bc9ab567d7 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Mon, 20 Apr 2020 02:05:49 -0400
> Subject: [PATCH] gnu: Add blueman.
>
> * gnu/packages/networking.scm (blueman): New variable.

Applied with the cosmetic changes below.  Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 9864783bd4..6231632c06 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -167,9 +167,10 @@
        ("pygobject" ,python-pygobject)
        ("python" ,python-wrapper)
        ("libnm" ,libnma)))
-    (synopsis "GTK+ Bluetooth Manager")
-    (description "Blueman is a bluetooth management utility using bluez dbus
-backend.  It is designed to be easy to use for most common bluetooth tasks.")
+    (synopsis "GTK+ Bluetooth manager")
+    (description "Blueman is a Bluetooth management utility using the Bluez
+D-Bus backend.  It is designed to be easy to use for most common Bluetooth
+tasks.")
     (home-page "https://github.com/blueman-project/blueman")
     (license license:gpl3+)))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.