GNU bug report logs - #40643
[PATCH] git-version: Handle invalid arguments gracefully

Previous Next

Full log

Message #8 received at 40643 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 40643 <at> debbugs.gnu.org
Subject: Re: [bug#40643] [PATCH] git-version: Handle invalid arguments
 gracefully
Date: Fri, 17 Apr 2020 23:16:44 +0200

Hi Jakub,

Jakub Kądziołka <kuba <at> kadziolka.net> skribis:

> * guix/git-download.scm (git-version): Add a check for commit ID length.
> ---
> If you're curious for the motivation, see [1]. This took a while to
> debug, so I'm hoping to ease this for the next person who inevitably
> stumbles upon this. Is a change like this okay?

Yes, I think so.  The ‘error’ procedure is not great, we would rather
use ‘raise’ with a ‘&message’ condition (which additionally allows for
i18n) but it’s no big deal here.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.