GNU bug report logs - #40643
[PATCH] git-version: Handle invalid arguments gracefully

Previous Next

Full log

View this message in rfc822 format

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40643 <at> debbugs.gnu.org
Subject: [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully
Date: Wed, 22 Apr 2020 00:45:45 +0200

[Message part 1 (text/plain, inline)]

On Fri, Apr 17, 2020 at 11:16:44PM +0200, Ludovic Courtès wrote:
> Hi Jakub,
> 
> Jakub Kądziołka <kuba <at> kadziolka.net> skribis:
> 
> > * guix/git-download.scm (git-version): Add a check for commit ID length.
> > ---
> > If you're curious for the motivation, see [1]. This took a while to
> > debug, so I'm hoping to ease this for the next person who inevitably
> > stumbles upon this. Is a change like this okay?
> 
> Yes, I think so.  The ‘error’ procedure is not great, we would rather
> use ‘raise’ with a ‘&message’ condition (which additionally allows for
> i18n) but it’s no big deal here.

I considered using raise instead, but I couldn't get it to work
properly. I was getting a "Wrong type (expecting exact integer)" error
instead:

(raise
  (condition (&message
    (message "git-version: commit ID unexpectedly short"))))

Do you know why that might be?

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.