GNU bug report logs - #40622
new package 'flowee'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40622 in the body.
You can then email your comments to 40622 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: guix-patches <at> gnu.org
Subject: new package 'flowee'.
Date: Tue, 14 Apr 2020 09:27:00 +0200

[Message part 1 (text/plain, inline)]

Please merge.

-- 
Tom Zander

[0001-gnu-Add-flowee.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tom Zander via Guix-patches via <guix-patches <at> gnu.org>
Cc: 40622 <at> debbugs.gnu.org, Tom Zander <tomz <at> freedommail.ch>
Subject: Re: [bug#40622] new package 'flowee'.
Date: Tue, 14 Apr 2020 10:09:36 +0200

Hello,

Tom Zander via Guix-patches via <guix-patches <at> gnu.org> writes:

> Please merge.

Thank you. I have some comments first. :)

>         (sha256
> -        (base32 "1c1hkik8avill8ha33g76rk4b03j5ac8wiml69q4jav7a63ywgfy"))))
> +        (base32 "1ajd5axv9zyhh6njrvamm11zn52j1q4j3mwn2nfv7cjd4lhnhlsr"))))

This change is unrelated.

>      (build-system gnu-build-system)
>      (arguments
>       `(#:phases
> @@ -1440,6 +1440,70 @@ walets in a fast and small server.  The full data is stored in a full node,
>  like Flowee the Hub, which Fulcrum connects to over RPC.")
>      (license license:gpl3+)))
>  
> +(package
> +  (name "flowee")
> +  (version "2020.03.1")

You forgot to define a variable for this package.

> +  (source (origin
> +         (method url-fetch)
> +         (uri (string-append "https://gitlab.com/FloweeTheHub/thehub/-/archive/"
> +                             version "/thehub-" version ".tar.gz"))
> +          (sha256
> +            (base32
> +             "1w20haldxlnppi2lkn5xsmw8cnxpcc92yradhb823d2ih66ybp0l"))))

Nitpick: I would move `origin' under `source' and `base32' on the same
line as the string.

> +  (build-system cmake-build-system)
> +  (arguments
> +   `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF")
> +     #:phases
> +      (modify-phases %standard-phases
> +        (add-before 'configure 'make-qt-deterministic
> +          (lambda _
> +            ; Make Qt deterministic.

Comments on a full line need two semicolons.

> +            (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1")
> +           #t))
> +        (add-before 'configure 'disable-black-box
> +          ; the black-box testing runs full hubs and lets them interact.
> +          ; this is more fragile and a slow machine, or low memory machine, may
> +          ; make the tests timeout and fail.  We just disable them here.

Ditto.
> +          (lambda _
> +            (substitute* "testing/CMakeLists.txt"
> +              (("test_api") ""))
> +            #t))
> +        (add-after 'configure 'set-build-info
> +          ; Their genbuild.sh to generate a build.h fails in guix (no .git dir) .
> +          ; Its purpose is to write the tag name in the build.h file. We do that
> +          ; here instead.

See above.

> +  (inputs
> +   `(("boost" ,boost)
> +     ("libevent" ,libevent)
> +     ("miniupnpc" ,miniupnpc)
> +     ("qtbase" ,qtbase)
> +     ("gmp" ,gmp)
> +     ("openssl" ,openssl)))
> +  (native-inputs
> +   `(("pkg-config" ,pkg-config)
> +     ("util-linux" ,util-linux)       ; provides the hexdump command for tests
> +     ("qttools" ,qttools)))

Could you re-order inputs alphabetically?

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #14 received at 40622 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 40622 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#40622] new package 'flowee'.
Date: Tue, 14 Apr 2020 16:43:23 +0200

[Message part 1 (text/plain, inline)]

On dinsdag 14 april 2020 10:09:36 CEST Nicolas Goaziou wrote:
> Could you send an updated patch?

Thanks for your comments!

I applied all requested changes and please find a new patch attached.


-- 
Tom Zander

[0001-gnu-Add-flowee.patch (text/x-patch, attachment)]

Message #19 received at 40622-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tom Zander <tomz <at> freedommail.ch>
Cc: 40622-done <at> debbugs.gnu.org
Subject: Re: [bug#40622] new package 'flowee'.
Date: Wed, 15 Apr 2020 22:29:25 +0200

Hello,

Tom Zander <tomz <at> freedommail.ch> writes:

> I applied all requested changes and please find a new patch attached.

Thank you! I applied it as 87b343f7539fe9e5b4cb3814d1607855b8e7bde9.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.