Subject: [bug#40617] sysbench (New package)

From: Mathieu Othacehe <[email-masked]>
Date: Tue, 28 Apr 2020 10:28:21 +0200

Hello Eric,

Thanks for the patch.

> +    (version "1.0.19")

Looks like 1.0.20 is out there.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/akopytov/sysbench")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zgqb9cr7ld3vw4a3jhq1mlszhcyjlpr0c8q1jcp1d27l9dcvd1w"))
> +       (modules '((guix build utils)))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; until shebangs fixed

Tests can run but you actually need to modify run_tests.sh so that it's
able to locate the python interpreter.

> +       (modify-phases %standard-phases
> +         (delete 'bootstrap)
> +         (add-after 'patch-source-shebangs 'libtoolize
> +           (lambda _ (invoke "libtoolize" "--copy" "--force")))
> +         (add-after 'libtoolize 'aclocal
> +           (lambda _ (invoke "aclocal" "-I" "m4")))
> +         (add-after 'aclocal 'autoreconf
> +           (lambda _ (invoke "autoreconf" "--install")))
> +         (add-after 'autoreconf 'automake
> +           (lambda _ (invoke "automake"
> +                             "-c" "--foreign" "--add-missing")))
> +         (add-after 'automake 'autoconf
> +           (lambda _ (invoke "autoconf"))))))

You can remove all this block by just adding "which" to the
native-inputs list :)

> +    (synopsis "Scriptable multi-threaded benchmark tool ")

Trailing space at the end of the sentence.

> +    (description "sysbench is a scriptable multi-threaded benchmark tool based
> +on LuaJIT. It is most frequently used for database benchmarks, but can also be
> +used to create arbitrarily complex workloads that do not involve a database
> +server.")

Please remember to run `guix lint' before submitting.

Thanks,

Mathieu