GNU bug report logs - #40613
[PATCH] gnu: Add emacs-typing.

Previous Next

Full log

Message #16 received at 40613-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40613-done <at> debbugs.gnu.org,
 Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
Subject: Re: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Thu, 22 Oct 2020 17:33:17 -0400

Hello Nicolas, Alberto,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
>
> Thank you.
>
>> +(define-public emacs-typing
>> +  (package
>> +    (name "emacs-typing")
>> +    (version "1.1.4")
>
> This is not a regular release, this is extracted from the main file. We
> need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".
>
>> +    (description "@code{emacs-typing} is a game for Emacs that
>
> I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
> name of the game instead of the symbol.
>
>> +forces you to type words correctly as fast as possible, otherwise
>> +you will die.  The game builds the list of words from the active buffer")
>
> The description is missing a final dot.
>
>> +    (license license:gpl2)))
>
> The license is gpl2+.
>
> Could you send an updated patch?

I modified the original definition with your above suggestions and
pushed as commit a49bfa1f6c22363c9e495070f51b82e60b1495af.

Closing.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.