From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Leo , 4061@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 06 Aug 2009 03:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124952937127757 (code B ref -1); Thu, 06 Aug 2009 03:35:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 6 Aug 2009 03:29:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,GAPPY_SUBJECT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n763TTue027754 for ; Wed, 5 Aug 2009 20:29:30 -0700 Received: from mx10.gnu.org ([199.232.76.166]:49526) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MYtfU-0004R5-G0 for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MYtfT-0000aU-Iz for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:28 -0400 Received: from mx20.gnu.org ([199.232.41.8]:29204) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MYtfT-0000Zs-5j for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:27 -0400 Received: from ppsw-5.csi.cam.ac.uk ([131.111.8.135]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MYtfR-0005cv-HT for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:25 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:62727 helo=victoria.local) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MYtfP-00080P-Gl (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Thu, 06 Aug 2009 04:29:23 +0100 From: Leo To: emacs-pretest-bug@gnu.org Date: Thu, 06 Aug 2009 04:29:21 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: With saveplace enabled, it will be nice if place (point) can survive C-x C-v. At the moment, C-x C-v will move the point to a 'random' place. Leo From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Leo , 4061@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 15 Aug 2009 20:25:11 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.12503674956631 (code B ref 4061); Sat, 15 Aug 2009 20:25:11 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 15 Aug 2009 20:18:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,GAPPY_SUBJECT, HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-6.csi.cam.ac.uk (ppsw-6.csi.cam.ac.uk [131.111.8.136]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7FKIDku006622 for <4061@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 13:18:15 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:43230) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1McPhb-00082Y-JQ (Exim 4.70) for 4061@emacsbugs.donarmstrong.com (return-path ); Sat, 15 Aug 2009 21:18:11 +0100 From: Leo To: 4061@debbugs.gnu.org References: Date: Sat, 15 Aug 2009 21:18:10 +0100 In-Reply-To: (Leo's message of "Thu, 06 Aug 2009 04:29:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-08-06 04:29 +0100, Leo wrote: > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > With saveplace enabled, it will be nice if place (point) can survive C-x > C-v. At the moment, C-x C-v will move the point to a 'random' place. > > Leo In `find-alternate-file', the old buffer is renamed, the new buffer is created and then the renamed old buffer is killed. so the place is not saved before re-opening the file. It seems at the moment for a user the clean way to implement this feature is by using defadvice. But I think this is a very useful feature to have. -- Leo's Emacs uptime: 11 days, 19 hours, 50 minutes, 33 seconds From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Chong Yidong , 4061@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 16 Aug 2009 00:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.125038315419551 (code B ref 4061); Sun, 16 Aug 2009 00:45:04 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 16 Aug 2009 00:39:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.6 required=4.0 tests=AWL,GAPPY_SUBJECT,GMAIL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7G0dCL2019548 for <4061@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 17:39:13 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 6328057E21C; Sat, 15 Aug 2009 20:40:11 -0400 (EDT) From: Chong Yidong To: Karl Fogel Cc: 4061@debbugs.gnu.org, Leo Date: Sat, 15 Aug 2009 20:40:11 -0400 Message-ID: <87vdkok2vo.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Hi Karl, are you still maintaining saveplace.el? Could you take a look at this bug report? Leo wrote: > With saveplace enabled, it will be nice if place (point) can survive > C-x C-v. At the moment, C-x C-v will move the point to a 'random' > place. From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Karl Fogel , 4061@debbugs.gnu.org Resent-From: Karl Fogel Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 16 Aug 2009 16:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.125043911516284 (code B ref 4061); Sun, 16 Aug 2009 16:20:03 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 16 Aug 2009 16:11:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=GAPPY_SUBJECT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@Sanpietro.red-bean.com [66.146.193.61]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7GGBrRQ016281 for <4061@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 09:11:54 -0700 Received: from localhost ([127.0.0.1]:34161 helo=kfogel-work ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1MciKm-0000ln-ON; Sun, 16 Aug 2009 11:11:52 -0500 From: Karl Fogel To: Chong Yidong Cc: 4061@debbugs.gnu.org, Leo References: <87vdkok2vo.fsf@cyd.mit.edu> Date: Sun, 16 Aug 2009 12:11:52 -0400 In-Reply-To: <87vdkok2vo.fsf@cyd.mit.edu> (Chong Yidong's message of "Sat, 15 Aug 2009 20:40:11 -0400") Message-ID: <87y6pju4af.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Chong Yidong writes: > Hi Karl, are you still maintaining saveplace.el? Could you take a look > at this bug report? Yes, I'll take a look. Thank you for calling my attention to it. -Karl From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Leo , 4061@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 14:10:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.125051767520084 (code B ref 4061); Mon, 17 Aug 2009 14:10:04 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 17 Aug 2009 14:01:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,GAPPY_SUBJECT, HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-6.csi.cam.ac.uk (ppsw-6.csi.cam.ac.uk [131.111.8.136]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HE1Dum020081 for <4061@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 07:01:15 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:56117) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Md2ls-0003oP-K2 (Exim 4.70) (return-path ); Mon, 17 Aug 2009 15:01:12 +0100 From: Leo To: Karl Fogel Cc: 4061@debbugs.gnu.org, Chong Yidong References: <87vdkok2vo.fsf@cyd.mit.edu> <87y6pju4af.fsf@red-bean.com> Date: Mon, 17 Aug 2009 15:01:11 +0100 In-Reply-To: <87y6pju4af.fsf@red-bean.com> (Karl Fogel's message of "Sun, 16 Aug 2009 12:11:52 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-08-16 17:11 +0100, Karl Fogel wrote: > Chong Yidong writes: >> Hi Karl, are you still maintaining saveplace.el? Could you take a look >> at this bug report? > > Yes, I'll take a look. Thank you for calling my attention to it. > > -Karl I have been using the following simple defadvice. (defadvice find-alternate-file (before save-place activate) "Save place before `find-alternate-file'." (save-place-to-alist)) But I think a solution involving no defadvice is better. Hope this helps. Leo -- Leo's Emacs uptime: 13 days, 13 hours, 56 minutes, 25 seconds From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Karl Fogel , 4061@debbugs.gnu.org Resent-From: Karl Fogel Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 04 Sep 2009 21:45:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.125210034610939 (code B ref 4061); Fri, 04 Sep 2009 21:45:05 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 4 Sep 2009 21:39:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=AWL,FOURLA,GAPPY_SUBJECT, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84Ld4wr010936 for <4061@emacsbugs.donarmstrong.com>; Fri, 4 Sep 2009 14:39:05 -0700 Received: from localhost ([127.0.0.1]:59744 helo=kfogel-work ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1MjgUq-0006YV-2L; Fri, 04 Sep 2009 16:39:04 -0500 From: Karl Fogel To: 4061@debbugs.gnu.org Cc: Leo References: <87vdkok2vo.fsf@cyd.mit.edu> Date: Fri, 04 Sep 2009 17:39:02 -0400 In-Reply-To: <87vdkok2vo.fsf@cyd.mit.edu> (Chong Yidong's message of "Sat, 15 Aug 2009 20:40:11 -0400") Message-ID: <87k50e8k5l.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I know what causes this now. saveplace.el works like this: (add-hook 'kill-buffer-hook 'save-place-to-alist) Now, `save-place-to-alist' checks `buffer-file-name' and (properly) does nothing if there is no associated file. Since `find-alternate-file' unsets `buffer-file-name' after renaming the old buffer but before killing it, that effectively makes `save-place-to-alist' a no-op in the old buffer. It's not even clear what the most desirable behavior is. For example, in `find-alternate-file' (without my patch), if the old buffer is modified, should we still save place before killing it? I think so; or rather, I think we should do whatever saveplace.el does if one kills a modified buffer the normal way. I'm still thinking. My patch below isn't really the right thing (see below for why), but I wanted to record this all here to remember it. [[[ * emacs/emacs-cvs/lisp/files.el (find-alternate-file): Restore certain state in the old buffer before killing it, so that hooks behave as expected. This addresses http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4061. NOTE: DRAFT PATCH ONLY, DO NOT COMMIT. With this patch, doing C-x C-v in a modified buffer visiting a file causes the user to be prompted to save buffer " **lose**" (see files.el:find-alternate-file for why) after they have successfully found their new file. That is hardly a desirable behavior. I will post for others' thoughts on whether the original bug is a bug, and if it is what is the best way to fix it. ]]] [[[ * emacs/emacs-cvs/lisp/files.el (find-alternate-file): Restore certain state in the old buffer before killing it, so that hooks behave as expected. This addresses http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4061. NOTE: DRAFT PATCH ONLY, DO NOT COMMIT. With this patch, doing C-x C-v in a modified buffer visiting a file causes the user to be prompted to save buffer " **lose**" (see files.el:find-alternate-file for why) after they have successfully found their new file. That is hardly a desirable behavior. I will post for others' thoughts on whether the original bug is a bug, and if it is what is the best way to fix it. ]]] Index: lisp/files.el =================================================================== RCS file: /sources/emacs/emacs/lisp/files.el,v retrieving revision 1.1076 diff -u -r1.1076 files.el --- lisp/files.el 4 Sep 2009 03:18:11 -0000 1.1076 +++ lisp/files.el 4 Sep 2009 21:30:00 -0000 @@ -1507,17 +1507,24 @@ ;; Likewise for dired buffers. (setq dired-directory nil) (find-file filename wildcards)) - (when (eq obuf (current-buffer)) - ;; This executes if find-file gets an error - ;; and does not really find anything. - ;; We put things back as they were. - ;; If find-file actually finds something, we kill obuf below. - (setq buffer-file-name ofile) - (setq buffer-file-number onum) - (setq buffer-file-truename otrue) - (setq dired-directory odir) - (lock-buffer) - (rename-buffer oname))) + (progn + ;; There's some state that we want to restore in obuf before + ;; we kill obuf, whether find-file succeeded or not. For + ;; example, we restore buffer-file-name so that certain hooks + ;; (e.g., 'save-place-to-alist in 'kill-buffer-hook) can + ;; behave as expected. + (save-excursion + (set-buffer obuf) + (setq buffer-file-name ofile) + (setq buffer-file-number onum) + (setq buffer-file-truename otrue) + (setq dired-directory odir)) + ;; On the other hand, if find-file got an error and did not + ;; really find anything, we want to put everything back as it + ;; was, including the lock and the buffer name. + (when (eq obuf (current-buffer)) + (lock-buffer) + (rename-buffer oname)))) (unless (eq (current-buffer) obuf) (with-current-buffer obuf ;; We already asked; don't ask again. From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: 23.1.50; C-x C-v and saveplace Reply-To: Leo , 4061@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 05 Sep 2009 00:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.125210982110927 (code B ref 4061); Sat, 05 Sep 2009 00:20:04 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 5 Sep 2009 00:17:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,GAPPY_SUBJECT, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-1.csi.cam.ac.uk (ppsw-1.csi.cam.ac.uk [131.111.8.131]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n850Gx2O010919 for <4061@emacsbugs.donarmstrong.com>; Fri, 4 Sep 2009 17:17:01 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:37624) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Mjixf-0006Zu-3N (Exim 4.70) (return-path ); Sat, 05 Sep 2009 01:16:59 +0100 From: Leo To: Karl Fogel Cc: 4061@debbugs.gnu.org References: <87vdkok2vo.fsf@cyd.mit.edu> <87k50e8k5l.fsf@red-bean.com> Date: Sat, 05 Sep 2009 01:16:58 +0100 In-Reply-To: <87k50e8k5l.fsf@red-bean.com> (Karl Fogel's message of "Fri, 04 Sep 2009 17:39:02 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-09-04 22:39 +0100, Karl Fogel wrote: > I know what causes this now. saveplace.el works like this: > Now, `save-place-to-alist' checks `buffer-file-name' and (properly) does > nothing if there is no associated file. Since `find-alternate-file' > unsets `buffer-file-name' after renaming the old buffer but before > killing it, that effectively makes `save-place-to-alist' a no-op in the > old buffer. Thank you for looking into it. > > It's not even clear what the most desirable behavior is. For example, > in `find-alternate-file' (without my patch), if the old buffer is > modified, should we still save place before killing it? I think so; or > rather, I think we should do whatever saveplace.el does if one kills a > modified buffer the normal way. I agree with this. -- Leo's Emacs uptime: 2 days, 13 hours, 17 minutes, 9 seconds From unknown Sat Aug 16 16:07:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Leo Subject: bug#4061 closed by Karl Fogel (Re: bug#4061: 23.1.50; C-x C-v and saveplace) Message-ID: References: <873a7173dl.fsf@red-bean.com> X-Emacs-PR-Message: they-closed 4061 X-Emacs-PR-Package: emacs Reply-To: 4061@debbugs.gnu.org Date: Sat, 05 Sep 2009 16:45:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1252169104-5034-1" This is a multi-part message in MIME format... ------------=_1252169104-5034-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4061: 23.1.50; C-x C-v and saveplace It has been closed by Karl Fogel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Karl Fogel by replying to this email. --=20 4061: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4061 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1252169104-5034-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4061-done) by emacsbugs.donarmstrong.com; 5 Sep 2009 16:39:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=AWL,GAPPY_SUBJECT, HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n85Gd6vn003944 for <4061-done@emacsbugs.donarmstrong.com>; Sat, 5 Sep 2009 09:39:07 -0700 Received: from localhost ([127.0.0.1]:34390 helo=kfogel-work ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1MjyI5-0005yY-Iv; Sat, 05 Sep 2009 11:39:05 -0500 From: Karl Fogel To: 4061-done@debbugs.gnu.org Cc: Leo Subject: Re: bug#4061: 23.1.50; C-x C-v and saveplace References: <87vdkok2vo.fsf@cyd.mit.edu> <87k50e8k5l.fsf@red-bean.com> Reply-To: Karl Fogel Date: Sat, 05 Sep 2009 12:39:02 -0400 In-Reply-To: (Leo's message of "Sat, 05 Sep 2009 01:16:58 +0100") Message-ID: <873a7173dl.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Okay, this is fixed now: $ cat log-message.txt * lisp/files.el (find-alternate-file): Run `kill-buffer-hook' manually before killing the old buffer, since by the time `kill-buffer' is run so many buffer variables have been set to nil that it may not behave as expected. (Bug#4061) $ cvs ci -F log-message.txt files.el ChangeLog /sources/emacs/emacs/lisp/files.el,v <-- files.el new revision: 1.1078; previous revision: 1.1077 /sources/emacs/emacs/lisp/ChangeLog,v <-- ChangeLog new revision: 1.16100; previous revision: 1.16099 Mailing notification to emacs-diffs@gnu.org... sent. $ Leo, please test if you get a chance and let us know if you run into any problems. Notes on closing: I'm closing this report now by sending this mail to 4061-done@, as documented on http://debbugs.gnu.org/Developer#closing. I'm not positive that's the Right Way to do it, but since much of the documentation is still written in terms of Debian GNU/Linux instead of Emacs, and http://debbugs.gnu.org/server-control#fixed doesn't clarify either (for example, what should the "version" be? The version the bug was reported against, or the version the fix is likely to be be released in?), this is as good a guess as any. If someone knows the Right Way, please tell me, or better yet, document it where developers are likely to find it. -Karl ------------=_1252169104-5034-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 6 Aug 2009 03:29:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,GAPPY_SUBJECT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n763TTue027754 for ; Wed, 5 Aug 2009 20:29:30 -0700 Received: from mx10.gnu.org ([199.232.76.166]:49526) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MYtfU-0004R5-G0 for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MYtfT-0000aU-Iz for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:28 -0400 Received: from mx20.gnu.org ([199.232.41.8]:29204) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MYtfT-0000Zs-5j for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:27 -0400 Received: from ppsw-5.csi.cam.ac.uk ([131.111.8.135]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MYtfR-0005cv-HT for emacs-pretest-bug@gnu.org; Wed, 05 Aug 2009 23:29:25 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:62727 helo=victoria.local) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MYtfP-00080P-Gl (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Thu, 06 Aug 2009 04:29:23 +0100 From: Leo To: emacs-pretest-bug@gnu.org Subject: 23.1.50; C-x C-v and saveplace Date: Thu, 06 Aug 2009 04:29:21 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: With saveplace enabled, it will be nice if place (point) can survive C-x C-v. At the moment, C-x C-v will move the point to a 'random' place. Leo ------------=_1252169104-5034-1-- From unknown Sat Aug 16 16:07:49 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4061: marked as done (23.1.50; C-x C-v and saveplace) Reply-To: Leo , 4061@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 05 Sep 2009 17:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4061 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4061-submit@emacsbugs.donarmstrong.com id=B4061.12521696876857 (code B ref 4061); Sat, 05 Sep 2009 17:00:03 +0000 Received: (at 4061) by emacsbugs.donarmstrong.com; 5 Sep 2009 16:54:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,GAPPY_SUBJECT, HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-7.csi.cam.ac.uk (ppsw-7.csi.cam.ac.uk [131.111.8.137]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n85Gsjr7006852 for <4061@emacsbugs.donarmstrong.com>; Sat, 5 Sep 2009 09:54:46 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:38510) by ppsw-7.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MjyXD-0000xX-OO (Exim 4.70) (return-path ); Sat, 05 Sep 2009 17:54:43 +0100 From: Leo To: 4061@debbugs.gnu.org Cc: Karl Fogel References: <873a7173dl.fsf@red-bean.com> Date: Sat, 05 Sep 2009 17:54:43 +0100 In-Reply-To: (Emacs bug Tracking System's message of "Sat, 05 Sep 2009 16:45:03 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-09-05 17:45 +0100, Emacs bug Tracking System wrote: > Leo, please test if you get a chance and let us know if you run into > any problems. I downloaded the latest files.el and loaded with Emacs -q. After a brief testing, it seems the bug has indeed been fixed. Thank you very much. Best wishes, Leo -- Leo's Emacs uptime: 3 days, 5 hours, 56 minutes, 57 seconds