GNU bug report logs - #40607
Add usbguard package

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40609: closed (Add usbguard package)
Date: Thu, 30 Apr 2020 23:21:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 01 May 2020 01:20:35 +0200
with message-id <87bln8imrg.fsf <at> gnu.org>
and subject line Re: [bug#40607] [PATCH v3 0/3] Add usbguard package
has caused the debbugs.gnu.org bug report #40607,
regarding Add usbguard package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40607: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40607
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/3] gnu: umockdev: Fix test.
Date: Mon, 13 Apr 2020 21:49:58 +0200

* gnu/packages/check.scm (umockdev)[inputs]: Remove
'gobject-introspection'.
[arguments]: Replace phase 'skip-broken-test' by 'fix-test'.
---
 gnu/packages/check.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 2cfaddbc5f..ca0a00e004 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2020 Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
+;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2427,11 +2428,10 @@ provides a simple way to achieve this.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'skip-broken-test
+         (add-after 'unpack 'fix-test
            (lambda _
              (substitute* "tests/test-umockdev.c"
-               (("/\\* sys/ in other dir")
-                (string-append "return; // ")))
+               (("/run") "/tmp"))
              #t)))))
     (native-inputs
      `(("vala" ,vala)
@@ -2444,8 +2444,7 @@ provides a simple way to achieve this.")
     (inputs
      `(("glib" ,glib)
        ("eudev" ,eudev)
-       ("libgudev" ,libgudev)
-       ("gobject-introspection" ,gobject-introspection)))
+       ("libgudev" ,libgudev)))
     (home-page "https://github.com/martinpitt/umockdev/")
     (synopsis "Mock hardware devices for creating unit tests")
     (description "umockdev mocks hardware devices for creating integration
-- 
2.26.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40607-done <at> debbugs.gnu.org
Subject: Re: [bug#40607] [PATCH v3 0/3] Add usbguard package
Date: Fri, 01 May 2020 01:20:35 +0200

Hi,

Brice Waegeneire <brice <at> waegenei.re> skribis:

>   gnu: umockdev: Fix test.
>   gnu: Add libqb.
>   gnu: Add usbguard.

Applied, thanks!

For usbguard, there are apparently harmless warnings like:

--8<---------------cut here---------------start------------->8---
make[4]: Entering directory '/tmp/guix-build-usbguard-0.7.6.drv-0/usbguard-0.7.6/src/Tests'
  CXX      main.o
  CXX      Unit/test_Rule.o
cc1plus: warning: /usr/include/catch: No such file or directory [-Wmissing-include-dirs]
--8<---------------cut here---------------end--------------->8---

Looks like they pass -I/usr/include/catch?  Anyway, doesn’t matter much.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.