GNU bug report logs - #40601
guix-install.sh: port to other distros & init systems

Previous Next

Package: guix-patches;

Reported by: Vincent Legoll <vincent.legoll <at> gmail.com>

Date: Mon, 13 Apr 2020 16:05:01 UTC

Severity: normal

Tags: patch

Done: Vincent Legoll <vincent.legoll <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 40601 <at> debbugs.gnu.org
Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Remove $UID bashism.
Date: Wed, 23 Dec 2020 15:59:00 +0100

Hello,

On Wed, Dec 23, 2020 at 1:17 PM Christopher Baines <mail <at> cbaines.net> wrote:
> > -[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
> > +[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
> >
> >  REQUIRE=(
> >      "dirname"
>
> Should id be added as a requirement?

good catch !

thanks, I'll respin after this round of feedback

-- 
Vincent Legoll
This bug report was last modified 345 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.