GNU bug report logs - #40600
27.0.90; M-x strokes-list-strokes error

Previous Next

Full log

Message #11 received at 40600 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: tsuucat <tsuucat <at> icloud.com>
Cc: 40600 <at> debbugs.gnu.org
Subject: Re: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error
Date: Tue, 14 Apr 2020 12:48:55 -0400

tsuucat <tsuucat <at> icloud.com> writes:

> -  (let ((command-name-1 (symbol-name (cdr stroke1)))
> -	(command-name-2 (symbol-name (cdr stroke2))))
> +  (let ((command-name-1 (if (symbolp (cdr stroke1))
> +                            (symbol-name (cdr stroke1))
> +                          (prin1-to-string (cdr stroke1))))

Why use prin1-to-string?

> +        (command-name-2 (if (symbolp (cdr stroke2))
> +                            (symbol-name (cdr stroke2))
> +                          (prin1-to-string (cdr stroke2)))))
>      (string-lessp command-name-1 command-name-2)))

Actually, since string-lessp accepts symbols, an easier fix would be to
just drop the calls to symbol-name.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.