From unknown Mon Jun 23 22:03:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40600 <40600@debbugs.gnu.org> To: bug#40600 <40600@debbugs.gnu.org> Subject: Status: 27.0.90; M-x strokes-list-strokes error Reply-To: bug#40600 <40600@debbugs.gnu.org> Date: Tue, 24 Jun 2025 05:03:28 +0000 retitle 40600 27.0.90; M-x strokes-list-strokes error=20 reassign 40600 emacs submitter 40600 tsuucat severity 40600 normal tag 40600 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 13 11:51:27 2020 Received: (at submit) by debbugs.gnu.org; 13 Apr 2020 15:51:27 +0000 Received: from localhost ([127.0.0.1]:60530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jO1Ms-0006Q0-NT for submit@debbugs.gnu.org; Mon, 13 Apr 2020 11:51:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:48616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jO1Mr-0006Pt-N8 for submit@debbugs.gnu.org; Mon, 13 Apr 2020 11:51:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56918) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO1Mq-0008MG-If for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 11:51:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jO1Mp-0005F5-G8 for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 11:51:24 -0400 Received: from pv50p00im-ztdg10022001.me.com ([17.58.6.58]:47012) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jO1Mp-0005Bg-AP for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 11:51:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1586793081; bh=nKyby3rFYzipglup0iCdcLgTmoKNDH7P+9Qy1Opkhc8=; h=From:Content-Type:Subject:Message-Id:Date:To; b=vP+HqOTbYmC9roN1w1Stp+jmoeRdFEFK8FQfB94VVVQLNWUcm+vLPKxCcekQCYQVS hrxBa5g9YYWjuj46+Wc+j0qjHQ5Lg4byN54JxXgXU7rBY7enB9lQBKGDUii6hLP9XR Cac9RqF+gAHQgGqvv0qFDzrdBEF4GUO8Y6QEdHcb/o/XmS1kSkn4e6SwKkY0kzW3rP syir9W9pa5TP+DfIw19yD6ezBM7ZT/DqX3Z1GZ6ZYEkmRDANicinawDcO42awfyQ/X pG6dwjBMn1vInmKIy3uNOHW9YwFr1lzxqtwc73+/Uwx/IryWG5tbVjNdBjaCQxH4Bw 2WeWPwqrs625w== Received: from [192.168.129.26] (i114-183-98-221.s41.a008.ap.plala.or.jp [114.183.98.221]) by pv50p00im-ztdg10022001.me.com (Postfix) with ESMTPSA id B3C5FA05C8 for ; Mon, 13 Apr 2020 15:51:20 +0000 (UTC) From: tsuucat Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: 27.0.90; M-x strokes-list-strokes error Message-Id: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> Date: Tue, 14 Apr 2020 00:51:17 +0900 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-13_07:2020-04-13, 2020-04-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=366 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2002250000 definitions=main-2004130121 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 17.58.6.58 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I browsed Emacs source repository and found strokes.el package. This is very awesome but I found a bug. When two or more strokes are defined including string returning strokes,=20= M-x strokes-list-strokes causes an error. Reproduce steps: 1. emacs -Q 2. M-x strokes-global-set-stroke (and define a stroke and corresponding = command(emacs-version)) 3. M-x strokes-global-set-stroke-string (and define a stroke and = corresponding string(emacs)) 4. M-x strokes-list-strokes =3D> error message ;; when (setq debug-on-error t) Debugger entered--Lisp error: (wrong-type-argument symbolp "emacs") symbol-name("emacs") strokes-alphabetic-lessp((((6 . 0) (5 . 0) (4 . 0) (3 . 0) (2 . 0) (1 = . 0) (0 . 1) (0 . 2) (0 . 3) (0 . 4) (0 . 5) (1 . 5) (2 . 6) (3 . 6) (4 = . 6) (4 . 5) (5 . 4) (5 . 3) (6 . 3) (6 . 2) (6 . 1) (6 . 2) (6 . 3) (6 = . 4) (7 . 5) (7 . 6) (8 . 6) (8 . 7) (8 . 8)) . emacs-version) (((5 . 2) = (5 . 1) (4 . 1) (4 . 0) (3 . 0) (2 . 0) (2 . 1) (1 . 1) (1 . 2) (0 . 2) = (0 . 3) (0 . 4) (0 . 5) (0 . 6) (0 . 7) (1 . 7) (2 . 7) (3 . 7) (4 . 7) = (5 . 7) (6 . 7) (6 . 6) (7 . 5) (7 . 4) (7 . 5) (7 . 6) (7 . 7) (8 . 7) = (8 . 8)) . "emacs")) sort(((((5 . 2) (5 . 1) (4 . 1) (4 . 0) (3 . 0) (2 . 0) (2 . 1) (1 . = 1) (1 . 2) (0 . 2) (0 . 3) (0 . 4) (0 . 5) (0 . 6) (0 . 7) (1 . 7) (2 . = 7) (3 . 7) (4 . 7) (5 . 7) (6 . 7) (6 . 6) (7 . 5) (7 . 4) (7 . 5) (7 . = 6) (7 . 7) (8 . 7) (8 . 8)) . "emacs")) strokes-alphabetic-lessp) strokes-list-strokes(nil) funcall-interactively(strokes-list-strokes nil) call-interactively(strokes-list-strokes record nil) command-execute(strokes-list-strokes record) execute-extended-command(nil "strokes-list-strokes" "strokes-lis") funcall-interactively(execute-extended-command nil = "strokes-list-strokes" "strokes-lis") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) Thanks. -- tsuucat From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 10:38:42 2020 Received: (at 40600) by debbugs.gnu.org; 14 Apr 2020 14:38:42 +0000 Received: from localhost ([127.0.0.1]:34537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOMi2-0006sz-2E for submit@debbugs.gnu.org; Tue, 14 Apr 2020 10:38:42 -0400 Received: from pv50p00im-ztdg10012101.me.com ([17.58.6.49]:43518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOMhz-0006si-PK for 40600@debbugs.gnu.org; Tue, 14 Apr 2020 10:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1586875113; bh=16ZDMFfao/mPOkXSuK6dAP2LmvNKPQTlySLzsqL4dic=; h=From:Content-Type:Subject:Date:To:Message-Id; b=Q/1+6eN+qxcq/c19cGkZ66jgUT2A2ulAD9fYcE+ZVpmbIF+2sLUEiyrEcoQ5Gn+yU LAH9uTtVyPqbhjP3CoBdnfEbcnMQeLVfFby3c2D96POhvrS3D1sFS/6NODDFt+YkjB qKhk89xt7wU78v1uOaImUHFlZT2pmXy69PVZJp8nQb8/ZYULFTDlFhoqTpNWtl/rqy LMKrxmlpy+uN8rkWnvcHvVNKF7L28+zyyGMSsDt59npZPTTrMONpwfXQ9m1p7t/4My 2lDvquipgLSPT1gXZdgTwOHkJpruPQxW208RHSPJwliuIWCYYHMNI310uQ+XjL+FDq 5+SUYXLj5hjJA== Received: from [192.168.129.26] (i114-183-98-221.s41.a008.ap.plala.or.jp [114.183.98.221]) by pv50p00im-ztdg10012101.me.com (Postfix) with ESMTPSA id 852CA84076B for <40600@debbugs.gnu.org>; Tue, 14 Apr 2020 14:38:33 +0000 (UTC) From: tsuucat Content-Type: multipart/mixed; boundary="Apple-Mail=_EBA5D2C4-FA36-4041-8F21-55457C01C30C" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: [PATCH] 27.0.90; M-x strokes-list-strokes error Date: Tue, 14 Apr 2020 23:38:28 +0900 References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> To: 40600@debbugs.gnu.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.104.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-14_06:2020-04-14, 2020-04-14 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=507 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2002250000 definitions=main-2004140120 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40600 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_EBA5D2C4-FA36-4041-8F21-55457C01C30C Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii I made a patch. Please see an attachment. -- tsuucat --Apple-Mail=_EBA5D2C4-FA36-4041-8F21-55457C01C30C Content-Disposition: attachment; filename=0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch" Content-Transfer-Encoding: quoted-printable =46rom=20a95cf228b1cebbea0a0a56f2804cc0c42035c8a7=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Masahiro=20Nakamura=20=0A= Date:=20Tue,=2014=20Apr=202020=2022:37:17=20+0900=0ASubject:=20[PATCH]=20= Fix=20comparing=20command=20names=20in=20strokes.el=20(bug#40600)=0A=0A*=20= lisp/strokes.el=20(strokes-alphabetic-lessp):=20Check=20arguments=20with=20= symbolp=0Abecause=20arguments=20may=20be=20strings.=0A---=0A=20= lisp/strokes.el=20|=208=20++++++--=0A=201=20file=20changed,=206=20= insertions(+),=202=20deletions(-)=0A=0Adiff=20--git=20a/lisp/strokes.el=20= b/lisp/strokes.el=0Aindex=207a887445..5f40ffcc=20100644=0A---=20= a/lisp/strokes.el=0A+++=20b/lisp/strokes.el=0A@@=20-1373,8=20+1373,12=20= @@=20strokes-list-strokes=0A=20=0A=20(defun=20strokes-alphabetic-lessp=20= (stroke1=20stroke2)=0A=20=20=20"Return=20t=20if=20STROKE1's=20command=20= name=20precedes=20STROKE2's=20in=20lexicographic=20order."=0A-=20=20(let=20= ((command-name-1=20(symbol-name=20(cdr=20stroke1)))=0A-=09= (command-name-2=20(symbol-name=20(cdr=20stroke2))))=0A+=20=20(let=20= ((command-name-1=20(if=20(symbolp=20(cdr=20stroke1))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (symbol-name=20(cdr=20stroke1))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(prin1-to-string=20(cdr=20= stroke1))))=0A+=20=20=20=20=20=20=20=20(command-name-2=20(if=20(symbolp=20= (cdr=20stroke2))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(symbol-name=20(cdr=20stroke2))=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (prin1-to-string=20(cdr=20stroke2)))))=0A=20=20=20=20=20(string-lessp=20= command-name-1=20command-name-2)))=0A=20=0A=20(defvar=20strokes-mode-map=0A= --=20=0A2.21.0=0A=0A= --Apple-Mail=_EBA5D2C4-FA36-4041-8F21-55457C01C30C-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 12:49:10 2020 Received: (at 40600) by debbugs.gnu.org; 14 Apr 2020 16:49:10 +0000 Received: from localhost ([127.0.0.1]:34630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOOkF-0003ih-1n for submit@debbugs.gnu.org; Tue, 14 Apr 2020 12:49:10 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]:42495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOOkA-0003iB-MN for 40600@debbugs.gnu.org; Tue, 14 Apr 2020 12:49:06 -0400 Received: by mail-qv1-f49.google.com with SMTP id v18so146462qvx.9 for <40600@debbugs.gnu.org>; Tue, 14 Apr 2020 09:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=izmdC8dTNVvPzIMAZiQlXo2TEFP7nW5JG/KBOYob6S4=; b=kXjlabLDnSd6jq1SUybQfLWyqIYlugH7NXf1ytdGjOpFq3hP48h9n/P0rWlYnsyN96 r85O5ZS63UtRM03hCZR8v/9AbA/97m1O9sioOtQEvD9CWXBps0z+rr7E0BJTxHFHg4pQ Y78KhG/yD5qGcA/OF9mfBb02u6AmcBaHMEUXuOHBpDq9kBvUuMhvE1/Jirj4BVRLdyh/ 3B0sk+7tdkYkautjP1bwASgsjE2IU840jBfypOSUwBSN+zIyzNGVAf4K42IABwo0n3Rc y+fGD5C0vdeb1Bu/yauqE3Z0cRlU+BGzLhqGL1VRsnVPFTArcBGslkJG8tcPzYAbXkU2 YRAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=izmdC8dTNVvPzIMAZiQlXo2TEFP7nW5JG/KBOYob6S4=; b=VJOLbrvIGKC93wo5948OvNYzWMExLkiQ1e5ZcSjJ7enp1LNXWYOm0SzJpEpC4/SC7p JOJcYyMG09YICrtlSj35FCB5MxH3PIu/Ri8/xOXugXIxPMMPt2SghAb0hkK+IX4DtyQb 2X8J2ypq85IRQhbCnbcn+Kh/nR/En7wyJ5kNT4/jEAgHU1RLfUXPWbZnQR4bZHQ0d+J0 V35BFLJhs4fUw7Hwk5GgvmOhTA+0tuMR6H+ppT4RayNGyDcxD3HypmYLXvt9fGfYcOgG UhAGJ3uUpMVEs/ta78RsFb48WrI+/m6DomQvyf5vrTwe6liu8qdzn+CMnIw7w1QJxP0S v6BQ== X-Gm-Message-State: AGi0PuYw2GJkWKpLlanuUtw/TGIJ+2jqah4IUdRHpIxEAsROUlBB+Ab0 2U37oFXdo1skx68LVML1L+5jhfKyCfE= X-Google-Smtp-Source: APiQypLoRQ02InOHCikHDuIg0IR+uxtBeDErMopnc0tfhoC2m7Iu5SiX+rivAQCTbKO3oPzk0h4e0A== X-Received: by 2002:a0c:c187:: with SMTP id n7mr903195qvh.240.1586882936880; Tue, 14 Apr 2020 09:48:56 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id z3sm11027042qtq.7.2020.04.14.09.48.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 09:48:56 -0700 (PDT) From: Noam Postavsky To: tsuucat Subject: Re: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> Date: Tue, 14 Apr 2020 12:48:55 -0400 In-Reply-To: (tsuucat@icloud.com's message of "Tue, 14 Apr 2020 23:38:28 +0900") Message-ID: <851roqypvs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40600 Cc: 40600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) tsuucat writes: > - (let ((command-name-1 (symbol-name (cdr stroke1))) > - (command-name-2 (symbol-name (cdr stroke2)))) > + (let ((command-name-1 (if (symbolp (cdr stroke1)) > + (symbol-name (cdr stroke1)) > + (prin1-to-string (cdr stroke1)))) Why use prin1-to-string? > + (command-name-2 (if (symbolp (cdr stroke2)) > + (symbol-name (cdr stroke2)) > + (prin1-to-string (cdr stroke2))))) > (string-lessp command-name-1 command-name-2))) Actually, since string-lessp accepts symbols, an easier fix would be to just drop the calls to symbol-name. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 13:15:13 2020 Received: (at 40600) by debbugs.gnu.org; 14 Apr 2020 17:15:13 +0000 Received: from localhost ([127.0.0.1]:34693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOP9V-0006RO-8o for submit@debbugs.gnu.org; Tue, 14 Apr 2020 13:15:13 -0400 Received: from pv50p00im-ztdg10022001.me.com ([17.58.6.58]:60005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOP9S-0006R3-ST for 40600@debbugs.gnu.org; Tue, 14 Apr 2020 13:15:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1586884505; bh=Pc8BzvuWxh5a0tNI0Aobyy+oiPXdKngrpTT4+4jPl/4=; h=From:Message-Id:Content-Type:Subject:Date:To; b=TkXL/+Fjcu/zx9aUrXDI2CibyT5AqGP02PQHV6mhgJc6LKf3B889zbF7naJnUWj+o H4xdAGXQH56wFA0RJY2Wc1fYfi6SXXDtZYUpCGUzfImqk6D6K9ZvSy0EF0qKYyPNcD kvnzFk4R29xxtuZQD/h6U6l8N1RnX76MnU3mHOweo7v6e4DG4Xk3P37bPA4TldBk1W AZWsKAoljxDm44ax7DHOpPcCvxUQqZTFTF7JVaVU0IZ5gCWRyelnTYY3K02BUIJosz lIo763SN7VpnGAygafPzIfceX6AzNCDcml38Rg1oRezhiaB7BWYFuJw9UbUyyg91V6 C/+NBNSssny5g== Received: from [192.168.129.26] (i114-183-98-221.s41.a008.ap.plala.or.jp [114.183.98.221]) by pv50p00im-ztdg10022001.me.com (Postfix) with ESMTPSA id B1BC2A0826; Tue, 14 Apr 2020 17:15:04 +0000 (UTC) From: tsuucat Message-Id: <763AC822-39EF-4BC2-85C2-8A473EC6CD8E@icloud.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error Date: Wed, 15 Apr 2020 02:15:02 +0900 In-Reply-To: <851roqypvs.fsf@gmail.com> To: Noam Postavsky References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> <851roqypvs.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.104.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-14_08:2020-04-14, 2020-04-14 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=808 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2002250000 definitions=main-2004140131 X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 40600 Cc: 40600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Why use prin1-to-string? That=E2=80=99s simply because I imitate the code in strokes-list-strokes = function. > Actually, since string-lessp accepts symbols, an easier fix would be = to > just drop the calls to symbol-name. Thanks for the advice! I made another patch and checked this works = well. -- tsuucat --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8 Content-Disposition: attachment; filename=0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch" Content-Transfer-Encoding: quoted-printable =46rom=20af31735e07528973392cb1e163f9f9e1682951e4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Masahiro=20Nakamura=20=0A= Date:=20Tue,=2014=20Apr=202020=2022:37:17=20+0900=0ASubject:=20[PATCH]=20= Fix=20comparing=20command=20names=20in=20strokes.el=20(bug#40600)=0A=0A*=20= lisp/strokes.el=20(strokes-alphabetic-lessp):=20Simply=20call=20= string-lessp=0Abecause=20the=20cdr=20of=20the=20argument=20may=20be=20= string.=0A---=0A=20lisp/strokes.el=20|=204=20+---=0A=201=20file=20= changed,=201=20insertion(+),=203=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/strokes.el=20b/lisp/strokes.el=0Aindex=207a887445..e511a63f=20= 100644=0A---=20a/lisp/strokes.el=0A+++=20b/lisp/strokes.el=0A@@=20= -1373,9=20+1373,7=20@@=20strokes-list-strokes=0A=20=0A=20(defun=20= strokes-alphabetic-lessp=20(stroke1=20stroke2)=0A=20=20=20"Return=20t=20= if=20STROKE1's=20command=20name=20precedes=20STROKE2's=20in=20= lexicographic=20order."=0A-=20=20(let=20((command-name-1=20(symbol-name=20= (cdr=20stroke1)))=0A-=09(command-name-2=20(symbol-name=20(cdr=20= stroke2))))=0A-=20=20=20=20(string-lessp=20command-name-1=20= command-name-2)))=0A+=20=20(string-lessp=20(cdr=20stroke1)=20(cdr=20= stroke2)))=0A=20=0A=20(defvar=20strokes-mode-map=0A=20=20=20(let=20((map=20= (make-sparse-keymap)))=0A--=20=0A2.21.0=0A=0A= --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 16 20:50:07 2020 Received: (at 40600) by debbugs.gnu.org; 17 Apr 2020 00:50:07 +0000 Received: from localhost ([127.0.0.1]:39731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPFCo-0008E6-Sy for submit@debbugs.gnu.org; Thu, 16 Apr 2020 20:50:07 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:35968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPFCm-0008DR-Rd; Thu, 16 Apr 2020 20:50:05 -0400 Received: by mail-qk1-f176.google.com with SMTP id l25so833142qkk.3; Thu, 16 Apr 2020 17:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jLvXrNiUYjbIs5JYUyO4CiJGjHVKEB8hvkvipUpkb0A=; b=Oa7BlUI11vCSIpOLouIKrgpXDg+QvvF7T9G3NbyJr0/xSUcsIpxjB8ffOK4Od2pJ42 f2KilxFzWQyl0ANPgs9p6634ddaFUGohYrOqHE5VQ9SaoMBElCJSoiDJl8CTbF1CI9MG 42XpP1lfJQ+eqo5w1D4LpSmRc84EpCdqAXtFK4KayWRWZRQu/HXLDnTiev+1TXkR2fMB 1yR4A7gY/o2JwKqcABG+W0J6h9qBA7NM3si3djKghsR0+0wEj9R8a4Wi5B/TfrlYM18H 6KtwLx1GnN04Czve/NOav/VLRSn8L1XixLSqOKTapO/Ifo6DNrmYg8JhjdNnBIxKhept HDrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jLvXrNiUYjbIs5JYUyO4CiJGjHVKEB8hvkvipUpkb0A=; b=NTtEvtNSJhDQjCuAkPnVeuN5kelTN78NW8Ubt9hF0ukk67EIztGIzGfae2PY6U1oYx eb2VmPvF/ChWmNITojmgIuBaFZk5RzFgc3Y4q2JkROxsdGYdSpw3WLj2MjpI/zu2i2LS Y9iYuaxZYKs87QnbjskYsCDhCDQfn2d/C5J2ptHo5FKrDZInpTlZDZ+SAQkTJ1UVdBbW I8tC7aA1gpyq/V8hQ6bupHajxeHaths9GtZjRKsXwaSyWlPevv18hhnQxioWPmoseLhc o9JR7ehB34hQtpGhwF8NYH4/aWmmjGAivdqnEL4eV3Mu/m4NlpDpoZWiNBB9j/krUz8h q10g== X-Gm-Message-State: AGi0PuZYfu6bRjIr0RiMnNUUWcr0gAZTw0uRfRHZX8ot7+wvSGPDTFvq kKKnTHtqcy2PLZ7T4Fb9kAKwSMsJ X-Google-Smtp-Source: APiQypIy6Bci41YLPeWCX7sTGf4KIqvXfUTInM/u/P6IbhIle603GUYqjXUVB87QfD2RGZTqZ+qE+A== X-Received: by 2002:a05:620a:108e:: with SMTP id g14mr782150qkk.277.1587084598945; Thu, 16 Apr 2020 17:49:58 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id g63sm16053040qkb.89.2020.04.16.17.49.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Apr 2020 17:49:57 -0700 (PDT) From: Noam Postavsky To: tsuucat Subject: Re: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> <851roqypvs.fsf@gmail.com> <763AC822-39EF-4BC2-85C2-8A473EC6CD8E@icloud.com> Date: Thu, 16 Apr 2020 20:49:56 -0400 In-Reply-To: <763AC822-39EF-4BC2-85C2-8A473EC6CD8E@icloud.com> (tsuucat@icloud.com's message of "Wed, 15 Apr 2020 02:15:02 +0900") Message-ID: <87imhz2ax7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 40600 fixed close 40600 28.1 quit tsuucat writes: > Thanks for the advice! I made another patch and checked this works well. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: icloud.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.222.176 listed in list.dnswl.org] -0.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.222.176 listed in wl.mailspike.net] 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email X-Debbugs-Envelope-To: 40600 Cc: 40600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) tags 40600 fixed close 40600 28.1 quit tsuucat writes: > Thanks for the advice! I made another patch and checked this works well. Thanks, pushed to master. [1: be77a68d52]: 2020-04-16 20:47:35 -0400 Fix comparing command names in strokes.el (bug#40600) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=be77a68d527223f7f276e94e16fe05b49846c7a3 From unknown Mon Jun 23 22:03:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 May 2020 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator