GNU bug report logs - #40593
Added emacs-uml-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40593 in the body.
You can then email your comments to 40593 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alberto EFG <albertoefg <at> posteo.mx>
To: guix-patches <at> gnu.org
Subject: Added emacs-uml-mode
Date: Mon, 13 Apr 2020 01:15:41 -0500

[Message part 1 (text/plain, inline)]

Added emacs-uml-mode. I used the same branch where I wrote
emacs-org-roam (bug#40591) hope it is ok.

guix size is 0.1 MB

The package is just an emacs file, there should not be much problem.

[0001-gnu-Add-emacs-uml-mode.patch (text/x-patch, inline)]

From 0289b51837ea2edfe610deb2e91ee329601f1234 Mon Sep 17 00:00:00 2001
From: Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
Date: Mon, 13 Apr 2020 01:07:04 -0500
Subject: [PATCH] gnu: Add emacs-uml-mode.

* gnu/packages/emacs-xyz.scm (emacs-uml-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0f1c48be2e..0fdc509038 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22332,3 +22332,25 @@ without hierarchy and are connected by tags.  Notes can be found
 and created quickly.  Org-roam should also work as a plug-and-play
  solution for anyone already using Org-mode for their personal wiki.")
    (license license:gpl3)))
+
+(define-public emacs-uml-mode
+  (package
+   (name "emacs-uml-mode")
+   (version "0.0.4")
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/ianxm/emacs-uml.git")
+           (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200")))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32
+       "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka"))))
+   (build-system emacs-build-system)
+   (home-page "https://github.com/ianxm/emacs-uml")
+   (synopsis "Minor mode for editing ascii UML sequence diagrams")
+   (description "@code{emacs-uml-mode} is a minor mode that
+ makes it easy to build ascii UML sequence diagrams in Emacs,
+which can be embedded in source code, comments or emails.")
+   (license license:gpl3)))
-- 
2.26.0

Message #8 received at 40593 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 40591 <at> debbugs.gnu.org, 40593 <at> debbugs.gnu.org, 40616 <at> debbugs.gnu.org,
 40613 <at> debbugs.gnu.org
Date: Tue, 14 Apr 2020 02:55:02 +0200

[Message part 1 (text/plain, inline)]

For the record (and any reviewers), these patches should be 
applied in order:

#40591 emacs-org-roam
#40593 emacs-uml-mode
#40616 emacs-4clojure
#40613 emacs-typing

They're not interdependent, just patch-context-dependent.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 40593-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alberto EFG <albertoefg <at> posteo.mx>
Cc: 40593-done <at> debbugs.gnu.org
Subject: Re: [bug#40593] Added emacs-uml-mode
Date: Tue, 14 Apr 2020 11:12:33 +0200

Hello,

Alberto EFG <albertoefg <at> posteo.mx> writes:

> Added emacs-uml-mode. I used the same branch where I wrote
> emacs-org-roam (bug#40591) hope it is ok.

Thank you.

Note that adding all new packages at the end of the file is likely to
create merge conflicts. If they are tied, send them in the same bug
report.

> +(define-public emacs-uml-mode
> +  (package
> +   (name "emacs-uml-mode")
> +   (version "0.0.4")

This is not an official release. So I added a commit, a revision, and
a comment. Therefore, the line became:

  (version (git-version "0.0.4" revision commit))

> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/ianxm/emacs-uml.git")
> +           (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200")))

As a consequence of the "no revision" situation, the line above  became:

  (commit commit)

> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka"))))
> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/ianxm/emacs-uml")
> +   (synopsis "Minor mode for editing ascii UML sequence diagrams")
> +   (description "@code{emacs-uml-mode} is a minor mode that
> + makes it easy to build ascii UML sequence diagrams in Emacs,
> +which can be embedded in source code, comments or emails.")
> +   (license license:gpl3)))

Please also see my comments about "emacs-org-roam" (indentation, commit,
license).

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.