Subject: Re: bug#40581: [wip-hurd-vm] uptime from coreutils looks for /bin/w

From: Ludovic Courtès <[email-masked]>
Date: Mon, 13 Apr 2020 12:44:35 +0200

Hey ho!

Jan Nieuwenhuizen <[email-masked]> skribis:

> Rene writes:
>
> Hello Rene, Efraim,
>
>> Debian project currently uses `/bin/w` from the hurd package, so I
>> propose the attached patch.
>
> LGTM!
>
>> @@ -398,6 +399,9 @@ boot, since this cannot be done from GNU/Linux."
>>                 (substitute* '("startup/startup.c" "init/init.c" "config/ttys")
>>                   (("/libexec/")
>>                    (string-append out "/libexec/")))
>> +               (substitute* '("utils/uptime.sh")
>> +                 (("/bin/w")
>> +                  (string-append out "/bin/w")))
>>                 (substitute* "daemons/console-run.c"
>>                   (("/hurd/")
>>                    (string-append out "/hurd/")))
>
> Looking at this again it looks fine; following the pattern we created.

Yup, LGTM!

> This now makes me wonder whether upstream Hurd could use a patch for
> ${bindir} and ${libexecdir}.  Possibly even for `/hurd'.
>
> What do you all think?

Yes, I think this prefix issue should be fixed upstream.

Ludo’.