Subject: Re: [bug#40579] [RFC PATCH] add iPXE.

From: Danny Milosavljevic <[email-masked]>
Date: Sun, 12 Apr 2020 21:46:09 +0200

Hi,

On Sun, 12 Apr 2020 20:47:23 +0200
Tobias Geerinckx-Rice via Guix-patches via <[email-masked]> wrote:

> Could you elaborate?  What's "interesting" about it?  That all 
> looks very boring and straightforward to me (which is good! :-) — 
> the result is GPL2-only, no?

No, there are different makefile targets (rom output filenames) which will
result in different parts of ipxe to be built and included in the output.

There's special makefile targets for each of these targets to determine
the license that applies to each of the latter targets, respectively.

Unfortunately, there's no "all.license" target.

> /bin is not the right place for these files.  /lib/ipxe looks to 
> be the standard; let's use that.

I agree.

> Let's, instead:
> 
>   (add-after 'unpack 'enter-source-directory
>     (lambda _ (chdir "src") #t))
>
> Don't worry, the state can't hurt you now.  Now we can keep the 
> standard build & install phases.

I agree.

> If you feel like it (there aren't that many files) you could list 
> the licences for each output binary, but that's optional.  The 
> combined work appears to be GPL2.

Does it?  Did you try to make all of the targets' license targets?

P.S. The following ROMs are not reproducible:

10222000.rom GPL2
10500940.rom GPL2 
10ec8139.rom GPL2
15ad07b0.rom GPL2+
1af41000.rom GPL2+
8086100e.mrom GPL2+
8086100f.mrom GPL2+
808610d3.mrom GPL2+
80861209.rom GPL2+
ipxe.iso license checker doesn't work
rtl8139.rom GPL2

which are ALL of them except blib.a, ipxe.dsk, ipxe.lkrn, ipxe.pxe, ipxe.usb
and undionly.kpxe (this one has GPL2+) (which are not roms).

Note: Maybe also pass make-flags to overwrite those:

./Makefile.housekeeping:ECHO_E_BIN_ECHO         := /bin/echo
./Makefile.housekeeping:ECHO_E_BIN_ECHO_E       := /bin/echo -e