GNU bug report logs - #40573
27.0.90; flymake-mode broken in scratch buffer

Previous Next

Full log

Message #173 received at 40573 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: contovob <at> tcd.ie, 40573 <at> debbugs.gnu.org, dgutov <at> yandex.ru,
 monnier <at> iro.umontreal.ca, juri <at> linkov.net
Subject: Re: bug#40573: 27.0.90; flymake-mode broken in scratch buffer
Date: Sun, 19 Apr 2020 17:01:03 +0300

> From: João Távora <joaotavora <at> gmail.com>
> Date: Sun, 19 Apr 2020 00:36:36 +0100
> Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, Stefan Monnier <monnier <at> iro.umontreal.ca>, 
> 	Juri Linkov <juri <at> linkov.net>, 40573 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
> 
> Here's the final patch as a sum of all the commits in the
> scratch/add-lisp-data-mode
> branch.  I fixed the small lisp-mode-variables backward incompatibility
> issue.

Thanks for working on this.

> Any comments/objections?

I have one comment and one objection, below.

> Does this need documentation?

The new mode should be called out in NEWS, yes.

> diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
> index 13263f2fb5..3b0f5493ee 100644
> --- b/lisp/emacs-lisp/lisp-mode.el
> +++ a/lisp/emacs-lisp/lisp-mode.el
> @@ -611,15 +611,10 @@
>    ;; a single docstring.  Let's fix it here.
>    (if (looking-at "\\s-+\"[^\n\"]+\"\\s-*$") ""))
> 
> -(defun lisp-mode-variables (&optional lisp-syntax keywords-case-insensitive
> -                                      elisp)
> +(defun lisp-mode-variables (&rest ignored)

Please don't make this backward-incompatible change.  Let's keep the
API of this function unchanged.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.