GNU bug report logs - #40557
[PATCH] Add dhall.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40557 in the body.
You can then email your comments to 40557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add dhall.
Date: Sat, 11 Apr 2020 09:04:26 -0700

[Message part 1 (text/plain, inline)]

Hi Guix!

Dhall is a language for configuration that aims to be the best in class
for devops work.  It features strong normalization, strong static types,
imports, and more.

I hope you enjoy it!

Thanks,

John

[0001-gnu-Add-ghc-inspection-testing.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-data-fix.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-cborg.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-cborg-json.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-dotgen.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-generic-random.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-text-manipulate.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-spoon.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-special-values.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-serialise.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-pretty-simple.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-pgp-wordlist.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-optional-args.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-turtle.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-managed.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-lens-family-core.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-prettyprinter.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-repline.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-haskeline-0.8.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-repline-0.3.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-prettyprinter-1.6.patch (text/x-patch, attachment)]

[0022-gnu-Add-ghc-prettyprinter-ansi-terminal.patch (text/x-patch, attachment)]

[0023-gnu-Add-ghc-generic-random-1.3.0.1.patch (text/x-patch, attachment)]

[0024-gnu-Add-ghc-atomic-write-0.2.0.7.patch (text/x-patch, attachment)]

[0025-gnu-Add-dhall.patch (text/x-patch, attachment)]

Message #8 received at 40557 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40557 <at> debbugs.gnu.org
Subject: Re: [bug#40557] [PATCH] Add dhall.
Date: Thu, 28 May 2020 21:50:42 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 11, 2020 at 09:04:26AM -0700, John Soo wrote:
> Hi Guix!
> 
> Dhall is a language for configuration that aims to be the best in class
> for devops work.  It features strong normalization, strong static types,
> imports, and more.
> 
> I hope you enjoy it!

Thanks! The first 24 patches LGTM as-is.

> From 97163f01cb31dd70e09e0245630d1f7babe5251c Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Fri, 10 Apr 2020 21:01:46 -0700
> Subject: [PATCH 25/25] gnu: Add dhall.
> 
> * gnu/packages/dhall.scm (dhall): New variable.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add dhall.scm.
> * gnu/packages/patches/dhall-remove-network-tests.patch: Add patch to remove
>   network tests.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'remove-more-tests

Can you add a brief comment explaining why we need to remove these
tests, rename the phase to reflect that, and send a revised patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40557 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40557 <at> debbugs.gnu.org
Subject: Re: [bug#40557] [PATCH] Add dhall.
Date: Fri, 29 May 2020 06:40:11 -0700

[Message part 1 (text/plain, inline)]

Hello,

Leo Famulari <leo <at> famulari.name> writes:

> Thanks! The first 24 patches LGTM as-is.

Thank you.

>> * gnu/packages/dhall.scm (dhall): New variable.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add dhall.scm.
>> * gnu/packages/patches/dhall-remove-network-tests.patch: Add patch to remove
>>   network tests.
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'remove-more-tests
>
> Can you add a brief comment explaining why we need to remove these
> tests, rename the phase to reflect that, and send a revised patch?

Alright, done.  Let me know what else I can do.

Thanks again!

- John

[0001-gnu-Add-ghc-inspection-testing.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-data-fix.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-cborg.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-cborg-json.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-dotgen.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-generic-random.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-text-manipulate.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-spoon.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-special-values.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-serialise.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-pretty-simple.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-pgp-wordlist.patch (text/x-patch, attachment)]

[0013-gnu-Add-ghc-optional-args.patch (text/x-patch, attachment)]

[0014-gnu-Add-ghc-turtle.patch (text/x-patch, attachment)]

[0015-gnu-Add-ghc-managed.patch (text/x-patch, attachment)]

[0016-gnu-Add-ghc-lens-family-core.patch (text/x-patch, attachment)]

[0017-gnu-Add-ghc-prettyprinter.patch (text/x-patch, attachment)]

[0018-gnu-Add-ghc-repline.patch (text/x-patch, attachment)]

[0019-gnu-Add-ghc-haskeline-0.8.patch (text/x-patch, attachment)]

[0020-gnu-Add-ghc-repline-0.3.patch (text/x-patch, attachment)]

[0021-gnu-Add-ghc-prettyprinter-1.6.patch (text/x-patch, attachment)]

[0022-gnu-Add-ghc-prettyprinter-ansi-terminal.patch (text/x-patch, attachment)]

[0023-gnu-Add-ghc-generic-random-1.3.0.1.patch (text/x-patch, attachment)]

[0024-gnu-Add-ghc-atomic-write-0.2.0.7.patch (text/x-patch, attachment)]

[0025-gnu-Add-dhall.patch (text/x-patch, attachment)]

Message #16 received at 40557-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40557-done <at> debbugs.gnu.org
Subject: Re: [bug#40557] [PATCH] Add dhall.
Date: Fri, 29 May 2020 11:01:31 -0400

On Fri, May 29, 2020 at 06:40:11AM -0700, John Soo wrote:
> Alright, done.  Let me know what else I can do.

Thanks! I pushed as 9ff667ea05d0807b4e6512c92914ae517b9ec755 after also
registering the patch in 'gnu/local.mk' (I had overlooked this
previously).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.