From unknown Fri Jun 20 07:19:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40555 <40555@debbugs.gnu.org> To: bug#40555 <40555@debbugs.gnu.org> Subject: Status: 27.0.90; out of bound array access in setup_process_coding_systems Reply-To: bug#40555 <40555@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:19:48 +0000 retitle 40555 27.0.90; out of bound array access in setup_process_coding_sy= stems reassign 40555 emacs submitter 40555 Matthieu Hauglustaine severity 40555 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 11:36:00 2020 Received: (at submit) by debbugs.gnu.org; 11 Apr 2020 15:36:00 +0000 Received: from localhost ([127.0.0.1]:56982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNIAp-0004G6-KZ for submit@debbugs.gnu.org; Sat, 11 Apr 2020 11:36:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:36556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNI18-00040m-Dn for submit@debbugs.gnu.org; Sat, 11 Apr 2020 11:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43646) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNI16-00070I-BY for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2020 11:25:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNI14-0002QA-Bx for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2020 11:25:56 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:40023) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNI14-0002Q3-4G for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2020 11:25:54 -0400 Received: by mail-wr1-x432.google.com with SMTP id s8so5417383wrt.7 for ; Sat, 11 Apr 2020 08:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=aWHTtMQIOBgTa3MBKgGhuykkMwhcLx5nOoSjCXaxsXM=; b=f0OA7W8897duKa8Ugr+SQXdfV7UBJMi36a42d+kEua7wu/TSoHwloNqt3jJhu+hfaw qUD1DuaDiTQ3RBPYKPStLwGqw2+apa0vFnk6YC1wJ0OyvO5Fsbj99Z6cQst6e2nN+N9v CrH+CHLdAGxeI6EH9uB5gK3P3h0x9+YLN1UbodOMgSywg3BxVf+Sld0gG3O6L/KIHrfO QeolVIAxIBDw6Hrpvk2IEg5xMP5UvizsclF/U2L4SczDXvW1mBGHdD1oTkJR7GJFJbzT zyr5ckCKbnFGZ0ZU9DfNdOXMhFfvS16iiffW0DxbUy77GXSQVwRVlvtJTG5FyqXPaeIj YQFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=aWHTtMQIOBgTa3MBKgGhuykkMwhcLx5nOoSjCXaxsXM=; b=HOCn9oXVczByqo34m+BqGhy6H94tefKdbm3G54TKLVtDM6kFTirBqmtEOi9I2sv3pT DcLLeYoPaoHhvKiHdvmwIbumlcaum8Hbsa4+luW4SLJ8XiaCf8gdhB3vElm+rBjEPyJT H0nr4HqAGNzG6GZf+ZREscRI1U2kvWAW3bD1BGB1HlCqOrGIXzb7NvkWy8rOP4KXM1GW AuikPKpslE67K9MuLfMW+Zsr6pB0hzE4lUtFaVxznDfDwXQ948JMa3rNb/PPmeYWKPVM awXAjb1chFwoNthyPCAQYshEAx5xRs1STT4XsOPjd9PFBJQv9pAsTHtE+yk+gC1R/ePK T3eQ== X-Gm-Message-State: AGi0PubLlbIeMKN7Jj4wI4kQZ/l4wDmSLe52rEEiuAYDiTqjtlJ4Qlbv iRGhODz0wjE85Ql8Koa6J3fvPLGq X-Google-Smtp-Source: APiQypLOJZvyC2Ctr2Dqr9DDAVMqZBYaVhip+jmM9Wc7VHhVKAoKr/BzlRzcnpGohet1uJb8pWBUSw== X-Received: by 2002:a5d:4111:: with SMTP id l17mr10877848wrp.271.1586618751689; Sat, 11 Apr 2020 08:25:51 -0700 (PDT) Received: from Matthieus-MacBook-Pro.local ([51.15.153.247]) by smtp.gmail.com with ESMTPSA id b85sm7357916wmb.21.2020.04.11.08.25.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2020 08:25:51 -0700 (PDT) From: Matthieu Hauglustaine To: bug-gnu-emacs@gnu.org Subject: 27.0.90; out of bound array access in setup_process_coding_systems Date: Sat, 11 Apr 2020 17:24:16 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, I've experienced a EXC_BAD_ACCESS when using Emacs 27.0.90 on OS X 10.15. The root cause appears to be an out of bound access on proc_decode_coding_system (src/process.c:7988), in setup_process_coding_systems() when calling setup_coding_system(). This results in an invalid [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: porkrind.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (matt.hauglustaine[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 11 Apr 2020 11:35:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, I've experienced a EXC_BAD_ACCESS when using Emacs 27.0.90 on OS X 10.15. The root cause appears to be an out of bound access on proc_decode_coding_system (src/process.c:7988), in setup_process_coding_systems() when calling setup_coding_system(). This results in an invalid write to coding->id from CHECK_CODING_SYSTEM_GET_ID (src/coding.c:5678). [1] for the stacktrace. On Emacs initialization (init_process_emacs(), src/emacs.c:8234), RLIMIT_NOFILE.rlim_cur is set to FD_SETSIZE, and the assumption seem to be that this limit will never change for the lifetime of the process. proc_decode_coding_system and proc_encode_coding_system are declared with a size of FD_SETSIZE (src/process.c:311). However, on OS X systems, the call to NSURL.getResourceValue:forKey: (src/nsfns.c:497), when opening a file, apparently result in a call to setrlimit with RLIMIT_NOFILE.rlim_cur > FD_SETSIZE. Thus, when the number of FDs opened by Emacs is greater than FD_SETSIZE, an illegal access is done when make-process is called. I've experienced this consistently when using lsp-mode along with lsp-java, as by default this mode will set kqueue watches on all directories of the workspace, which can result in a lot of open files. Fkqueue_add_watch relies on RLIMIT_NOFILE.rlim_cur to limit the number of watches created, and not on FD_SETSIZE (src/kqueue.c:391). Disabling file watching works as a workaround. To reproduce, without lsp, I have been doing the following: 1. Run Emacs with lldb: % lldb Emacs-x86_64-10_14 (lldb) target create "Emacs-x86_64-10_14" Current executable set to '/Applications/Emacs.app/Contents/MacOS/Emacs-x86_64-10_14' (x86_64). (lldb) run -Q --dump-file=/Applications/Emacs.app/Contents/MacOS/Emacs.pdmp Process 50395 launched: '/Applications/Emacs.app/Contents/MacOS/Emacs-x86_64-10_14' (x86_64) 2. Assert RLIMIT_NOFILE.rlim_cur is at FD_SETSIZE (1024): (lldb) expression struct rlimit { uint64_t cur, max; } $lims (lldb expression (void)getrlimit(8, &$lims) (lldb) memory read &$lims -s 8 -c 2 -fu 0x100ec5190: 1024 0x100ec5198: 9223372036854775807 3. Open a file. If a breakpoint on setrlimit was set, we can see a call is made, [2] for the stacktrace. 4. Observe RLIMIT_NOFILE.rlim_cur has been changed: (lldb) expression (void)getrlimit(8, &$lims) (lldb) memory read &$lims -s 8 -c 2 -fu 0x100ec5190: 3328 0x100ec5198: 9223372036854775807 5. Create > FD_SETSIZE file descriptors (I've been using file-notify-add-watch, as lsp-mode does): (require 'filenotify) (dotimes (_ 1900) (let ((dir (make-temp-file "foo" t))) (file-notify-add-watch dir '(change) 'prin1))) 6. Assert process has > FD_SETSIZE open files: % lsof -p 50395|wc -l 1958 7. Call make-process, resulting in SEGV: (make-process :name "test" :buffer "test" :command '("echo" "hello")) * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xffffffffffffffff) frame #0: 0x000000010007a1b5 Emacs-x86_64-10_14`setup_coding_system + 53 Emacs-x86_64-10_14`setup_coding_system: -> 0x10007a1b5 <+53>: movq %rax, (%r15) 0x10007a1b8 <+56>: testq %rax, %rax 0x10007a1bb <+59>: jns 0x10007a1e2 ; <+98> 0x10007a1bd <+61>: movq %rbx, %rdi I would love to help out with a patch. I'm am, however, unfamiliar with Emacs' internals and uncertain about the best course of action. I have the following ideas: 1. Report an error in create_process (src/process.c:2033) if in/out channel FDs > FD_SETSIZE. 2. Use min(FD_SETSIZE, RLIMIT_NOFILE.rlim_cur) as maxfd in Fkqueue_add_watch, src/kqueue.c:390. Although there is probably other scenarios in which the Emacs process end up having more than FD_SETSIZE open file descriptors? 3. Ensure RLIMIT_NOFILE.rlim_cur is at FD_SETSIZE periodically, in case some subroutine we don't know about changed it (where could that happen? Should it be in command_loop, src/keyboard.c:1042?). Thanks, Matthieu In GNU Emacs 27.0.90 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95)) of 2020-03-03 built on builder10-14.porkrind.org Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.3 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS PDUMPER Important settings: value of $LANG: en_FR.UTF-8 locale-coding-system: utf-8 [1] Stacktrace, disassembled code and registers on EXC_BAD_ACCESS * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT) frame #0: 0x000000010007a1b5 Emacs-x86_64-10_14`setup_coding_system + 53 * frame #1: 0x00000001001916c8 Emacs-x86_64-10_14`setup_process_coding_systems + 152 frame #2: 0x0000000100193752 Emacs-x86_64-10_14`create_process + 546 frame #3: 0x0000000100192dcf Emacs-x86_64-10_14`Fmake_process + 2767 frame #4: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #5: 0x000000010014b07c Emacs-x86_64-10_14`Fapply + 588 frame #6: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #7: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #8: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #9: 0x000000010014b07c Emacs-x86_64-10_14`Fapply + 588 frame #10: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #11: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #12: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #13: 0x000000010014b07c Emacs-x86_64-10_14`Fapply + 588 frame #14: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #15: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #16: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #17: 0x000000010014b07c Emacs-x86_64-10_14`Fapply + 588 frame #18: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #19: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #20: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #21: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #22: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #23: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #24: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #25: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #26: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #27: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #28: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #29: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #30: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #31: 0x000000010014c355 Emacs-x86_64-10_14`funcall_lambda + 773 frame #32: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #33: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #34: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #35: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #36: 0x0000000100144b19 Emacs-x86_64-10_14`Ffuncall_interactively + 73 frame #37: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #38: 0x0000000100146008 Emacs-x86_64-10_14`Fcall_interactively + 5336 frame #39: 0x000000010014bf61 Emacs-x86_64-10_14`funcall_subr + 289 frame #40: 0x000000010014b52b Emacs-x86_64-10_14`Ffuncall + 843 frame #41: 0x000000010018ea47 Emacs-x86_64-10_14`exec_byte_code + 1815 frame #42: 0x000000010014b4c9 Emacs-x86_64-10_14`Ffuncall + 745 frame #43: 0x000000010014bb9c Emacs-x86_64-10_14`call1 + 44 frame #44: 0x00000001000c3249 Emacs-x86_64-10_14`command_loop_1 + 2009 frame #45: 0x0000000100149b87 Emacs-x86_64-10_14`internal_condition_case + 263 frame #46: 0x00000001000d3120 Emacs-x86_64-10_14`command_loop_2 + 48 frame #47: 0x00000001001493ab Emacs-x86_64-10_14`internal_catch + 267 frame #48: 0x0000000100215385 Emacs-x86_64-10_14`command_loop.cold.1 + 69 frame #49: 0x00000001000c2073 Emacs-x86_64-10_14`command_loop + 131 frame #50: 0x00000001000c1fa3 Emacs-x86_64-10_14`recursive_edit_1 + 115 frame #51: 0x00000001000c21fb Emacs-x86_64-10_14`Frecursive_edit + 347 frame #52: 0x00000001000c0dd7 Emacs-x86_64-10_14`main + 7431 frame #53: 0x00007fff6c9c97fd libdyld.dylib`start + 1 frame #54: 0x00007fff6c9c97fd libdyld.dylib`start + 1 Emacs-x86_64-10_14`setup_coding_system: -> 0x10007a1b5 <+53>: movq %rax, (%r15) 0x10007a1b8 <+56>: testq %rax, %rax 0x10007a1bb <+59>: jns 0x10007a1e2 ; <+98> 0x10007a1bd <+61>: movq %rbx, %rdi General Purpose Registers: rax = 0x0000000000000022 rbx = 0x000000000000d0b0 rcx = 0x0000000000000220 rdx = 0x00000000000004bf rdi = 0x000000000000d0b0 rsi = 0x000000000000d0b0 rbp = 0x00007ffeefbfe5d0 rsp = 0x00007ffeefbfe5a0 r8 = 0x0000000103b235b4 r9 = 0x00007ffeefbfe687 r10 = 0x0000000000000018 r11 = 0x0000000000000202 r12 = 0x0000000100679c40 Emacs-x86_64-10_14`proc_decode_coding_system r13 = 0x00007ffeefbfe601 r14 = 0x000000010067e698 Emacs-x86_64-10_14`Vcoding_system_hash_table r15 = 0xffffffffffffffff rip = 0x000000010007a1b5 Emacs-x86_64-10_14`setup_coding_system + 53 rflags = 0x0000000000010246 cs = 0x000000000000002b fs = 0x0000000000000000 gs = 0x0000000000000000 [2] Stacktrace of call to setrlimit resulting in RLIMIT_NOFILE.rlim_cur greater than FD_SETSIZE * thread #1, queue = 'com.apple.clouddocs.xpc', stop reason = breakpoint 1.1 * frame #0: 0x00007fff6cb0c4cd libsystem_kernel.dylib`setrlimit frame #1: 0x00007fff37b22162 Foundation`+[NSFileHandle initialize] + 200 frame #2: 0x00007fff6b65d985 libobjc.A.dylib`CALLING_SOME_+initialize_METHOD + 17 frame #3: 0x00007fff6b65e2bc libobjc.A.dylib`initializeNonMetaClass + 638 frame #4: 0x00007fff6b65e991 libobjc.A.dylib`initializeAndMaybeRelock(objc_class*, objc_object*, mutex_tt&, bool) + 214 frame #5: 0x00007fff6b6503db libobjc.A.dylib`lookUpImpOrForward + 969 frame #6: 0x00007fff6b64fb99 libobjc.A.dylib`_objc_msgSend_uncached + 73 frame #7: 0x00007fff3549e353 CoreFoundation`-[__NSSetI containsObject:] + 156 frame #8: 0x00007fff37b1ab04 Foundation`setProtocolMetadataWithSignature + 416 frame #9: 0x00007fff37b1a8ad Foundation`setProtocolMetdataWithMethods + 699 frame #10: 0x00007fff37b1a571 Foundation`setProtocolMetadata + 214 frame #11: 0x00007fff37b1a40e Foundation`-[NSXPCInterface setProtocol:] + 299 frame #12: 0x00007fff4acee054 CloudDocs`__BRCXPCInterface_block_invoke + 101 frame #13: 0x00007fff6c97050e libdispatch.dylib`_dispatch_client_callout + 8 frame #14: 0x00007fff6c971686 libdispatch.dylib`_dispatch_once_callout + 20 frame #15: 0x00007fff4acedfec CloudDocs`BRCXPCInterface + 45 frame #16: 0x00007fff4aceca41 CloudDocs`-[BRDaemonConnection _setupAndResume] + 111 frame #17: 0x00007fff4acedf9b CloudDocs`-[BRDaemonConnection initUsingUserLocalDaemon] + 104 frame #18: 0x00007fff4acedef7 CloudDocs`__39+[BRDaemonConnection defaultConnection]_block_invoke + 83 frame #19: 0x00007fff6c97050e libdispatch.dylib`_dispatch_client_callout + 8 frame #20: 0x00007fff6c97c567 libdispatch.dylib`_dispatch_lane_barrier_sync_invoke_and_complete + 60 frame #21: 0x00007fff4acede6c CloudDocs`+[BRDaemonConnection defaultConnection] + 136 frame #22: 0x00007fff4acfbf05 CloudDocs`-[BRFrameworkSyncedRootURLCache _fetchSyncedRootURLs] + 45 frame #23: 0x00007fff4acfbeb9 CloudDocs`__47-[BRFrameworkSyncedRootURLCache syncedRootURLs]_block_invoke + 35 frame #24: 0x00007fff6c97050e libdispatch.dylib`_dispatch_client_callout + 8 frame #25: 0x00007fff6c97c567 libdispatch.dylib`_dispatch_lane_barrier_sync_invoke_and_complete + 60 frame #26: 0x00007fff4acfbe5e CloudDocs`-[BRFrameworkSyncedRootURLCache syncedRootURLs] + 140 frame #27: 0x00007fff4acf2d55 CloudDocs`-[NSURL(BRAdditions) _br_isInSyncedLocationStrictly:] + 135 frame #28: 0x0000000100ec5eaa CloudDocsFileProvider`___lldb_unnamed_symbol13$$CloudDocsFileProvider + 81 frame #29: 0x00007fff3549ffec CoreFoundation`__invoking___ + 140 frame #30: 0x00007fff3549fe83 CoreFoundation`-[NSInvocation invoke] + 305 frame #31: 0x00007fff354d3d7e CoreFoundation`-[NSInvocation invokeWithTarget:] + 70 frame #32: 0x00007fff379c3f82 FileProvider`-[FPFrameworkOverridesIterator callNextOverrides] + 556 frame #33: 0x00007fff379c3ced FileProvider`-[FPFrameworkOverridesIterator forwardInvocation:] + 81 frame #34: 0x00007fff3549e889 CoreFoundation`___forwarding___ + 829 frame #35: 0x00007fff3549e4b8 CoreFoundation`_CF_forwarding_prep_0 + 120 frame #36: 0x00007fff379c2e23 FileProvider`FPCFCopyAttributeValuesForItem + 292 frame #37: 0x00007fff4de231ad CoreServicesInternal`CopyFromFileProvider(__CFURL const*, void const*, void const**, __CFError**) + 70 frame #38: 0x00007fff4de230d6 CoreServicesInternal`ExternalProviderPrepareValues(__CFURL const*, __FileCache*, __CFString const* const*, void const**, long, void const*, __CFError**) + 358 frame #39: 0x00007fff4de087e4 CoreServicesInternal`prepareValuesForBitmap(__CFURL const*, __FileCache*, _FilePropertyBitmap*, __CFError**) + 363 frame #40: 0x00007fff4de04eba CoreServicesInternal`_FSURLCopyResourcePropertyForKeyInternal(__CFURL const*, __CFString const*, void*, void*, __CFError**, unsigned char) + 221 frame #41: 0x00007fff35491958 CoreFoundation`CFURLCopyResourcePropertyForKey + 119 frame #42: 0x00007fff354a84ff CoreFoundation`-[NSURL getResourceValue:forKey:error:] + 110 frame #43: 0x00000001001f0dcf Emacs-x86_64-10_14`ns_implicitly_set_name + 287 frame #44: 0x0000000100053531 Emacs-x86_64-10_14`gui_consider_frame_title + 609 frame #45: 0x00000001000289fc Emacs-x86_64-10_14`redisplay_internal + 1324 frame #46: 0x00000001000c6be5 Emacs-x86_64-10_14`read_char + 2213 frame #47: 0x00000001000c47aa Emacs-x86_64-10_14`read_key_sequence + 1722 frame #48: 0x00000001000c2fac Emacs-x86_64-10_14`command_loop_1 + 1340 frame #49: 0x0000000100149b87 Emacs-x86_64-10_14`internal_condition_case + 263 frame #50: 0x00000001000d3120 Emacs-x86_64-10_14`command_loop_2 + 48 frame #51: 0x00000001001493ab Emacs-x86_64-10_14`internal_catch + 267 frame #52: 0x0000000100215385 Emacs-x86_64-10_14`command_loop.cold.1 + 69 frame #53: 0x00000001000c2073 Emacs-x86_64-10_14`command_loop + 131 frame #54: 0x00000001000c1fa3 Emacs-x86_64-10_14`recursive_edit_1 + 115 frame #55: 0x00000001000c21fb Emacs-x86_64-10_14`Frecursive_edit + 347 frame #56: 0x00000001000c0dd7 Emacs-x86_64-10_14`main + 7431 frame #57: 0x00007fff6c9c97fd libdyld.dylib`start + 1 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 12:05:45 2020 Received: (at 40555) by debbugs.gnu.org; 11 Apr 2020 16:05:45 +0000 Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNIdc-0004zY-S0 for submit@debbugs.gnu.org; Sat, 11 Apr 2020 12:05:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNIda-0004zG-SL; Sat, 11 Apr 2020 12:05:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNIdV-00026d-QP; Sat, 11 Apr 2020 12:05:37 -0400 Received: from [176.228.60.248] (port=2216 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNIdU-0005Wy-8k; Sat, 11 Apr 2020 12:05:37 -0400 Date: Sat, 11 Apr 2020 19:05:21 +0300 Message-Id: <83o8rykny6.fsf@gnu.org> From: Eli Zaretskii To: Matthieu Hauglustaine In-Reply-To: (message from Matthieu Hauglustaine on Sat, 11 Apr 2020 17:24:16 +0200) Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40555 Cc: 40555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) merge 40555 40023 thanks > From: Matthieu Hauglustaine > Date: Sat, 11 Apr 2020 17:24:16 +0200 > > I've experienced a EXC_BAD_ACCESS when using Emacs 27.0.90 on OS X > 10.15. > > The root cause appears to be an out of bound access on > proc_decode_coding_system (src/process.c:7988), in > setup_process_coding_systems() when calling setup_coding_system(). This > results in an invalid write to coding->id from > CHECK_CODING_SYSTEM_GET_ID (src/coding.c:5678). [1] for the stacktrace. > > On Emacs initialization (init_process_emacs(), src/emacs.c:8234), > RLIMIT_NOFILE.rlim_cur is set to FD_SETSIZE, and the assumption seem to > be that this limit will never change for the lifetime of the > process. proc_decode_coding_system and proc_encode_coding_system are > declared with a size of FD_SETSIZE (src/process.c:311). > > However, on OS X systems, the call to NSURL.getResourceValue:forKey: > (src/nsfns.c:497), when opening a file, apparently result in a call to > setrlimit with RLIMIT_NOFILE.rlim_cur > FD_SETSIZE. > > Thus, when the number of FDs opened by Emacs is greater than FD_SETSIZE, > an illegal access is done when make-process is called. Thankjs, this is bug#40023. There's a patch there, maybe you could try it. If the patch works for you, we could install it on the emacs-27 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 15:10:34 2020 Received: (at 40555) by debbugs.gnu.org; 11 Apr 2020 19:10:34 +0000 Received: from localhost ([127.0.0.1]:57098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNLWT-0002yG-Nj for submit@debbugs.gnu.org; Sat, 11 Apr 2020 15:10:34 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:42590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNK42-0000mr-OM for 40555@debbugs.gnu.org; Sat, 11 Apr 2020 13:37:08 -0400 Received: by mail-io1-f53.google.com with SMTP id y17so4887866iow.9 for <40555@debbugs.gnu.org>; Sat, 11 Apr 2020 10:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MOQh4NV0Xc1hOcGZFsRHFEljYJMcsBg4ijWHe60+peg=; b=OkeflwJBpQWL5o6JxrR9OIc1UBMeqDCZhmSW+EdQueLMYBYFMMa9YoZ9DPJeVZO916 ve/kufMihUjfbQIzgzNDOLJUibVConhG09+ntAL9MjEsZQ+kMg6hHafshjdPs6OYJzkm Cz0NNW1M2DaOx7GiuvnsX2glbKnVaggNzhQ6jrweTNDIBVGsVba6p7b8uFiDfrkie2Tb Q21ib+Xt2nKTib4UFlTsGbrj2Ypo8Zd0oS+cztCZmtzNhWXlrAxpl4piNhxPKgT6Cj5A 1NjesCzGMWDsTYZr5vL4kX8vosNgWPTyD4bDAjDf67UJSLD0rdGAhD7UjEZuA/fHI5DO wSjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MOQh4NV0Xc1hOcGZFsRHFEljYJMcsBg4ijWHe60+peg=; b=gGiqm80U/h5JIVefVwNiJKiPNoZurea/PKM/weO1iwkQwAKPOis8SamBOgOTg+8+RD xfC1Ab/zi6eKCnWPqhxtqsyNk+7A8UQTB9lki5I7tgerGMcnT8peUtWoNTbgg5rv22xZ 1uPDzFObXEcCq0YzE+j+R8zLFvYN9z7JOqcfcU/hsWzCA61JRmIwEcFUl1GLZ5itpQ5u Afd4CP4mqEavvKtsBse3z8DcqJk/DKeZwe3OBk0Y5rqak65eAKRvRNih4eBCjzGkdEUD wuv6dVjSBLGwDkqsub+YKVh34C2ujjXguSt3+w4i9ELlivlHMHc7YUfyAYY+P58EhjYk OBjA== X-Gm-Message-State: AGi0PuYTq4XibQRKDchPABrnTPrYJyRVLK5r6pRJsOpt5RMJJ2u8Asaf 4OpXuWt/EsJtU7TkCMgD3niCTtcTcWzc1dFdvk3p9HD8GrE= X-Google-Smtp-Source: APiQypIRQVFIvoqieACjh7NM+vYKslsrvJyMAa+/8GDqMfbMUx0SSWJPWJVlckd68w+fcsQ1OG4YhS5DN1jFwrLzKnk= X-Received: by 2002:a05:6602:1214:: with SMTP id y20mr9562060iot.106.1586626621001; Sat, 11 Apr 2020 10:37:01 -0700 (PDT) MIME-Version: 1.0 References: <83o8rykny6.fsf@gnu.org> In-Reply-To: <83o8rykny6.fsf@gnu.org> From: Matthieu Hauglustaine Date: Sat, 11 Apr 2020 19:36:25 +0200 Message-ID: Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000022d57505a3074c57" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40555 X-Mailman-Approved-At: Sat, 11 Apr 2020 15:10:32 -0400 Cc: 40555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000022d57505a3074c57 Content-Type: text/plain; charset="UTF-8" Apologies for the duplicate. I can confirm I reproduced with a built on branch-27, and applying Robert's patch fixes the issue. Thanks, Matthieu On Sat, Apr 11, 2020 at 6:05 PM Eli Zaretskii wrote: > merge 40555 40023 > thanks > > > From: Matthieu Hauglustaine > > Date: Sat, 11 Apr 2020 17:24:16 +0200 > > > > I've experienced a EXC_BAD_ACCESS when using Emacs 27.0.90 on OS X > > 10.15. > > > > The root cause appears to be an out of bound access on > > proc_decode_coding_system (src/process.c:7988), in > > setup_process_coding_systems() when calling setup_coding_system(). This > > results in an invalid write to coding->id from > > CHECK_CODING_SYSTEM_GET_ID (src/coding.c:5678). [1] for the stacktrace. > > > > On Emacs initialization (init_process_emacs(), src/emacs.c:8234), > > RLIMIT_NOFILE.rlim_cur is set to FD_SETSIZE, and the assumption seem to > > be that this limit will never change for the lifetime of the > > process. proc_decode_coding_system and proc_encode_coding_system are > > declared with a size of FD_SETSIZE (src/process.c:311). > > > > However, on OS X systems, the call to NSURL.getResourceValue:forKey: > > (src/nsfns.c:497), when opening a file, apparently result in a call to > > setrlimit with RLIMIT_NOFILE.rlim_cur > FD_SETSIZE. > > > > Thus, when the number of FDs opened by Emacs is greater than FD_SETSIZE, > > an illegal access is done when make-process is called. > > Thankjs, this is bug#40023. There's a patch there, maybe you could > try it. If the patch works for you, we could install it on the > emacs-27 branch. > > --00000000000022d57505a3074c57 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Apologies=C2=A0for the duplicate.

I can= confirm I reproduced with a built on branch-27, and applying Robert's = patch fixes the issue.

Thanks,
Matthieu<= /div>

On Sat, Apr 11, 2020 at 6:05 PM Eli Zaretskii <eliz@gnu.org> wrote:
merge 40555 40023
thanks

> From: Matthieu Hauglustaine <matt.hauglustaine@gmail.com>
> Date: Sat, 11 Apr 2020 17:24:16 +0200
>
> I've experienced a EXC_BAD_ACCESS when using Emacs 27.0.90 on OS X=
> 10.15.
>
> The root cause appears to be an out of bound access on
> proc_decode_coding_system (src/process.c:7988), in
> setup_process_coding_systems() when calling setup_coding_system(). Thi= s
> results in an invalid write to coding->id from
> CHECK_CODING_SYSTEM_GET_ID (src/coding.c:5678). [1] for the stacktrace= .
>
> On Emacs initialization (init_process_emacs(), src/emacs.c:8234),
> RLIMIT_NOFILE.rlim_cur is set to FD_SETSIZE, and the assumption seem t= o
> be that this limit will never change for the lifetime of the
> process. proc_decode_coding_system and proc_encode_coding_system are > declared with a size of FD_SETSIZE (src/process.c:311).
>
> However, on OS X systems, the call to NSURL.getResourceValue:forKey: > (src/nsfns.c:497), when opening a file, apparently result in a call to=
> setrlimit with RLIMIT_NOFILE.rlim_cur > FD_SETSIZE.
>
> Thus, when the number of FDs opened by Emacs is greater than FD_SETSIZ= E,
> an illegal access is done when make-process is called.

Thankjs, this is bug#40023.=C2=A0 There's a patch there, maybe you coul= d
try it.=C2=A0 If the patch works for you, we could install it on the
emacs-27 branch.

--00000000000022d57505a3074c57-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 10:06:33 2020 Received: (at 40555) by debbugs.gnu.org; 14 Apr 2020 14:06:33 +0000 Received: from localhost ([127.0.0.1]:34528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOMCv-00042p-EZ for submit@debbugs.gnu.org; Tue, 14 Apr 2020 10:06:33 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:37758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOMCu-00042d-6f for 40555@debbugs.gnu.org; Tue, 14 Apr 2020 10:06:32 -0400 Received: by mail-wr1-f46.google.com with SMTP id k1so7249551wrx.4 for <40555@debbugs.gnu.org>; Tue, 14 Apr 2020 07:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=Ie11BUv7ez6CKqKjigwTAznaxZAyMB/6/VTdm8UYYgA=; b=Q9Pim5mbsixsGsFj+wZ+wHeP1bIXh1tZMjZmMGMBdWeALBsidIE9fr40pmliMvnv2g PDmVKKcn6SV2HfpmkzSAhCkxS21OxDT8MIqJbHM+GwwPe0GV3K2/9UnxHaZu6xDvNdU0 /MCYmmRi0zUXSQh8h7M8hykZB8YAQJnGAACl6aDJfavDxRgNzHY9lZYqzAjeALccgHTo 1T8eBSSfqrKDJtQ4TP3IZWnvUiq5IWDtE+guOwvrn/U7X0LuoKDA5XkJNnsHXeE1ONbc cQHvDXdPpGkwzNX5DR0TtqEr7JVIoDFQTHHrNSaYbffmwnBDJ+htESkYebJcPiAN/w3r Ht7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Ie11BUv7ez6CKqKjigwTAznaxZAyMB/6/VTdm8UYYgA=; b=YNyY55s7NYDs+VxXfZ5Q7HUyJ/vhtK/0GjmSh4HsGlTl95BMMn8VSbjTj/SbMgLgEu K9zjQ9JU0OJIM4/xwWP4EqKGkx1FcRCKWDCDkK1tM9yi88oTAmO1koNI1iwjVfmsFCv1 lNdoZScKJSEYEsGm376Rt4W3ToQJ+BlsubYMp0liHuVjgZ9zAkckVH/RtZhGcM2Y6+H3 qjRT+waI3Jj4VHY4NQl76iqISnscx2yWUCMgDh7YfWV1SfPkLuOhAHRkFiSs3itvdv23 6RXURtjntIQczvxHXIPsAGUvS7vAwYQo+s7wLqNxXptUZ3sDyubktOJxlwhBnsbg6/vh lA6w== X-Gm-Message-State: AGi0PuZzlOUF1evTRY5BvBF+F306QdylUJqjsZOxeyO4ehy8Fi2oOVVK PkEFubohPM79NY7e0aN5rXt+AnlO X-Google-Smtp-Source: APiQypIWM9WY2M0JNeJinNxuaTRNcTZH0+lXF9yIA/D0aB+cpw3kSxzldSGnbhUNtJn1KaRNKpV8BQ== X-Received: by 2002:adf:f187:: with SMTP id h7mr24371023wro.331.1586873186134; Tue, 14 Apr 2020 07:06:26 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:f1a6:22e0:cfda:c9f2]) by smtp.gmail.com with ESMTPSA id i25sm18766628wml.43.2020.04.14.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:06:25 -0700 (PDT) From: Robert Pluim To: Matthieu Hauglustaine Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: <83o8rykny6.fsf@gnu.org> Date: Tue, 14 Apr 2020 16:06:23 +0200 In-Reply-To: (Matthieu Hauglustaine's message of "Sat, 11 Apr 2020 19:36:25 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40555 Cc: 40555@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) >>>>> On Sat, 11 Apr 2020 19:36:25 +0200, Matthieu Hauglustaine said: Matthieu> Apologies for the duplicate. Matthieu> I can confirm I reproduced with a built on branch-27, and app= lying Robert's Matthieu> patch fixes the issue. Thanks for testing. It=CA=BCs not my patch originally, but that=CA=BCs by the by. Eli, what wou= ld you like me to do with it? Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 13:38:10 2020 Received: (at 40555) by debbugs.gnu.org; 14 Apr 2020 17:38:10 +0000 Received: from localhost ([127.0.0.1]:34738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOPVi-00071V-A2 for submit@debbugs.gnu.org; Tue, 14 Apr 2020 13:38:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOPVh-00071J-2x for 40555@debbugs.gnu.org; Tue, 14 Apr 2020 13:38:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jOPVb-0001wK-TN; Tue, 14 Apr 2020 13:38:03 -0400 Received: from [176.228.60.248] (port=2937 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jOPVb-0002f9-De; Tue, 14 Apr 2020 13:38:03 -0400 Date: Tue, 14 Apr 2020 20:37:45 +0300 Message-Id: <83wo6ige8m.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: (message from Robert Pluim on Tue, 14 Apr 2020 16:06:23 +0200) Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: <83o8rykny6.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40555 Cc: 40555@debbugs.gnu.org, matt.hauglustaine@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Robert Pluim > Cc: Eli Zaretskii , 40555@debbugs.gnu.org > Date: Tue, 14 Apr 2020 16:06:23 +0200 > > >>>>> On Sat, 11 Apr 2020 19:36:25 +0200, Matthieu Hauglustaine said: > > Matthieu> Apologies for the duplicate. > Matthieu> I can confirm I reproduced with a built on branch-27, and applying Robert's > Matthieu> patch fixes the issue. > > Thanks for testing. > > Itʼs not my patch originally, but thatʼs by the by. Eli, what would > you like me to do with it? Any reasons not to install this? I think you wanted someone to test it, and now we have our volunteer who did. Or am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 04:04:39 2020 Received: (at control) by debbugs.gnu.org; 15 Apr 2020 08:04:39 +0000 Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOd2F-0006ma-IS for submit@debbugs.gnu.org; Wed, 15 Apr 2020 04:04:39 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOd2E-0006mI-0p for control@debbugs.gnu.org; Wed, 15 Apr 2020 04:04:38 -0400 Received: by mail-wr1-f41.google.com with SMTP id k11so17326870wrp.5 for ; Wed, 15 Apr 2020 01:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=goa6H9g6my93aiWcMmx50DEbkU6X3LU4WnIW4Q2egA4=; b=VqnA8gq5B0c+6REw9ROrj5iUt1VsoRJAyYx8MoXDJIZGW3EXC33BJPORgJpXr0KqTM Lmn8r3pIQaHUqVmWSSg3siayvEilgM8Fvb6v+E2VQsHLwuWWNJFT1CUxAbrYSg0Gx4XI 3mEdLaqvS7r9r2kUfOb2GSdDzLOisNet1FvYuWXrLmEy0mcUmnWKf6cg+yg8PY/glk+6 etYq3ohMrAEjv2xW/MaO66DU4fIkqr31HS+MCg3vkBCbt6pKSPcCkswga7NPj0x8VpOP t4mO3mUXVNuMUFw2fo/pKkhVTb96ZJttfbdEBg29+1Ci1AOmfIncR7pw2lF8Wt5K02Tk XgTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=goa6H9g6my93aiWcMmx50DEbkU6X3LU4WnIW4Q2egA4=; b=p5qorcbgfdaZmK913Nh63RjNMCZ/g5LciC0fzOyx5XuPYj18/j3oz4HrHarDE5jAiu sHh96YmLL2ZWfh5CLJrq5rkOCBU1o4+ngmAia9mi83c7kl+ItsTah8KpFJssKCSMidF7 BhrFe1Imi1TtvShzOEN5pPAt6zMhJreUpDSrCZrXftJUqI27B2eWtLa70N1GNzLMITD4 2w+RY7JJU6MHvtBS1BIEvCgFvi5Dn6ZXkNC0iwgvxEoOvt/57VFKLLMgeCqOn4F9oV2Y onByvmj0DxmT6lrp4thiOohmzydm00hBrdoxOewJb2q7cKBSYM0kpANTY/BVbyIFK3pE +zvQ== X-Gm-Message-State: AGi0PuYwXTTkA8nYX23/HY21I40Ovj9kHtca4pE7Xh5lI5EN1bL4dxLZ EcN+mGQu2X+DEiWK/1S1PplDwi+1 X-Google-Smtp-Source: APiQypJPH1ZkZaxpHGy5EUW6B+GCoIkwF/9oHy4u0OECXkaSJggvskrra9v5qJmX3D/wCG24cJUCJA== X-Received: by 2002:adf:cd84:: with SMTP id q4mr13532979wrj.320.1586937871747; Wed, 15 Apr 2020 01:04:31 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:f1a6:22e0:cfda:c9f2]) by smtp.gmail.com with ESMTPSA id 1sm3289367wmz.13.2020.04.15.01.04.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 01:04:31 -0700 (PDT) From: Robert Pluim To: control@debbugs.gnu.org Subject: control message for bug #40023 Date: Wed, 15 Apr 2020 10:04:29 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) merge 40023 39164 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 04:06:40 2020 Received: (at 40555) by debbugs.gnu.org; 15 Apr 2020 08:06:40 +0000 Received: from localhost ([127.0.0.1]:35196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOd4B-0006qW-TV for submit@debbugs.gnu.org; Wed, 15 Apr 2020 04:06:40 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:44249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOd4A-0006qD-4Y for 40555@debbugs.gnu.org; Wed, 15 Apr 2020 04:06:38 -0400 Received: by mail-wr1-f46.google.com with SMTP id d17so11034945wrg.11 for <40555@debbugs.gnu.org>; Wed, 15 Apr 2020 01:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=oeYxfhfyMJGy0D9PiP0RJ8Ap9ePNSMyXvjQfj1hxp8Y=; b=W7+rN6xBnT3ThWUs1nhTzG9tWNQ5nM2wAp0k6xJXsz+QTN57UiWrbdvf7hyJxW1D7o H19CJWrMG1NS5B5Al8/4nv9pZTMt+cdMAFdjtmeqEsZwWd8GC7l/BL/+ijpAgFsuRU2s 5RjSAersuFg5eWG5IlpJ6ASIkZEcbawk7xBE0D2WHGA9arqw7ichT/Dl71ybX2QrXNe2 kMdX0z7qKScD/HFglGLIgFFCIf5Fy9hoHxhkF879xv005ex9j1+vbRnnGHV/vRpSKPlw XqW9UgjSMt904NWId2vNPdX9c790DU3FYhhBMk+sG3hvt/+ZYhtR9hXUhtCGW5cCaoMQ ajOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=oeYxfhfyMJGy0D9PiP0RJ8Ap9ePNSMyXvjQfj1hxp8Y=; b=D66Xe2n98B9kaUmazHI/TtupP+s1gU6TmZn42a152y9JdHpx677KQ0CuIxyA6zfNkp qo+z5kY/EevZSHfBBDWSU8hOGATjRPP504EW9GKjQibEAHkIS4XQKY8r8rjcmPnLj2S+ IhcWKPuxPJnjKLFT9IUffMT9sCwkvbePGOfJwGAaWBBR94L1SFWL0CaQNDfUQhpHqQYm a7BD6acjLOM+KuI2IFMdMDtElGtcY/MZspU4L/O0un9b6MSi2zM5uLbU49knELOik88F H7gFJQoR31LvqZtEhwa7QXtXDzRv4B0Pm2xUjTKXuFO8qPZlIZvTy5cxb20RcGec9CPl 0Dmg== X-Gm-Message-State: AGi0Pua0YznRSYLWIP1C7rFep24zjewUd3Vqflewwe1AKaOzkFAuryDS xtqMb33kR8IgUAh/I9XaudFraOHi X-Google-Smtp-Source: APiQypIZPc/m3chvuaoH0hjZCScRoVWrh1nxNzrzQ3PDjfXuw703UqgYXInR0+ezp0KKEqJUaxYWdQ== X-Received: by 2002:adf:c188:: with SMTP id x8mr26456292wre.136.1586937992231; Wed, 15 Apr 2020 01:06:32 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:f1a6:22e0:cfda:c9f2]) by smtp.gmail.com with ESMTPSA id u12sm1124850wmu.25.2020.04.15.01.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 01:06:31 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: <83o8rykny6.fsf@gnu.org> <83wo6ige8m.fsf@gnu.org> Date: Wed, 15 Apr 2020 10:06:30 +0200 In-Reply-To: <83wo6ige8m.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Apr 2020 20:37:45 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40555 Cc: 40555@debbugs.gnu.org, matt.hauglustaine@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) >>>>> On Tue, 14 Apr 2020 20:37:45 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii , 40555@debbugs.gnu.org >> Date: Tue, 14 Apr 2020 16:06:23 +0200 >>=20 >> >>>>> On Sat, 11 Apr 2020 19:36:25 +0200, Matthieu Hauglustaine >> said: >>=20 Matthieu> Apologies for the duplicate. Matthieu> I can confirm I reproduced with a built on branch-27, and app= lying Robert's Matthieu> patch fixes the issue. >>=20 >> Thanks for testing. >>=20 >> It=CA=BCs not my patch originally, but that=CA=BCs by the by. Eli, w= hat would >> you like me to do with it? Eli> Any reasons not to install this? I think you wanted someone to te= st Eli> it, and now we have our volunteer who did. Or am I missing someth= ing? I can push it to emacs-27. Should I set the Author to Yamamoto-san? Robert From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 05:40:42 2020 Received: (at 40555) by debbugs.gnu.org; 15 Apr 2020 09:40:42 +0000 Received: from localhost ([127.0.0.1]:35258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOeXC-0002t1-3W for submit@debbugs.gnu.org; Wed, 15 Apr 2020 05:40:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOeXA-0002sl-9s for 40555@debbugs.gnu.org; Wed, 15 Apr 2020 05:40:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jOeX5-0005sm-5N; Wed, 15 Apr 2020 05:40:35 -0400 Received: from [176.228.60.248] (port=1641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jOeX4-00055h-7o; Wed, 15 Apr 2020 05:40:34 -0400 Date: Wed, 15 Apr 2020 12:40:16 +0300 Message-Id: <83imi1gk8v.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: (message from Robert Pluim on Wed, 15 Apr 2020 10:06:30 +0200) Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: <83o8rykny6.fsf@gnu.org> <83wo6ige8m.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 40555 Cc: 40555@debbugs.gnu.org, matt.hauglustaine@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) > From: Robert Pluim > Cc: matt.hauglustaine@gmail.com, 40555@debbugs.gnu.org > Date: Wed, 15 Apr 2020 10:06:30 +0200 > > >> Itʼs not my patch originally, but thatʼs by the by. Eli, what would > >> you like me to do with it? > > Eli> Any reasons not to install this? I think you wanted someone to test > Eli> it, and now we have our volunteer who did. Or am I missing something? > > I can push it to emacs-27. Please do. > Should I set the Author to Yamamoto-san? Either that or "Patch from" will be fine, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 06:01:30 2020 Received: (at 40555-done) by debbugs.gnu.org; 15 Apr 2020 10:01:30 +0000 Received: from localhost ([127.0.0.1]:35267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOerK-0003Ql-FP for submit@debbugs.gnu.org; Wed, 15 Apr 2020 06:01:30 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:35900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOerI-0003QZ-Tp for 40555-done@debbugs.gnu.org; Wed, 15 Apr 2020 06:01:29 -0400 Received: by mail-wm1-f48.google.com with SMTP id a201so17860859wme.1 for <40555-done@debbugs.gnu.org>; Wed, 15 Apr 2020 03:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=Pmg6/1d+Ax2OgeRJYkali3zgXPDH5Ej0NF0Wgw4Kqw0=; b=hzh1Krv7Odl6hSNuxD0B7r5ElLpiG9Q+0pczPE3eUlxF7iNaeYYuqV3Edq4KFaJOhW 9zTK+Ls3hDx3mNyRx0lh1/i1LmXqgWVkNL/DEA1IhFZqYbnuK4X3oXjp7WQOtuuPt/qK rq1a8DqB1F8mDluraKD1rPwMVr+jpXxmKCuCQme780f6NdDSAU+1yvg71+rFYmjN2MZc b/zYcpfBATlYj8NFLdQusuA3eaSvNTSIX6c2kPr15EvH/gPqvlsxWd+ntJK7P0t8FK3e ZYElzfIEMJtO+7Trz0oJuoD1F+LFqFX7ONUWZSUGq7R7ZtES7De2M8RS+bZU31g50gBy vQ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Pmg6/1d+Ax2OgeRJYkali3zgXPDH5Ej0NF0Wgw4Kqw0=; b=KIXawOUCudwM4/VCJXv5yznihIkvBAp9/5t1QjfEK8RfdQEfaQ8ZPBDA99RpgOpzva N3RMqISE5zFtclKILvPTYZV2NEI6oi8oi6VmiEfHsm+LN7EXBkVMfz3S05vfGvrRp4he uwrOp+kCGTyDvl0Xu6oeoG5KxyPWz1SDqtFOccmIWWMO2urQjsjXTo3vSZ03qrFv3FNp LSklYlB9nm1IaVdNGiV0aCOL90JoGTwUyz1V9v+bayQGlR0MjdFP/SS0RWeCpQ+XrNHD zVnHXbqUf3s7UeDzpr9Iumohk3yiLEJLMVKcuXlwbgjvjS4RvTFdGN/zxRflGuHp7tbU 6lOA== X-Gm-Message-State: AGi0PuZMdhRoYC3zId0vLqVu33rHxMkVZ1U4DoZuxDXp+4fIHtRm0VbM +UfsYZyvMR7eqeIX7HEzdFewQJlq X-Google-Smtp-Source: APiQypLWXRyti9liyFebTLVTYCQg4wQ9bjBPdOJMXggBPd53RDyWcMzjGTiK4R0sKvo9RHJhx00Whw== X-Received: by 2002:a1c:bb08:: with SMTP id l8mr4780138wmf.168.1586944882523; Wed, 15 Apr 2020 03:01:22 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:f1a6:22e0:cfda:c9f2]) by smtp.gmail.com with ESMTPSA id k133sm23229323wma.0.2020.04.15.03.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:01:21 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#40555: 27.0.90; out of bound array access in setup_process_coding_systems References: <83o8rykny6.fsf@gnu.org> <83wo6ige8m.fsf@gnu.org> <83imi1gk8v.fsf@gnu.org> Date: Wed, 15 Apr 2020 12:01:20 +0200 In-Reply-To: <83imi1gk8v.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Apr 2020 12:40:16 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 40555-done Cc: 40555-done@debbugs.gnu.org, matt.hauglustaine@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) >>>>> On Wed, 15 Apr 2020 12:40:16 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: matt.hauglustaine@gmail.com, 40555@debbugs.gnu.org >> Date: Wed, 15 Apr 2020 10:06:30 +0200 >>=20 >> >> It=CA=BCs not my patch originally, but that=CA=BCs by the by. Eli= , what would >> >> you like me to do with it? >>=20 Eli> Any reasons not to install this? I think you wanted someone to te= st Eli> it, and now we have our volunteer who did. Or am I missing someth= ing? >>=20 >> I can push it to emacs-27. Eli> Please do. Done as d87a4d1f4e Closing. >> Should I set the Author to Yamamoto-san? Eli> Either that or "Patch from" will be fine, thanks. I set 'Author'. Robert From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 06:02:03 2020 Received: (at control) by debbugs.gnu.org; 15 Apr 2020 10:02:03 +0000 Received: from localhost ([127.0.0.1]:35276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOerq-0003S8-RH for submit@debbugs.gnu.org; Wed, 15 Apr 2020 06:02:03 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOerp-0003RN-BW for control@debbugs.gnu.org; Wed, 15 Apr 2020 06:02:01 -0400 Received: by mail-wr1-f52.google.com with SMTP id x18so14096440wrq.2 for ; Wed, 15 Apr 2020 03:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5cQK0QMSw3//kXATr0/BXOHVAAJLE6zAJBYUwm51ewc=; b=VwqMtAcapG2zDk3ecHxBV5+TldCNrBcR8Tmy3p72nB5izqSie5DYMTq9rtYnbxsBmV ZrqEuCKGzby2IuXFqOzrQ54ONwczzZ4Ip/9XYEOP3BYI3PbJCMeNp3WoZ/qnw+PI1lxg IlERTwGVzigTtNaasv4RzVM5B0csQqXhHilzdt/QdvIP4GuTRfDf7vZrkkkdMmainS83 FJFan4JGI6qJL2IaSJ9dzUhOiFINsM1EnsrYc9ZI1w6u08RRygQwLhbezeZcEgNCBqjM 7IPoeFXzkbY1DlvTFq8FW8CpFPhtHBY/6MDLMvDMDMpOfWPpfNA5IXaOBpaNmZXsAQHi bFag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5cQK0QMSw3//kXATr0/BXOHVAAJLE6zAJBYUwm51ewc=; b=BJiKmskpHvwPcnREOnoA1AChmbxusUxtf+XDyjDuKkQVeqxY8LetyewuvFLWvCS6Ad k7PI4AZmT0kohvsTQKkyuqu7oeC1BRoIyUabR2Bpyi2rWlx9K3yw4ExZO604tQiPkTqe 3TVsxGPnU98jkBzQMmBasgbA5h2G1pJ/G+j5jWqAYXfYUlzBx8UNR3avF2Wy/8VpO92z CZzt/VrxmKYNL2l6fiLHm3L56H9Lqs+u6IwgC7ULy5RhXXV3EFQayr5groSf5YBBO6fg PWlo5u69IHwoYP52aBFI50dYd60HEeqLp2+kLpqQm1TN2ioOmmHkbeBAlrqZgizQolGp Pebg== X-Gm-Message-State: AGi0PuZJzWwbVuswSjBw8WQ2Eg2d62Hm1Itf3vrjP6EZb1fiBcO9wKEt PZINExQWHuvMwImXmTJw8jkuAwIn X-Google-Smtp-Source: APiQypKIYGZDQicduhBEMHKgBa3szRXFuH855PUwawldJ1Cb13B2pgunrF9FkLWpwUVqhGWsOM5fpw== X-Received: by 2002:a5d:660a:: with SMTP id n10mr27406359wru.74.1586944915155; Wed, 15 Apr 2020 03:01:55 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:f1a6:22e0:cfda:c9f2]) by smtp.gmail.com with ESMTPSA id q8sm21666606wmg.22.2020.04.15.03.01.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:01:54 -0700 (PDT) From: Robert Pluim To: control@debbugs.gnu.org Subject: control message for bug #39164 Date: Wed, 15 Apr 2020 12:01:53 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) fixed 39164 27.1 quit From unknown Fri Jun 20 07:19:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 May 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator