Subject: Re: bug#40538: installer: Support uvesafb to install on machines without KMS.

From: "pelzflorian (Florian Pelz)" <[email-masked]>
Date: Sun, 12 Apr 2020 11:23:30 +0200

On Sun, Apr 12, 2020 at 12:11:52AM +0300, Efraim Flashner wrote:
> >           (respawn? #f)
> >           (one-shot? #t))))
> 
> You don't need both of these lines. If it's a one-shot service then it
> shouldn't respawn when it finishes, just when something else needs it
> again.

Thank you.  Maybe I should push the attached patch?

Regards,
Florian

>From e16a277d1ec1afa14dede7bac0307b12603ebebd Mon Sep 17 00:00:00 2001
From: Florian Pelz <[email-masked]>
Date: Sun, 12 Apr 2020 11:08:28 +0200
Subject: [PATCH] services: kernel-module-loader: Clean up.

Suggested by Efraim Flashner <[email-masked]>.
See <https://lists.gnu.org/archive/html/bug-guix/2020-04/msg00237.html>.

* gnu/services/linux.scm (kernel-module-loader-shepherd-service):
Remove unneeded 'respawn?' field.
---
 gnu/services/linux.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/services/linux.scm b/gnu/services/linux.scm
index 781a61973c..12934c2084 100644
--- a/gnu/services/linux.scm
+++ b/gnu/services/linux.scm
@@ -142,7 +142,6 @@ representation."
        (documentation "Load kernel modules.")
        (provision '(kernel-module-loader))
        (requirement '(file-systems))
-       (respawn? #f)
        (one-shot? #t)
        (modules `((srfi srfi-1)
                   (srfi srfi-34)
-- 
2.26.0