GNU bug report logs - #40537
[PATCH] gnu: Add bchoppr.

Previous Next

Package: guix-patches;

Reported by: Alexandros Theodotou <alex <at> zrythm.org>

Date: Fri, 10 Apr 2020 12:40:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alexandros Theodotou <alex <at> zrythm.org>
Subject: bug#40537: closed (Re: [bug#40537] [PATCH] gnu: Add bchoppr.)
Date: Sun, 03 May 2020 10:20:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#40537: [PATCH] gnu: Add bchoppr.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40537 <at> debbugs.gnu.org.

-- 
40537: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40537
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 40537-done <at> debbugs.gnu.org
Subject: Re: [bug#40537] [PATCH] gnu: Add bchoppr.
Date: Sun, 03 May 2020 11:19:48 +0100
[Message part 3 (text/plain, inline)]
Alexandros Theodotou <alex <at> zrythm.org> writes:

> I think these should inherit from bsequencer since these are plugins by
> the same author and it's reasonable that they follow the same build
> procedure. We already to do this for other similar situations and it
> also makes maintenance easier and DRY. Perhaps moving them below
> bsequencer would be a better solution?

Sorry for the slow reply. In terms of maintenance going forward, the
cost of inheritance is that it means that changes to one package
definition can effect others. So the question should be, should changes
to bsequencer like the inputs or arguments be applied to bchoppr as
well.

Anyway, these things become clearer with time. I've gone ahead and
pushed this (the 1.4.2 version) as
d5aee5003422c1cc4f3adfe016a24cc1b9c35881. I've moved the package up from
the bottom of the file, and tweaked the commit message (capital N in
new).

Chris
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add bchoppr.
Date: Fri, 10 Apr 2020 13:38:22 +0100
[Message part 6 (text/plain, inline)]
Hi,

These patches add 3 new LV2 plugins by the same author as bsequencer:
bchoppr
bshapr
bjumblr

Thanks,
Alex
[0003-gnu-Add-bjumblr.patch (text/x-patch, attachment)]
[0002-gnu-Add-bshapr.patch (text/x-patch, attachment)]
[0001-gnu-Add-bchoppr.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 22 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.