Subject: bug#40537: closed (Re: [bug#40537] [PATCH] gnu: Add bchoppr.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 03 May 2020 10:20:02 +0000

Your bug report

#40537: [PATCH] gnu: Add bchoppr.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
40537: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40537
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#40537] [PATCH] gnu: Add bchoppr.
From: Christopher Baines <[email-masked]>
To: Alexandros Theodotou <[email-masked]>
Cc: [email-masked]
Date: Sun, 03 May 2020 11:19:48 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Alexandros Theodotou <[email-masked]> writes:

> I think these should inherit from bsequencer since these are plugins by
> the same author and it's reasonable that they follow the same build
> procedure. We already to do this for other similar situations and it
> also makes maintenance easier and DRY. Perhaps moving them below
> bsequencer would be a better solution?

Sorry for the slow reply. In terms of maintenance going forward, the
cost of inheritance is that it means that changes to one package
definition can effect others. So the question should be, should changes
to bsequencer like the inputs or arguments be applied to bchoppr as
well.

Anyway, these things become clearer with time. I've gone ahead and
pushed this (the 1.4.2 version) as
d5aee5003422c1cc4f3adfe016a24cc1b9c35881. I've moved the package up from
the bottom of the file, and tweaked the commit message (capital N in
new).

Chris

Subject: [PATCH] gnu: Add bchoppr.
From: Alexandros Theodotou <[email-masked]>
To: Guix patches <[email-masked]>
Date: Fri, 10 Apr 2020 13:38:22 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

These patches add 3 new LV2 plugins by the same author as bsequencer:
bchoppr
bshapr
bjumblr

Thanks,
Alex
From 31fd828bc4a5bdec19770671ec55c5e2ec36af90 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <[email-masked]>
Date: Fri, 10 Apr 2020 13:36:23 +0100
Subject: [PATCH 3/3] gnu: Add bjumblr.

* gnu/packages/music.scm (bjumblr): new variable.
---
 gnu/packages/music.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index d3936de348..1d570bc79a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5464,3 +5464,28 @@ B.Choppr is the successor of B.Slizr.")
     (description "B.Shapr is a beat/envelope shaper LV2 plugin")
     (home-page "https://github.com/sjaehn/BShapr")
     (license license:gpl3+)))
+
+(define-public bjumblr
+  (package
+    (inherit bsequencer)
+    (name "bjumblr")
+    (version "0.2")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sjaehn/BJumblr.git")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "14z8113zkwykbhm1a8h2xs972dgifvlfij92b08jckyc7cbz84ys"))))
+    (inputs
+      `(("cairo", cairo)
+        ("libsndfile", libsndfile)
+        ("lv2", lv2)))
+    (synopsis "Pattern-controlled audio stream/sample re-sequencer LV2 plugin")
+    (description "B.Jumblr is a pattern-controlled audio stream / sample
+re-sequencer LV2 plugin.")
+    (home-page "https://github.com/sjaehn/BJumblr")
+    (license license:gpl3+)))
-- 
2.26.0

From 46def2c5a6bb112375640e836ba426928d5e6a99 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <[email-masked]>
Date: Fri, 10 Apr 2020 13:35:49 +0100
Subject: [PATCH 2/3] gnu: Add bshapr.

* gnu/packages/music.scm (bshapr): new variable.
---
 gnu/packages/music.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index fb8c0445bb..d3936de348 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5444,3 +5444,23 @@ sequence of up to 16 chops.  Each chop can be leveled up or down (gating).
 B.Choppr is the successor of B.Slizr.")
     (home-page "https://github.com/sjaehn/BChoppr")
     (license license:gpl3+)))
+
+(define-public bshapr
+  (package
+    (inherit bsequencer)
+    (name "bshapr")
+    (version "0.8")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sjaehn/BShapr.git")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0jlq5rjicc4fxlpk869dg0l5bwwz8k9aj2wfk9v89b0qw8l8kaxl"))))
+    (synopsis "Beat/envelope shaper LV2 plugin")
+    (description "B.Shapr is a beat/envelope shaper LV2 plugin")
+    (home-page "https://github.com/sjaehn/BShapr")
+    (license license:gpl3+)))
-- 
2.26.0

From cb765aeba81d505a103203d6bfdf917fdf0b5bab Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <[email-masked]>
Date: Fri, 10 Apr 2020 13:34:17 +0100
Subject: [PATCH 1/3] gnu: Add bchoppr.

* gnu/packages/music.scm (bchoppr): new variable.
---
 gnu/packages/music.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5257d9463a..fb8c0445bb 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5422,3 +5422,25 @@ plugin and a standalone JACK application.")
   offers an LV2 version ported by moddevices.")
       (home-page "http://tap-plugins.sourceforge.net/")
       (license license:gpl2))))
+
+(define-public bchoppr
+  (package
+    (inherit bsequencer)
+    (name "bchoppr")
+    (version "1.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sjaehn/BChoppr.git")
+               (commit version)))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "1qq1bg1p4qawhwdag0j8hvf6kdsxkyn8gdjd9pbx00p1i314mp6r"))))
+    (synopsis "Audio stream-chopping LV2 plugin")
+    (description "B.Choppr cuts the audio input stream into a repeated
+sequence of up to 16 chops.  Each chop can be leveled up or down (gating).
+B.Choppr is the successor of B.Slizr.")
+    (home-page "https://github.com/sjaehn/BChoppr")
+    (license license:gpl3+)))
-- 
2.26.0