From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 18:06:45 2020 Received: (at submit) by debbugs.gnu.org; 9 Apr 2020 22:06:45 +0000 Received: from localhost ([127.0.0.1]:54604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMfJt-0005O1-07 for submit@debbugs.gnu.org; Thu, 09 Apr 2020 18:06:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:52221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMeDp-0003dQ-QV for submit@debbugs.gnu.org; Thu, 09 Apr 2020 16:56:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39476) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMeDo-0004et-8X for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 16:56:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMeDm-0003qT-SI for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 16:56:24 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:41728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMeDm-0003q0-OJ for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 16:56:22 -0400 Received: by mail-qk1-x733.google.com with SMTP id y3so178057qky.8 for ; Thu, 09 Apr 2020 13:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=V612K3m05fv3Iik63LoNoPTEkvLNE9Lqw/oh6WNm6s4=; b=Nn3sRwtk5aon/H5zdKm5fdxIX+TZ5qiG0sTkcDaIYhfL3QO6II8/BEHQsE9cmLGWfX VtRdcf+jFKgRG3OanpOlPcErVYX4NHUQxuHs0L1l+wnOH4shKB8QBAOhZHxAFRWZACOk Ykv5hTiBT1VPyl1mlpKq3LuboP8g2sPXBWdXKQ/T6V8KfBe06+0fKuYR3TjKXCmGrt/k F1NKecgQaKMWjOpjKdzcIPaWq60duvlZ7ZHhd7j8SFXKeI+muOPpyLayv7lITkJOp6eu uor04tffX7hfY4bmwB0jEUqDh984QYF/Y20jBLRHaIYFaNqhqoybHv12dQok5hMhpuzk 1FsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=V612K3m05fv3Iik63LoNoPTEkvLNE9Lqw/oh6WNm6s4=; b=H90TlqmekqY0flgBW/CRVZ5NhqcvIZWKqLnb30Dhm2rxxOWK3HcmxcUAixrgxP6wWo u6wuTZ/D1bFxtq3vJ7r6wYU0z5/Tzchpg9fSoBYHq8okb77t7F5ln7Ff0Zjll8/jFi3u j2oz6CTYVyI5ICGUs2RQRscjROy4o5HDuHNaggXjMjOk2AWoaeRj3o6WTJHLzAuJEUZa N9CmhhPTwqAm+WOTWQUVUjkBBpftLnSKR4m6wMEmfy6yb8rA9UTW+Y/3ORos1JeN67s9 yjsG70cGsjmAOsDloIXvKO0CEJyQ+Gv7tiFZWbIaXVVMnXi78XJsn7KqFafEmP80LTO9 tZxA== X-Gm-Message-State: AGi0PuaDCO4aATQ/zm/If2zInovvqOytsXYouAxVQcPktl/F+VeLAHfW pmlXexhWppOLVsfFy3SeIx8BBC3UGoM4e6YMwKXaGzVe74w= X-Google-Smtp-Source: APiQypI4hgm8CLcopXpdsnieq9PZXesWrJIrcQeTWPIlHelRx/zlzZIzRfZECUZvuiiGP9ZzwrqqygbsYWpolunznaY= X-Received: by 2002:a05:620a:1187:: with SMTP id b7mr809696qkk.272.1586465780808; Thu, 09 Apr 2020 13:56:20 -0700 (PDT) MIME-Version: 1.0 From: Aidan Beggs Date: Thu, 9 Apr 2020 16:55:44 -0400 Message-ID: Subject: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000503ecc05a2e1d905" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::733 X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I'm running into errors when attempting to run flymake-show-diagnostics-buffer. If run after I've enabled line numbers via global-display-line-numbers-mode, I get the following stack trace: Debugger entered--Lisp error: (wrong-type-argument stringp nil) flymake--diagnostics-buffer-entries() tabulated-list-print(t) tabulated-list-revert() run-hooks(display-line-numbers-mode-hook display-l [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (nadiasggeb001[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (nadiasggeb001[at]gmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 09 Apr 2020 18:06:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000503ecc05a2e1d905 Content-Type: text/plain; charset="UTF-8" I'm running into errors when attempting to run flymake-show-diagnostics-buffer. If run after I've enabled line numbers via global-display-line-numbers-mode, I get the following stack trace: Debugger entered--Lisp error: (wrong-type-argument stringp nil) flymake--diagnostics-buffer-entries() tabulated-list-print(t) tabulated-list-revert() run-hooks(display-line-numbers-mode-hook display-line-numbers-mode-on-hook) display-line-numbers-mode() display-line-numbers--turn-on() global-display-line-numbers-mode-enable-in-buffers() run-hooks(after-change-major-mode-hook) run-mode-hooks(flymake-diagnostics-buffer-mode-hook) flymake-diagnostics-buffer-mode() flymake-show-diagnostics-buffer() funcall-interactively(flymake-show-diagnostics-buffer) call-interactively(flymake-show-diagnostics-buffer record nil) command-execute(flymake-show-diagnostics-buffer record) execute-extended-command(nil "flymake-show-diagnostics-buffer" "flymake-show-diagnostics") funcall-interactively(execute-extended-command nil "flymake-show-diagnostics-buffer" "flymake-show-diagnostics") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) Once this has been thrown once, running flymake-show-diagnostics-buffer works properly. The only thing in my config file is (global-display-line-numbers-mode). To repro: emacs -Q C-x b *scratch* M-x global-display-line-numbers-mode M-x flymake-mode M-x flymake-show-diagnostics-buffer Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Flymake mode enabled in current buffer tabulated-list-print: Wrong type argument: stringp, nil Making completion list... Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: flymake-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t --000000000000503ecc05a2e1d905 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm running into errors when attempting to run flymake= -show-diagnostics-buffer. If run after I've enabled line numbers via gl= obal-display-line-numbers-mode, I get the following stack trace:

Deb= ugger entered--Lisp error: (wrong-type-argument stringp nil)
=C2=A0 flym= ake--diagnostics-buffer-entries()
=C2=A0 tabulated-list-print(t)
=C2= =A0 tabulated-list-revert()
=C2=A0 run-hooks(display-line-numbers-mode-h= ook display-line-numbers-mode-on-hook)
=C2=A0 display-line-numbers-mode(= )
=C2=A0 display-line-numbers--turn-on()
=C2=A0 global-display-line-n= umbers-mode-enable-in-buffers()
=C2=A0 run-hooks(after-change-major-mode= -hook)
=C2=A0 run-mode-hooks(flymake-diagnostics-buffer-mode-hook)
= =C2=A0 flymake-diagnostics-buffer-mode()
=C2=A0 flymake-show-diagnostics= -buffer()
=C2=A0 funcall-interactively(flymake-show-diagnostics-buffer)<= br>=C2=A0 call-interactively(flymake-show-diagnostics-buffer record nil)=C2=A0 command-execute(flymake-show-diagnostics-buffer record)
=C2=A0 e= xecute-extended-command(nil "flymake-show-diagnostics-buffer" &qu= ot;flymake-show-diagnostics")
=C2=A0 funcall-interactively(execute-= extended-command nil "flymake-show-diagnostics-buffer" "flym= ake-show-diagnostics")
=C2=A0 call-interactively(execute-extended-c= ommand nil nil)
=C2=A0 command-execute(execute-extended-command)
=C2= =A0
Once this has been thrown once, running flymake-show-diagnostics-bu= ffer
works properly. The only thing in my config file is
(global-disp= lay-line-numbers-mode).

To repro:

emacs -Q
C-x b *scratch*=
M-x global-display-line-numbers-mode
M-x flymake-mode
M-x fl= ymake-show-diagnostics-buffer

Recent messages:
= For information about GNU Emacs and the GNU system, type C-h C-a.
Flymak= e mode enabled in current buffer
tabulated-list-print: Wrong type argume= nt: stringp, nil
Making completion list...

Configured using:
= =C2=A0'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/us= r/lib
=C2=A0--localstatedir=3D/var --with-x-toolkit=3Dgtk3 --with-xft --= with-modules
=C2=A0'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -p= ipe -fno-plt'
=C2=A0CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2
=C2=A0LDFLAG= S=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configure= d features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTI= NGS GLIB
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
= TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2
<= br>Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 loca= le-coding-system: utf-8-unix

Major mode: Lisp Interaction

Min= or modes in effect:
=C2=A0 flymake-mode: t
=C2=A0 global-display-line= -numbers-mode: t
=C2=A0 display-line-numbers-mode: t
=C2=A0 tooltip-m= ode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 eldoc-mode: t
=C2=A0 ele= ctric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode:= t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 = global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor= -mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode:= t
=C2=A0 auto-compression-mode: t
=C2=A0 line-number-mode: t
=C2= =A0 transient-mark-mode: t
--000000000000503ecc05a2e1d905-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 02:30:46 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 06:30:46 +0000 Received: from localhost ([127.0.0.1]:54735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMnBe-0000j8-0o for submit@debbugs.gnu.org; Fri, 10 Apr 2020 02:30:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMnBd-0000ix-4u for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 02:30:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMnBW-0005LR-9k; Fri, 10 Apr 2020 02:30:39 -0400 Received: from [176.228.60.248] (port=2115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMnBV-0002E7-Fr; Fri, 10 Apr 2020 02:30:37 -0400 Date: Fri, 10 Apr 2020 09:30:20 +0300 Message-Id: <83v9m7n98j.fsf@gnu.org> From: Eli Zaretskii To: Aidan Beggs , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from Aidan Beggs on Thu, 9 Apr 2020 16:55:44 -0400) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Aidan Beggs > Date: Thu, 9 Apr 2020 16:55:44 -0400 > > emacs -Q > C-x b *scratch* > M-x global-display-line-numbers-mode > M-x flymake-mode > M-x flymake-show-diagnostics-buffer João, here are the results of my preliminary investigation into this, as posted on Reddit (where this was first reported), I hope they will be helpful: Under the above settings, flymake--diagnostics-buffer-entries is invoked as side effect of calling flymake-diagnostics-buffer-mode from flymake-show-diagnostics-buffer, and at that point flymake--diagnostics-buffer-source has not yet been set to a valid buffer name. So the with-current-buffer form at the beginning of flymake--diagnostics-buffer-entries barfs. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 07:50:38 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 11:50:38 +0000 Received: from localhost ([127.0.0.1]:54806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMsBC-00025a-2n for submit@debbugs.gnu.org; Fri, 10 Apr 2020 07:50:38 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:38057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMsBB-00025L-3P for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 07:50:37 -0400 Received: by mail-io1-f50.google.com with SMTP id f19so1498537iog.5 for <40529@debbugs.gnu.org>; Fri, 10 Apr 2020 04:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d+XS+UUbNdkSOmLtujVGSMrHQHzTHgKwecTEChGqVyA=; b=UWIJvjd7i/lSykC9OEFY1JNFd7ms7bicdGh9Cc+qLr+pVzjX1O9+CLE21riQnntwG8 UZ02j+xrnoHJb80QZqGMpUPW6FqH+pjfTWbtdLK4mxGPVrAcQO1GlqpB/s6BHKEyMmcK xStFho7Z4a2o8PuSkuh7eongwruUHee4jOiDdXdo01GSEPX8urbFSu8dZnLIUg/S7/Vr x9FIwJkG6kJoGK2ZP7T+N7A49x1e/6Jsg2AVgROTTH+/fsmdsQI0agXh0/gDwg1w3yvB QyNhHHsrUsd1BFymVWT9b4cyeMhIKF2eIb70/5HKnxLd6FD9jrMk3WaMfTnMQRJwBVti nZrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d+XS+UUbNdkSOmLtujVGSMrHQHzTHgKwecTEChGqVyA=; b=RwLFjwUHsHXsvrsAnmI5bVR2lJvM1s1qt7WlvvX81IjCL2C1Tp6qj15zxI0CPaUBGB m740P7dckt1Fv7IMr38VhbBkgLeJNADkMi17zd7p+z1djKl9fzWA+uJQ62h6xVLvMqDt nHI37nb5BDBUNRwuHh6zSNjpPW7xp//oUN4yFUHL7ycCpobT1/kVmN2N18p94oPiEnjO vbxaFY3eXC5CEBUODp0wxhelQlLASISxx64v4PiMyNX9t1obV0gthVspVADjsBjrlSsz IaZfyCySF3bApJddEYJtas+/WJmS/tbT5TXULhg+BXOyFkNKcZx1y4GNYLk7/O4xj9iQ LwkA== X-Gm-Message-State: AGi0PuYWcbqii48zYelEk6swXCj/5mf8L3DcrJA8hlOrOGeScfxC5P4B Wud6/wKr4FKfGkMl0RgqucYKSZdrbjO4a7CO7A4= X-Google-Smtp-Source: APiQypKq9Ocop3NyY/Q9HhYczqwHRonIdy+XWmrmdKiSCgZo6a3qYxcyeCkqjCqhWZpnEXjKj271dThaNUnOHtuOPCg= X-Received: by 2002:a5d:984b:: with SMTP id p11mr3910887ios.175.1586519431546; Fri, 10 Apr 2020 04:50:31 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> In-Reply-To: <83v9m7n98j.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 10 Apr 2020 12:50:19 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000258e7905a2ee5703" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, Aidan Beggs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000258e7905a2ee5703 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, I will have a look at this soon. One thing I don't understand is the influence of `global-display-line-numbers-mode` in all of this. I suppose the situation doesn't happen if it's off. Knowing why will probably solve the mystery. Actually, having a look at the backtrace, it seems turning on display-line-numbers-mode causes the tabulated list to reprint itself via some hook that is presumably there by default. Anyway, this afternoon or tomorrow. Jo=C3=A3o On Fri, Apr 10, 2020 at 7:30 AM Eli Zaretskii wrote: > > From: Aidan Beggs > > Date: Thu, 9 Apr 2020 16:55:44 -0400 > > > > emacs -Q > > C-x b *scratch* > > M-x global-display-line-numbers-mode > > M-x flymake-mode > > M-x flymake-show-diagnostics-buffer > > Jo=C3=A3o, here are the results of my preliminary investigation into this= , > as posted on Reddit (where this was first reported), I hope they will > be helpful: > > Under the above settings, flymake--diagnostics-buffer-entries is > invoked as side effect of calling flymake-diagnostics-buffer-mode from > flymake-show-diagnostics-buffer, and at that point > flymake--diagnostics-buffer-source has not yet been set to a valid > buffer name. So the with-current-buffer form at the beginning of > flymake--diagnostics-buffer-entries barfs. > > Thanks. > --=20 Jo=C3=A3o T=C3=A1vora --000000000000258e7905a2ee5703 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, I will have a look at this soon.=C2=A0 One th= ing I don't understand is
the influence of `global-displ= ay-line-numbers-mode` in all of this. I suppose
the situation doe= sn't happen if it's off.=C2=A0 Knowing why will probably solve
the mystery.

Actually, having a look at the = backtrace, it seems turning on
display-line-numbers-mode cau= ses the tabulated list to reprint itself via some
hook that is pr= esumably there by default.=C2=A0

Anyway, this= afternoon or tomorrow.

Jo=C3=A3o

On = Fri, Apr 10, 2020 at 7:30 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Aidan Beggs <nadiasggeb001@gmail.com>
> Date: Thu, 9 Apr 2020 16:55:44 -0400
>
> emacs -Q
> C-x b *scratch*
> M-x global-display-line-numbers-mode
> M-x flymake-mode
> M-x flymake-show-diagnostics-buffer

Jo=C3=A3o, here are the results of my preliminary investigation into this,<= br> as posted on Reddit (where this was first reported), I hope they will
be helpful:

=C2=A0 Under the above settings, flymake--diagnostics-buffer-entries is
=C2=A0 invoked as side effect of calling flymake-diagnostics-buffer-mode fr= om
=C2=A0 flymake-show-diagnostics-buffer, and at that point
=C2=A0 flymake--diagnostics-buffer-source has not yet been set to a valid =C2=A0 buffer name.=C2=A0 So the with-current-buffer form at the beginning = of
=C2=A0 flymake--diagnostics-buffer-entries barfs.

Thanks.


--
Jo=C3=A3o T=C3=A1vora
--000000000000258e7905a2ee5703-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 08:16:57 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 12:16:57 +0000 Received: from localhost ([127.0.0.1]:54848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMsae-0002mN-VK for submit@debbugs.gnu.org; Fri, 10 Apr 2020 08:16:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMsad-0002m7-FS for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 08:16:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMsaY-0006XJ-9F; Fri, 10 Apr 2020 08:16:50 -0400 Received: from [176.228.60.248] (port=3525 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMsaX-00024a-Cs; Fri, 10 Apr 2020 08:16:50 -0400 Date: Fri, 10 Apr 2020 15:16:31 +0300 Message-Id: <83r1wvmt7k.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Fri, 10 Apr 2020 12:50:19 +0100) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Fri, 10 Apr 2020 12:50:19 +0100 > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > Thanks, I will have a look at this soon. One thing I don't understand is > the influence of `global-display-line-numbers-mode` in all of this. I suppose > the situation doesn't happen if it's off. Knowing why will probably solve > the mystery. > > Actually, having a look at the backtrace, it seems turning on > display-line-numbers-mode causes the tabulated list to reprint itself via some > hook that is presumably there by default. Exactly. I think this answers your question in the first paragraph. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 10:39:17 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 14:39:17 +0000 Received: from localhost ([127.0.0.1]:55850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMuoO-0008U6-TR for submit@debbugs.gnu.org; Fri, 10 Apr 2020 10:39:17 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:46832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMuoN-0008Ts-2f for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 10:39:15 -0400 Received: by mail-io1-f54.google.com with SMTP id i3so1891896ioo.13 for <40529@debbugs.gnu.org>; Fri, 10 Apr 2020 07:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UKDiCv384RwaZHG8KAxs/S/NJFnZFlxnBWR7fMFbyTg=; b=mffIK66sWPtCB1GbUR6nblq+LFoSVgb/HDELYPemZqO4mN9In8QVldkSJCH0e2YoP2 B4HmXImzOec4f11IGXiSXmZkZ0qQ2mNfE0p9K8igDUzQdHtTOdKpP6onHe6G9RKXR4B4 FoTaA0HXO78/+m/cDif3qdDyOEg4iJToeyCz95WNjp4ZW4wa9Y2zaX7hy4qvS8cFVuiI d4PuN/486NCkqOr+m+G+6GodiYcYaRGyq/cQ/U3hMEfvsHwqAjh3r+0+yaxcEMkGJy1x jxI6Ey8DZzDUD3MLEqW03tS8SXEzZuYzvZDetrtTorFHwlo12sY2pKpXEJEPgC/YZMfI /C0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UKDiCv384RwaZHG8KAxs/S/NJFnZFlxnBWR7fMFbyTg=; b=OuLVklOBA3iclXMenL4ME1lK7oyOG21J1oq6ceEsim3z78B9RKhW4EvZT8v/Iw25Xq 8JgFQVnRJvQvA/1OwHzqE03OlUdSTYAxpi7bE83u+uh5U6l/ZgJayLPOT57Xbw7BbPuX h/t2VCGjioH/VQGew5qibjHyqrQZmpcHcaK/tVq67lnI2OXph0i2/y2jSORFXNsjyRkr WQfFSCAB1KT+q16C4bTQC59tbHxLXM5BkINhFeObu90g9bjlWqKiWSYbn0SBMrtqhRPA Khlb4i2VwHk61hcqcj4rMaXoY8LMFD+hKTBZ9g5tJgRLCPpaTuwzRy6DxaIo5N4mkYFw QvIw== X-Gm-Message-State: AGi0PubmbEv4vkZAJbNGTaxeTERErTBoxpEMhZIzBKFPbSCtgYsX+AIR 1p9KdXuSLNpb9aWkD3FpjXVn4x1gpXGCXGKETqs= X-Google-Smtp-Source: APiQypKqgaZqL/t0EyMRLtCyG5rdQs6wCLWArIBhrEoSTIDgPlfv8joRkQIX1Jf55w0Nnc89OYCzw8rPYzR3m1VXWgU= X-Received: by 2002:a02:b897:: with SMTP id p23mr4947821jam.120.1586529549500; Fri, 10 Apr 2020 07:39:09 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> In-Reply-To: <83r1wvmt7k.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 10 Apr 2020 15:38:58 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000039448905a2f0b276" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000039448905a2f0b276 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 1:16 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Fri, 10 Apr 2020 12:50:19 +0100 > > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > > > Thanks, I will have a look at this soon. One thing I don't understand > is > > the influence of `global-display-line-numbers-mode` in all of this. I > suppose > > the situation doesn't happen if it's off. Knowing why will probably > solve > > the mystery. > > > > Actually, having a look at the backtrace, it seems turning on > > display-line-numbers-mode causes the tabulated list to reprint itself > via some > > hook that is presumably there by default. > > Exactly. I think this answers your question in the first paragraph. > Yes, and it raises another one for which I don't have an answer to. Why does it do that? What do line numbers have to do with tabulated lists? Jo=C3=A3o T=C3=A1vora --00000000000039448905a2f0b276 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 10, 2020 at 1:16 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com><= br> > Date: Fri, 10 Apr 2020 12:50:19 +0100
> Cc: Aidan Beggs <nadiasggeb001@gmail.com>, 40529@debbugs.gnu.org
>
> Thanks, I will have a look at this soon.=C2=A0 One thing I don't u= nderstand is
> the influence of `global-display-line-numbers-mode` in all of this. I = suppose
> the situation doesn't happen if it's off.=C2=A0 Knowing why wi= ll probably solve
> the mystery.
>
> Actually, having a look at the backtrace, it seems turning on
> display-line-numbers-mode causes the tabulated list to reprint itself = via some
> hook that is presumably there by default.=C2=A0

Exactly.=C2=A0 I think this answers your question in the first paragraph.

Yes, and it raises another one for which= I don't have an answer to.=C2=A0
Why does it do that? W= hat do line numbers have to do with
tabulated lists?
=C2=A0
Jo=C3=A3o T=C3= =A1vora
--00000000000039448905a2f0b276-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 11:51:08 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 15:51:08 +0000 Received: from localhost ([127.0.0.1]:55868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMvvv-0001xV-1D for submit@debbugs.gnu.org; Fri, 10 Apr 2020 11:51:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMvvp-0001wz-W5 for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 11:51:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMvvk-0000uH-Qa; Fri, 10 Apr 2020 11:50:56 -0400 Received: from [176.228.60.248] (port=4494 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMvvk-00081L-6y; Fri, 10 Apr 2020 11:50:56 -0400 Date: Fri, 10 Apr 2020 18:50:40 +0300 Message-Id: <83ftdbmjan.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Fri, 10 Apr 2020 15:38:58 +0100) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Fri, 10 Apr 2020 15:38:58 +0100 > Cc: nadiasggeb001@gmail.com, 40529@debbugs.gnu.org > > Exactly. I think this answers your question in the first paragraph. > > Yes, and it raises another one for which I don't have an answer to. > Why does it do that? What do line numbers have to do with > tabulated lists? When line numbers are turned on or off in a buffer under tabulated-list-mode, the buffer needs to be redisplayed because the column counts change, and that affects alignment of the columns. That's why tabulated-list-mode defines a function to be run from display-line-numbers-mode-hook. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 12:09:54 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 16:09:54 +0000 Received: from localhost ([127.0.0.1]:55901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMwE6-0002R1-7d for submit@debbugs.gnu.org; Fri, 10 Apr 2020 12:09:54 -0400 Received: from mail-il1-f174.google.com ([209.85.166.174]:41917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMwE5-0002Qp-2R for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 12:09:53 -0400 Received: by mail-il1-f174.google.com with SMTP id t6so2225639ilj.8 for <40529@debbugs.gnu.org>; Fri, 10 Apr 2020 09:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eD8Fk3lbvq5fjTsyyZXfm0zK+VHnsngYFozt3IkrH8U=; b=TRolO6mrnaK5PO+hGOi4IBqcnykp9MLJoNuxOYi5LdgAsJZO/RX95wwlRtvPyczhR4 K/tERfO8w72HRcHnMQFzKzS3VdSM400Q6EJzQKgR36BnKKHHAaeYJqbdhfyzGHk025vx 6pk+vVFGyU0XBVO5/sbDNH998AfYkgFFnK09BTIYljDKi+3ASRbZCSLTm2NQjS7QOQ9/ IAOkDFG1fLi037pnRng+6YM66nZXa+OTIsW1srCnEO1GYNHSm400oHERoEAK3vCJsodb urZ+KDRCVaMhqPsmHYfsMChKy2s1KBOFoWuIRgeK0Z1/qbhlGdZp+JzfaeAkrUK+oI43 rqMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eD8Fk3lbvq5fjTsyyZXfm0zK+VHnsngYFozt3IkrH8U=; b=T/MH0nE4XZofboUaZf9X/chddsrQyBFV9bIi5zFbpnTU2zU76ciCGKXBmcXnXe7L0r q6CD9U6eA0q2sEw3VQqFVPICiS6AnDV31Duq7ud/ZEUADyi+RKuwpHy4Gwmz5OXg4aVm o0UnFihA60r6fsnp7Xk6awhNPxXbBey70qHmKfxY6mojs6+Ypmtlc0bfv1sH0bRnRh0+ u6+VBiT+J2iwn75rmipbB6girZKGlB0FqU6BN5XbFouZIHytTaAC1n8cI04tDjTGvdTp f/1Px9zkNDP2aHQ5j9aF05xVRhhYapNJHYLt28FZQDQ96Jb6i/Y00xsSw54AeGgpsTti i14w== X-Gm-Message-State: AGi0PuaBn4Dc8E6Pyk0EoLJ9qDM9ayoxRaJYuUBuKgbrJBxU71GKExhO pLgm2h2ytoah3OtAkoDYN+/jxfDK7MVe2ItKSAE= X-Google-Smtp-Source: APiQypKEsxufpF5/b6Yef6Tq6IAIljwmrs751stINI4fqPKKHlqwiEp574eJ3zE/RbdVBmLhNg0DIuUDW4VkQprNdkA= X-Received: by 2002:a92:c00c:: with SMTP id q12mr5711814ild.125.1586534987573; Fri, 10 Apr 2020 09:09:47 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> In-Reply-To: <83ftdbmjan.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 10 Apr 2020 17:09:36 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000005baf3705a2f1f637" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005baf3705a2f1f637 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 4:50 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Fri, 10 Apr 2020 15:38:58 +0100 > > Cc: nadiasggeb001@gmail.com, 40529@debbugs.gnu.org > > > > Exactly. I think this answers your question in the first paragraph. > > > > Yes, and it raises another one for which I don't have an answer to. > > Why does it do that? What do line numbers have to do with > > tabulated lists? > > When line numbers are turned on or off in a buffer under > tabulated-list-mode, the buffer needs to be redisplayed because the > column counts change, and that affects alignment of the columns. > That's why tabulated-list-mode defines a function to be run from > display-line-numbers-mode-hook. > Thanks. That makes some sense, though I didn't know line numbers affected column counts in the actual buffer contents (I though they used the margin or the fringe, but I confess my ignorance here). Anyway, this leaves me wondering if there isn't a hook ordering bug here. Maybe it's just a question of delaying entry in tabulated-list-mode until important stuff is set up. I don't know, I haven't looked at actual code yet. Jo=C3=A3o --0000000000005baf3705a2f1f637 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 10, 2020 at 4:50 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com><= br> > Date: Fri, 10 Apr 2020 15:38:58 +0100
> Cc: nadia= sggeb001@gmail.com, 40529@debbugs.gnu.org
>
>=C2=A0 Exactly.=C2=A0 I think this answers your question in the first p= aragraph.
>
> Yes, and it raises another one for which I don't have an answer to= .=C2=A0
> Why does it do that? What do line numbers have to do with
> tabulated lists?

When line numbers are turned on or off in a buffer under
tabulated-list-mode, the buffer needs to be redisplayed because the
column counts change, and that affects alignment of the columns.
That's why tabulated-list-mode defines a function to be run from
display-line-numbers-mode-hook.

Thanks.= =C2=A0 That makes some sense, though I didn't know line numbers
affected column counts in the actual buffer contents (I though they used=
the margin or the fringe, but I confess my ignorance here).=C2= =A0 Anyway, this
leaves me wondering if there isn't a ho= ok ordering bug here. Maybe it's
just a question of delaying = entry in tabulated-list-mode until important stuff
is set up.=C2= =A0 I don't know, I haven't looked at actual code yet.

Jo=C3=A3o
--0000000000005baf3705a2f1f637-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 12:17:05 2020 Received: (at 40529) by debbugs.gnu.org; 10 Apr 2020 16:17:05 +0000 Received: from localhost ([127.0.0.1]:55909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMwL3-0004Se-2L for submit@debbugs.gnu.org; Fri, 10 Apr 2020 12:17:05 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:34176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMwL1-0004Mx-Rd for 40529@debbugs.gnu.org; Fri, 10 Apr 2020 12:17:04 -0400 Received: by mail-il1-f182.google.com with SMTP id t11so2290414ils.1 for <40529@debbugs.gnu.org>; Fri, 10 Apr 2020 09:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LHx2U/icmgAXPuL9YAm/VE8gVRQ55H5fkhpjQUDShKM=; b=k/H+JT1fZThr5Y2AVT5e98vIMswdAg/NKPxxsgWb1xNXw3HPKFynkG2TZoZMCiBOew 5io5Krjh/cn1PzYOAXlS/vqbHaiY7FHdQvJ9LwGj/thmBK2AJhQ7mxpAWley+TpRm3Yb 0YgbyIG58uUkn/9yuitMyhf1tMThBqrPbpIcefZ1bpLDBF5vte69BaxdEA2gCU+CaYWJ 0U9JVynM8v14Nhp9ZSc223mUClezk0rqDkH3LFYgcgJmakgIbNnUmdJTO/TQtqIUjwxa B/ilUx/eTyjURZrS+eQtckmHjQwl26bUWqrs7m7FQ14Glv94pR1OZ1gPQe/ZPwoO7NEu b5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LHx2U/icmgAXPuL9YAm/VE8gVRQ55H5fkhpjQUDShKM=; b=H6x+zQUywWlAG2F3KoOji1/HHqJz6moJmNhoEhGeU2DxByO2YbQ7bD9sQ1Y8+gSSVO T3r3QVOtH7IkreZFCUIa03GkdgQTRTZQXtmE/UmRYdjcaYg0H7FmwWBoRtUvgZ93rh+z JXfFr0LXFus1PU0EeBdcu6EI/OuaaIBiepbtaFUCjatyhFyNBioZk+TB80TnHaCLSukM yhcIlPY8Ws4J3uDa2SJ0fqJFzNYp/8b3V+rrhsVN5pXrazJco7Sh2TsrkvoWZIs6kdYH V4mcAj6/GgbR2jPacNchkd6VjjIRzCU0f1Hu6r+zc9UGPjIbByAG9PINLH/XTe/BRkod h4WA== X-Gm-Message-State: AGi0PuaAsdln7x9NGkQBuwXu24bVdyxxMUmYdR/5c6YQ5tFVSCFO+Ybu qcwkCTWyJxSRViHhftcupGcCtdw7YkCiR5cNedU= X-Google-Smtp-Source: APiQypKkekBPMwevvpkyFTFbigi2lEmsc+r5xi42R35gTmB+YPXel9eDII5EoQ7SeR8iMD8XmCC0XIxeyTL9xnCd0zA= X-Received: by 2002:a05:6e02:c25:: with SMTP id q5mr5241677ilg.97.1586535418257; Fri, 10 Apr 2020 09:16:58 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 10 Apr 2020 17:16:47 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000007666a05a2f21009" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, Aidan Beggs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000007666a05a2f21009 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 5:09 PM Jo=C3=A3o T=C3=A1vora wrote: > leaves me wondering if there isn't a hook ordering bug here. Maybe it's > just a question of delaying entry in tabulated-list-mode until important stuff > is set up. Or maybe all that's needed is this (100% untested) change: diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 25a2152f00..72171f5f8b 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1378,10 +1378,10 @@ flymake-show-diagnostics-buffer (source (current-buffer)) (target (or (get-buffer name) (with-current-buffer (get-buffer-create name) + (setq flymake--diagnostics-buffer-source source) (flymake-diagnostics-buffer-mode) (current-buffer))))) (with-current-buffer target - (setq flymake--diagnostics-buffer-source source) (revert-buffer) (display-buffer (current-buffer))))) --00000000000007666a05a2f21009 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 10, 2020 at 5:09 PM Jo=C3=A3o T=C3=A1vora <= joaotavora@gmail.com> wrote:=

> leaves me wondering if there isn't a hook ordering bug her= e. Maybe it's
> just a question of delaying entry in tabulated-li= st-mode until important stuff
> is set up.

Or maybe all that's needed is this (100% untested) change:

diff --git a/lisp/progmodes/flymake.el b/lisp/progmod= es/flymake.el
index 25a2152f00..72171f5f8b 100644
--- a/lisp/progmode= s/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1378,10 +1378,10 @@ = flymake-show-diagnostics-buffer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sour= ce (current-buffer))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (target (or (get= -buffer name)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (with-current-buffer (get-buffer-create name)
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= setq flymake--diagnostics-buffer-source source)
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (flymake-diagno= stics-buffer-mode)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (current-buffer)))))
=C2=A0 =C2=A0 =C2= =A0(with-current-buffer target
- =C2=A0 =C2=A0 =C2=A0(setq flymake--diag= nostics-buffer-source source)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(revert-buffer)=
=C2=A0 =C2=A0 =C2=A0 =C2=A0(display-buffer (current-buffer)))))
--00000000000007666a05a2f21009-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 08:22:53 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 12:22:53 +0000 Received: from localhost ([127.0.0.1]:57482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNbdU-0006xI-Ng for submit@debbugs.gnu.org; Sun, 12 Apr 2020 08:22:53 -0400 Received: from mail-il1-f171.google.com ([209.85.166.171]:37346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNbdT-0006x4-JR for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 08:22:52 -0400 Received: by mail-il1-f171.google.com with SMTP id e4so3929013ils.4 for <40529@debbugs.gnu.org>; Sun, 12 Apr 2020 05:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gfdo36VZ4s/eI8K7acpgE8I7ac182KxgBWjH7cSdII0=; b=Rpq+VX9FPA3zvJO4Zy5rlxXr21mqweJXkwP5UTSS828IpoWjdyj75xCaEhfw8jzFrk LR+drLXNzbpG1FYRC4D2YPDrVuH6AXfdHcfDHypn1v53pCSm/exhivgBJIU8t3vL1VIl lrAs5LGxs/qUjiJSDsuSnxQ9s2gv9NZZLmbKbVRK9jvpavMj3d7NvoQG2iUdmJPAlWe0 7mqC5pa8xoxb3zzSJG8VakLiw6M1rEfP3q0kKpksKXAEk9Axx091nqjUqbXKl9pCGE4X 2xcEf7tXeEEB0HDGv9geQxZjE57GkJycqjdsp2DR7L3nE/ycNGrkQX23CVqS5CSuJ1mQ Or7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gfdo36VZ4s/eI8K7acpgE8I7ac182KxgBWjH7cSdII0=; b=nDLpoWpxE5yRVjf1QkW0JAqNuy+5rfiZC1NRnH7boIPd9IrbfoR4a1z+wFpk17Aqf5 7tGJDaRsEmS8UMPQVDkilyQft3Z6TpeU1fqSgDkxre3tWcfQ0d/8rI2wOSggP/Y226nc r4Qk2ckhiDi6+6dx9Oo25G9cZlj2PcZCJg8vvRr5SL5nadhCAhG0mO8XdtAJ0+DZCAi+ IlQ5EnT61QElx5JglpYHNgeLMtVjUEuP6OqQmrvIwGitudPzJcwq3makNqkZ6kxlXyth /XianvURhA4VE2jxotx5qJ3o4+a+mUMkQN5+3qWFmEBhJER+p5w7AVxqSKYNwxSttShP 2Rcg== X-Gm-Message-State: AGi0PuZ/mGAQR+mEqM2W1T4GUF59GBt1JNg+Skr0VzplUR4fPUyCaP90 Gw8fSIIWxnCm7oJEOIRPt0cDas/pAtjoNpYz3rc= X-Google-Smtp-Source: APiQypJ0qsLsw+XRUZWze1Jtyp0eV7NEDkxW8b+1q/a8rTZ4C52kL3DWlttLVjxFWxDcO6+qqix49uj1Oun12Qrhe/0= X-Received: by 2002:a05:6e02:6c1:: with SMTP id p1mr13388301ils.137.1586694165999; Sun, 12 Apr 2020 05:22:45 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 12 Apr 2020 13:22:34 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000021b7bb05a31706e0" X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, Aidan Beggs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --00000000000021b7bb05a31706e0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 10, 2020 at 5:16 PM Jo=C3=A3o T=C3=A1vora wrote: > > On Fri, Apr 10, 2020 at 5:09 PM Jo=C3=A3o T=C3=A1vora wrote: > > > leaves me wondering if there isn't a hook ordering bug here. Maybe it's > > just a question of delaying entry in tabulated-list-mode until important stuff > > is set up. > > Or maybe all that's needed is this (100% untested) change: > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el Finally looked into the problem and no, this doesn't work because flymake-diagnostics-buffer-mode erases local vars before setting up the tabulated-list-mode derived mode. This is kind of a chicken-and-egg issue that can only be fixed in flymake.el with some ugly hacks. But after some analysis, I think it is tabulated-list-mode, or rather its recent adaptation to display-line-numbers-mode, which is in the wrong here. It used to be that using a mode derived from tabulated-list-mode didn't immediately force a request for refreshing its rows. After display-line-numbers-mode came along, that ceased to be true in some situations. Reading the special code in tabulated-list-mode concerned with line numbers, the latter seem to affect only the header line, not the buffer's contents. So this seems to be the correct fix: commit 0145b3c87f329e51c729703d778848cdc8393a33 Author: Jo=C3=A3o T=C3=A1vora Date: Sun Apr 12 13:10:45 2020 +0100 Fix tabulated-list-mode bootstrapping problem Fixes: bug#40529 Don't refresh all the tabulated-list rows when entering tabulated-list-mode just because display-line-number-mode is t. * lisp/emacs-lisp/tabulated-list.el (tabulated-list-mode): Don't call tabulated-list-revert, just tabulated-list-init-header. diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 501cc3a29e..68eaef1fcd 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -765,7 +765,7 @@ tabulated-list-mode ;; column of the first entry happens to begin with a R2L letter. (setq bidi-paragraph-direction 'left-to-right) ;; This is for if/when they turn on display-line-numbers - (add-hook 'display-line-numbers-mode-hook #'tabulated-list-revert nil t) + (add-hook 'display-line-numbers-mode-hook #'tabulated-list-init-header nil t) ;; This is for if/when they customize the line-number face or when ;; the line-number width needs to change due to scrolling. (setq-local tabulated-list--current-lnum-width 0) --00000000000021b7bb05a31706e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 10, 2020 at 5:16 PM Jo=C3=A3o T=C3=A1vora <= joaotavora@gmail.com> wrote:=
>
> On Fri, Apr 10, 2020 at 5:09 PM Jo=C3=A3o T=C3=A1vora <= joaotavora@gmail.com> wrote:=
>
> > leaves me wondering if there isn't a hook orderin= g bug here. Maybe it's
> > just a question of delaying entry i= n tabulated-list-mode until important stuff
> > is set up.
>=
> Or maybe all that's needed is this (100% untested) change:
= >
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymak= e.el

Finally looked into the problem and no, this doesn't work b= ecause
flymake-diagnostics-buffer-mode erases local vars before setting = up the
tabulated-list-mode derived mode.=C2=A0 This is kind of a chicken= -and-egg
issue that can only be fixed in flymake.el with some ugly hacks= .

But after some analysis, I think it is tabulated-list-mode, or rat= her
its recent adaptation to display-line-numbers-mode, which is in the<= br>wrong here.=C2=A0 It used to be that using a mode derived from
t= abulated-list-mode didn't immediately force a request for refreshing it= s
rows.=C2=A0 After display-line-numbers-mode came along, th= at ceased to be
true in some situations.

Reading the special co= de in tabulated-list-mode concerned with line
numbers, the latter seem t= o affect only the header line, not the
buffer's contents.=C2=A0 So t= his seems to be the correct fix:

commit 0145b3c87f329e51c729703d7788= 48cdc8393a33
Author: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
Date: =C2=A0 Sun Apr 12 13:1= 0:45 2020 +0100

=C2=A0 =C2=A0 Fix tabulated-list-mode bootstrapping = problem
=C2=A0 =C2=A0
=C2=A0 =C2=A0 Fixes: bug#40529
=C2=A0 =C2= =A0 Don't refresh all the tabulated-list rows when entering
=C2=A0 = =C2=A0 tabulated-list-mode just because display-line-number-mode is t.
= =C2=A0 =C2=A0
=C2=A0 =C2=A0 * lisp/emacs-lisp/tabulated-list.el (tabula= ted-list-mode): Don't
=C2=A0 =C2=A0 call tabulated-list-revert, just= tabulated-list-init-header.

diff --git a/lisp/emacs-lisp/tabulated-= list.el b/lisp/emacs-lisp/tabulated-list.el
index 501cc3a29e..68eaef1fcd= 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp= /tabulated-list.el
@@ -765,7 +765,7 @@ tabulated-list-mode
=C2=A0 =C2= =A0;; column of the first entry happens to begin with a R2L letter.
=C2= =A0 =C2=A0(setq bidi-paragraph-direction 'left-to-right)
=C2=A0 =C2= =A0;; This is for if/when they turn on display-line-numbers
- =C2=A0(add= -hook 'display-line-numbers-mode-hook #'tabulated-list-revert nil t= )
+ =C2=A0(add-hook 'display-line-numbers-mode-hook #'tabulated-= list-init-header nil t)
=C2=A0 =C2=A0;; This is for if/when they customi= ze the line-number face or when
=C2=A0 =C2=A0;; the line-number width ne= eds to change due to scrolling.
=C2=A0 =C2=A0(setq-local tabulated-list-= -current-lnum-width 0)
--00000000000021b7bb05a31706e0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 09:43:35 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 13:43:35 +0000 Received: from localhost ([127.0.0.1]:57532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNctb-0000VD-0m for submit@debbugs.gnu.org; Sun, 12 Apr 2020 09:43:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNctZ-0000V1-LG for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 09:43:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNctU-0006U4-G3; Sun, 12 Apr 2020 09:43:28 -0400 Received: from [176.228.60.248] (port=3602 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNctT-0003y9-UE; Sun, 12 Apr 2020 09:43:28 -0400 Date: Sun, 12 Apr 2020 16:43:17 +0300 Message-Id: <837dyklszu.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 12 Apr 2020 13:22:34 +0100) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Sun, 12 Apr 2020 13:22:34 +0100 > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > But after some analysis, I think it is tabulated-list-mode, or rather > its recent adaptation to display-line-numbers-mode, which is in the > wrong here. It used to be that using a mode derived from > tabulated-list-mode didn't immediately force a request for refreshing its > rows. After display-line-numbers-mode came along, that ceased to be > true in some situations. > > Reading the special code in tabulated-list-mode concerned with line > numbers, the latter seem to affect only the header line, not the > buffer's contents. So this seems to be the correct fix: I don't remember all the callers/users of tabulated-list-mode, so I cannot be sure your patch is correct. (Why only update the header? the columns below the header need to be realigned as well, no? See tabulated-line-print-col, for example.) However, if you are convinced it's TRT, I'm okay with doing that on master. On the release branch, please try to find a solution that is not in tabulated-list-mode, but in Flymake. TIA From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 10:13:53 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 14:13:54 +0000 Received: from localhost ([127.0.0.1]:58622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdMv-0001WP-Hs for submit@debbugs.gnu.org; Sun, 12 Apr 2020 10:13:53 -0400 Received: from mail-il1-f181.google.com ([209.85.166.181]:36906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdMt-0001WC-T1 for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 10:13:52 -0400 Received: by mail-il1-f181.google.com with SMTP id e4so4076143ils.4 for <40529@debbugs.gnu.org>; Sun, 12 Apr 2020 07:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TZE5SI50vKTy2HVa/+mBZxn8q8/vawTpbXMV9orm8dk=; b=gyHmUTO2TqgMMqBifgubiNxmU5exbU3JBtO02s80Zp0++OMpTHjCz2S27qrmfw6nQU 4m48Vnm0m0QxlLl7zKKt7eguWVofX0VCmuno4JqhNLRuM/JC+bbGbpUz+mfLm/HaBElH S5r1byZB6tDT6cSKGf7LeKfPgsRvhCFkoF7ybrdac1dEON+5wbnzxsaUuZNGv35nlsau nfMfmzourqXLazOpz6AdSxX5XlNfP9HzY6R6bxvg150rib4qtqplVk7AQY8mfzAmuvCk 87ohuXfHk49iju16R1mgyt5HMFHOtLuapaokhw2Tl3U+bBo8Z/scNEhElFdhgzqsSngl TJKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TZE5SI50vKTy2HVa/+mBZxn8q8/vawTpbXMV9orm8dk=; b=TJwFf1XAbME7SUjioNqMoQzsS6m6IChihH+MAOqNjwvhMd2emfhgPxlXwPxUXzLbRB eJUhRUtej+jIApB/vMreUG1TEe6P1hlt8l/Fr50g4/StN02gUzDN70OVr5wLd5akZyUX tpDb2QbG7YHrvHZpD4kYY4YciD5X1SP2hsPIyOhdKn+OfAbkK2uO0BcHAIbhi38W8PHw XQ+YCmNpA640EuwAaterhB3FtdM0dJSou463IK9D+V8XUF3BZM/RphyJaA9PnO5EwQRW VAPfX3FwBbXgEC0AeBgI+YbCG+5IlD/bIvjdIR1jSbJAx5ljc0K4JcEHBk56DCRFRX9g qtpw== X-Gm-Message-State: AGi0PubLkOUGfRht4Ocot1GGkBfGoCms4t8/XWxdd1HeAFbXClEk5HKW fQ22ZmkTT6bOUdNe2Nwzf3x8IMQDGu1QBJqJzGA= X-Google-Smtp-Source: APiQypJz2tlaLsL+xkFPqlLnKBQL5Nk6v6qIUM76ml7ALUTkXxtIhSj2UALdsUKTwZE4O23dSynHxnxq4GgKpOTaTv0= X-Received: by 2002:a92:ce8b:: with SMTP id r11mr13328061ilo.199.1586700826335; Sun, 12 Apr 2020 07:13:46 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> In-Reply-To: <837dyklszu.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 12 Apr 2020 15:13:35 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000001e5d0005a3189351" X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, Aidan Beggs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --0000000000001e5d0005a3189351 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 12, 2020 at 2:43 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sun, 12 Apr 2020 13:22:34 +0100 > > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > > > But after some analysis, I think it is tabulated-list-mode, or rather > > its recent adaptation to display-line-numbers-mode, which is in the > > wrong here. It used to be that using a mode derived from > > tabulated-list-mode didn't immediately force a request for refreshing > its > > rows. After display-line-numbers-mode came along, that ceased to be > > true in some situations. > > > > Reading the special code in tabulated-list-mode concerned with line > > numbers, the latter seem to affect only the header line, not the > > buffer's contents. So this seems to be the correct fix: > > I don't remember all the callers/users of tabulated-list-mode, so I > cannot be sure your patch is correct. (Why only update the header? > the columns below the header need to be realigned as well, no? See > tabulated-line-print-col, for example.) > I don't know what you are calling attention to in that function. Can you be more specific? Regarding your question (why only the header?), well that seems to be the only place where a line-number _isn't_ printed, so it needs the additional indentation. I think that also explains why you already _only_ update only the header in pre-redisplay-functions and window-scroll-functions. Have a look at tabulated-list-watch-line-number-width and tabulated-list-window-scroll-function. All they do is update the header, not the contents. I'm just extending that criteria to the turn-on/off of d-l-n-m. Furthermore I think it is a regression in itself to deliver an Emacs 27 with this changed tabulated-list-mode bootstrapping behaviour. However, if you are convinced it's TRT, I'm okay with doing that on > master. On the release branch, please try to find a solution that is > not in tabulated-list-mode, but in Flymake. > I tried around a bit and couldn't come up with anything that I know is safe, short of some very ugly vapourware hacks. Not saying that it doesn't exist, but I started searching in tabulated-list-mode and I do think that's the best place to fix it. Jo=C3=A3o --0000000000001e5d0005a3189351 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Apr 12, 2020 at 2:43 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3= =A3o T=C3=A1vora <joaotavora@gmail.com>
> Date: Sun, 12 Apr 2020 13:22:34 +0100
> Cc: Aidan Beggs <nadiasggeb001@gmail.com>, 40529@debbugs.gnu.org
>
> But after some analysis, I think it is tabulated-list-mode, or rather<= br> > its recent adaptation to display-line-numbers-mode, which is in the > wrong here.=C2=A0 It used to be that using a mode derived from
> tabulated-list-mode didn't immediately force a request for refresh= ing its
> rows.=C2=A0 After display-line-numbers-mode came along, that ceased to= be
> true in some situations.
>
> Reading the special code in tabulated-list-mode concerned with line > numbers, the latter seem to affect only the header line, not the
> buffer's contents.=C2=A0 So this seems to be the correct fix:

I don't remember all the callers/users of tabulated-list-mode, so I
cannot be sure your patch is correct.=C2=A0 (Why only update the header? the columns below the header need to be realigned as well, no?=C2=A0 See tabulated-line-print-col, for example.)

I don't know what you are calling attention to in that function. Can <= br>
you be more specific?

Regarding your= question (why only the header?), well that seems
to be the = only place where a line-number _isn't_ printed, so
it ne= eds the additional indentation.=C2=A0 I think that also explains
= why you already _only_ update only the header in pre-redisplay-functions
and window-scroll-functions.=C2=A0 Have a look at
tabula= ted-list-watch-line-number-width and
tabulated-list-window-s= croll-function. All they do is update the
header, not the conten= ts.=C2=A0

I'm just extending that criteri= a to the turn-on/off of d-l-n-m.

Furthermore I thi= nk it is a regression in itself to deliver an Emacs
27 with = this changed tabulated-list-mode bootstrapping behaviour.

However, if you are co= nvinced it's TRT, I'm okay with doing that on
master.=C2=A0 On the release branch, please try to find a solution that is<= br> not in tabulated-list-mode, but in Flymake.

=
I tried around a bit and couldn't come up with anything that I kno= w is
safe, short of some very ugly vapourware hacks. Not say= ing that it
doesn't exist, but I started searching in ta= bulated-list-mode and
I do think that's the best place t= o fix it.

Jo=C3=A3o

<= br>

--0000000000001e5d0005a3189351-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 10:42:29 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 14:42:30 +0000 Received: from localhost ([127.0.0.1]:58652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdob-0002FO-Ml for submit@debbugs.gnu.org; Sun, 12 Apr 2020 10:42:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdoa-0002FB-3f for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 10:42:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNdoU-0005by-T8; Sun, 12 Apr 2020 10:42:22 -0400 Received: from [176.228.60.248] (port=3681 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNdoU-0003fi-Bv; Sun, 12 Apr 2020 10:42:22 -0400 Date: Sun, 12 Apr 2020 17:42:11 +0300 Message-Id: <833698lq9o.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 12 Apr 2020 15:13:35 +0100) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Sun, 12 Apr 2020 15:13:35 +0100 > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > I don't remember all the callers/users of tabulated-list-mode, so I > cannot be sure your patch is correct. (Why only update the header? > the columns below the header need to be realigned as well, no? See > tabulated-line-print-col, for example.) > > I don't know what you are calling attention to in that function. Can > you be more specific? AFAIR, the :align-to display spec needs to be recalculated when line numbers are turned on or off. > Furthermore I think it is a regression in itself to deliver an Emacs > 27 with this changed tabulated-list-mode bootstrapping behaviour. Maybe so, but that code endured many months on the master branch and then in the pretest, so we have some reason to believe it is correct. The code was introduced to solve real problems in some users of tabulated-list-mode (and we have quite a few of them in core alone). > However, if you are convinced it's TRT, I'm okay with doing that on > master. On the release branch, please try to find a solution that is > not in tabulated-list-mode, but in Flymake. > > I tried around a bit and couldn't come up with anything that I know is > safe, short of some very ugly vapourware hacks. Not saying that it > doesn't exist, but I started searching in tabulated-list-mode and > I do think that's the best place to fix it. Like I said: making changes in tabulated-list-mode is too risky at this point for the release branch. I'm sure a simple solution for Flymake can be found. E.g., what about skipping the entire body of flymake--diagnostics-buffer-entries if flymake--diagnostics-buffer-source is nil? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 12:58:34 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 16:58:34 +0000 Received: from localhost ([127.0.0.1]:58735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNfwI-0005aV-4s for submit@debbugs.gnu.org; Sun, 12 Apr 2020 12:58:34 -0400 Received: from mail-il1-f172.google.com ([209.85.166.172]:36929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNfwH-0005aH-4X for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 12:58:33 -0400 Received: by mail-il1-f172.google.com with SMTP id e4so4295050ils.4 for <40529@debbugs.gnu.org>; Sun, 12 Apr 2020 09:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rzsf1p3eLpDEano0uult3UaQfYyPZ+w6dTf1YKyN5pY=; b=HWwTlA6MWIrFQb4bCjNP8Cu/MuFAZ7ussdu4UdeLsH0bYaSvXnAj5CF0ve+nNObaXk XfesHqW53Q8WAs6IaP+uX3zMgWxKc3kWznheeRIDhh5cgCnJyPZZzDtjgmRiifUjv4mJ Qr2qET09Zv8i27u8ctkR3FYYrcT9qZywrIWBKMeTkUOWYFykOn+w0/MFA9cGcFrBndVX WaEpC3vimvcNuGdbgjJwrNyvEHdoJ5+mz2kDa1Dc3aRKCkAd3VvMjuArmxh8GNigrek0 ubX51L0+qMx0ekjr3gMz6pqIg8qMEkTEYfbe9DvRtYN1E3fonT30LjJdkuH3LDYVqy+W Zwwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rzsf1p3eLpDEano0uult3UaQfYyPZ+w6dTf1YKyN5pY=; b=nY6PBphzX4IsjzAhWLarVOEz7oHycIKoC014EVq4Tn3oiJx888FVchDH5ymbnMYwPQ n1QjtDtNrwhvD1fmYMSWR1KA9Xqqkuc6QxvAwzvxe/ODfB73cEUndBbNwkx/s9dHT7Mr 2jb+69PuoxL2tJyoTroKNwmj3Uvj/81maK/S1OIzzAq7u6P11wTM54cAqFDYW5wzKELJ 9U/1EuEzQPwL77ruyG3VR/30q/ewQPVco2BeK7havOCOxJ8vMrlhfXms73vQOnvc2TCn av5Wc+JAVq8Tg+RxQgaappMPZcGh6J6nEaiuoyH2l7ReRR+x8Gre9roOdtlIhM82eYvY quNQ== X-Gm-Message-State: AGi0PuaGRkDpp0ZmJaz6GgVvnqkR4aILvwoMNw41zozkUz9HWuj8k5He CJR9HrWzN3Scdj8HN0neRXfNe+UVnLyujUl/wrs= X-Google-Smtp-Source: APiQypK9ffHZ1xj5Xa2UUGQAte4YuHD7EzCynXn435wIQbCagA/xWE2OkwhrJKuipsv8Oyl6BcSvm59EoYNgs02oy/s= X-Received: by 2002:a92:ce8b:: with SMTP id r11mr13779833ilo.199.1586710707420; Sun, 12 Apr 2020 09:58:27 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> <833698lq9o.fsf@gnu.org> In-Reply-To: <833698lq9o.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 12 Apr 2020 17:58:16 +0100 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000013c3d805a31ae059" X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, Aidan Beggs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --00000000000013c3d805a31ae059 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 12, 2020 at 3:42 PM Eli Zaretskii wrote: > AFAIR, the :align-to display spec needs to be recalculated when line > numbers are turned on or off. I don't know what that is, but if it involves propertizing the rows themselves, there's possiblya bug when you gain or lose a character when scrolling. As evidenced by the fact that the hooks I showed you also only recalculate the header. > The code was introduced to solve real problems in some users of > tabulated-list-mode (and we have quite a few of them in core alone). Do you have reason to believe these would resurface if you did my change? What are these "real problems"? Can references to them be found in the git log? > Maybe so, but that code endured many months on the master branch and > then in the pretest, so we have some reason to believe it is correct. I don't think it's correct to ask the buffer's row-providing backend to produce rows just you turned on the mode. Certainly I can't think how it can be correct to do that depending on whether or not a totally unrelated customization related to presentation is enabled or not. If you disagree, I would at least indicate this possibility in the manual before releasing. The manual says, in https://www.gnu.org/software/emacs/manual/html_node/elisp/Tabulated-List-Mo= de.html The listing command should create or switch to a buffer, turn on the derived mode, specify the tabulated data, and finally call tabulated-list-print to populate the buffer. Maybe you should add something explaining that sometimes populating happens automatically, sometimes not. If gathering the data is expensive, the client code can be doing it twice, a bad thing IMO. But even conceptually and intuitively, changing the line numbers to the left of a buffer shouldn't need recalculating the buffer's contents. Even the effect on the header line smells a little, to be honest. Shouldn't line numbers care to handle also push the header line forward as they do the remainder of the buffer? I don't know and I don't use line numbers, just wondering. > I'm sure a simple solution for Flymake can be found. E.g., what about > skipping the entire body of flymake--diagnostics-buffer-entries if > flymake--diagnostics-buffer-source is nil Maybe that works, yes. Feel free to try it and commit it to Emacs 27, I have little time and I'm booted into a machine with no Emacs. Thanks, Jo=C3=A3o --00000000000013c3d805a31ae059 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Apr 12, 2020 at 3:42 PM Eli Zaretskii <eliz@gnu.org> wrote:

> AFAIR, the :align-to display spec needs to be recalculated when line<= br>> numbers are turned on or off.

I don't know what that is, but if it involves propertizing=
the rows themselves, there's possib= lya bug when you gain
or los= e a character when scrolling. As evidenced by the fact
that the hooks I showed you also only recalculat= e the header.

> The code was introduced to solve real problems in= some users of
> tabulated-list-mode (and we have quite a few of= them in core alone).

Do you have reason to believ= e these would resurface if you
did my change? What are these &quo= t;real problems"?=C2=A0 Can
references to them be found= in the git log?

> Maybe so, but that code = endured many months on the master branch and
> then in the pretest, s= o we have some reason to believe it is correct.

I don't think it's correct to ask the buffer's row-providing=
backend to produce rows just you turned on the mode.=C2=A0 =
Certainly I can't think how it can be correct to do that= depending
on whether or not a totally unrelated customization re= lated to
presentation is enabled or not.

If you disagree, I would at least indicate this possibility in
the manual before releasing.

The manual s= ays, in

=
=C2=A0=C2=A0 The listing command should create or switch to a
=C2=A0=C2=A0 buffer, turn on the derived mode, specify the tabulated= data,
=C2=A0=C2=A0 and finally call tabulated-list-print to populate the buffer.
=

Maybe you should add something explaining that so= metimes
populating happens automatically, sometimes not.=C2=A0 If= gathering
the data is expensive, the client code can be doing it= twice,
a bad thing IMO.

But even c= onceptually and intuitively, changing the line numbers
to th= e left of a buffer shouldn't need recalculating the buffer's
contents. Even the effect on the header line smells a little, to <= br>
be honest. Shouldn't line numbers care to handle also pus= h
the header line forward as they do the remainder of the buffer?=
I don't know and I don't use line numbers, just wonderin= g.

> I'm sure a simple solution f= or Flymake can be found.=C2=A0 E.g., what about
> skipping the entire= body of flymake--diagnostics-buffer-entries if
> flymake--diagn= ostics-buffer-source is nil

Maybe that works, yes.= Feel free to try it and commit it
to Emacs 27, I have littl= e time and I'm booted into a machine
with no Emacs.

Thanks,
Jo=C3=A3o
--00000000000013c3d805a31ae059-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 13:15:27 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 17:15:28 +0000 Received: from localhost ([127.0.0.1]:58774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNgCd-00063G-KP for submit@debbugs.gnu.org; Sun, 12 Apr 2020 13:15:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNgCb-000633-LB for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 13:15:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNgCW-0001S0-Go; Sun, 12 Apr 2020 13:15:20 -0400 Received: from [176.228.60.248] (port=1436 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNgCV-0007Dd-GG; Sun, 12 Apr 2020 13:15:20 -0400 Date: Sun, 12 Apr 2020 20:15:08 +0300 Message-Id: <83wo6kk4mb.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 12 Apr 2020 17:58:16 +0100) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> <833698lq9o.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529 Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Sun, 12 Apr 2020 17:58:16 +0100 > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > > I'm sure a simple solution for Flymake can be found. E.g., what about > > skipping the entire body of flymake--diagnostics-buffer-entries if > > flymake--diagnostics-buffer-source is nil > > Maybe that works, yes. Feel free to try it and commit it > to Emacs 27, I have little time and I'm booted into a machine > with no Emacs. OK. Aidan, can you try the patch below and see if it solves the problem? The initial error in the recipe you posted is definitely gone after applying the patch, but please also try this after that and see that flymake-show-diagnostics-buffer also works after that, in real-life use. Thanks. diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 25a2152..b37b72e 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1321,35 +1321,36 @@ flymake-goto-diagnostic (flymake-show-diagnostic (if (button-type pos) (button-start pos) pos)))) (defun flymake--diagnostics-buffer-entries () - (with-current-buffer flymake--diagnostics-buffer-source - (cl-loop for diag in - (cl-sort (flymake-diagnostics) #'< :key #'flymake-diagnostic-beg) - for (line . col) = - (save-excursion - (goto-char (flymake--diag-beg diag)) - (cons (line-number-at-pos) - (- (point) - (line-beginning-position)))) - for type = (flymake--diag-type diag) - collect - (list (list :diagnostic diag - :line line - :severity (flymake--lookup-type-property - type - 'severity (warning-numeric-level :error))) - `[,(format "%s" line) - ,(format "%s" col) - ,(propertize (format "%s" - (flymake--lookup-type-property - type 'flymake-type-name type)) - 'face (flymake--lookup-type-property - type 'mode-line-face 'flymake-error)) - (,(format "%s" (flymake--diag-text diag)) - mouse-face highlight - help-echo "mouse-2: visit this diagnostic" - face nil - action flymake-goto-diagnostic - mouse-action flymake-goto-diagnostic)])))) + (when (bufferp flymake--diagnostics-buffer-source) + (with-current-buffer flymake--diagnostics-buffer-source + (cl-loop for diag in + (cl-sort (flymake-diagnostics) #'< :key #'flymake-diagnostic-beg) + for (line . col) = + (save-excursion + (goto-char (flymake--diag-beg diag)) + (cons (line-number-at-pos) + (- (point) + (line-beginning-position)))) + for type = (flymake--diag-type diag) + collect + (list (list :diagnostic diag + :line line + :severity (flymake--lookup-type-property + type + 'severity (warning-numeric-level :error))) + `[,(format "%s" line) + ,(format "%s" col) + ,(propertize (format "%s" + (flymake--lookup-type-property + type 'flymake-type-name type)) + 'face (flymake--lookup-type-property + type 'mode-line-face 'flymake-error)) + (,(format "%s" (flymake--diag-text diag)) + mouse-face highlight + help-echo "mouse-2: visit this diagnostic" + face nil + action flymake-goto-diagnostic + mouse-action flymake-goto-diagnostic)]))))) (define-derived-mode flymake-diagnostics-buffer-mode tabulated-list-mode "Flymake diagnostics" From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 18:07:37 2020 Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 22:07:37 +0000 Received: from localhost ([127.0.0.1]:58983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNklN-0004cX-0w for submit@debbugs.gnu.org; Sun, 12 Apr 2020 18:07:37 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:38445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNjUO-0002kD-Q4 for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 16:46:01 -0400 Received: by mail-qt1-f175.google.com with SMTP id f13so5687089qti.5 for <40529@debbugs.gnu.org>; Sun, 12 Apr 2020 13:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XGqfIQNmXRnLRXXKmkXAOQ4RDzribOekC3FqaGZ+LbA=; b=USIdhia7w8hqbr3xurmGrtUN3RToAFcmWi3jMlZ1aDyaqcMU+IC3JSOvSn8Ia8AiBh RqXM5ICUIYhKPitqBhaklHQ22j4l2B7+St/kpHdw4W3m7iGhfNg2yhvGhY4mr7BhYKg8 UbomCKvtE7uOuvcBuoBjX1p8tApDAetDm+UHrRPNoKX6rJHJaSfeum7kKILAxLE5RM/9 ef3rHXPlvN/nww5V3p5EUSfc3sba8h/waB8BDvgEnROtbBDMWIE3Zsre6hdtg5CrypZ3 ObFd6JOAgAF05ymxEsEsUPf2NScmdJ9pN63/EUCYzQGI/DiN/5SKobiw7vSfpr/9+Ffd bOUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XGqfIQNmXRnLRXXKmkXAOQ4RDzribOekC3FqaGZ+LbA=; b=TMmv1V8Es7wTgEVECmK8mP8k9SI4bRHp2KX5YSQGHK78+Ba5tzy29Vnj6F4yP7BXQu 8yFFwgHam/Zdol+b3O0uRPA50Y6OLSzYH95jnVrCfjRgo1pUoWZxt1PoVqpv0mEo3qQN 7rDnOl/1pFhcRP5ur5K8u7I4pIEDD4tIrFOb39doM5iyYRNJzBMXSraVEpvLEQZz2oTM K1YqAPmya5okIgrfRSOiLNL+G7vzSF87M2GcQ5tE1+W9dicdnNtcBeAf+i7R9m9Eze+d lS+K4B7YZcUu1DHFHSpHivgjVOLRqW9bSmQ2hO6yCH76qIvRU7Wkawvyj2yUXGOtxMPH L5mg== X-Gm-Message-State: AGi0PuYdvv3oxxNTok4O/9cHDCdlMwopbpX3rR53NgL9FWiN+7Cw3nIZ 4jmPjGSo3BCItrbBmtz/34lKVle5dEwVu4XXkP8= X-Google-Smtp-Source: APiQypJvBDSrEEmKyi9PHMbimlylNMyw2ZgwafJcCjtEIf0K24+oHYEyAafiI8NqCnOOHhEX7va6JUS0vWqbA9Rh9LU= X-Received: by 2002:aed:25e2:: with SMTP id y31mr2544890qtc.325.1586724354912; Sun, 12 Apr 2020 13:45:54 -0700 (PDT) MIME-Version: 1.0 References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> <833698lq9o.fsf@gnu.org> <83wo6kk4mb.fsf@gnu.org> In-Reply-To: <83wo6kk4mb.fsf@gnu.org> From: Aidan Beggs Date: Sun, 12 Apr 2020 16:45:18 -0400 Message-ID: Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000087f74305a31e0d26" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 40529 X-Mailman-Approved-At: Sun, 12 Apr 2020 18:07:36 -0400 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 40529@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --00000000000087f74305a31e0d26 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That patch seems to do the trick for me. I don't make particularly extensive use of the flymake diagnostics buffer, but for regular use it seems to work as expected. Thanks, Aidan On Sun, Apr 12, 2020 at 1:15 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sun, 12 Apr 2020 17:58:16 +0100 > > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > > > > I'm sure a simple solution for Flymake can be found. E.g., what abou= t > > > skipping the entire body of flymake--diagnostics-buffer-entries if > > > flymake--diagnostics-buffer-source is nil > > > > Maybe that works, yes. Feel free to try it and commit it > > to Emacs 27, I have little time and I'm booted into a machine > > with no Emacs. > > OK. > > Aidan, can you try the patch below and see if it solves the problem? > The initial error in the recipe you posted is definitely gone after > applying the patch, but please also try this after that and see that > flymake-show-diagnostics-buffer also works after that, in real-life > use. > > Thanks. > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 25a2152..b37b72e 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -1321,35 +1321,36 @@ flymake-goto-diagnostic > (flymake-show-diagnostic (if (button-type pos) (button-start pos) > pos)))) > > (defun flymake--diagnostics-buffer-entries () > - (with-current-buffer flymake--diagnostics-buffer-source > - (cl-loop for diag in > - (cl-sort (flymake-diagnostics) #'< :key > #'flymake-diagnostic-beg) > - for (line . col) =3D > - (save-excursion > - (goto-char (flymake--diag-beg diag)) > - (cons (line-number-at-pos) > - (- (point) > - (line-beginning-position)))) > - for type =3D (flymake--diag-type diag) > - collect > - (list (list :diagnostic diag > - :line line > - :severity (flymake--lookup-type-property > - type > - 'severity (warning-numeric-level > :error))) > - `[,(format "%s" line) > - ,(format "%s" col) > - ,(propertize (format "%s" > - (flymake--lookup-type-property > - type 'flymake-type-name type)= ) > - 'face (flymake--lookup-type-property > - type 'mode-line-face > 'flymake-error)) > - (,(format "%s" (flymake--diag-text diag)) > - mouse-face highlight > - help-echo "mouse-2: visit this diagnostic" > - face nil > - action flymake-goto-diagnostic > - mouse-action flymake-goto-diagnostic)])))) > + (when (bufferp flymake--diagnostics-buffer-source) > + (with-current-buffer flymake--diagnostics-buffer-source > + (cl-loop for diag in > + (cl-sort (flymake-diagnostics) #'< :key > #'flymake-diagnostic-beg) > + for (line . col) =3D > + (save-excursion > + (goto-char (flymake--diag-beg diag)) > + (cons (line-number-at-pos) > + (- (point) > + (line-beginning-position)))) > + for type =3D (flymake--diag-type diag) > + collect > + (list (list :diagnostic diag > + :line line > + :severity (flymake--lookup-type-property > + type > + 'severity (warning-numeric-level > :error))) > + `[,(format "%s" line) > + ,(format "%s" col) > + ,(propertize (format "%s" > + (flymake--lookup-type-proper= ty > + type 'flymake-type-name > type)) > + 'face (flymake--lookup-type-property > + type 'mode-line-face > 'flymake-error)) > + (,(format "%s" (flymake--diag-text diag)) > + mouse-face highlight > + help-echo "mouse-2: visit this diagnostic" > + face nil > + action flymake-goto-diagnostic > + mouse-action flymake-goto-diagnostic)]))))) > > (define-derived-mode flymake-diagnostics-buffer-mode tabulated-list-mode > "Flymake diagnostics" --00000000000087f74305a31e0d26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdiBkaXI9Imx0ciI+VGhhdCBwYXRjaCBzZWVtcyB0byBkbyB0aGUg dHJpY2sgZm9yIG1lLiBJIGRvbiYjMzk7dCBtYWtlIHBhcnRpY3VsYXJseSBleHRlbnNpdmUgdXNl IG9mIHRoZSBmbHltYWtlIGRpYWdub3N0aWNzIGJ1ZmZlciwgYnV0IGZvciByZWd1bGFyIHVzZSBp dCBzZWVtcyB0byB3b3JrIGFzIGV4cGVjdGVkLjxkaXY+PGJyPjwvZGl2PjxkaXY+VGhhbmtzLDwv ZGl2PjxkaXY+QWlkYW48L2Rpdj48L2Rpdj48YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxk aXYgZGlyPSJsdHIiIGNsYXNzPSJnbWFpbF9hdHRyIj5PbiBTdW4sIEFwciAxMiwgMjAyMCBhdCAx OjE1IFBNIEVsaSBaYXJldHNraWkgJmx0OzxhIGhyZWY9Im1haWx0bzplbGl6QGdudS5vcmciIHRh cmdldD0iX2JsYW5rIj5lbGl6QGdudS5vcmc8L2E+Jmd0OyB3cm90ZTo8YnI+PC9kaXY+PGJsb2Nr cXVvdGUgY2xhc3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjBweCAwcHggMHB4IDAuOGV4 O2JvcmRlci1sZWZ0OjFweCBzb2xpZCByZ2IoMjA0LDIwNCwyMDQpO3BhZGRpbmctbGVmdDoxZXgi PiZndDsgRnJvbTogSm/Do28gVMOhdm9yYSAmbHQ7PGEgaHJlZj0ibWFpbHRvOmpvYW90YXZvcmFA Z21haWwuY29tIiB0YXJnZXQ9Il9ibGFuayI+am9hb3Rhdm9yYUBnbWFpbC5jb208L2E+Jmd0Ozxi cj4NCiZndDsgRGF0ZTogU3VuLCAxMiBBcHIgMjAyMCAxNzo1ODoxNiArMDEwMDxicj4NCiZndDsg Q2M6IEFpZGFuIEJlZ2dzICZsdDs8YSBocmVmPSJtYWlsdG86bmFkaWFzZ2dlYjAwMUBnbWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5uYWRpYXNnZ2ViMDAxQGdtYWlsLmNvbTwvYT4mZ3Q7LCA8YSBo cmVmPSJtYWlsdG86NDA1MjlAZGViYnVncy5nbnUub3JnIiB0YXJnZXQ9Il9ibGFuayI+NDA1MjlA ZGViYnVncy5nbnUub3JnPC9hPjxicj4NCiZndDsgPGJyPg0KJmd0OyAmZ3Q7IEkmIzM5O20gc3Vy ZSBhIHNpbXBsZSBzb2x1dGlvbiBmb3IgRmx5bWFrZSBjYW4gYmUgZm91bmQuwqAgRS5nLiwgd2hh dCBhYm91dDxicj4NCiZndDsgJmd0OyBza2lwcGluZyB0aGUgZW50aXJlIGJvZHkgb2YgZmx5bWFr ZS0tZGlhZ25vc3RpY3MtYnVmZmVyLWVudHJpZXMgaWY8YnI+DQomZ3Q7ICZndDsgZmx5bWFrZS0t ZGlhZ25vc3RpY3MtYnVmZmVyLXNvdXJjZSBpcyBuaWw8YnI+DQomZ3Q7IDxicj4NCiZndDsgTWF5 YmUgdGhhdCB3b3JrcywgeWVzLiBGZWVsIGZyZWUgdG8gdHJ5IGl0IGFuZCBjb21taXQgaXQgPGJy Pg0KJmd0OyB0byBFbWFjcyAyNywgSSBoYXZlIGxpdHRsZSB0aW1lIGFuZCBJJiMzOTttIGJvb3Rl ZCBpbnRvIGEgbWFjaGluZSA8YnI+DQomZ3Q7IHdpdGggbm8gRW1hY3MuPGJyPg0KPGJyPg0KT0su PGJyPg0KPGJyPg0KQWlkYW4sIGNhbiB5b3UgdHJ5IHRoZSBwYXRjaCBiZWxvdyBhbmQgc2VlIGlm IGl0IHNvbHZlcyB0aGUgcHJvYmxlbT88YnI+DQpUaGUgaW5pdGlhbCBlcnJvciBpbiB0aGUgcmVj aXBlIHlvdSBwb3N0ZWQgaXMgZGVmaW5pdGVseSBnb25lIGFmdGVyPGJyPg0KYXBwbHlpbmcgdGhl IHBhdGNoLCBidXQgcGxlYXNlIGFsc28gdHJ5IHRoaXMgYWZ0ZXIgdGhhdCBhbmQgc2VlIHRoYXQ8 YnI+DQpmbHltYWtlLXNob3ctZGlhZ25vc3RpY3MtYnVmZmVyIGFsc28gd29ya3MgYWZ0ZXIgdGhh dCwgaW4gcmVhbC1saWZlPGJyPg0KdXNlLjxicj4NCjxicj4NClRoYW5rcy48YnI+DQo8YnI+DQpk aWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZmx5bWFrZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2Zs eW1ha2UuZWw8YnI+DQppbmRleCAyNWEyMTUyLi5iMzdiNzJlIDEwMDY0NDxicj4NCi0tLSBhL2xp c3AvcHJvZ21vZGVzL2ZseW1ha2UuZWw8YnI+DQorKysgYi9saXNwL3Byb2dtb2Rlcy9mbHltYWtl LmVsPGJyPg0KQEAgLTEzMjEsMzUgKzEzMjEsMzYgQEAgZmx5bWFrZS1nb3RvLWRpYWdub3N0aWM8 YnI+DQrCoCDCoCAoZmx5bWFrZS1zaG93LWRpYWdub3N0aWMgKGlmIChidXR0b24tdHlwZSBwb3Mp IChidXR0b24tc3RhcnQgcG9zKSBwb3MpKSkpPGJyPg0KPGJyPg0KwqAoZGVmdW4gZmx5bWFrZS0t ZGlhZ25vc3RpY3MtYnVmZmVyLWVudHJpZXMgKCk8YnI+DQotwqAgKHdpdGgtY3VycmVudC1idWZm ZXIgZmx5bWFrZS0tZGlhZ25vc3RpY3MtYnVmZmVyLXNvdXJjZTxicj4NCi3CoCDCoCAoY2wtbG9v cCBmb3IgZGlhZyBpbjxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoChjbC1zb3J0IChmbHltYWtl LWRpYWdub3N0aWNzKSAjJiMzOTsmbHQ7IDprZXkgIyYjMzk7Zmx5bWFrZS1kaWFnbm9zdGljLWJl Zyk8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqBmb3IgKGxpbmUgLiBjb2wpID08YnI+DQotwqAg wqAgwqAgwqAgwqAgwqAgwqAoc2F2ZS1leGN1cnNpb248YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAoZ290by1jaGFyIChmbHltYWtlLS1kaWFnLWJlZyBkaWFnKSk8YnI+DQotwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAoY29ucyAobGluZS1udW1iZXItYXQtcG9zKTxicj4NCi3CoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCgtIChwb2ludCk8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKSkpKTxicj4NCi3CoCDC oCDCoCDCoCDCoCDCoCDCoGZvciB0eXBlID0gKGZseW1ha2UtLWRpYWctdHlwZSBkaWFnKTxicj4N Ci3CoCDCoCDCoCDCoCDCoCDCoCDCoGNvbGxlY3Q8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAo bGlzdCAobGlzdCA6ZGlhZ25vc3RpYyBkaWFnPGJyPg0KLcKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgOmxpbmUgbGluZTxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoDpzZXZlcml0eSAoZmx5bWFrZS0tbG9va3VwLXR5cGUtcHJvcGVydHk8YnI+ DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg dHlwZTxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCAmIzM5O3NldmVyaXR5ICh3YXJuaW5nLW51bWVyaWMtbGV2ZWwgOmVycm9yKSkpPGJy Pg0KLcKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgYFssKGZvcm1hdCAmcXVvdDslcyZxdW90 OyBsaW5lKTxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCwoZm9ybWF0ICZx dW90OyVzJnF1b3Q7IGNvbCk8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAs KHByb3BlcnRpemUgKGZvcm1hdCAmcXVvdDslcyZxdW90Ozxicj4NCi3CoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAoZmx5bWFrZS0t bG9va3VwLXR5cGUtcHJvcGVydHk8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB0eXBlICYjMzk7Zmx5bWFrZS10eXBl LW5hbWUgdHlwZSkpPGJyPg0KLcKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgICYjMzk7ZmFjZSAoZmx5bWFrZS0tbG9va3VwLXR5cGUtcHJvcGVydHk8YnI+ DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqB0eXBlICYjMzk7bW9kZS1saW5lLWZhY2UgJiMzOTtmbHltYWtlLWVycm9yKSk8YnI+ DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAoLChmb3JtYXQgJnF1b3Q7JXMmcXVv dDsgKGZseW1ha2UtLWRpYWctdGV4dCBkaWFnKSk8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgbW91c2UtZmFjZSBoaWdobGlnaHQ8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgaGVscC1lY2hvICZxdW90O21vdXNlLTI6IHZpc2l0IHRoaXMgZGlhZ25v c3RpYyZxdW90Ozxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBmYWNlIG5p bDxicj4NCi3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBhY3Rpb24gZmx5bWFrZS1n b3RvLWRpYWdub3N0aWM8YnI+DQotwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgbW91 c2UtYWN0aW9uIGZseW1ha2UtZ290by1kaWFnbm9zdGljKV0pKSkpPGJyPg0KK8KgICh3aGVuIChi dWZmZXJwIGZseW1ha2UtLWRpYWdub3N0aWNzLWJ1ZmZlci1zb3VyY2UpPGJyPg0KK8KgIMKgICh3 aXRoLWN1cnJlbnQtYnVmZmVyIGZseW1ha2UtLWRpYWdub3N0aWNzLWJ1ZmZlci1zb3VyY2U8YnI+ DQorwqAgwqAgwqAgKGNsLWxvb3AgZm9yIGRpYWcgaW48YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAoY2wtc29ydCAoZmx5bWFrZS1kaWFnbm9zdGljcykgIyYjMzk7Jmx0OyA6a2V5ICMmIzM5 O2ZseW1ha2UtZGlhZ25vc3RpYy1iZWcpPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgZm9y IChsaW5lIC4gY29sKSA9PGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgKHNhdmUtZXhjdXJz aW9uPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgKGdvdG8tY2hhciAoZmx5bWFrZS0t ZGlhZy1iZWcgZGlhZykpPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgKGNvbnMgKGxp bmUtbnVtYmVyLWF0LXBvcyk8YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAoLSAocG9pbnQpPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikpKSk8YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBmb3IgdHlwZSA9IChmbHltYWtlLS1kaWFnLXR5cGUgZGlhZyk8YnI+DQorwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqBjb2xsZWN0PGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgKGxpc3QgKGxp c3QgOmRpYWdub3N0aWMgZGlhZzxicj4NCivCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoDpsaW5lIGxpbmU8YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqA6c2V2ZXJpdHkgKGZseW1ha2UtLWxvb2t1cC10eXBlLXByb3BlcnR5PGJyPg0K K8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IHR5cGU8YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgJiMzOTtzZXZlcml0eSAod2FybmluZy1udW1lcmljLWxldmVsIDplcnJvcikp KTxicj4NCivCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGBbLChmb3JtYXQgJnF1b3Q7 JXMmcXVvdDsgbGluZSk8YnI+DQorwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAs KGZvcm1hdCAmcXVvdDslcyZxdW90OyBjb2wpPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgLChwcm9wZXJ0aXplIChmb3JtYXQgJnF1b3Q7JXMmcXVvdDs8YnI+DQorwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgKGZseW1ha2UtLWxvb2t1cC10eXBlLXByb3BlcnR5PGJyPg0KK8KgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdHlw ZSAmIzM5O2ZseW1ha2UtdHlwZS1uYW1lIHR5cGUpKTxicj4NCivCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAmIzM5O2ZhY2UgKGZseW1ha2UtLWxv b2t1cC10eXBlLXByb3BlcnR5PGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdHlwZSAmIzM5O21vZGUtbGluZS1mYWNl ICYjMzk7Zmx5bWFrZS1lcnJvcikpPGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgKCwoZm9ybWF0ICZxdW90OyVzJnF1b3Q7IChmbHltYWtlLS1kaWFnLXRleHQgZGlhZykp PGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIG1vdXNlLWZhY2UgaGln aGxpZ2h0PGJyPg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGhlbHAtZWNo byAmcXVvdDttb3VzZS0yOiB2aXNpdCB0aGlzIGRpYWdub3N0aWMmcXVvdDs8YnI+DQorwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZmFjZSBuaWw8YnI+DQorwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgYWN0aW9uIGZseW1ha2UtZ290by1kaWFnbm9zdGljPGJy Pg0KK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIG1vdXNlLWFjdGlvbiBmbHlt YWtlLWdvdG8tZGlhZ25vc3RpYyldKSkpKSk8YnI+DQo8YnI+DQrCoChkZWZpbmUtZGVyaXZlZC1t b2RlIGZseW1ha2UtZGlhZ25vc3RpY3MtYnVmZmVyLW1vZGUgdGFidWxhdGVkLWxpc3QtbW9kZTxi cj4NCsKgIMKgJnF1b3Q7Rmx5bWFrZSBkaWFnbm9zdGljcyZxdW90OzwvYmxvY2txdW90ZT48L2Rp dj4NCjwvZGl2Pg0K --00000000000087f74305a31e0d26-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 13 01:03:18 2020 Received: (at 40529-done) by debbugs.gnu.org; 13 Apr 2020 05:03:18 +0000 Received: from localhost ([127.0.0.1]:59117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNrFd-0006Gs-Tz for submit@debbugs.gnu.org; Mon, 13 Apr 2020 01:03:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNrFc-0006Gi-D6 for 40529-done@debbugs.gnu.org; Mon, 13 Apr 2020 01:03:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNrFX-0004ZL-97; Mon, 13 Apr 2020 01:03:11 -0400 Received: from [176.228.60.248] (port=4630 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNrFV-0003pF-SO; Mon, 13 Apr 2020 01:03:11 -0400 Date: Mon, 13 Apr 2020 08:03:00 +0300 Message-Id: <83imi4j7uj.fsf@gnu.org> From: Eli Zaretskii To: Aidan Beggs In-Reply-To: (message from Aidan Beggs on Sun, 12 Apr 2020 16:45:18 -0400) Subject: Re: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> <833698lq9o.fsf@gnu.org> <83wo6kk4mb.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40529-done Cc: joaotavora@gmail.com, 40529-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Aidan Beggs > Date: Sun, 12 Apr 2020 16:45:18 -0400 > Cc: João Távora , > 40529@debbugs.gnu.org > > That patch seems to do the trick for me. I don't make particularly extensive use of the flymake diagnostics > buffer, but for regular use it seems to work as expected. Thanks, I've now installed the patch on the emacs-27 branch, and I'm marking this bug done. Feel free to reopen if there are more problems related to this. From unknown Wed Sep 10 09:28:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 May 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator