From unknown Wed Sep 10 01:09:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40528 <40528@debbugs.gnu.org> To: bug#40528 <40528@debbugs.gnu.org> Subject: Status: 'guix lint' does not check whether propagated-inputs should be native Reply-To: bug#40528 <40528@debbugs.gnu.org> Date: Wed, 10 Sep 2025 08:09:06 +0000 retitle 40528 'guix lint' does not check whether propagated-inputs should b= e native reassign 40528 guix submitter 40528 Marius Bakke severity 40528 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 17:24:35 2020 Received: (at submit) by debbugs.gnu.org; 9 Apr 2020 21:24:36 +0000 Received: from localhost ([127.0.0.1]:54550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMef5-0004KJ-Lv for submit@debbugs.gnu.org; Thu, 09 Apr 2020 17:24:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:49071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMef4-0004KA-AJ for submit@debbugs.gnu.org; Thu, 09 Apr 2020 17:24:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43527) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMef3-00063B-BX for bug-guix@gnu.org; Thu, 09 Apr 2020 17:24:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMef1-0003hn-F4 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:24:33 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:38605) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMef1-0003h3-4Z for bug-guix@gnu.org; Thu, 09 Apr 2020 17:24:31 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D3750641 for ; Thu, 9 Apr 2020 17:24:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 09 Apr 2020 17:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:date:message-id:mime-version:content-type; s= fm2; bh=1DwUWoKZ4YiJtJCB9QasMQl6cwo8ETkrjZZmUZh1q3g=; b=Y+6i9Kk1 yUziXnaKfMTyg/3ee2Q+ZdZRrc1w8joD8w3jxkJDV76P6gW5rd+AC0Z+zA8SZbqX m1EL08Gx8mwsev+zddZz5NZcn3lyAB0SsdnKPrvG0UGIVFTXFYCmF2t9zKOab5bp rd2ohyEhVmMs2NfuIwBvSCxB1QBdONPxSOWKPzN5VAJAx2Xw36kxumiK1xYofFcr NWIDF0b0iXlGp1a0wl0Y/SQNzd9uMx4ozweCKGxC2U73wgZl/B664vCh8E/DewQs PMYhlUP7PLyKkkZ9uKQ5gm9Cub3StOOHCgxpjLYSwwtGJ842ErsmUID/C04FLHuk qh2nJfS7n+2acg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=1DwUWoKZ4YiJtJCB9QasMQl6cwo8E TkrjZZmUZh1q3g=; b=yMiYC/4/6kIgTiPFvFynqHeBE6rzwvTN5kg1B379egAYt /klb2SNkXatqLluAEDGDC2OvnMQ+bcp1Ww/hkUqERfHmdTLvSnHdFkJhrcG9cKkC IEEJteJ4KBbzgHHI1U6QN1UZQIWa3i4xRuFkMobiyvyASkDwaD3+0HeHysHD2URb 7qRwHhUyDLJq9wOlKj3S+GuNXNcfdaE0YYmOL+GWYYK7Vn4lwYL0NRxj8ufR/abU 5PE05KfOcRxctxq349YDmavt0F1zWrFcsCFj3JXJSVn0B+IddF3rIjXdZUU/SHrG /OtiDhRrl6Gs1CXQsyfFBuqTlsFnZhx3TWbNZQruQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddtgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehgtderredtre dtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgr ihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghi lhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id E99BE306005E for ; Thu, 9 Apr 2020 17:24:27 -0400 (EDT) From: Marius Bakke To: bug-guix@gnu.org Subject: 'guix lint' does not check whether propagated-inputs should be native User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 09 Apr 2020 23:24:25 +0200 Message-ID: <87h7xsjqt2.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.20 X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of a package, not propagated-inputs. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: fastmail.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mbakke[at]fastmail.com) 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of a package, not propagated-inputs. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6PkokACgkQoqBt8qM6 VPpfQgf/ayUGwODaL4tTY/y0XV18utrNoGPd4qzTnuTEWSQBPb7G/sbjXToDErPE yAvp+P/2lO8lWI7ApfASkQShk9cj/akZv+T3dFQ2XAobkRgJyA4+fv0j1ey+JoiU b4jbLwUpBEs4LLNNZ8zP39JtePSJz6StzvDDp69yYUGFWBCsNJSMyOSJuwOY6sER Y1oVw+CZYejj0JScrtp9rxXVsEO7qDuiqrpZaS9RoiEOSsUrJPSNiS1hP9bWAdCk WTuVXkTPx43dBvKA0gG5eXdsUsSCVHYFFFo/lE5QfiDbN6gr7iR/P2+G+WVZJLQb FkIiUbiyh5PuxY9RIIbRUfGmjNZYjA== =/jej -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 17:32:13 2020 Received: (at 40528) by debbugs.gnu.org; 9 Apr 2020 21:32:13 +0000 Received: from localhost ([127.0.0.1]:54563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMemS-0004Yj-MT for submit@debbugs.gnu.org; Thu, 09 Apr 2020 17:32:12 -0400 Received: from flashner.co.il ([178.62.234.194]:40472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMemQ-0004YU-9P for 40528@debbugs.gnu.org; Thu, 09 Apr 2020 17:32:10 -0400 Received: from localhost (unknown [141.226.9.17]) by flashner.co.il (Postfix) with ESMTPSA id 478F64025C; Thu, 9 Apr 2020 21:32:04 +0000 (UTC) Date: Fri, 10 Apr 2020 00:31:31 +0300 From: Efraim Flashner To: Marius Bakke Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs should be native Message-ID: <20200409213131.GX1518@E5400> References: <87h7xsjqt2.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QxSStYAgvEtE+iQJ" Content-Disposition: inline In-Reply-To: <87h7xsjqt2.fsf@devup.no> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40528 Cc: 40528@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --QxSStYAgvEtE+iQJ Content-Type: multipart/mixed; boundary="vDpQvD79HZx/5O2q" Content-Disposition: inline --vDpQvD79HZx/5O2q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: > 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of > a package, not propagated-inputs. The attached patch should add the propagated inputs to the list of inputs to check. Do we want to start telling it to ignore some of them? gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' shoul= d probably be a native input --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --vDpQvD79HZx/5O2q Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-lint-Check-for-inappropriate-inputs-in-propagated-in.patch" Content-Transfer-Encoding: quoted-printable =46rom 2ca0a385847c8dfcaffe4f32c5dbce7297086859 Mon Sep 17 00:00:00 2001 =46rom: Efraim Flashner Date: Fri, 10 Apr 2020 00:29:56 +0300 Subject: [PATCH] lint: Check for inappropriate inputs in propagated-inputs too. * guix/lint.scm (check-inputs-should-be-native): Also check the propagated inputs of the package. --- guix/lint.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index 72582cfffb..bda5c0cd77 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -7,7 +7,7 @@ ;;; Copyright =C2=A9 2016 Hartmut Goebel ;;; Copyright =C2=A9 2017 Alex Kost ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice -;;; Copyright =C2=A9 2017, 2018 Efraim Flashner +;;; Copyright =C2=A9 2017, 2018, 2020 Efraim Flashner ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; ;;; This file is part of GNU Guix. @@ -286,7 +286,8 @@ of a package, and INPUT-NAMES, a list of package specif= ications such as (define (check-inputs-should-be-native package) ;; Emit a warning if some inputs of PACKAGE are likely to belong to its ;; native inputs. - (let ((inputs (package-inputs package)) + (let ((inputs (append (package-inputs package) + (package-propagated-inputs package))) (input-names '("pkg-config" "autoconf" --=20 2.26.0 --vDpQvD79HZx/5O2q-- --QxSStYAgvEtE+iQJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6PlDIACgkQQarn3Mo9 g1Hagw//TxPUWE7nwX7YToJNseWcuHxs3ozRqIS53isJ7aXIulxjWooCCWHEXsUV mpQ210tINTr07nYu3c8NRAB6fhtEUscTNJ7UfcfjHqZh8A57FuZz4RRHgngLwXie D4t2veFHjTrCKC8VOdS0HzCd/R45WNTqfXaLRPBtyWkUSxCLVFiPEekg62Fgjukx 8UycNoS3nW8jBUNUNvHBmT1Gs4jO/Xm/6DtYFQMKe0u6s3tmXtWuDijLobi007el kq8EA+3YxpM0jsCgnkHwSwlxHD8if6lIbLo+44+rbWvsN5caGeLbl5gvnBPOnEUC F+LhMHKBnNl18y6A9E2H3PLIHZ1lXbWVddOpdz0Bj77Xc/HV/bkw94T6y+NGUkko jadv7PmJBwewh2sUz8mldGcDNXODiu7E4xOeq4wUPB2e8Q5AT/xBH48OIKLgIbMC LFUU4wZXk7+Ki0WHJXXFHljPxtjBKlzoGdVM/B/bnRsvIbeGYjrrSiCCLzF2BcBh AXiAYKAXOiW2NcJBg3G6hRzGP57QVKAdDIpFriajwN1SHhlU3on3/JJPEb3gZObB XNzgsuOXNKuKy7VML3BN2qZyV5UW9I9XWRlgieWr2BfvZ7ndzNfqjlItfbNbolsz y43XZytMbbtNBpcY+olvPgxvH2yedGGuwmm6HRiNf36k7PYYNYI= =HVk4 -----END PGP SIGNATURE----- --QxSStYAgvEtE+iQJ-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 17:42:30 2020 Received: (at 40528) by debbugs.gnu.org; 9 Apr 2020 21:42:30 +0000 Received: from localhost ([127.0.0.1]:54577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMewQ-0004o0-95 for submit@debbugs.gnu.org; Thu, 09 Apr 2020 17:42:30 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:49031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMewO-0004no-92 for 40528@debbugs.gnu.org; Thu, 09 Apr 2020 17:42:28 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DC5E7440; Thu, 9 Apr 2020 17:42:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 09 Apr 2020 17:42:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=xfXnECSuJCtw0CriWOnxNpJxFE B0j0O9w9y75YWJuJs=; b=0CDB2chtTe3GTg7JJDD9seY9n1o5CAfeFjWRpgDVH3 AnEVa1uwvLIembkokPq2o3Q3Ufba1K+1GZXqK/ACwhFojhnF+UbuoMz4a+TRZ3uw vuqBGT2DvT01OTG0zdV7n+gJkhob17I/heA9X6GHZOHySsK91XXZnuBCTnK4fwgI W79ZEX9bH4kiK0PQy7GUIQIKNHs7hptjjvGMinMUDuwJ9TSuHCiUwcEHCQspj6Ob vZpIwK4yEoDKl0JsgkuA0rtUxqbtzRlWuJUiK52arU1Rtbf6Ed66GAQiiR2eEjF1 cNhr+Q1EXs6njJbJQVV4Q78NSxVB2d4ZK/L+lxe2JU+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xfXnEC SuJCtw0CriWOnxNpJxFEB0j0O9w9y75YWJuJs=; b=3+fwmTyvKHqQ4RRZz6H9Lf SyED/4Q/aq+21TAC8G+Sbz2Jhyl2Fi+S5cTJgrnsOwCdsI0XP5BHEjtFuKHriytV kqCSyQeM9k5ynxKYycOylD1DelCDl8a2jMJzr/Mz8avags9NYjIF0JVzE4aa25be 4OEGQG1m6vS0tBd9HZQ27koHmR4KhlqhvAzjH7rSfuFcQRXfD0xuv6iTpXwY/N7h j7tFAgjvvDOH3TbEAHkAdiC9Jc7qul0q4uTQU6xQFLPO9OITtkG4ULcAeYMCYHSm gnId8mEuTEqdExuS50kuyS8AJJzkWsSvP2HWEl2XRfvUwL9abwODjmkVz8E55iWQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdduucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufgjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhushcuuegr khhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucfkphepkeegrddvtd dvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id C6AA7328005A; Thu, 9 Apr 2020 17:42:20 -0400 (EDT) From: Marius Bakke To: Efraim Flashner Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs should be native In-Reply-To: <20200409213131.GX1518@E5400> References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 09 Apr 2020 23:42:18 +0200 Message-ID: <87eeswjpz9.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40528 Cc: 40528@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Efraim Flashner writes: > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of >> a package, not propagated-inputs. > > The attached patch should add the propagated inputs to the list of > inputs to check. Do we want to start telling it to ignore some of them? Wow, that was incredibly fast! > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' should probably be a native input I'm inclined to leave it. I think many of these plugin packages should not be propagating the package that they plug into anyway. LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6PlrsACgkQoqBt8qM6 VPpHtgf/W0xedlDc5Wk7a1zlE5jreEhow+SjZdYw1rzXxzNR7QKoDtIgkCUA4Zpd +CNEsnMncaCXQSi7tjqeAmHLWaxnAlkv+J5KOeOW0adWtgyOCabOK3xJWB9fRuhy /hlvX4mWModGGky6G2CYbKiYGxEj6xG2Ol4Cs0TJ2cghWYdC8dyGljMxiTPAvoEL zuWhTH+QVdjGYbliwEcTZO/zOb4uBbf4pL2eqHXj6djscqMyS4cH7xiZ4hfOPUgy NFl0EJ5O0Xn2QSfInf3sD77GticAfzIpDC83VaF8i07A5qW9pNPaydHkQBC8AJoG jdpCCPKqqD/g8pw1cJqY3wBegxQyMw== =H5Jx -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 17:50:51 2020 Received: (at 40528-done) by debbugs.gnu.org; 9 Apr 2020 21:50:51 +0000 Received: from localhost ([127.0.0.1]:54581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMf4V-0004zl-4s for submit@debbugs.gnu.org; Thu, 09 Apr 2020 17:50:51 -0400 Received: from flashner.co.il ([178.62.234.194]:40510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMf4T-0004zY-CH for 40528-done@debbugs.gnu.org; Thu, 09 Apr 2020 17:50:49 -0400 Received: from localhost (unknown [141.226.9.17]) by flashner.co.il (Postfix) with ESMTPSA id 0C65D4025C; Thu, 9 Apr 2020 21:50:42 +0000 (UTC) Date: Fri, 10 Apr 2020 00:50:10 +0300 From: Efraim Flashner To: Marius Bakke Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs should be native Message-ID: <20200409215010.GY1518@E5400> References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400> <87eeswjpz9.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1ugEqy3masBx2OgH" Content-Disposition: inline In-Reply-To: <87eeswjpz9.fsf@devup.no> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40528-done Cc: 40528-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --1ugEqy3masBx2OgH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote: > Efraim Flashner writes: >=20 > > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: > >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field = of > >> a package, not propagated-inputs. > > > > The attached patch should add the propagated inputs to the list of > > inputs to check. Do we want to start telling it to ignore some of them? >=20 > Wow, that was incredibly fast! >=20 > > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' s= hould probably be a native input >=20 > I'm inclined to leave it. I think many of these plugin packages should > not be propagating the package that they plug into anyway. >=20 > LGTM! OK, patch pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --1ugEqy3masBx2OgH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6PmJIACgkQQarn3Mo9 g1EOlxAArJJNcsLXvMz/d5+U6QMRQgzNgpWkF6CbTfg1RnJO7b4bbbaItQStdq/M wtogQzWMu2zNKGeyeQ6E9Ig/e/7s4aoMA8AQ2eK8QGbGSB/egvaGnidoEGQG1KwN OBcu/icFToSS5k6ScLjDvf+zWKyXrxxW4GFZQVQqf4dy987vJCky649pw8zHNDGS Ho2OtLo9YsVm6vhQIsXbvCreALlff8DlpO4+waUqrHqxJgiGHB1y651OTTeOyPXQ HYi0SNhSAYJpnRdfS7h1kNnrhQ3gi9Fei2RTbgoOQ2FcMIl8KDhx3LEqXKaGrWex kyZW0RZStFuuCiQHqb+reF/LLSP5OMwALC6RWOOuqTME1hBUJ38gJPvd9k1OW5a0 d4agpjJHi/yQW91ZObk7cVxQ/nLSvVs+S++2faUJu5hGo/K1/YCmB7nP5bo93Iwt lX04dknNdWK6BShpFor3NPCRtwnclLrsC53kw0nlXPIGtOsuNRWgZgdzOylA4K6S G8kzDV7hq5mTrcGfbR3tgMUbihI4G9OpLH8D7GeOCRR2aVRkYTaa5lwQK/Kd9zX0 htCemwEWE1GhB97hCfusmuPKX1mz6tkomiJD6VUYjJJbhWG8/sAPAxsJ+MFbOpYX ArLKAGvNJRUl2+V2EKPmIf/8pfF3nDT9xvodLtmDc1nApBKwrd0= =zknw -----END PGP SIGNATURE----- --1ugEqy3masBx2OgH-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 04:51:57 2020 Received: (at 40528-done) by debbugs.gnu.org; 10 Apr 2020 08:51:57 +0000 Received: from localhost ([127.0.0.1]:54760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMpOH-000472-0C for submit@debbugs.gnu.org; Fri, 10 Apr 2020 04:51:57 -0400 Received: from mira.cbaines.net ([212.71.252.8]:46708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMpOF-00046u-5p for 40528-done@debbugs.gnu.org; Fri, 10 Apr 2020 04:51:55 -0400 Received: from localhost (unknown [46.237.163.111]) by mira.cbaines.net (Postfix) with ESMTPSA id 3024C27BBE1; Fri, 10 Apr 2020 09:51:54 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 2ec14b91; Fri, 10 Apr 2020 08:51:52 +0000 (UTC) References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400> <87eeswjpz9.fsf@devup.no> <20200409215010.GY1518@E5400> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Marius Bakke , 40528-done@debbugs.gnu.org Subject: Re: bug#40528: 'guix lint' does not check whether propagated-inputs should be native In-reply-to: <20200409215010.GY1518@E5400> Date: Fri, 10 Apr 2020 09:51:52 +0100 Message-ID: <87zhbj7mfr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40528-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Efraim Flashner writes: > On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote: >> Efraim Flashner writes: >> >> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: >> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of >> >> a package, not propagated-inputs. >> > >> > The attached patch should add the propagated inputs to the list of >> > inputs to check. Do we want to start telling it to ignore some of them? >> >> Wow, that was incredibly fast! >> >> > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' should probably be a native input >> >> I'm inclined to leave it. I think many of these plugin packages should >> not be propagating the package that they plug into anyway. >> >> LGTM! > > OK, patch pushed. Looks like it's working :) [1] 1: http://data.guix.gnu.org/compare?base_commit=960abd585940c33744040c79e2a37e588d36e589&target_commit=d95252baf97adb261dd823d4e7a74a7522815c1c --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6QM6hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfQQQ/+Pl0enu20EzmHkKEx3y5pY3j7i/bg0B2nPriD1tGwniw0joC5kqwWwVPB R2kXamxdGRE+i/U1Vt+hMFWY/AJ+MHFR8wsG0p1O3Z9XzVGx1q3sy501F+HHcJa6 8kBYKrHS5F1aVCBgwX4K+Vj5P8pBKkrA9HGsVlSgneohJ/hRZNB1Fev7vE1/6u2v XkXbid6OAyZlXM9JR/rPkLcPWgmS9TdmYaK9Z1QxS4iNYoBM8/btvlIZ0RxHy6BJ 1/ffpcSTUG3sS8F1X6W2wqsY74j6bhtCOAeD6jMlwubXZ+ikN5rtRRvJoZvWBkep wIVsPUqrbg3+NaVPwq5javXFrkkw3EE+8s/C9psmmjljTA5lCNcCBtVzuiVa6U8K k7lHu9djhKvmMdoxi9AOZUOYiF7mNKWCOiQFHFbsV4fl5O1hjTw2T9OM5zBeiRSD 1By8Q43GK4RuiVu1qp/tDVf0fGQQVT/+hB41S+kiZhV74tevSg5MyNJ7WRm/dvtT EXpWPGqBnKcccFcp7FF7dWCLOOrWE1cihAh7AYSpX9zdxjJ8QCFpzfF5MZw+uxOH hx/G3HrrjU0Xw7cL827ly6m7Qsf15YT+X4UpBIKS4FOCvAfJzjoFzjpXte0Q28l9 XUSga+j6JTsvi5poiJgLCfzmaYpAUQRb3yYAcMGvdfhEhDZzX/U= =YQRZ -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Sep 10 01:09:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 May 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator