Subject: bug#40528: 'guix lint' does not check whether propagated-inputs should be native

From: Christopher Baines <[email-masked]>
Date: Fri, 10 Apr 2020 09:51:52 +0100

Efraim Flashner <[email-masked]> writes:

> On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
>> Efraim Flashner <[email-masked]> writes:
>>
>> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
>> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
>> >> a package, not propagated-inputs.
>> >
>> > The attached patch should add the propagated inputs to the list of
>> > inputs to check. Do we want to start telling it to ignore some of them?
>>
>> Wow, that was incredibly fast!
>>
>> > gnu/packages/check.scm:2200:2: [email-masked]: 'python-nose' should probably be a native input
>>
>> I'm inclined to leave it.  I think many of these plugin packages should
>> not be propagating the package that they plug into anyway.
>>
>> LGTM!
>
> OK, patch pushed.

Looks like it's working :) [1]

1: http://data.guix.gnu.org/compare?base_commit=960abd585940c33744040c79e2a37e588d36e589&target_commit=d95252baf97adb261dd823d4e7a74a7522815c1c