GNU bug report logs - #40502
28.0.50; Hangul Jamo conjoining characters are not composed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40502 in the body.
You can then email your comments to 40502 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Hangul Jamo conjoining characters are not composed
Date: Wed, 08 Apr 2020 11:28:25 +0200

According to Unicode 13 Chapter 18.6, Hangul Jamo characters should be
composed into the corresponding pre-composed Hangul characters. Iʼm
not seeing this, e.g

하 (U+1112 U+1161) should be displayed as 하 (U+D558), but is shown as
two separate glyphs (all using Apple SD Gothic Neo)

(set-char-table-range composition-function-table
                      #x1112
                      (list (vector "..")
                            0
                            'compose-gstring-for-graphic))

does not help.

This is:

In GNU Emacs 28.0.50 (build 127, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G4032))
 of 2020-04-02 built on rpluim-mac

although I see the same in a Cairo+HarfBuzz build on GNU/Linux.

Message #6 received at 40502 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 40502 <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50;
 Hangul Jamo conjoining characters are not composed
Date: Wed, 08 Apr 2020 12:55:19 +0300

> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Wed, 08 Apr 2020 11:28:25 +0200
> 
> According to Unicode 13 Chapter 18.6, Hangul Jamo characters should be
> composed into the corresponding pre-composed Hangul characters. Iʼm
> not seeing this, e.g
> 
> 하 (U+1112 U+1161) should be displayed as 하 (U+D558), but is shown as
> two separate glyphs (all using Apple SD Gothic Neo)

I hope I've just fixed that on the master branch, please take a look.

> (set-char-table-range composition-function-table
>                       #x1112
>                       (list (vector "..")
>                             0
>                             'compose-gstring-for-graphic))
> 
> does not help.

The call is incorrect: 'vector' should include both 0 and the function
symbol.

Thanks.

Message #9 received at 40502 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: 40502 <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not
 composed
Date: Wed, 08 Apr 2020 12:00:32 +0200

>>>>> On Wed, 08 Apr 2020 11:28:25 +0200, Robert Pluim <rpluim <at> gmail.com> said:

    Robert> According to Unicode 13 Chapter 18.6, Hangul Jamo characters should be
    Robert> composed into the corresponding pre-composed Hangul characters. Iʼm
    Robert> not seeing this, e.g

    Robert> 하 (U+1112 U+1161) should be displayed as 하 (U+D558), but is shown as
    Robert> two separate glyphs (all using Apple SD Gothic Neo)

    Robert> (set-char-table-range composition-function-table
    Robert>                       #x1112
    Robert>                       (list (vector "..")
    Robert>                             0
    Robert>                             'compose-gstring-for-graphic))

    Robert> does not help.

It doesnʼt help because I got the parameters to set-char-table-range
wrong. <sigh>

Robert

Message #16 received at 40502-done <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40502-done <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not
 composed
Date: Wed, 08 Apr 2020 12:11:56 +0200

>>>>> On Wed, 08 Apr 2020 12:55:19 +0300, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Date: Wed, 08 Apr 2020 11:28:25 +0200
    >> 
    >> According to Unicode 13 Chapter 18.6, Hangul Jamo characters should be
    >> composed into the corresponding pre-composed Hangul characters. Iʼm
    >> not seeing this, e.g
    >> 
    >> 하 (U+1112 U+1161) should be displayed as 하 (U+D558), but is shown as
    >> two separate glyphs (all using Apple SD Gothic Neo)

    Eli> I hope I've just fixed that on the master branch, please take a look.

Yes, on both macOS and GNU/Linux, including the three character
variant (I tested with U+1112 U+1161 U+11AB).

    >> (set-char-table-range composition-function-table
    >> #x1112
    >> (list (vector "..")
    >> 0
    >> 'compose-gstring-for-graphic))
    >> 
    >> does not help.

    Eli> The call is incorrect: 'vector' should include both 0 and the function
    Eli> symbol.

Yes. I misread the docstring of composition-function-table rather than
copying the correct call I had sitting in a buffer already.

Closing.

Robert

Message #19 received at 40502 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 40502 <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not
 composed
Date: Wed, 08 Apr 2020 14:18:22 +0300

> From: Robert Pluim <rpluim <at> gmail.com>
> Cc: 40502-done <at> debbugs.gnu.org
> Date: Wed, 08 Apr 2020 12:11:56 +0200
> 
>     Eli> The call is incorrect: 'vector' should include both 0 and the function
>     Eli> symbol.
> 
> Yes. I misread the docstring of composition-function-table rather than
> copying the correct call I had sitting in a buffer already.

Maybe we should improve the doc string?  Which part was confusing?

Message #22 received at 40502 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40502 <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not
 composed
Date: Wed, 08 Apr 2020 14:11:19 +0200

>>>>> On Wed, 08 Apr 2020 14:18:22 +0300, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Cc: 40502-done <at> debbugs.gnu.org
    >> Date: Wed, 08 Apr 2020 12:11:56 +0200
    >> 
    Eli> The call is incorrect: 'vector' should include both 0 and the function
    Eli> symbol.
    >> 
    >> Yes. I misread the docstring of composition-function-table rather than
    >> copying the correct call I had sitting in a buffer already.

    Eli> Maybe we should improve the doc string?  Which part was confusing?

I donʼt know if itʼs confusing, just that it says:

    The element at index C in the table, if non-nil, is a list of
    composition rules of this form: ([PATTERN PREV-CHARS FUNC] ...)

So I did
   (list (vector [..]

then continued to read the docstring, and by the time I got back to
the code, my brain conflated the brackets from the regexp with the
ones from the vector, so I closed the list, and carried on. So
entirely down to my brain fart. Maybe saying

((vector PATTERN PREV-CHARS FUNC) ...)

would have helped, but itʼs too late to tell now.

Perhaps we should have a macro or defun 'composition-function-add-entry' or
somesuch to hide the details? And ensure that weʼre not overwriting
previous entries. How often do people write these things?

    (defsubst composition-function-add-entry (char-or-range pattern
    prev-chars func &optional replace)
    "Add composition-function-table entry for CHAR-OR-RANGE.

    CHAR-OR-RANGE is a single character or a cons of character codes.
    Adds [PATTERN PREV-CHARS FUNC] to any existing composition-function-table
    entry for CHAR-OR-RANGE.

    Optional arg REPLACE non-nil means replace the existing entry rather
    than adding to it.

    See `composition-function-table' and `auto-composition-mode' for
    more details.

(or does this end up growing 'add-to-front', 'supersede',
'sort-then-insert' etc options? :-) )

Robert

Message #25 received at 40502 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 40502 <at> debbugs.gnu.org
Subject: Re: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not
 composed
Date: Wed, 08 Apr 2020 16:51:14 +0300

> From: Robert Pluim <rpluim <at> gmail.com>
> Cc: 40502 <at> debbugs.gnu.org
> Date: Wed, 08 Apr 2020 14:11:19 +0200
> 
> Perhaps we should have a macro or defun 'composition-function-add-entry' or
> somesuch to hide the details?

We could if this is done frequently enough.

> How often do people write these things?

Probably not too often.  "git log --grep" shows only 55 changes since
1999, with only a dozen or so since 2008.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.