Subject: bug#40492: closed (Re: [bug#40492] [PATCH] gnu: Add meshlab)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 13 Jun 2020 14:59:02 +0000

Your bug report

#40492: [PATCH] gnu: Add meshlab

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
40492: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40492
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#40492] [PATCH] gnu: Add meshlab
From: Ludovic Courtès <[email-masked]>
To: Ekaitz Zarraga <[email-masked]>
Cc: "[email-masked]" <[email-masked]>
Date: Sat, 13 Jun 2020 16:58:29 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Ekaitz Zarraga <[email-masked]> skribis:

> From 2779f50ad71b4458272aaa9223df96e3a77f60e4 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <[email-masked]>
> Date: Fri, 12 Jun 2020 23:41:18 +0200
> Subject: [PATCH] gnu: Add meshlab.
>
> * gnu/packages/engineering.scm (meshlab): New variable.

Alright!  Applied with the following changes (whitespace-insensitive
diff).  I hope we can eventually fix the qhull issue, we’ll see.

Thank you!

Ludo’.

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index b243974dcc..fe3c87edd5 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2622,20 +2622,20 @@ export filters.")
     (license license:lgpl2.1+)))
 
 (define-public meshlab
-  (let ((version "2020.05"))
   (package
     (name "meshlab")
-      (version version)
+    (version "2020.05")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/cnr-isti-vclab/meshlab")
                     (commit (string-append "Meshlab-" version))
                     (recursive? #t)))
+              (file-name (git-file-name name version))
               (sha256
                (base32 "00sim20ka9vjwljixdj4cqd285j21mpaq05ari7nqq2w8yyglp5m"))))
     (build-system cmake-build-system)
-      (native-inputs
+    (inputs
      `(("qtbase" ,qtbase)
        ("qtscript" ,qtscript)
        ("qtxmlpatterns" ,qtxmlpatterns)
@@ -2648,20 +2648,17 @@ export filters.")
        ("libfreenect" ,libfreenect)
        ("lib3ds" ,lib3ds)
        ("openctm" ,openctm)
-         ;; Compilation fails with system qhull
+       ;; FIXME: Compilation fails with system qhull:
        ;; https://github.com/cnr-isti-vclab/meshlab/issues/678
        ;; ("qhull" ,qhull)
        ))
     (arguments
      `(#:tests? #f                                ; Has no tests
        #:phases
-         (modify-phases
-             %standard-phases
-           (add-after
-               'unpack 'go-to-source-dir
+       (modify-phases %standard-phases
+         (add-after 'unpack 'go-to-source-dir
            (lambda _ (chdir "src") #t))
-           (add-after
-               'install 'move-files
+         (add-after 'install 'move-files
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((lib (string-append (assoc-ref outputs "out")
                                        "/lib")))
@@ -2679,4 +2676,4 @@ rendering and converting this kind of meshes.  These tools include MeshLab
 proper, a versatile program with a graphical user interface, and meshlabserver,
 a program that can perform mesh processing tasks in batch mode, without a
 GUI.")
-      (license license:gpl3+))))
+    (license license:gpl3+)))

Subject: [PATCH] gnu: Add meshlab
From: Ekaitz Zarraga <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Tue, 07 Apr 2020 17:08:06 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi everyone,

I wrote a package to add meshlab but I'm not sure if I did it right:
- It doesn't have tests so I removed the testing.
- It fails to check RUNPATH, but I don't really know why so I disabled
  it at the moment. It fails while searching for meshlab core libraries
  but the search path is correct (it misses a /meshlab at the end).

Can you please check it and suggest a solution?

It works as it is but the runpath checks should pass...

Thanks!
Ekaitz

---

>From d9020d7e64020dc7eea1bd46af184856d568ca7d Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <[email-masked]>
Date: Tue, 7 Apr 2020 18:56:06 +0200
Subject: [PATCH] gnu: Add meshlab

---
 gnu/packages/engineering.scm | 39 ++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 5405db762c..85efc01c4c 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2491,3 +2491,42 @@ without any changes.  And programmers that are familiar with the magellan API
 can continue using it with a free library without the restrictions of the
 official SDK.")
     (license license:bsd-3)))
+
+(define-public meshlab
+  (let ((commit-ref "Meshlab-2020.04"))
+    (package
+      (name "meshlab")
+      (version commit-ref)
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                       (url "https://github.com/cnr-isti-vclab/meshlab")
+                       (commit commit-ref)
+                       (recursive? #t)))
+                (sha256
+                  (base32 "1vx9jcsnnxvzi90pcxpp7p72cqg3cm6jiivdmrxkzhr2fiz3pfvr"))))
+      (build-system cmake-build-system)
+      (native-inputs
+        `(("qtbase" ,qtbase)
+          ("qtscript" ,qtscript)
+          ("qtxmlpatterns" ,qtxmlpatterns)
+          ("mesa", mesa)
+          ("glu", glu)))
+      (arguments
+        `(#:tests? #f
+          #:validate-runpath? #f
+          #:phases (modify-phases %standard-phases
+                                  (add-after 'unpack 'go-to-source-dir
+                                             (lambda _ (chdir "src") #t)))))
+      (synopsis
+        "The open source system for processing and editing 3D triangular meshes.")
+      (home-page "http://www.meshlab.net/")
+      (description "MeshLab is an open source, portable, and extensible system
+for the processing and editing of unstructured large 3D triangular meshes.  It
+is aimed to help the processing of the typical not-so-small unstructured models
+arising in 3D scanning, providing a set of tools for editing, cleaning,
+healing, inspecting, rendering and converting this kind of meshes.  These tools
+include MeshLab proper, a versatile program with a graphical user interface,
+and meshlabserver, a program that can perform mesh
+processing tasks in batch mode, without a GUI.")
+      (license license:gpl3+))))
--
2.25.1