Subject: Re: [bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

From: Naga Malleswari <[email-masked]>
Date: Fri, 10 Apr 2020 02:12:42 +0530

Hi

Finally It worked......Submitting the patch for review.

Now xfce4-embed-plugin is building fine after i modified the input to
old version of libxfce4ui.

I referred the older commit message from help2man from the log. I am
still not sure about it.

Its the same code i have sent you. I used the origin block. And (name  
x) was the only difference.

On 09/04/20 3:49 am, Danny Milosavljevic wrote:
> + (inherit libxfce4ui-1)
> +    (name "libxfce4ui") ; not necessary but I like it for no reason
> +    (version "4.15.2")
> +    (source (origin ; necessary block!!
I used the same. I added name block. It worked !!!
> $ ./pre-inst-env guix build [email-masked]
> /gnu/store/fk1ziblzyslg9z7gpm9j410jfgwbilsr-libxfce4ui-4.14.1
>
> $ ./pre-inst-env guix build [email-masked]
> /gnu/store/cy5wyx1zrq9ahp6zl0wjpv0nd0a6hpkb-libxfce4ui-4.15.2

It worked the same.

1) If name block is removed in latest.   Its building the older version.
Why??

2)  /latest is also removed from variable. Would i make a difference?

> ewline)
>   (write (package-version b))
>   (newline)
Thanks for such a long explanation. It took a bit of time for me.
> package "b" would have: (name "b") and (version "b").
>
>     Guile variables are invisible to the end user of the "guix" tool.

-- 
Regards
NagaMalli

>From ce3d3d40a09631de05fd45eaec964d5473a4ca73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <[email-masked]>
Date: Fri, 10 Apr 2020 01:59:43 +0530
Subject: [PATCH] gnu: libxfce4ui: Add 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): New variable.
---
 gnu/packages/xfce.scm | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..9556d5aa39 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,7 @@ Xfce Desktop Environment.")
 storage system.")
     (license lgpl2.0+)))
 
-(define-public libxfce4ui
+(define-public libxfce4ui-1
   (package
     (name "libxfce4ui")
     (version "4.14.1")
@@ -201,6 +201,20 @@ storage system.")
 to share commonly used Xfce widgets among the Xfce applications.")
     (license lgpl2.0+)))
 
+(define-public libxfce4ui
+  (package
+    (inherit libxfce4ui-1)
+    (name "libxfce4ui")
+    (version "4.15.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/xfce/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
 (define-public exo
   (package
     (name "exo")
@@ -1449,7 +1463,7 @@ performance (bytes transferred per second).")
      `(("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("libxfce4ui" ,libxfce4ui)
+     `(("libxfce4ui" ,libxfce4ui-1)
        ("xfce4-panel" ,xfce4-panel)
        ("gtk+-2" ,gtk+-2)))
     (home-page
-- 
2.25.1