GNU bug report logs - #40445
gnu: gsm: Update to 1.0.19.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40445 in the body.
You can then email your comments to 40445 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 07:07:51 +0000

[Message part 1 (text/plain, inline)]

[update-gsm.patch (application/octet-stream, attachment)]

Message #10 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 11:40:07 +0200

Hello Raghav,

> +       #:make-flags
> +       (list
> +        ;; Added -fPIC with other default options.
> +        "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")

I wonder if we need all those options, the package seems to build fine
without them. Could you have a look?

Thanks,

Mathieu

Message #13 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 09:45:55 +0000

Hi Mathieu!

>> + #:make-flags
>> + (list
>> + ;; Added -fPIC with other default options.
>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
> 
> I wonder if we need all those options, the package seems to build fine
> without them. Could you have a look?

Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)

Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".

Regards,
RG.

Message #16 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 12:22:55 +0200

> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)

Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
CCFLAGS without having to repeat all the other options that are already
present in the Makefile:

--8<---------------cut here---------------start------------->8---
CCFLAGS 	= -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
--8<---------------cut here---------------end--------------->8---

Adding a new 'add-fpic-ccflag' phase could be an option?

Thanks,

Mathieu

Message #19 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:26:46 +0000

Hi Mathieu!

> Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
> CCFLAGS without having to repeat all the other options that are already
> present in the Makefile:
> 
> --8<---------------cut here---------------start------------->8---
> CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
> --8<---------------cut here---------------end--------------->8---
> 
> Adding a new 'add-fpic-ccflag' phase could be an option?

We can do that too. But this seems simple and less messy :-)

Regards,
RG.

Message #22 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:28:20 +0000

Hi Mathieu!

>> Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
>> CCFLAGS without having to repeat all the other options that are already
>> present in the Makefile:
>> 
>> --8<---------------cut here---------------start------------->8---
>> CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
>> --8<---------------cut here---------------end--------------->8---
>> 
>> Adding a new 'add-fpic-ccflag' phase could be an option?
> 
> We can do that too. But this seems simple and less messy :-)

Also, I believe, the make-flag just overwrites that line in the source.

Regards,
RG.

Message #25 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 12:33:16 +0200

>> We can do that too. But this seems simple and less messy :-)
>
> Also, I believe, the make-flag just overwrites that line in the source.

Yes that's what it does. But if in a future release this package updates
its CCFLAGS list in the Makefile, we will have to update our own package
definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
seems safer to me.

Mathieu

Message #28 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:37:13 +0000

> Yes that's what it does. But if in a future release this package updates
> its CCFLAGS list in the Makefile, we will have to update our own package
> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
> seems safer to me.

Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for examples.

Regards,
RG.

Message #31 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:52:32 +0000

>> Yes that's what it does. But if in a future release this package updates
>> its CCFLAGS list in the Makefile, we will have to update our own package
>> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
>> seems safer to me.
> 
> Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for
> examples.

No I also think that its a double-edged sword. 'CCFLAGS += -fPIC' also has to be changed/removed, if new release adds "-fPIC"?

Regards,
RG.

Message #34 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:53:34 +0000

>>> Yes that's what it does. But if in a future release this package updates
>>> its CCFLAGS list in the Makefile, we will have to update our own package
>>> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
>>> seems safer to me.
>> 
>> Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for
>> examples.
> 
> No I also think that its a double-edged sword. 'CCFLAGS += -fPIC' also has to be changed/removed,
> if new release adds "-fPIC"?

* Now

Message #37 received at 40445 <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, 40445 <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 13:38:40 -0400

Hello,

"Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:

> Hi Mathieu!
>
>>> + #:make-flags
>>> + (list
>>> + ;; Added -fPIC with other default options.
>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>> 
>> I wonder if we need all those options, the package seems to build fine
>> without them. Could you have a look?
>
> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>
> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>
> Regards,
> RG.

Ooops.  Sorry about that.  I meant:

-       #:make-flags '("INSTALL_ROOT=%output"
-                      "CCFLAGS=-fPIC \
+       #:make-flags (list (string-append "INSTALL_ROOT=" %output)
+                          "CCFLAGS=-fPIC \

But I'll take into accounts comments from Mathieu, which make sense.

Maxim

Message #42 received at 40445-done <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: maxim.cournoyer <at> gmail.com
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 Mathieu Othacehe <m.othacehe <at> gmail.com>, 40445-done <at> debbugs.gnu.org
Subject: Re: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 14:20:56 -0400

Hi all,

maxim.cournoyer <at> gmail.com writes:

> Hello,
>
> "Raghav Gururajan" <raghavgururajan <at> disroot.org> writes:
>
>> Hi Mathieu!
>>
>>>> + #:make-flags
>>>> + (list
>>>> + ;; Added -fPIC with other default options.
>>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>> 
>>> I wonder if we need all those options, the package seems to build fine
>>> without them. Could you have a look?
>>
>> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>>
>> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>>
>> Regards,
>> RG.
>
> Ooops.  Sorry about that.  I meant:
>
> -       #:make-flags '("INSTALL_ROOT=%output"
> -                      "CCFLAGS=-fPIC \
> +       #:make-flags (list (string-append "INSTALL_ROOT=" %output)
> +                          "CCFLAGS=-fPIC \
>
> But I'll take into accounts comments from Mathieu, which make sense.
>
> Maxim

I've fixed the breakage I caused with commit
5b05f8e9654ea722270c45c0fd0eead369bc0daf, and committed the update to
gsm 1.0.19 from Raghav on top as
5e16e4401f854d39f5fbebaf247750e554bd4a09.

Closing.

Thanks for the ideas!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.