From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 04 07:58:35 2020 Received: (at submit) by debbugs.gnu.org; 4 Apr 2020 11:58:35 +0000 Received: from localhost ([127.0.0.1]:43559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKhRa-00080d-Rp for submit@debbugs.gnu.org; Sat, 04 Apr 2020 07:58:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:49897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKhRY-00080O-9S for submit@debbugs.gnu.org; Sat, 04 Apr 2020 07:58:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50199) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKhRU-0006R2-D9 for guix-patches@gnu.org; Sat, 04 Apr 2020 07:58:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_40, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW, SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKhRS-0006Fk-AW for guix-patches@gnu.org; Sat, 04 Apr 2020 07:58:27 -0400 Received: from mail-40130.protonmail.ch ([185.70.40.130]:33057) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKhRR-0006CX-9G for guix-patches@gnu.org; Sat, 04 Apr 2020 07:58:26 -0400 Date: Sat, 04 Apr 2020 11:58:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1586001501; bh=rGM4ubhN4LBDxb8xhrNQWktgQOrfQ0mdBaNw7vVNn/Q=; h=Date:To:From:Reply-To:Subject:From; b=jsZBhlQxXyP8q38ZPfmCmVF4EFjdfsS7zoRwhIkdtvN6Fcvo5NIvEQcTOIPehS7em YaDO0WPUIm5BjxhK4YJwJ3s3SoNl7Ckhhpi6LHVVj0wIQoyQenyG2qVJWjft8oiXOB /dREQtFrAgln+P1I866m7qljlSdllmpETJe878ro= To: "guix-patches@gnu.org" From: Vitaliy Shatrov Subject: [PATCH] Add g-golf Message-ID: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_0a90dec8c69143fe49e8581a3e96ff3c" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.130 X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: str1ngs and nly want it to be submitted to guix, and i was proudly take this task. Package was copied "as-is", and tested as per Guix manual. There is desire to package be named "g-golf", and not as " [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (d0dybo0d0dybo0[at]protonmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (d0dybo0d0dybo0[at]protonmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in digit (d0dybo0d0dybo0[at]protonmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Vitaliy Shatrov Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) This is a multi-part message in MIME format. --b1_0a90dec8c69143fe49e8581a3e96ff3c Content-Type: multipart/alternative; boundary="b2_0a90dec8c69143fe49e8581a3e96ff3c" --b2_0a90dec8c69143fe49e8581a3e96ff3c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 c3RyMW5ncyBhbmQgbmx5IHdhbnQgaXQgdG8gYmUgc3VibWl0dGVkIHRvIGd1aXgsIGFuZCBpIHdh cyBwcm91ZGx5IHRha2UgdGhpcyB0YXNrLiAgUGFja2FnZSB3YXMgY29waWVkICJhcy1pcyIsIGFu ZCB0ZXN0ZWQgYXMgcGVyIEd1aXggbWFudWFsLgogICBUaGVyZSBpcyBkZXNpcmUgdG8gcGFja2Fn ZSBiZSBuYW1lZCAiZy1nb2xmIiwgYW5kIG5vdCBhcyAiZ3VpbGUtZy1nb2xmIiwgYXMgdGhlIHBh Y2thZ2UgbmFtZSBzdGFuZHMgZm9yICJHbm9tZTogR3VpbGUgT2JqZWN0IExpYnJhcnkgRm9yIi4K ClNlbnQgd2l0aCBbUHJvdG9uTWFpbF0oaHR0cHM6Ly9wcm90b25tYWlsLmNvbSkgU2VjdXJlIEVt YWlsLg== --b2_0a90dec8c69143fe49e8581a3e96ff3c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj4mbmJzcDsgJm5ic3A7c3RyMW5ncyBhbmQgbmx5IHdhbnQgaXQgdG8gYmUgc3VibWl0dGVk IHRvIGd1aXgsIGFuZCBpIHdhcyBwcm91ZGx5IHRha2UgdGhpcyB0YXNrLiAmbmJzcDtQYWNrYWdl IHdhcyBjb3BpZWQgImFzLWlzIiwgYW5kIHRlc3RlZCBhcyBwZXIgR3VpeCBtYW51YWwuPGJyPjwv ZGl2PjxkaXY+Jm5ic3A7ICZuYnNwO1RoZXJlIGlzIGRlc2lyZSB0byBwYWNrYWdlIGJlIG5hbWVk ICJnLWdvbGYiLCBhbmQgbm90IGFzICJndWlsZS1nLWdvbGYiLCBhcyB0aGUgcGFja2FnZSBuYW1l IHN0YW5kcyBmb3IgIkdub21lOiBHdWlsZSBPYmplY3QgTGlicmFyeSBGb3IiLjxicj48L2Rpdj48 ZGl2Pjxicj48L2Rpdj48ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jayI+PGRp diBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stdXNlciBwcm90b25tYWlsX3NpZ25h dHVyZV9ibG9jay1lbXB0eSI+PGJyPjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0 dXJlX2Jsb2NrLXByb3RvbiI+U2VudCB3aXRoIDxhIGhyZWY9Imh0dHBzOi8vcHJvdG9ubWFpbC5j b20iIHRhcmdldD0iX2JsYW5rIj5Qcm90b25NYWlsPC9hPiBTZWN1cmUgRW1haWwuPGJyPjwvZGl2 PjwvZGl2PjxkaXY+PGJyPjwvZGl2Pg== --b2_0a90dec8c69143fe49e8581a3e96ff3c-- --b1_0a90dec8c69143fe49e8581a3e96ff3c Content-Type: text/x-patch; name="0001-gnu-Add-g-golf.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-g-golf.patch RnJvbSBkNWEyOWE3ZDZkNjFjOWIwYzJiOWU1NDhjZDcyNjA2MmEzMDc4NDA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaXRhbGl5IFNoYXRyb3YgPEQwZHlCbzBEMGR5Qm8wQHByb3Rv bm1haWwuY29tPgpEYXRlOiBTYXQsIDQgQXByIDIwMjAgMTg6NDE6MzggKzA3MDAKU3ViamVjdDog W1BBVENIXSBnbnU6IEFkZCBnLWdvbGYKCiogZ251L3BhY2thZ2VzL2d1aWxlLXh5ei5zY20gKGct Z29sZik6IE5ldyB2YXJpYWJsZQotLS0KIGdudS9wYWNrYWdlcy9ndWlsZS14eXouc2NtIHwgNzkg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA3 OSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2d1aWxlLXh5ei5zY20g Yi9nbnUvcGFja2FnZXMvZ3VpbGUteHl6LnNjbQppbmRleCA2MmViYjgyOTRmLi5mOTI1MWYwZDJh IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ3VpbGUteHl6LnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvZ3VpbGUteHl6LnNjbQpAQCAtMzI4MywzICszMjgzLDgyIEBAIFJlbGF5IENoYXR9IChJUkMp LiIpCiBXZWJTb2NrZXQgcHJvdG9jb2wgYXMgZGVmaW5lZCBieSBSRkMgNjQ1NS4iKQogICAgICAg KGhvbWUtcGFnZSAiaHR0cHM6Ly9naXQuZHRob21wc29uLnVzL2d1aWxlLXdlYnNvY2tldC5naXQi KQogICAgICAgKGxpY2Vuc2UgbGljZW5zZTpsZ3BsMyspKSkpCisKKyhkZWZpbmUtcHVibGljIGct Z29sZgorICAobGV0ICgoY29tbWl0ICI0YTRlZGYyNWU0ODc3ZGY5MTgyYzc3ODQzYmRkOThhYjU5 ZTEzZWY3IikpCisgICAgKHBhY2thZ2UKKyAgICAgIChuYW1lICJnLWdvbGYiKQorICAgICAgKHZl cnNpb24gKGdpdC12ZXJzaW9uICIxIiAiNjgzIiBjb21taXQpKQorICAgICAgKHNvdXJjZSAob3Jp Z2luCisgICAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAgICAgICAg KHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8v Z2l0LnNhdmFubmFoLmdudS5vcmcvZ2l0L2ctZ29sZi5naXQiKQorICAgICAgICAgICAgICAgICAg ICAgIChjb21taXQgY29tbWl0KSkpCisgICAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZp bGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAg ICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICAgIjA5cDBnZjcxd2JtbG05a3JpNjkz YThmdnI5aGwzaGhsbWxpZHlhZHdqZGg3ODUzeGcwaDgiKSkpKQorICAgICAgKGJ1aWxkLXN5c3Rl bSBnbnUtYnVpbGQtc3lzdGVtKQorICAgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAgICBgKCgiYXV0 b2NvbmYiICxhdXRvY29uZikKKyAgICAgICAgICgiYXV0b21ha2UiICxhdXRvbWFrZSkKKyAgICAg ICAgICgidGV4aW5mbyIgLHRleGluZm8pCisgICAgICAgICAoImdldHRleHQiICxnZXR0ZXh0LW1p bmltYWwpCisgICAgICAgICAoImxpYnRvb2wiICxsaWJ0b29sKQorICAgICAgICAgKCJwa2ctY29u ZmlnIiAscGtnLWNvbmZpZykpKQorICAgICAgKGlucHV0cworICAgICAgIGAoKCJndWlsZSIgLGd1 aWxlLTIuMikKKyAgICAgICAgICgiZ3VpbGUtbGliIiAsZ3VpbGUtbGliKQorICAgICAgICAgKCJj bHV0dGVyIiAsY2x1dHRlcikKKyAgICAgICAgICgiZ3RrIiAsZ3RrKykKKyAgICAgICAgICgiZ2xp YiIgLGdsaWIpKSkKKyAgICAgIChwcm9wYWdhdGVkLWlucHV0cworICAgICAgIGAoKCJnb2JqZWN0 LWludHJvc3BlY3Rpb24iICxnb2JqZWN0LWludHJvc3BlY3Rpb24pKSkKKyAgICAgIChhcmd1bWVu dHMKKyAgICAgICBgKCM6dGVzdHM/ICN0CisgICAgICAgICAjOnBoYXNlcworICAgICAgICAgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAoYWRkLWJlZm9yZSAnY29u ZmlndXJlICd0ZXN0cy13b3JrLWFyb3VuZHMKKyAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkg aW5wdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgIDs7IEluIGJ1aWxkIGVu dmlyb25tZW50LCBUaGVyZSBpcyBubyAvZGV2L3R0eQorICAgICAgICAgICAgICAgKHN1YnN0aXR1 dGUqCisgICAgICAgICAgICAgICAgICAgInRlc3Qtc3VpdGUvdGVzdHMvZ29iamVjdC5zY20iCisg ICAgICAgICAgICAgICAgICgoIi9kZXYvdHR5IikgIi9kZXYvbnVsbCIpKSkpCisgICAgICAgICAg IChhZGQtYmVmb3JlICdjb25maWd1cmUgJ3N1YnN0aXR1dGUtbGlicworICAgICAgICAgICAgIChs YW1iZGEqICgjOmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAg ICAgICAgICAobGV0KiAoKGdldCAobGFtYmRhIChrZXkgbGliKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAoYXNzb2MtcmVmIGlucHV0cyBrZXkpICIvbGliLyIg bGliKSkpCisgICAgICAgICAgICAgICAgICAgICAgKGxpYmdpICAgICAgKGdldCAiZ29iamVjdC1p bnRyb3NwZWN0aW9uIiAibGliZ2lyZXBvc2l0b3J5LTEuMCIpKQorICAgICAgICAgICAgICAgICAg ICAgIChsaWJnbGliICAgIChnZXQgImdsaWIiICJsaWJnbGliLTIuMCIpKQorICAgICAgICAgICAg ICAgICAgICAgIChsaWJnb2JqZWN0IChnZXQgImdsaWIiICJsaWJnb2JqZWN0LTIuMCIpKQorICAg ICAgICAgICAgICAgICAgICAgIChsaWJnZGsgICAgIChnZXQgImd0ayIgImxpYmdkay0zIikpKQor ICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImNvbmZpZ3VyZSIKKyAgICAgICAgICAgICAg ICAgICAoKCJTSVRFRElSPVwiXFwkZGF0YWRpci9nLWdvbGZcIiIpCisgICAgICAgICAgICAgICAg ICAgICJTSVRFRElSPVwiJGRhdGFkaXIvZ3VpbGUvc2l0ZS8kR1VJTEVfRUZGRUNUSVZFX1ZFUlNJ T05cIiIpCisgICAgICAgICAgICAgICAgICAgKCgiU0lURUNDQUNIRURJUj1cIlxcJGxpYmRpci9n LWdvbGYvIikKKyAgICAgICAgICAgICAgICAgICAgIlNJVEVDQ0FDSEVESVI9XCIkbGliZGlyLyIp KQorICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImctZ29sZi9pbml0LnNjbSIKKyAgICAg ICAgICAgICAgICAgICAoKCJsaWJnaXJlcG9zaXRvcnktMS4wIikgbGliZ2kpCisgICAgICAgICAg ICAgICAgICAgKCgibGliZ2xpYi0yLjAiKSBsaWJnbGliKQorICAgICAgICAgICAgICAgICAgICgo ImxpYmdkay0zIikgbGliZ2RrKQorICAgICAgICAgICAgICAgICAgICgoImxpYmdvYmplY3QtMi4w IikgbGliZ29iamVjdCkKKyAgICAgICAgICAgICAgICAgICAoKCJcXChkeW5hbWljLWxpbmsgXCJs aWJnLWdvbGZcIlxcKSIpCisgICAgICAgICAgICAgICAgICAgIChmb3JtYXQgI2YgIn5zIgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGAoZHluYW1pYy1saW5rCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZm9ybWF0ICNmICJ+YWxpYmctZ29sZiIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGlmIChnZXRlbnYgIkdVSUxFX0dHT0xGX1VOSU5TVEFMTEVE IikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIiCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAsKGZvcm1hdCAjZiAifmEvbGliLyIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhc3Nv Yy1yZWYgb3V0cHV0cyAib3V0IikpKSkpKSkpCisgICAgICAgICAgICAgICAgIChzZXRlbnYgIkdV SUxFX0FVVE9fQ09NUElMRSIgIjAiKQorICAgICAgICAgICAgICAgICAoc2V0ZW52ICJHVUlMRV9H R09MRl9VTklOU1RBTExFRCIgIjEiKQorICAgICAgICAgICAgICAgICAjdCkpKSkpKQorICAgICAg KGhvbWUtcGFnZSAiaHR0cHM6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9nLWdvbGYvIikKKyAgICAg IChzeW5vcHNpcyAiR3VpbGUgYmluZGluZ3MgZm9yIEdPYmplY3QgSW50cm9zcGVjdGlvbiIpCisg ICAgICAoZGVzY3JpcHRpb24KKyAgICAgICAiRy1Hb2xmIChHbm9tZTogKEd1aWxlIE9iamVjdCBM aWJyYXJ5IGZvcikpIGlzIGEgbGlicmFyeSBmb3IgZGV2ZWxvcGluZworYXBwbGljYXRpb25zIGlu IEd1aWxlIFNjaGVtZS4gIEl0IGNvbXByaXNlcyBhIGRpcmVjdCBiaW5kaW5nIHRvIHRoZSBsb3cg bGV2ZWwKK0dPYmplY3QgSW50cm9zcGVjdGlvbiBBUEkgYW5kIGhpZ2hlci1sZXZlbCBmdW5jdGlv bmFsaXR5IGZvciBpbXBvcnRpbmcgR25vbWUKK2xpYnJhcmllcyBhbmQgbWFraW5nIEdPYmplY3Qg Y2xhc3NlcyAoYW5kIG1ldGhvZHMpIGF2YWlsYWJsZSBpbiBHdWlsZSdzCitvYmplY3Qtb3JpZW50 ZWQgcHJvZ3JhbW1pbmcgc3lzdGVtLCBHT09QUy4iKQorICAgICAgKGxpY2Vuc2UgbGljZW5zZTps Z3BsMyspKSkpCi0tIAoyLjI1LjEKCg== --b1_0a90dec8c69143fe49e8581a3e96ff3c-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 04 22:56:13 2020 Received: (at submit) by debbugs.gnu.org; 5 Apr 2020 02:56:13 +0000 Received: from localhost ([127.0.0.1]:45016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKvSH-000552-7D for submit@debbugs.gnu.org; Sat, 04 Apr 2020 22:56:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:34452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKvSE-00054s-Q3 for submit@debbugs.gnu.org; Sat, 04 Apr 2020 22:56:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60635) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKvSD-0005Q0-Hg for guix-patches@gnu.org; Sat, 04 Apr 2020 22:56:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKvSC-0001ya-HA for guix-patches@gnu.org; Sat, 04 Apr 2020 22:56:09 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:45917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKvSC-0001xh-Br for guix-patches@gnu.org; Sat, 04 Apr 2020 22:56:08 -0400 Received: by mail-pf1-x444.google.com with SMTP id r14so5732892pfl.12 for ; Sat, 04 Apr 2020 19:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=3Np0dnQfXUaEuNm2M9m8v/nITDzRkjniA2ZTd+UOFGc=; b=tPR2h+GXslkHCQ+Yja/wmcvRLvm7o9kZzRoAoReMUJZUrcnMPUMe+2dmi4eFDedH0x kuKKEwbnWsCOIPGcBW87yO/pcTAhN1a1HD6SgI68hwIxSbJf3FAHgysKjIjME6xkuBhT gBV8tMumYbyR0FjmBHvuevISXDItNKaYW476XWfb6BIWvxitz0qFm7U8ZeyD1nwPYpUx 5teiTpk6ZJzAvjKjNWgWjKKqQOESozRPbpngGLJ3pjfi+pRgVuZenk4RpUJKvuvQ7ZNV aDD0dXQV+MrFd203upvEGoBTrl5mMX0Ps6iXaYjqakDqbP/DBOTHRkuTuJlWyH/tXPTA nXVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=3Np0dnQfXUaEuNm2M9m8v/nITDzRkjniA2ZTd+UOFGc=; b=r4GCITB8PIcE48lMqIhbOGg8Stp0cVwQTongfEE+vug53XgHExlKtNxabMjxNG9yw+ tLrg25tckZz7sIMMA76ZoJuegkyn4IIcHEvHxh2Gw0XCbViZYuUVz0PHptRwAodmjbSx 98Ui48ky9C3+qQEue5v3DNR26pH0zB3QulbzC6sVXmmWQBKoCIqVosZesu2hGRyt3oix 4NO2v5YWwMeBpK/B2uLJpoGs01YagXeH/u+Y/m2Of8ZRIICRimGWo+FRH7ofx1hkabor BSn5p1G97invZMJ+ad2vNE8esbsMZrg+9GT/kCY8N2Q3HAci7KBu/qovb47EBIZKK5tO cJEA== X-Gm-Message-State: AGi0PubFm+5ZdBw7czTL1/pc/ufOHy7R+VwA0wDmtayKXbsCotu7SKIR fSFX73hdqMTn5KrqhvegmYs= X-Google-Smtp-Source: APiQypK2ik0bBFEt4zxIohJ44ooeX0Eggp0cZnYPjvqV0pHN5/oKSjytlMNQykDKpV83yeI20BaPww== X-Received: by 2002:a62:e20c:: with SMTP id a12mr15912563pfi.37.1586055366940; Sat, 04 Apr 2020 19:56:06 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id x25sm8048202pgc.63.2020.04.04.19.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2020 19:56:06 -0700 (PDT) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Mike Rosset To: Vitaliy Shatrov , Vitaliy Shatrov via Guix-patches Subject: Re: [bug#40426] [PATCH] Add g-golf In-reply-to: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> Date: Sat, 04 Apr 2020 19:56:01 -0700 Message-ID: <87ftdiy726.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Vitaliy Shatrov via Guix-patches via writes: > str1ngs and nly want it to be submitted to guix, and i was proudly take this task. Package was copied "as-is", and tested as per Guix manual. > There is desire to package be named "g-golf", and not as "guile-g-golf", as the package name stands for "Gnome: Guile Object Library For". > > Sent with [ProtonMail](https://protonmail.com) Secure Email. Thank you Vitaliy, I appreciate you submitting this patch for us. We've been using g-golf sometime in Nomad, though Nomad and g-golf are still pretty much WIP. We thought it would be nice to get g-golf included into guix as a preliminary for Nomad's next replease, which ports most of the C code to scheme using g-golf. We've been using this current declaration for sometime and it's been working quite well so far. If anyone has some feedbak on it please let us know. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 14:10:45 2020 Received: (at 40426) by debbugs.gnu.org; 14 Apr 2020 18:10:45 +0000 Received: from localhost ([127.0.0.1]:34761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOQ1E-0007o8-Oe for submit@debbugs.gnu.org; Tue, 14 Apr 2020 14:10:45 -0400 Received: from mira.cbaines.net ([212.71.252.8]:53106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOQ1D-0007o0-6K for 40426@debbugs.gnu.org; Tue, 14 Apr 2020 14:10:43 -0400 Received: from localhost (unknown [46.237.163.111]) by mira.cbaines.net (Postfix) with ESMTPSA id 4E3D527BBE1; Tue, 14 Apr 2020 19:10:42 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id add38bfa; Tue, 14 Apr 2020 18:10:39 +0000 (UTC) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Vitaliy Shatrov Subject: Re: [bug#40426] [PATCH] Add g-golf In-reply-to: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> Date: Tue, 14 Apr 2020 19:10:37 +0100 Message-ID: <87eesq6iqq.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40426 Cc: 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Vitaliy Shatrov via Guix-patches via writes: > str1ngs and nly want it to be submitted to guix, and i was proudly > take this task. Package was copied "as-is", and tested as per Guix > manual. There is desire to package be named "g-golf", and not as > "guile-g-golf", as the package name stands for "Gnome: Guile Object > Library For". Thanks for the patch, > +(define-public g-golf > + (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7")) > + (package > + (name "g-golf") > + (version (git-version "1" "683" commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.savannah.gnu.org/git/g-golf.git") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "09p0gf71wbmlm9kri693a8fvr9hl3hhlmlidyadwjdh7853xg0h8")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("texinfo" ,texinfo) > + ("gettext" ,gettext-minimal) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("guile" ,guile-2.2) Does g-golf work with Guile 3 yet? If not, that's OK. > + ("guile-lib" ,guile-lib) > + ("clutter" ,clutter) > + ("gtk" ,gtk+) > + ("glib" ,glib))) > + (propagated-inputs > + `(("gobject-introspection" ,gobject-introspection))) > + (arguments > + `(#:tests? #t I'd remove the #:tests? argument given the default value of #t is fine. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'tests-work-arounds > + (lambda* (#:key inputs #:allow-other-keys) > + ;; In build environment, There is no /dev/tty > + (substitute* > + "test-suite/tests/gobject.scm" > + (("/dev/tty") "/dev/null")))) > + (add-before 'configure 'substitute-libs > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((get (lambda (key lib) > + (string-append (assoc-ref inputs key) "/lib/" lib))) > + (libgi (get "gobject-introspection" "libgirepository-1.0")) > + (libglib (get "glib" "libglib-2.0")) > + (libgobject (get "glib" "libgobject-2.0")) > + (libgdk (get "gtk" "libgdk-3"))) > + (substitute* "configure" > + (("SITEDIR=\"\\$datadir/g-golf\"") > + "SITEDIR=\"$datadir/guile/site/$GUILE_EFFECTIVE_VERSION\"") > + (("SITECCACHEDIR=\"\\$libdir/g-golf/") > + "SITECCACHEDIR=\"$libdir/")) > + (substitute* "g-golf/init.scm" > + (("libgirepository-1.0") libgi) > + (("libglib-2.0") libglib) > + (("libgdk-3") libgdk) > + (("libgobject-2.0") libgobject) > + (("\\(dynamic-link \"libg-golf\"\\)") > + (format #f "~s" > + `(dynamic-link > + (format #f "~alibg-golf" > + (if (getenv "GUILE_GGOLF_UNINSTALLED") > + "" > + ,(format #f "~a/lib/" > + (assoc-ref outputs "out")))))))) > + (setenv "GUILE_AUTO_COMPILE" "0") > + (setenv "GUILE_GGOLF_UNINSTALLED" "1") I don't quite follow this GUILE_GGOLF_UNINSTALLED environment variable. Why not just use the absolute filename for the so file (without the extension I think)? Also, maybe delete the strip phase, as I don't think that does anything apart from producing a load of warnings. > + #t)))))) > + (home-page "https://www.gnu.org/software/g-golf/") > + (synopsis "Guile bindings for GObject Introspection") > + (description > + "G-Golf (Gnome: (Guile Object Library for)) is a library for developing > +applications in Guile Scheme. It comprises a direct binding to the low level > +GObject Introspection API and higher-level functionality for importing Gnome > +libraries and making GObject classes (and methods) available in Guile's This looks pretty good to me, just a few things to clear up :) Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6V/J1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xeg4w//X3hH9gOpGf322YS4YFDsbtkwBNsjfU2bhyX1XY1XI09/i8k/u1YB5WBy DjYOPTXaW6MR3gBznB2aFhva/6U7LlFn1pmvI1cfbHSX+gLndxJ7iwNjOGiAwajG 2aCD2ceVgv/y80LRbosUwaLi+VPlwMcY+/M3PIOyQ52BShVKhREnSVQeShNgxEIY zMV6+3K2a7E24/8bxnz/HQkDizEMfuwQNK1M4lrpu+m8k/i8M7UBe51WJcFueHuL IQ0qRr4vrcEFcbrShFTO3C9eU8VqA7t6ERdyjAIa1p751oa0cr+xqx4S2/wKKzSh F0yG5vhKolldKdWtxPbs4ryCzlvtLFO0NQKsodIhBrKbO2kviBgRRTosuLPLBOGr WwSEIttIGUkLC4muivjX3YjXxH9c86Vw9hMZzWgg8TMyK/kFuibnvjR5xj85Px0v uV+MX36Qt10MXNa4EDaO92UnY0SjWSsgpsR/BsG2XL7bZxUzI7uqv2tvfcjpkf6I bTq9Pj1sJqm9982xLm68yfSlyIixb+txRw0cCL3n0gozgJfTsnMHsyIB3u1xBL8K s3eqF3S5V8tYI//eQRVt+EG1X9f836wEMLStC2li0iqNguXY4CphMwgNy9c5xLa4 FGc6Z/xpNGvomtUW1z7sX8JRwY0azwau7WHU2KS7Y7jAeIyHG1c= =iVvA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 01:56:37 2020 Received: (at submit) by debbugs.gnu.org; 15 Apr 2020 05:56:37 +0000 Received: from localhost ([127.0.0.1]:35141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOb2K-0001YH-T7 for submit@debbugs.gnu.org; Wed, 15 Apr 2020 01:56:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:51932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOb2J-0001Y9-0u for submit@debbugs.gnu.org; Wed, 15 Apr 2020 01:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36292) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOb2H-0000ib-Ln for guix-patches@gnu.org; Wed, 15 Apr 2020 01:56:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOb2G-0004Og-JV for guix-patches@gnu.org; Wed, 15 Apr 2020 01:56:33 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:41226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOb2G-0004Ng-DM for guix-patches@gnu.org; Wed, 15 Apr 2020 01:56:32 -0400 Received: by mail-pl1-x643.google.com with SMTP id d24so858516pll.8 for ; Tue, 14 Apr 2020 22:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:message-id:in-reply-to :date:mime-version; bh=XtzyMU0NZ0KuApBHh4jrsVDQhEuhmMU6Oiy/3nL0hgk=; b=RKJw9W7aawBd2STwnP0XKWFbcMX0j7H2YoopbhJb/f4SUxwAIMwWBFOnXsvJrMnglv jpK0Ujeg9l2/N72C8o5j5de+SilNPTBwsRjxYQ6usoqu7Gc4XlEe8MNxzrIGEWegJMV3 62yGyFnzPM0UcJG+SFqNI7F2hM7oV2wyZgbck3GPz9Zg1npoYY0eEXZaw9EFbgzDJIid c1UJ4YPeBrdnlWMxuTWNuG5qud6K8DufPczuNzo4w7mQC1NN5fTaaSKLuLYBeeZqIYKI ggRqui3m6cXOgpH0QoN16OeCOSJ/Cn6tPswD8LAL8nyxygMmzpm4Eip3B9wbNdxJgxv+ nhsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :message-id:in-reply-to:date:mime-version; bh=XtzyMU0NZ0KuApBHh4jrsVDQhEuhmMU6Oiy/3nL0hgk=; b=DifmG6sqVfMt9ikbHxttgiPxIllyf+UQLx3aRq+rTjDN70kU6ngB7onjTCPQnmwUIs a6RoByEmnshvkO//UuFK93AJg6lju4C4NUsPd+jQEl+iPNVcsh1JMIcX0kGkP8kEasCN /KU2dVq9+KozqUnq1eIxf8S4t4f/akNcCYZ/JSZ8d7jwB4vB8kflgaJ48bkP2qcit2as 1dga8kv5YcGijinbVpH5V8DrNT4w9uP8Em86lvXn/aiL9gJdQS4FGXcbuJ8DxffI1nhM 3YlzxY6wjBLQN/Xdnh165LvZMS3EAXzbUNwXYB2YPAKa2Kj7xHOBnhmHrNV8zW3lnD1c GYnA== X-Gm-Message-State: AGi0PuapmjQnQNjOr9Mli4tOmL22CsiiLXwKzFUDmOrMkhinHm2Dg8iN jBmlYr1CU32n3ht4IosSGvX4n4L+ X-Google-Smtp-Source: APiQypKbKlE6igx0Y0XplAHkIKT8uiX8PMApTRka5j2tvmIWSQi75loPhFb5JKcK9EbKrX2xIJs2dw== X-Received: by 2002:a17:902:bb87:: with SMTP id m7mr3553365pls.9.1586930191000; Tue, 14 Apr 2020 22:56:31 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id bt19sm13658453pjb.3.2020.04.14.22.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 22:56:30 -0700 (PDT) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87eesq6iqq.fsf@cbaines.net> User-agent: mu4e 1.2.0; emacs 26.3 From: Mike Rosset To: guix-patches@gnu.org Subject: Re: [bug#40426] [PATCH] Add g-golf Message-ID: <87imi1z46t.fsf@gmail.com> In-reply-to: <87eesq6iqq.fsf@cbaines.net> Date: Tue, 14 Apr 2020 22:56:24 -0700 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Vitaliy Shatrov , 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Christopher Baines writes: > Vitaliy Shatrov via Guix-patches via writes: > > Does g-golf work with Guile 3 yet? If not, that's OK. > Hello Christopher, thanks for looking at this. I did quick look at seeing if g-golf would work with guile 3.0. But I ran into some issue with core module bindings. Since g-golf very much WIP and like wise Nomad which is my primary use for g-golf is also WIP. I've kept strictly to guile 2.2 for now to maintain a little extra stability. I'll follow up on it when both nomad a g-golf are more stable. > > I'd remove the #:tests? argument given the default value of #t is fine. > Not a problem either myself or Vitality will add a follow up patch. This was orphaned since we just recently got tests working. > I don't quite follow this GUILE_GGOLF_UNINSTALLED environment > variable. Why not just use the absolute filename for the so file > (without the extension I think)? The problem here is that libg-golf is needed both at compile time and runtime. So it can not be substituted say after the unpack stage. So this just checks if GUILE_GGOLF_UNINSTALLED is set. Then it will use libg-golf with normal dynamic-link search paths. Other wise it uses the full store path. I had discussed this scenario with the g-golf author, his recommendation was to use this approach it's the same one used for the guile-cv declaration. He's the author of guile-cv as well. > Also, maybe delete the strip phase, as I don't think that does anything > apart from producing a load of warnings. > I think the strip phase strips dynamic elf libraries as well? I don't think it would hurt here to keep it for libg-golf at least? Would you also be able to look at bug#40512 Christopher? That one is a trivial review just some upstream bug fixes for Emacsy and a hash bump in the package declaration. Technically not related to the patch. But eventually I'll need both of these when I release the next version of nomad. Regards, Mike From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 03:16:16 2020 Received: (at 40426) by debbugs.gnu.org; 15 Apr 2020 07:16:17 +0000 Received: from localhost ([127.0.0.1]:35182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOcHQ-0005aX-Jj for submit@debbugs.gnu.org; Wed, 15 Apr 2020 03:16:16 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOcHM-0005aE-Rs for 40426@debbugs.gnu.org; Wed, 15 Apr 2020 03:16:14 -0400 Date: Wed, 15 Apr 2020 07:15:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1586934966; bh=ATrA62kwyioWUtDaduQW9MK0KpiFKNx3SHmdLAy639M=; h=Date:To:From:Reply-To:Subject:From; b=XVZA+KoqfTX3i7H1OXwtMEZ1q9umHMO2jV1yGyAupeYssjpEAYMfW6ZcLaHtQTHd3 ZLX0SevZylaoMa6EMbvxbFYSs0t5tp2+gcDeJmZRlyA4XCTB01BBBu5wCC+TizIBWK XmERulkfS+87DuKz9Yatg89Ud8mpEmAZOJwdIOho= To: "40426@debbugs.gnu.org" <40426@debbugs.gnu.org> From: Vitaliy Shatrov Subject: v2, cleared Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_7232839b0d231e53cca7d0393671b43c" X-Spam-Status: No, score=-0.7 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 40426 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Vitaliy Shatrov Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --b1_7232839b0d231e53cca7d0393671b43c Content-Type: multipart/alternative; boundary="b2_7232839b0d231e53cca7d0393671b43c" --b2_7232839b0d231e53cca7d0393671b43c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 dGVzdHMgI3QgLS0gcmVtb3ZlZDsKdHJ5aW5nIGFub3RoZXIgZGVzYy4= --b2_7232839b0d231e53cca7d0393671b43c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj50ZXN0cyAjdCAtLSByZW1vdmVkOzxicj48L2Rpdj48ZGl2PnRyeWluZyBhbm90aGVyIGRl c2MuPGJyPjwvZGl2Pg== --b2_7232839b0d231e53cca7d0393671b43c-- --b1_7232839b0d231e53cca7d0393671b43c Content-Type: text/x-patch; name="0001-gnu-Add-g-golf.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-g-golf.patch RnJvbSBhMWVlYzI2OWE2M2Y3OGUzNzBkOTQ1ZTViMDY1YmNiODI3NGIxZWFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaXRhbGl5IFNoYXRyb3YgPEQwZHlCbzBEMGR5Qm8wQHByb3Rv bm1haWwuY29tPgpEYXRlOiBXZWQsIDE1IEFwciAyMDIwIDE0OjAyOjEzICswNzAwClN1YmplY3Q6 IFtQQVRDSF0gZ251OiBBZGQgZy1nb2xmCgoqIGdudS9wYWNrYWdlcy9ndWlsZS14eXouc2NtIChn LWdvbGYpOiBOZXcgdmFyaWFibGUKLS0tCiBnbnUvcGFja2FnZXMvZ3VpbGUteHl6LnNjbSB8IDc3 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg NzcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9ndWlsZS14eXouc2Nt IGIvZ251L3BhY2thZ2VzL2d1aWxlLXh5ei5zY20KaW5kZXggZTFmY2MxMjIyOS4uNjFkYWU2YmU0 MSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2d1aWxlLXh5ei5zY20KKysrIGIvZ251L3BhY2th Z2VzL2d1aWxlLXh5ei5zY20KQEAgLTMyNzEsMyArMzI3MSw4MCBAQCBSZWxheSBDaGF0fSAoSVJD KS4iKQogV2ViU29ja2V0IHByb3RvY29sIGFzIGRlZmluZWQgYnkgUkZDIDY0NTUuIikKICAgICAg IChob21lLXBhZ2UgImh0dHBzOi8vZ2l0LmR0aG9tcHNvbi51cy9ndWlsZS13ZWJzb2NrZXQuZ2l0 IikKICAgICAgIChsaWNlbnNlIGxpY2Vuc2U6bGdwbDMrKSkpKQorCisKKyhkZWZpbmUtcHVibGlj IGctZ29sZgorICAobGV0ICgoY29tbWl0ICI0YTRlZGYyNWU0ODc3ZGY5MTgyYzc3ODQzYmRkOThh YjU5ZTEzZWY3IikpCisgICAgKHBhY2thZ2UKKyAgICAgIChuYW1lICJnLWdvbGYiKQorICAgICAg KHZlcnNpb24gKGdpdC12ZXJzaW9uICIxIiAiNjgzIiBjb21taXQpKQorICAgICAgKHNvdXJjZSAo b3JpZ2luCisgICAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAgICAg ICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBz Oi8vZ2l0LnNhdmFubmFoLmdudS5vcmcvZ2l0L2ctZ29sZi5naXQiKQorICAgICAgICAgICAgICAg ICAgICAgIChjb21taXQgY29tbWl0KSkpCisgICAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0 LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAg ICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICAgIjA5cDBnZjcxd2JtbG05a3Jp NjkzYThmdnI5aGwzaGhsbWxpZHlhZHdqZGg3ODUzeGcwaDgiKSkpKQorICAgICAgKGJ1aWxkLXN5 c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAgICBgKCgi YXV0b2NvbmYiICxhdXRvY29uZikKKyAgICAgICAgICgiYXV0b21ha2UiICxhdXRvbWFrZSkKKyAg ICAgICAgICgidGV4aW5mbyIgLHRleGluZm8pCisgICAgICAgICAoImdldHRleHQiICxnZXR0ZXh0 LW1pbmltYWwpCisgICAgICAgICAoImxpYnRvb2wiICxsaWJ0b29sKQorICAgICAgICAgKCJwa2ct Y29uZmlnIiAscGtnLWNvbmZpZykpKQorICAgICAgKGlucHV0cworICAgICAgIGAoKCJndWlsZSIg LGd1aWxlLTIuMikKKyAgICAgICAgICgiZ3VpbGUtbGliIiAsZ3VpbGUtbGliKQorICAgICAgICAg KCJjbHV0dGVyIiAsY2x1dHRlcikKKyAgICAgICAgICgiZ3RrIiAsZ3RrKykKKyAgICAgICAgICgi Z2xpYiIgLGdsaWIpKSkKKyAgICAgIChwcm9wYWdhdGVkLWlucHV0cworICAgICAgIGAoKCJnb2Jq ZWN0LWludHJvc3BlY3Rpb24iICxnb2JqZWN0LWludHJvc3BlY3Rpb24pKSkKKyAgICAgIChhcmd1 bWVudHMKKyAgICAgICBgKCM6cGhhc2VzCisgICAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRh cmQtcGhhc2VzCisgICAgICAgICAgIChhZGQtYmVmb3JlICdjb25maWd1cmUgJ3Rlc3RzLXdvcmst YXJvdW5kcworICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgIzphbGxvdy1vdGhl ci1rZXlzKQorICAgICAgICAgICAgICAgOzsgSW4gYnVpbGQgZW52aXJvbm1lbnQsIFRoZXJlIGlz IG5vIC9kZXYvdHR5CisgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSoKKyAgICAgICAgICAgICAg ICAgICAidGVzdC1zdWl0ZS90ZXN0cy9nb2JqZWN0LnNjbSIKKyAgICAgICAgICAgICAgICAgKCgi L2Rldi90dHkiKSAiL2Rldi9udWxsIikpKSkKKyAgICAgICAgICAgKGFkZC1iZWZvcmUgJ2NvbmZp Z3VyZSAnc3Vic3RpdHV0ZS1saWJzCisgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlucHV0 cyBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgIChsZXQqICgoZ2V0 IChsYW1iZGEgKGtleSBsaWIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmct YXBwZW5kIChhc3NvYy1yZWYgaW5wdXRzIGtleSkgIi9saWIvIiBsaWIpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAobGliZ2kgICAgICAoZ2V0ICJnb2JqZWN0LWludHJvc3BlY3Rpb24iICJsaWJn aXJlcG9zaXRvcnktMS4wIikpCisgICAgICAgICAgICAgICAgICAgICAgKGxpYmdsaWIgICAgKGdl dCAiZ2xpYiIgImxpYmdsaWItMi4wIikpCisgICAgICAgICAgICAgICAgICAgICAgKGxpYmdvYmpl Y3QgKGdldCAiZ2xpYiIgImxpYmdvYmplY3QtMi4wIikpCisgICAgICAgICAgICAgICAgICAgICAg KGxpYmdkayAgICAgKGdldCAiZ3RrIiAibGliZ2RrLTMiKSkpCisgICAgICAgICAgICAgICAgIChz dWJzdGl0dXRlKiAiY29uZmlndXJlIgorICAgICAgICAgICAgICAgICAgICgoIlNJVEVESVI9XCJc XCRkYXRhZGlyL2ctZ29sZlwiIikKKyAgICAgICAgICAgICAgICAgICAgIlNJVEVESVI9XCIkZGF0 YWRpci9ndWlsZS9zaXRlLyRHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTlwiIikKKyAgICAgICAgICAg ICAgICAgICAoKCJTSVRFQ0NBQ0hFRElSPVwiXFwkbGliZGlyL2ctZ29sZi8iKQorICAgICAgICAg ICAgICAgICAgICAiU0lURUNDQUNIRURJUj1cIiRsaWJkaXIvIikpCisgICAgICAgICAgICAgICAg IChzdWJzdGl0dXRlKiAiZy1nb2xmL2luaXQuc2NtIgorICAgICAgICAgICAgICAgICAgICgoImxp YmdpcmVwb3NpdG9yeS0xLjAiKSBsaWJnaSkKKyAgICAgICAgICAgICAgICAgICAoKCJsaWJnbGli LTIuMCIpIGxpYmdsaWIpCisgICAgICAgICAgICAgICAgICAgKCgibGliZ2RrLTMiKSBsaWJnZGsp CisgICAgICAgICAgICAgICAgICAgKCgibGliZ29iamVjdC0yLjAiKSBsaWJnb2JqZWN0KQorICAg ICAgICAgICAgICAgICAgICgoIlxcKGR5bmFtaWMtbGluayBcImxpYmctZ29sZlwiXFwpIikKKyAg ICAgICAgICAgICAgICAgICAgKGZvcm1hdCAjZiAifnMiCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgYChkeW5hbWljLWxpbmsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmb3Jt YXQgI2YgIn5hbGliZy1nb2xmIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoaWYgKGdldGVudiAiR1VJTEVfR0dPTEZfVU5JTlNUQUxMRUQiKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICwoZm9ybWF0ICNmICJ+YS9saWIvIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQi KSkpKSkpKSkKKyAgICAgICAgICAgICAgICAgKHNldGVudiAiR1VJTEVfQVVUT19DT01QSUxFIiAi MCIpCisgICAgICAgICAgICAgICAgIChzZXRlbnYgIkdVSUxFX0dHT0xGX1VOSU5TVEFMTEVEIiAi MSIpCisgICAgICAgICAgICAgICAgICN0KSkpKSkpCisgICAgICAoaG9tZS1wYWdlICJodHRwczov L3d3dy5nbnUub3JnL3NvZnR3YXJlL2ctZ29sZi8iKQorICAgICAgKHN5bm9wc2lzICJHLUdvbGYg aXMgYSBHdWlsZSBPYmplY3QgTGlicmFyeSBmb3IgR05PTUUiKQorICAgICAgKGRlc2NyaXB0aW9u ICJHLUdvbGYgbG93IGxldmVsIEFQSSBjb21wcmlzZXMgYSBiaW5kaW5nIHRvIC0gKG1vc3Qgb2Yp IHRoZQorR09iamVjdCBJbnRyb3NwZWN0aW9uIGFuZCAoc29tZSBvZikgdGhlIEdPYmplY3QgYW5k IEdsaWIgbGlicmFyaWVzLCBhcyB3ZWxsIGFzCithZGRpdGlvbmFsIChHLUdvbGYpIHV0aWxpdGll cyAtIHVzZWQgdG8gaW1wb3J0IEdPYmplY3QgbGlicmFyaWVzIGFuZCBidWlsZAordGhlaXIgY29y cmVzcG9uZGluZyBHLUdvbGYgaGlnaCBsZXZlbCBBUEkuIikKKyAgICAgIChsaWNlbnNlIGxpY2Vu c2U6bGdwbDMrKSkpKQotLSAKMi4yNi4wCgo= --b1_7232839b0d231e53cca7d0393671b43c-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 04:24:53 2020 Received: (at 40426) by debbugs.gnu.org; 15 Apr 2020 08:24:53 +0000 Received: from localhost ([127.0.0.1]:35235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOdLp-0000xy-1X for submit@debbugs.gnu.org; Wed, 15 Apr 2020 04:24:53 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOdLn-0000xr-Ro for 40426@debbugs.gnu.org; Wed, 15 Apr 2020 04:24:52 -0400 Received: from localhost (unknown [46.237.160.17]) by mira.cbaines.net (Postfix) with ESMTPSA id DC6C127BBE1; Wed, 15 Apr 2020 09:24:50 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fd9c7138; Wed, 15 Apr 2020 08:24:48 +0000 (UTC) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87eesq6iqq.fsf@cbaines.net> <87imi1z46t.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Mike Rosset Subject: Re: [bug#40426] [PATCH] Add g-golf In-reply-to: <87imi1z46t.fsf@gmail.com> Date: Wed, 15 Apr 2020 09:24:47 +0100 Message-ID: <875ze16trk.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40426 Cc: D0dyBo0D0dyBo0@protonmail.com, 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Mike Rosset writes: > Christopher Baines writes: > >> Vitaliy Shatrov via Guix-patches via writes: >> >> Does g-golf work with Guile 3 yet? If not, that's OK. >> > Hello Christopher, thanks for looking at this. > > I did quick look at seeing if g-golf would work with guile 3.0. But I > ran into some issue with core module bindings. Since g-golf very much > WIP and like wise Nomad which is my primary use for g-golf is also > WIP. I've kept strictly to guile 2.2 for now to maintain a little extra > stability. I'll follow up on it when both nomad a g-golf are more > stable. Sure, no problem. >> I don't quite follow this GUILE_GGOLF_UNINSTALLED environment >> variable. Why not just use the absolute filename for the so file >> (without the extension I think)? > > > The problem here is that libg-golf is needed both at compile time and > runtime. So it can not be substituted say after the unpack stage. So > this just checks if GUILE_GGOLF_UNINSTALLED is set. Then it will > use libg-golf with normal dynamic-link search paths. Other wise it uses > the full store path. > > I had discussed this scenario with the g-golf author, his > recommendation was to use this approach it's the same one used for the > guile-cv declaration. He's the author of guile-cv as well. Right, so it's something to help build the Guix package. I think I understand now. >> Also, maybe delete the strip phase, as I don't think that does anything >> apart from producing a load of warnings. >> > > I think the strip phase strips dynamic elf libraries as well? I > don't think it would hurt here to keep it for libg-golf at least? Sure, it's OK to keep it as well. > Would you also be able to look at bug#40512 Christopher? That one is a > trivial review just some upstream bug fixes for Emacsy and a hash bump > in the package declaration. Technically not related to the patch. But > eventually I'll need both of these when I release the next version of > nomad. I've gone ahead and merged the emacsy-minimal update, I'll send an email to that bug in a minute. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6WxM9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xf7Uw//QXXA4M39FgRLxzpxXNkCGwADPzChF9IXhGM+nXKrUF85dCNwNT3t0Z15 T0O5MYJUE6rs1+/vINtOOild/9e0HSrdwBWoyEbIoxLr1sjPndLnhz0xVZitqkc9 +gPQOOh5+sWpAQuxLtI5rXaa8W/nlSaP9mldvccLhHWHUL69gChF9bxYgCq5TYvO MA3KWkPMUZ8/fIbTb/fjSpLe4WjACWSWKsbh7sWiFpQTMpMupeQjgPsrSz0IC5E+ 71JvypUSdu4dW0XfSlYlNvY9CssgDkY5sRCkFu5LTHj07Q5tgSxnV3m56m7tFzUE pe8oR0gMPKYIoH6ax9YR9BbqlzaMqdAE8O3il7FDXzkJ2QhpEa2AY/cAPUpiqOFw 7z975KcDIhDW7OBENM7XBDA7gpjqR42xTI+j8BuUje9Q4epfUARHzcTmtq6hb+1z ZzYYnCTaTkzqiWWxj7JwKgoht7/y2R9uy/fo+rXZAZ79wZGOKgPWjPcTJbYwY5rb ixEkux9j9BNU3Wa9bbXyGqZzhpg6slPVLmyekqtutSepgejdZIbtniUOaUlLPVpp n5CDOobN3eyiDmzxlhsCX4iftI3ImYzniRjuBMVip0wbe+BnlZgsA6mJBUIkjxcK bUqDEAlgFH/QeNu3hQIpxLMqNsJPMTz2xTU+KJCBv4V7SfvadIg= =88l/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 08:22:48 2020 Received: (at 40426-done) by debbugs.gnu.org; 15 Apr 2020 12:22:48 +0000 Received: from localhost ([127.0.0.1]:35346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOh44-0002tB-0H for submit@debbugs.gnu.org; Wed, 15 Apr 2020 08:22:48 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOh42-0002t4-EW for 40426-done@debbugs.gnu.org; Wed, 15 Apr 2020 08:22:46 -0400 Received: from localhost (unknown [46.237.160.17]) by mira.cbaines.net (Postfix) with ESMTPSA id 9899E27BBE1; Wed, 15 Apr 2020 13:22:45 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e040dfff; Wed, 15 Apr 2020 12:22:43 +0000 (UTC) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Vitaliy Shatrov Subject: Re: [bug#40426] v2, cleared In-reply-to: Date: Wed, 15 Apr 2020 13:22:43 +0100 Message-ID: <8736956ir0.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40426-done Cc: 40426-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Vitaliy Shatrov via Guix-patches via writes: > tests #t -- removed; > trying another desc. Thanks, I've gone ahead and pushed this to master as dfe277a5ce60d487fe44840506206fea8507bc69. I moved the package definition up a bit in the file, just so its not at the bottom, which can help to avoid merge conflicts. I also used the synopsis/description from the initial patch, mostly to avoid the lint warnings. Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6W/JNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfDEg//VOSnqM4tP1vBJziwkYBel1p6ImxbS6ip18Etnv7pZLqfCGikpTr8lBOz K8IuVEgM7kyp2mEjy9C7gUmGApo9Jhver6Fq7w/nmnMhqf4Pm67lDjuCg6mDRPlE bBhTlW4JsdDp1yI6K6ce+ebakqdSa8iJYiUsNK07X7E6iwWZ+pUbm7MSA35H657w 4H97LikBdyTAyq8fA/B+UHTHheumOMAmtlsx6VokrJNOh55SU6pJXVXTOTXg0QQL ZAT8BLjKw0qKGo+zirANOvMhhBDc1TN98o5OphRn/KH0FmQ0BIbR3uQqvN+tJnQR tP4OuIOf3ItSEMQYVyo7dSJX3XORqgS83GWFp3iNOHz+WLsLpD9XpZ5eJux6l08p cohvfhfYM7sgkXSBtOYips/TPMSSR3NI+atU172pDU7BkcFASfGKKDFErF0wJSTL BEoAKseUO/UFZOYAVVooTluxyUmR30smg1Ee40Ui1iG2Us90ZJ2v108gRzp5TzE6 /ZxSiZu3NllvSeNSTd4vB6Mdh+aBwa9sEo1LKZgDQbq9zhft23iTJzs709fLZKJy inipBym9+F6h69tl9hiS5XCGXz3G5AckLCAHxDHIAjuLDw+mLaWflqW05LPG31dK tzsaK2wn09VFC9sop9ksMfG7makc6qROCdLdW9pdlMr2tB922TE= =AeVC -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 09:57:48 2020 Received: (at 40426) by debbugs.gnu.org; 15 Apr 2020 13:57:48 +0000 Received: from localhost ([127.0.0.1]:36874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOiXz-0007qg-T8 for submit@debbugs.gnu.org; Wed, 15 Apr 2020 09:57:48 -0400 Received: from tobias.gr ([80.241.217.52]:60896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOiXx-0007qX-Bd for 40426@debbugs.gnu.org; Wed, 15 Apr 2020 09:57:46 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id dbd6b910; Wed, 15 Apr 2020 13:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:message-id:references:in-reply-to:date:mime-version :content-type; s=2018; i=me@tobias.gr; bh=uV+SOPqFB5u9yH03YcUbz2 /Mif8XtX60yKyS9XjlqTs=; b=mR0VIumtg3ppuvM0EaT6MsRolZYF3VmDHb5LuG wcXRkFdt68hlNdcEc04sPdBgmb7qhY6JB4Cd6LVw78rRiqYOXadE2oHC6AtP0Y3o WmJxSrMWRCPSCaJFPYqZGOgGyg1DWN+M+shnt90DoCVTreK/pDE62CuQUyCzlNiG sA5nFaFHfgLXye6XmUT8arIcaArCcr/8Ispgu5Cr4e/563gi5c2Dw/QiYeiFS6Ro YflkYV86ouuo1IlbA575CEDxMNdrRzTCPtPsxAGM5/5qI+C+JiUcZeXubrFLhifw Iq6vYEDDooFwVjXlhb6bFdFO7IBekLU0I1ud4WWvJonmGHmg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c26df91c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 15 Apr 2020 13:57:43 +0000 (UTC) From: Tobias Geerinckx-Rice To: Vitaliy Shatrov Subject: Re: [bug#40426] [PATCH] Add g-golf Message-ID: <87ftd426p6.fsf@nckx> References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> In-reply-to: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> Date: Wed, 15 Apr 2020 15:57:03 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40426 Cc: 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vitaliy, Vitaliy Shatrov via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > str1ngs and nly want it to be submitted to guix, and i was=20 > proudly take this task. Package was copied "as-is", and tested=20 > as per Guix manual. Thank you! > There is desire to package be named "g-golf", and not as=20 > "guile-g-golf", as the package name stands for "Gnome: Guile=20 > Object Library For". Too clever for me :-) It's a Guile library; hence the correct=20 Guix name (and variable) is =E2=80=98guile-g-golf=E2=80=99. We have plenty= of=20 =E2=80=98python-pyfoo=E2=80=99 packages to keep it company. > Subject: [PATCH] gnu: Add g-golf > > * gnu/packages/guile-xyz.scm (g-golf): New variable Nitpick: both lines should end with a full stop. > +(define-public g-golf Could you add a comment here explaining why we use a git commit,=20 instead of a release tarball or tag? I assume there are none;=20 that would do as comment. However=E2=80=A6 > + (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7")) > + (package > + (name "g-golf") > + (version (git-version "1" "683" commit)) =E2=80=A6=E2=80=981=E2=80=99 means the project has released version 1 prior= to this=20 commit, or at least regards this commit as part of the =E2=80=981=E2=80=99 = series.=20 I didn't spot any version number on the home page, NEWS file, git=20 tags, =E2=80=A6 If there is no =E2=80=981=E2=80=99 release, use =E2=80=980.0.0=E2=80=99. The second field (REVISION) should be =E2=80=980=E2=80=99, since this is th= e first=20 *Guix* revision of this package. The idea is that you increment=20 the revision each time you change COMMIT, so Guix knows which=20 commit is newer and can =E2=80=98guix package -u=E2=80=99 properly. Since the 2 should be updated together, bind them together: (let ((commit "f00") (revision "0")) =E2=80=A6 You obviously got =E2=80=98683=E2=80=99 from somewhere though. Where? > + `(#:tests? #t Does the guile-build-system disable tests by default? (I skimmed=20 the code but didn't find anything.) Otherwise, this can be=20 omitted. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'tests-work-arounds Prefer =E2=80=98verb-thing=E2=80=99; makes it much easier to skim unfamilia= r=20 packages. In this case we're not really working around the tests themselves,=20 so I'd go with the boring =E2=80=98patch-tests=E2=80=99. + (lambda* (#:key inputs #:allow-other-keys) + ;; In build environment, There is no /dev/tty + (substitute* + "test-suite/tests/gobject.scm" + (("/dev/tty") "/dev/null")))) For now, all phases must return #t. SUBSTITUTE* doesn't, so we=20 need (lambda =E2=80=A6 =E2=80=A6 (substitute* "test-suite/tests/gobject.scm" (("/dev/tty") "/dev/null")) #t) No need to put the file name on its own line here. + (add-before 'configure 'substitute-libs Bytes are cheap: =E2=80=98libraries=E2=80=99. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6XEq8ACgkQ2Imw8BjF STwwfQ/9GmS0s95NsVTc9ZZHJsk88DdNeq1QxtAqkou6Et0fz67nYiGIwwxpgIWM iqqtAtXB/sL0oulycjoJD1r66I9Sv2+mrl6/2Ov1PIe+BLREjhU20K8Ab0RuH3OK VtGewQpPMA4awXG5mS2R6EanKe83Mqk9p8kx2HUgifuiAjSDU5OX657Ai3urjAPc cm8X1pSPTaq2APLb4sHrMIFMdTG7y/KbQ7zH50m521H5HNNVEwUz59+Sl5y2rFmD Dp9DIZlggs6WgAnuj1bwu1v4YvfZ1b1AN02CSFZxJR97+QMCB0pIkkjTIlK5PUTX fuB/3J/glZw1sQldsw5lLo5b1SUsLSnIbJzL5ZwhWHK9is/vCfwaXmiKw1p+Z8Wk pAAkFTGR8DRPcVuYvBzOekjX1yjwffhkxv90solxz6/zrikRWeXs0aNfrAdMAaoN Y1Lkn/MLX7xuHPAFLFzUfU3MVvCsgP3mUSREkczCuAunf9J/ENKnvbakyIRvOv1i Ro4iH2mHFfjo6IZXUmMpHxHDpEGjZhalJ/az2kqk96up1t6fRMgfrmMbAuSTsa5U O0pkeRLt3pxEqKrk01aOSwlLz/ARYBD7g5XtiSCYGq9uqTQaudVlCRX2IrDT9gB3 UP2q7L+Ao6KuB26PKFO2t3yM+yU91R11aPK06cVGhfcfr9Q00RE= =4vjA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 12:47:10 2020 Received: (at submit) by debbugs.gnu.org; 15 Apr 2020 16:47:10 +0000 Received: from localhost ([127.0.0.1]:36998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOlBt-000856-Op for submit@debbugs.gnu.org; Wed, 15 Apr 2020 12:47:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:51541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOlBs-00084z-Ne for submit@debbugs.gnu.org; Wed, 15 Apr 2020 12:47:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37752) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOlBp-0004Iq-QT for guix-patches@gnu.org; Wed, 15 Apr 2020 12:47:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOlBo-00072Q-DQ for guix-patches@gnu.org; Wed, 15 Apr 2020 12:47:05 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:36317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOlBo-00071V-5A for guix-patches@gnu.org; Wed, 15 Apr 2020 12:47:04 -0400 Received: by mail-pg1-x52f.google.com with SMTP id c23so179123pgj.3 for ; Wed, 15 Apr 2020 09:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=hHfD9jFVc0/PWPMoVlnCMFLBpaRWMLA1aO38uX8sxKY=; b=KTzof3ZKPsVNeJH+e+M2JTjRTa8KKKfaqsOwz1k6QjaotB+TG0dJBNuxCmJvX/TqrC tI/SFRmGr9MmGxppbANtaiEuJCiXTR9hjomscoM1pxQgH+p70Fy9riP6vMT3uINfSyJm EbBoKXKrXGhplhjz8HoHlQgLTOKaBHfY8x7l0gOvTGwjuTy75t5BJ5CoPNm0M5LzA7vV CpX5yfMw8a7VyAKdaDKzSPhr1x87CVZrESAg/juJTwlbm6hQOkLTgFhof2v4de6vZ27A qzouj7j/SPwpjNBEg4khRAYwARLQe5EFLQX+uyIRSH5xRkP3Mt1yvntyN2BlGOLVw81m mhcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=hHfD9jFVc0/PWPMoVlnCMFLBpaRWMLA1aO38uX8sxKY=; b=kIrDZZsnBhC9nsABAoIQ+R0uEqai+Lt3iSM3xYeY9IoIF2ZhEjS9XitNgXYtRlhGMa zTKz2vWogor/2yMShkvvqMn71a4VG7Yf5solTXFJ5ZXhXhMC88dobKvFlFGuUhgBhRqf ffPU8BN7u07ioXBhZFWGjk3uIjaAmJQlHlGUNjvNf+CQe7/zVd3QoKXFAUzgwcauvutg EY0r14eqixJLdjsz7uF12UFyYczm+Wf2rt0tD3A6eIvUnQrMhSPBX+5sQmHuQFB6p7RN ozmRNnZiy64nL0t0FZtMpF7Ik/XPEh5Dt1oGzX+PO7DKK8E/oR407cHmUqd5fafMZxWN rtZg== X-Gm-Message-State: AGi0PuZanO6o7kBL0ckCCJ2UuiMn/aGcDbDNPNlK7IULOergnMB6I8he rzBLr/AU6u66D7JEbQTcPUk= X-Google-Smtp-Source: APiQypJ2j9hdDXk7rcw4BSn2XYAuAgbXPSdm/gAHUngxZJv9DEnVDyyp/0phE9gjLDwqbyq0pvD93w== X-Received: by 2002:a65:5a8b:: with SMTP id c11mr19893250pgt.215.1586969222792; Wed, 15 Apr 2020 09:47:02 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id c201sm14421028pfc.73.2020.04.15.09.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 09:47:02 -0700 (PDT) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87ftd426p6.fsf@nckx> User-agent: mu4e 1.2.0; emacs 26.3 From: Mike Rosset To: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches Subject: Re: [bug#40426] [PATCH] Add g-golf In-reply-to: <87ftd426p6.fsf@nckx> Date: Wed, 15 Apr 2020 09:47:01 -0700 Message-ID: <87eesozofu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52f X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Vitaliy Shatrov , 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via writes: > Vitaliy, > > Vitaliy Shatrov via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A >> str1ngs and nly want it to be submitted to guix, and i was proudly >> take this task. Package was copied "as-is", and tested as per Guix >> manual. > > Thank you! Tobias, this has already been merged with dfe277a5ce60d487fe44840506206fea8507bc69. I will though address your comments with this attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-g-golf-Fix-version-to-0.0.0-0.4a4edf2.patch Content-Description: 0001-gnu-g-golf-Fix-version-to-0.0.0-0.4a4edf2.patch >From 1b230e6e000b57bfa3d2b4ef63a894e5e02195d5 Mon Sep 17 00:00:00 2001 From: Mike Rosset Date: Wed, 15 Apr 2020 09:41:10 -0700 Subject: [PATCH] gnu: g-golf: Fix version to 0.0.0-0.4a4edf2 * gnu/packages/guile-xyz.scm (g-golf): Fix version to 0.0.0-0.4a4edf2. --- gnu/packages/guile-xyz.scm | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index ebd7d89dec..58938268e4 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -1652,10 +1652,13 @@ capabilities.") (license license:gpl3+))) (define-public g-golf - (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7")) + (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7") + (revision "0")) (package (name "g-golf") - (version (git-version "1" "683" commit)) + (version (git-version "0.0.0" revision commit)) + ;; g-golf is still work in progress. Since there are no release + ;; tarballs we use git for sources. (source (origin (method git-fetch) (uri (git-reference @@ -1684,13 +1687,13 @@ capabilities.") (arguments `(#:phases (modify-phases %standard-phases - (add-before 'configure 'tests-work-arounds + (add-before 'configure 'substitue-tty-test (lambda* (#:key inputs #:allow-other-keys) ;; In build environment, There is no /dev/tty - (substitute* - "test-suite/tests/gobject.scm" - (("/dev/tty") "/dev/null")))) - (add-before 'configure 'substitute-libs + (substitute* "test-suite/tests/gobject.scm" + (("/dev/tty") "/dev/null") + #t))) + (add-before 'configure 'substitute-libriaries (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((get (lambda (key lib) (string-append (assoc-ref inputs key) "/lib/" lib))) -- 2.26.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Too clever for me :-) It's a Guile library; hence the correct Guix > name (and variable) is =E2=80=98guile-g-golf=E2=80=99. We have plenty of > =E2=80=98python-pyfoo=E2=80=99 packages to keep it company. > No. I can't change this to guile-g-golf. The author of g-golf has explicated stated they would like the package name to be g-golf. > Could you add a comment here explaining why we use a git commit, > instead of a release tarball or tag? I assume there are none; that > would do as comment. However=E2=80=A6 I've added a comment for why git sources are used. > =E2=80=A6=E2=80=981=E2=80=99 means the project has released version 1 pri= or to this commit, or > at least regards this commit as part of the =E2=80=981=E2=80=99 series. I= didn't spot > any version number on the home page, NEWS file, git tags, =E2=80=A6 > > If there is no =E2=80=981=E2=80=99 release, use =E2=80=980.0.0=E2=80=99. > > The second field (REVISION) should be =E2=80=980=E2=80=99, since this is = the first > *Guix* revision of this package. The idea is that you increment the > revision each time you change COMMIT, so Guix knows which commit is > newer and can =E2=80=98guix package -u=E2=80=99 properly. > > Since the 2 should be updated together, bind them together: > > (let ((commit "f00") > (revision "0")) =E2=80=A6 > > You obviously got =E2=80=98683=E2=80=99 from somewhere though. Where? > This is fixed now, this got carried over from me tracking upstream revisions. I've reset it to version 0.0.0 and revision 0. This is probably the most important fix. > Prefer =E2=80=98verb-thing=E2=80=99; makes it much easier to skim unfamil= iar packages. > done > > For now, all phases must return #t. SUBSTITUTE* doesn't, so we need > > (lambda =E2=80=A6 > =E2=80=A6 > (substitute* "test-suite/tests/gobject.scm" > (("/dev/tty") "/dev/null")) > #t) done > No need to put the file name on its own line here. > > + (add-before 'configure 'substitute-libs done --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 15 19:02:42 2020 Received: (at submit) by debbugs.gnu.org; 15 Apr 2020 23:02:42 +0000 Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOr3J-0001Ct-PA for submit@debbugs.gnu.org; Wed, 15 Apr 2020 19:02:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:50599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOr3I-0001Cl-1J for submit@debbugs.gnu.org; Wed, 15 Apr 2020 19:02:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53576) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOr3G-0007WB-Nh for guix-patches@gnu.org; Wed, 15 Apr 2020 19:02:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOr3F-0007W7-MM for guix-patches@gnu.org; Wed, 15 Apr 2020 19:02:38 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:42163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOr3F-0007Vt-Dt for guix-patches@gnu.org; Wed, 15 Apr 2020 19:02:37 -0400 Received: by mail-pf1-x443.google.com with SMTP id r20so719642pfh.9 for ; Wed, 15 Apr 2020 16:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=DTxpe9od5IO/6iD5Osf76IJWMg7kt0U6QZkA2lpVwxg=; b=DpBaEuyfXGndZCZIZ8aGfXdLIwL5HdP/WSv2VyZhU01HIpe0CBo7n2L+h4kyu/pBwF Ph4QSfa6vh14vDT3wnbB2z8qBg3dFEzln7hKcJ9eiUWlZ5Vgli1eAhMm3ApRyb6RXQgb JUIuLhnYCHd9xFZnAmd2HjocIFBEyBCMkkKD69PUiehsAnotFCYN/Vz9o9o8CdHyHSc/ iR95r0RXDag3s+x88WS6cYWhCC4LnqPd5NF6fj0gOcGMAsXqFF4ejgI+MZkeFnWPWATi TtgwrCFHlpFfJYi1WxNNkgO8LQ8JAHZGrAbpmjxPkDsjlwvA8pmcTOd8nAEyK7ks4zwN Va1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=DTxpe9od5IO/6iD5Osf76IJWMg7kt0U6QZkA2lpVwxg=; b=SVz/fu4EuCit2mr3cjiz3xgcT0KD8oPFfu8oLTlN01Rz4uySLEtLH9IuVRKyA6NfSx 0TeMiS/QWjcixPVzp22k2K74MpD4baWGrRoAio8wA2tKowBWo5qnhBPNtNxzGRm5t+qh MnYffxFU3xdY5WWzxsMwR4y3xy63H6KvBg/YBz7i/G1i7ldS5jSIyYx6CEzywwT4HgqL To7BBhpgashtT28Eav9oJvZoCQ+qWVaywmG/Ab/wUhVbgk6LPq/GT9G+ljyCe6B+3kud kiWk+FYI6IcBIWgerorr3hTsO0vi0bNklfe6ePaQEPHHbzNOPpU4u5NEbLqX0Hiag36v tBgw== X-Gm-Message-State: AGi0Pua860groIchfMJfZq5ESxsJ7m7GfdB76YzKvIqfmDNe3kSqOSJC uW2/i2vi9+ldIZw2pKCEIBI= X-Google-Smtp-Source: APiQypLnjawwWGt5soSzMYfTr2BpQoMp3N6hCx+iVHMVMeddaKpJTA7cH0632c8SVMht7lDIo3Kokg== X-Received: by 2002:aa7:8a9a:: with SMTP id a26mr17185280pfc.77.1586991755901; Wed, 15 Apr 2020 16:02:35 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id b2sm13502328pgg.77.2020.04.15.16.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 16:02:35 -0700 (PDT) References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87ftd426p6.fsf@nckx> User-agent: mu4e 1.2.0; emacs 26.3 From: Mike Rosset To: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches Subject: Re: [bug#40426] [PATCH] Add g-golf In-reply-to: <87ftd426p6.fsf@nckx> Date: Wed, 15 Apr 2020 16:02:33 -0700 Message-ID: <87d088z71y.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Vitaliy Shatrov , 40426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via writes: > > =E2=80=A6=E2=80=981=E2=80=99 means the project has released version 1 pri= or to this commit, or > at least regards this commit as part of the =E2=80=981=E2=80=99 series. I= didn't spot > any version number on the home page, NEWS file, git tags, =E2=80=A6 > > If there is no =E2=80=981=E2=80=99 release, use =E2=80=980.0.0=E2=80=99. > > The second field (REVISION) should be =E2=80=980=E2=80=99, since this is = the first > *Guix* revision of this package. The idea is that you increment the > revision each time you change COMMIT, so Guix knows which commit is > newer and can =E2=80=98guix package -u=E2=80=99 properly. > > Since the 2 should be updated together, bind them together: > > (let ((commit "f00") > (revision "0")) =E2=80=A6 Slight change to my follow up patch, version should be 0.1.0. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-g-golf-Fix-version-to-0.1.0-0.4a4edf2.patch >From 31947bce363b87b2f82e98f69704296b22a1be47 Mon Sep 17 00:00:00 2001 From: Mike Rosset Date: Wed, 15 Apr 2020 09:41:10 -0700 Subject: [PATCH] gnu: g-golf: Fix version to 0.1.0-0.4a4edf2 * gnu/packages/guile-xyz.scm (g-golf): Fix version to 0.1.0-0.4a4edf2. --- gnu/packages/guile-xyz.scm | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index ebd7d89dec..f725280ce1 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -1652,10 +1652,13 @@ capabilities.") (license license:gpl3+))) (define-public g-golf - (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7")) + (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7") + (revision "0")) (package (name "g-golf") - (version (git-version "1" "683" commit)) + (version (git-version "0.1.0" revision commit)) + ;; g-golf is still work in progress. Since there are no release + ;; tarballs we use git for sources. (source (origin (method git-fetch) (uri (git-reference @@ -1684,13 +1687,13 @@ capabilities.") (arguments `(#:phases (modify-phases %standard-phases - (add-before 'configure 'tests-work-arounds + (add-before 'configure 'substitue-tty-test (lambda* (#:key inputs #:allow-other-keys) ;; In build environment, There is no /dev/tty - (substitute* - "test-suite/tests/gobject.scm" - (("/dev/tty") "/dev/null")))) - (add-before 'configure 'substitute-libs + (substitute* "test-suite/tests/gobject.scm" + (("/dev/tty") "/dev/null") + #t))) + (add-before 'configure 'substitute-libriaries (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((get (lambda (key lib) (string-append (assoc-ref inputs key) "/lib/" lib))) -- 2.26.0 --=-=-=-- From unknown Sat Aug 09 15:19:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 May 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator