From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 11:20:19 2020 Received: (at submit) by debbugs.gnu.org; 3 Apr 2020 15:20:19 +0000 Received: from localhost ([127.0.0.1]:43032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKO7G-0000Qa-PI for submit@debbugs.gnu.org; Fri, 03 Apr 2020 11:20:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:59212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKO7F-0000QL-Ay for submit@debbugs.gnu.org; Fri, 03 Apr 2020 11:20:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52112) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKO7C-00038Q-OC for bug-guix@gnu.org; Fri, 03 Apr 2020 11:20:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKO7B-00038R-JH for bug-guix@gnu.org; Fri, 03 Apr 2020 11:20:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42047) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKO7A-000364-Oa for bug-guix@gnu.org; Fri, 03 Apr 2020 11:20:13 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5C2B016005E for ; Fri, 3 Apr 2020 17:20:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1585927210; bh=AVx+kK0KdHujHD63l1prRk6msRbRsaHTTi3yyzUweq8=; h=From:To:Subject:Date:From; b=NVxw+dIxK0Jy6z/tc0ts/zbI7DoaHgEsMxStKLqrEGzHbRk7N51zb9uc3MeirLsf6 UtvPsBj2RORYiA/rdDvUI7cToapEm4rMWPdl62K9CzFegHSvTWJYTiKuesYXT+W97t Vb1jzFYKR058euxGynHRNzEdUd47uuSdr7EsZFQCyatIaU94K9ye3h2en1JVKIEmhs 22B8K7htugq83Lqadqn6uiXb0kozTeWIm432XvypUkdG6A4ECwWB4cCzuchINbm3gc N5CsGYLvP2jAHQb1yS4Vg35zJJ/1qodysv5DfTxcrmzwgrihvaOKTqzeC0unD01pIC hnsZHjBtqt1kg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48v3X95FT4z6tmH for ; Fri, 3 Apr 2020 17:20:09 +0200 (CEST) From: Diego Nicola Barbato To: bug-guix@gnu.org Subject: python-matplotlib fails to build on i686-linux Date: Fri, 03 Apr 2020 17:20:08 +0200 Message-ID: <87mu7s1tqv.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.65 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Guix, The package python-matplotlib fails to build during the check phase on i686-linux. The test failure appears to be deterministic: --8<---------------cut here---------------start------------->8--- =================================== FAILURES =================================== _______________________ test_slider_horizontal_vertical ________________________ def test_slider_horizontal_vertical(): fig, ax = plt.subplots() slider = widgets.Slider(ax=ax, label='', valmin=0, valmax=24, valinit=12, orientation='horizontal') slider.set_val(10) assert slider.val == 10 # check the dimension of the slider patch in axes units box = slider.poly.get_extents().transformed(ax.transAxes.inverted()) > assert_allclose(box.bounds, [0, 0, 10/24, 1]) E AssertionError: E Not equal to tolerance rtol=1e-07, atol=0 E E Mismatch: 25% E Max absolute difference: 1.11022302e-16 E Max relative difference: 2.66453526e-16 E x: array([ 0.000000e+00, -2.310706e-18, 4.166667e-01, 1.000000e+00]) E y: array([0. , 0. , 0.416667, 1. ]) /gnu/store/8g8yfikj63wf0y3hwvpk00hqj5wpfs7v-python-matplotlib-3.1.2/lib/python3.7/site-packages/matplotlib/tests/test_widgets.py:333: AssertionError --8<---------------cut here---------------end--------------->8--- Im currently on commit 151f3d4. Regards, Diego From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 12:18:12 2020 Received: (at 40406) by debbugs.gnu.org; 3 Apr 2020 16:18:13 +0000 Received: from localhost ([127.0.0.1]:43078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKP1I-0005t9-Mj for submit@debbugs.gnu.org; Fri, 03 Apr 2020 12:18:12 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKP1G-0005sc-VX for 40406@debbugs.gnu.org; Fri, 03 Apr 2020 12:18:11 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 96C025C0381; Fri, 3 Apr 2020 12:18:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 03 Apr 2020 12:18:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=2aNYxuTNgQIFVQhdVIH0nSdj rz7DZmFxsv1u/CgtHGQ=; b=JOrguuYozCp2UEr27YyhETq0db59Eg8n2AcAZo5n E5HTwP9YYfNbMkWfVYw9EbqmVwnt/ltp37WWWxVAe4EPvSnJvAgsD2+cBAMYoZql TWNek9qID46XMGP2UQDYBf7LA7OwFpBdBqaKuvKGXIt3DaTSDboaDj4CtJ5kQkcE Onk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2aNYxu TNgQIFVQhdVIH0nSdjrz7DZmFxsv1u/CgtHGQ=; b=vMc3KdWZqQZid239zAjNUG FjcaPeF374JDYkFP1gHhvBRV/5pYX9WKgQmPHla6aBaEn5MQxuHGTCanAWK+unxX 9gJiw2JgcCtzWjrt6ACid/mVScrLydQ8azPkdVojaZnJWj5DVmFdUQ71V/FdKyxV RZYVeUJmVbF6lUvB0vuvUsITZfK+i1V4fdQKm6L6Ibq9qdwKltMZ6I+5MA0dfeAb GdpsLY9BB/m0L59pMTYwTE7lMQ8iflZDzyRFBRaBxs1cs/CllZx6ikezgvvNlyAI MiLS5LbXtmq16vqgGy4ZwSnt1+ve6mmpQnCwN61q7Yvgu4oimLRh6YN6vB4I67xA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeigdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejiedrud dvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id E09C9306CFFB; Fri, 3 Apr 2020 12:18:04 -0400 (EDT) Date: Fri, 3 Apr 2020 12:18:02 -0400 From: Leo Famulari To: Diego Nicola Barbato Subject: Re: bug#40406: python-matplotlib fails to build on i686-linux Message-ID: <20200403161802.GA3560@jasmine.lan> References: <87mu7s1tqv.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mu7s1tqv.fsf@GlaDOS.home> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40406 Cc: 40406@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Apr 03, 2020 at 05:20:08PM +0200, Diego Nicola Barbato wrote: > The package python-matplotlib fails to build during the check phase on > i686-linux. The test failure appears to be deterministic: I wonder if this scientific computing stuff should be tried on i686 at all. Should we limit it to contemporary architectures? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 12:18:37 2020 Received: (at 40406) by debbugs.gnu.org; 2 Jun 2020 16:18:37 +0000 Received: from localhost ([127.0.0.1]:40737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg9cb-0001IZ-1V for submit@debbugs.gnu.org; Tue, 02 Jun 2020 12:18:37 -0400 Received: from mout02.posteo.de ([185.67.36.66]:56057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg9ca-0001IN-2L for 40406@debbugs.gnu.org; Tue, 02 Jun 2020 12:18:36 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A3EFF2400FC for <40406@debbugs.gnu.org>; Tue, 2 Jun 2020 18:18:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1591114709; bh=KbE07kq9Cmp9Gq1BYAqaW2sEH5ycHhtRvAgpLfAb3Ks=; h=From:To:Cc:Subject:Date:From; b=memyWeZWHnomWpNBIYIX11N1Bt0gIbcoYia1pGmLT4W9g97Guw368sTja2TzDMsfd gutLlrdInxMmvhZyE5ehfqcP08txxsmuh4zTYQnX/vCEiT8X5iqQbQqpuSiNzK+abp spiVUlMj9OKI424YocoQ6vRNcfWQiVwqrEKFG7OA+0N93altOoisKyrzj7ozYfzgnJ Ls8ug7Tsf9wQsP6PhWwZOIImruNOA2OizcbLrLNyd56wqY87NhCjQjGkseZt7mCplu kF1x1diMokqm6mMuugs6EQ5GPsqgnSwFOuMriMMEytcWu19pZYZ39Y0ciu3WNOYzau OtbtIsU24jEgg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49bxzm6vSFz9rxc; Tue, 2 Jun 2020 18:18:28 +0200 (CEST) From: Diego Nicola Barbato To: Leo Famulari Subject: Re: bug#40406: python-matplotlib fails to build on i686-linux References: <87mu7s1tqv.fsf@GlaDOS.home> <20200403161802.GA3560@jasmine.lan> Date: Tue, 02 Jun 2020 18:18:28 +0200 In-Reply-To: <20200403161802.GA3560@jasmine.lan> (Leo Famulari's message of "Fri, 3 Apr 2020 12:18:02 -0400") Message-ID: <878sh5a1bf.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40406 Cc: 40406@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Leo Famulari writes: > On Fri, Apr 03, 2020 at 05:20:08PM +0200, Diego Nicola Barbato wrote: >> The package python-matplotlib fails to build during the check phase on >> i686-linux. The test failure appears to be deterministic: I've taken a closer look at the failing test (on x86_64-linux, commit: ebbf915) by keeping the build tree ... --8<---------------cut here---------------start------------->8--- guix build --no-grafts -s i686-linux --keep-failed python-matplotlib --8<---------------cut here---------------end--------------->8--- ... and running python inside of it. --8<---------------cut here---------------start------------->8--- cd /tmp/guix-build-python-matplotlib-3.1.2.drv-0/matplotlib-3.1.2/ . ../environment-variables export PYTHONPATH="${PYTHONPATH}:build/lib.linux-i686-3.8" python3 --8<---------------cut here---------------end--------------->8--- I retraced the steps of the failing test ... --8<---------------cut here---------------start------------->8--- import matplotlib.pyplot as plt import matplotlib.widgets as widgets from numpy.testing import assert_allclose fig, ax = plt.subplots() slider = widgets.Slider(ax=ax, label='', valmin=0, valmax=24, valinit=12, orientation='horizontal') slider.set_val(10) box = slider.poly.get_extents().transformed(ax.transAxes.inverted()) assert_allclose(box.bounds, [0, 0, 10/24, 1]) --8<---------------cut here---------------end--------------->8--- ... and was able to reproduce the failing assertion ... --8<---------------cut here---------------start------------->8--- AssertionError: Not equal to tolerance rtol=1e-07, atol=0 Mismatch: 25% Max absolute difference: 1.11022302e-16 Max relative difference: 2.66453526e-16 x: array([ 0.000000e+00, -1.046255e-17, 4.166667e-01, 1.000000e+00]) y: array([0. , 0. , 0.416667, 1. ]) --8<---------------cut here---------------end--------------->8--- ... , although the differing value wasn't exactly the same as the one reported by the test. As expected, the assertion did not fail when I followed the same steps on x86_64. --8<---------------cut here---------------start------------->8--- guix environment --ad-hoc python python-matplotlib -- python3 --8<---------------cut here---------------end--------------->8--- A closer look at the intermediate results ... --8<---------------cut here---------------start------------->8--- print(slider.poly.get_extents().bounds, ax.transAxes.get_matrix(), ax.transAxes.inverted().get_matrix(), box.bounds, sep='\n') --8<---------------cut here---------------end--------------->8--- ... revealed that only the values of box.bounds differ. The dimensions of the slider are the same (as are the values of the transformation matrices) on i686-linux ... --8<---------------cut here---------------start------------->8--- (80.0, 52.8, 206.66666666666663, 369.59999999999997) [[496. 0. 80. ] [ 0. 369.6 52.8] [ 0. 0. 1. ]] [[ 0.00201613 0. -0.16129032] [ 0. 0.00270563 -0.14285714] [ 0. 0. 1. ]] (0.0, -1.0462550964485118e-17, 0.4166666666666666, 1.0) --8<---------------cut here---------------end--------------->8--- ... and on x86_64-linux. --8<---------------cut here---------------start------------->8--- (80.0, 52.8, 206.66666666666663, 369.59999999999997) [[496. 0. 80. ] [ 0. 369.6 52.8] [ 0. 0. 1. ]] [[ 0.00201613 0. -0.16129032] [ 0. 0.00270563 -0.14285714] [ 0. 0. 1. ]] (0.0, 0.0, 0.41666666666666663, 1.0000000000000002) --8<---------------cut here---------------end--------------->8--- Apparently there is nothing wrong with the slider. Instead matrix multiplication, which is used under the hood for transformations, seems to sometimes produce incorrect results on i686-linux. I have reported this as a separate bug (https://debbugs.gnu.org/41665). > I wonder if this scientific computing stuff should be tried on i686 at > all. Should we limit it to contemporary architectures? I was opposed to this at first (after all, if upstream supports Numpy on i686, why shouldn't we?), but after seeing that even simple things like matrix multiplication can produce incorrect results I'm in favour of limiting it to contemporary architectures. What do others think? Regards, Diego From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 13:39:25 2020 Received: (at 40406) by debbugs.gnu.org; 2 Jun 2020 17:39:25 +0000 Received: from localhost ([127.0.0.1]:40848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgAsn-0003H3-G7 for submit@debbugs.gnu.org; Tue, 02 Jun 2020 13:39:25 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgAsm-0003Gq-12 for 40406@debbugs.gnu.org; Tue, 02 Jun 2020 13:39:24 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D91735C00EE; Tue, 2 Jun 2020 13:39:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 02 Jun 2020 13:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=u1tOHg5xXtEcRdb6uuhQDRl/ H7/uiIdrOgOBw5XH9L4=; b=jtyg67W0rg4MxKYhrK6/r/gpEApos4nQdil0t1+4 Nf2wkyhx2KqrMX77GU1LDyLwA6El8SP7eU5ZKbgB2cuDLKMvwRPVJANCH/HOUSGC DyuPqUcxqblctQHkrhjDQ5aIj6sp8RjmXV7g+x9RKUxmWSYQ2uC71HlsknTZxjDR epc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=u1tOHg 5xXtEcRdb6uuhQDRl/H7/uiIdrOgOBw5XH9L4=; b=3d9KPAHk/j75Dvowf5oqbN XSvGeDjw5jnaj8Njmx8466VVA5Q6NV/BaYQnzxaZKk8bgEku0pOttXxO9uF6pAFy KKmENC9Ys4gR1DZGI48o7WP7iV+Ej/Z/sr180tTQJnanc605tr//a/i3Zw9oz6HY ePDN3kVJhoEOAiJD3amlkslSzRDfjztvowwUOh3wdByy1RQ05vKHw1DWj+iGDXHk KgenUmkbahDRAIGPvIpcm0pgfXLCw0lXLCh8xzndDD9RhAWbeI9+XgkPvUWJN+Fk skuBzWhRQvzAzr1sz/U0iDeJjgy+0WWGF5W+1eJ8T2JNArHv8bVaxdf//oWK8MkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefjedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 66A653280059; Tue, 2 Jun 2020 13:39:18 -0400 (EDT) Date: Tue, 2 Jun 2020 13:39:16 -0400 From: Leo Famulari To: Diego Nicola Barbato Subject: Re: bug#40406: python-matplotlib fails to build on i686-linux Message-ID: <20200602173916.GB19317@jasmine.lan> References: <87mu7s1tqv.fsf@GlaDOS.home> <20200403161802.GA3560@jasmine.lan> <878sh5a1bf.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878sh5a1bf.fsf@GlaDOS.home> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40406 Cc: 40406@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Jun 02, 2020 at 06:18:28PM +0200, Diego Nicola Barbato wrote: > I was opposed to this at first (after all, if upstream supports Numpy on > i686, why shouldn't we?), but after seeing that even simple things like > matrix multiplication can produce incorrect results I'm in favour of > limiting it to contemporary architectures. What do others think? I'll leave it up to you and others who are actually using these programs. I do think it's unlikely the upstream developers use or test the software on i686, or on anything besides x86_64. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 10:23:05 2020 Received: (at 40406) by debbugs.gnu.org; 8 Jun 2020 14:23:05 +0000 Received: from localhost ([127.0.0.1]:57592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiIg1-0003tz-Vp for submit@debbugs.gnu.org; Mon, 08 Jun 2020 10:23:05 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiIfz-0003tD-Uy for 40406@debbugs.gnu.org; Mon, 08 Jun 2020 10:23:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A336916005F for <40406@debbugs.gnu.org>; Mon, 8 Jun 2020 16:22:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1591626173; bh=A2qQCj8TijuyOpQe0KGu3BGzk5pthThp5swE0fiEFGs=; h=From:To:Cc:Subject:Date:From; b=kvMHzOJ9GV7uuFmQRy+7lYskm/YiF8Rx4XsSSBIvipn7x+opHZJhf4oETaGcScFk5 Sd/W6h3zC2Ep4oDyIk5+mR3Z/w6r+xdrMA8cSHeNWy5R+uBEoPvb3R7sfExDCthrB3 kzRrdfn5/VOsLZGDPOHqKnUC9S1lYPt/aag7MoRi5knJbZM6Sffg67p3j5YKMRqZqV qAZw8Xoaeumcu8yu6nkTePKWTtIT4HfKoM3i187o4F5A+lFp7Rftw0042gAyvHGCaQ mElN+QiYawmaEHTbV3DPq0vdaRX3zjF17On15qlc71yq0JUqwltRfzgeAX7+fFGMFy 5M4pp2Wy1S5rA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49gb7c63Pyz6tmT; Mon, 8 Jun 2020 16:22:52 +0200 (CEST) From: Diego Nicola Barbato To: 40406@debbugs.gnu.org Subject: Re: bug#40406: python-matplotlib fails to build on i686-linux References: <87mu7s1tqv.fsf@GlaDOS.home> <20200403161802.GA3560@jasmine.lan> <878sh5a1bf.fsf@GlaDOS.home> Date: Mon, 08 Jun 2020 16:22:52 +0200 In-Reply-To: <878sh5a1bf.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Tue, 02 Jun 2020 18:18:28 +0200") Message-ID: <87zh9d8wn7.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40406 Cc: Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hey, Diego Nicola Barbato writes: [...] > Apparently there is nothing wrong with the slider. Instead matrix > multiplication, which is used under the hood for transformations, seems > to sometimes produce incorrect results on i686-linux. I have reported > this as a separate bug (https://debbugs.gnu.org/41665). I got this wrong: This issue isn't caused by the Numpy bug, since Matplotlib doesn't use Numpy for transformations. Both bugs are caused by the excess precision of the x87 FPU's floating point registers. I've attached a patch which makes sure that the C and C++ extensions are compiled with -ffloat-store. This doesn't get rid of all possible rounding errors but it's enough for the slider test to pass. [...] Regards, Diego --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-python-matplotlib-Fix-rounding-errors-on-x86-CPU.patch Content-Transfer-Encoding: quoted-printable >From 7c60615e29a1aab7922139183d191cc8cedd5c7f Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Mon, 8 Jun 2020 02:31:17 +0200 Subject: [PATCH] gnu: python-matplotlib: Fix rounding errors on x86 CPUs. Fixes . Reported by Diego Nicola Barbato . * gnu/packages/python-xyz.scm (python-matplotlib)[arguments]: Set the environment variable CFLAGS to -ffloat-store. --- gnu/packages/python-xyz.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 94e63d1c74..f0b96c6fb0 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -81,6 +81,7 @@ ;;; Copyright =C2=A9 2020 Josh Holland ;;; Copyright =C2=A9 2020 Yuval Kogman ;;; Copyright =C2=A9 2020 Michael Rohleder +;;; Copyright =C2=A9 2020 Diego N. Barbato ;;; ;;; This file is part of GNU Guix. ;;; @@ -4744,6 +4745,10 @@ convert between colorspaces like sRGB, XYZ, CIEL*a*b= *, CIECAM02, CAM02-UCS, etc. ;; has not effect. (setenv "LD_LIBRARY_PATH" (string-append cairo "/lib")) (setenv "HOME" (getcwd)) + ;; Fix rounding errors when using the x87 FPU. + ,@(if (string-prefix? "i686" (%current-system)) + '((setenv "CFLAGS" "-ffloat-store")) + '()) (call-with-output-file "setup.cfg" (lambda (port) (format port "[directories]~% --=20 2.26.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 22:14:19 2020 Received: (at 40406-done) by debbugs.gnu.org; 15 Nov 2020 03:14:19 +0000 Received: from localhost ([127.0.0.1]:52336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke8Ud-00004u-Dh for submit@debbugs.gnu.org; Sat, 14 Nov 2020 22:14:19 -0500 Received: from mail-qv1-f52.google.com ([209.85.219.52]:37499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke8UZ-0008WM-4G for 40406-done@debbugs.gnu.org; Sat, 14 Nov 2020 22:14:18 -0500 Received: by mail-qv1-f52.google.com with SMTP id v20so3780057qvx.4 for <40406-done@debbugs.gnu.org>; Sat, 14 Nov 2020 19:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2+pddeo1yWW51vWWu/0F4btsF96za1ToDatf2efrdEc=; b=sM5Xh/vC2OX2Q4Htc27YZ21SO3BmiQIwyWsCMAm/gdGB5w4lHUbtQtVb3m55hEkdZH DwsXcaf1Sx4iy1/KVTwXnj3xpHxFHa4yh7kq81tagmtDNxf/7u9zoypvTSH/MZrl3ATx IIaIVpRyZFNkFKhI6Ml0DoKfJSO4ukpzSjlJAA72GUUgX9jlq3Q9eUukYmaWFqwEulVC O+8FiCkCAsttje/+pDPBziiX+8vZzEJ86cJuV2iFGDoGtRudAK5ZPi3pZXoVgbt3N/9Q j4O6Bh39bO8R0DXdWOVbhT7wlgNJAFMFob2/k7DTmrQl52ZqLVZ1wrkI1hlP0Lrgc752 tFug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2+pddeo1yWW51vWWu/0F4btsF96za1ToDatf2efrdEc=; b=qO0+mYw8A1MQZ3Tu7P5k5K8MHFMwaHSc3C9aeJABAXM5OxrCTgW+Rb8YRIZs7Hkump qIPOIjxdwq34XFiCK29MOt5lTOyRdwz/PmeqG7U7kwm6olAEz9Snsie+GDRHI/+vyBeO jyeCiahHH9C/i6fNzCnNU43oAa9b8+lGEx6LQ0B2BRQAMRVvj0mrwiwoJtQx+ZF9kVka YSYmkiGYnqrT/HYOTxlPxoiY0DhzsvTrJkjurhtKNHsaC5WrlcskFU0GkU9NKT+uYKy7 wKsjIgMSBea3gkaSxJ30fFoIsuNwTcu2QNgeKunviuGIVMaxKC3je70PLRcbeQTO+Oob txww== X-Gm-Message-State: AOAM5329AKTHgBbrCNO7tZgh+a5PzKhh6v168rgMuvoIbE1IRuvS14g9 JhY7WiEZaeXTu8WvcHqu1ex0CiYcno0= X-Google-Smtp-Source: ABdhPJzqs184OaXeUaK7bJRgsiNjdjugDWnWxUj1Z8ZMMF9pkeVOuiBGHfrlI6heEi/wyMIgioSlvQ== X-Received: by 2002:a05:6214:10cb:: with SMTP id r11mr9720040qvs.17.1605410049664; Sat, 14 Nov 2020 19:14:09 -0800 (PST) Received: from hurd (dsl-10-128-91.b2b2c.ca. [72.10.128.91]) by smtp.gmail.com with ESMTPSA id r16sm9178977qta.14.2020.11.14.19.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 19:14:09 -0800 (PST) From: Maxim Cournoyer To: Diego Nicola Barbato Subject: Re: bug#40406: python-matplotlib fails to build on i686-linux References: <87mu7s1tqv.fsf@GlaDOS.home> <20200403161802.GA3560@jasmine.lan> <878sh5a1bf.fsf@GlaDOS.home> <87zh9d8wn7.fsf@GlaDOS.home> Date: Sat, 14 Nov 2020 22:14:08 -0500 In-Reply-To: <87zh9d8wn7.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Mon, 08 Jun 2020 16:22:52 +0200") Message-ID: <877dqnfh1b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40406-done Cc: 40406-done@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Diego, Diego Nicola Barbato writes: > Hey, > > Diego Nicola Barbato writes: > > [...] > >> Apparently there is nothing wrong with the slider. Instead matrix >> multiplication, which is used under the hood for transformations, seems >> to sometimes produce incorrect results on i686-linux. I have reported >> this as a separate bug (https://debbugs.gnu.org/41665). > > I got this wrong: This issue isn't caused by the Numpy bug, since > Matplotlib doesn't use Numpy for transformations. Both bugs are caused > by the excess precision of the x87 FPU's floating point registers. > > I've attached a patch which makes sure that the C and C++ extensions are > compiled with -ffloat-store. This doesn't get rid of all possible > rounding errors but it's enough for the slider test to pass. Thanks for the investigationd and workaround! I've tested it and it seems to work well. I've pushed a slightly modified version to master as commit 81643c4cf3e61f5a98b92a72a92c230f5e7ca905. Thank you! Closing. Maxim From unknown Mon Aug 11 18:15:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Dec 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator