Subject: bug#40405: System log files are world readable

From: Ludovic Courtès <[email-masked]>
Date: Wed, 22 Apr 2020 22:04:23 +0200

Hi,

Ludovic Courtès <[email-masked]> skribis:

> Diego Nicola Barbato <[email-masked]> skribis:
>
>>>>From 43c9ded791ce5b480504ce3528ee34578168f90e Mon Sep 17 00:00:00 2001
>> From: Diego Nicola Barbato <[email-masked]>
>> Date: Tue, 7 Apr 2020 13:58:28 +0200
>> Subject: [PATCH 1/2] service: Create log files as non-world-readable.
>>
>> * modules/shepherd/service.scm (exec-command): Create log-file with file
>>   permissions #o640.
>
> [...]
>
>>>>From e491436967a912e6e7372f582b3bf5c9784b8209 Mon Sep 17 00:00:00 2001
>> From: Diego Nicola Barbato <[email-masked]>
>> Date: Tue, 7 Apr 2020 13:38:47 +0200
>> Subject: [PATCH 2/2] service: Add #:file-creation-mask to
>>  'make-forkexec-constructor'.
>>
>> * modules/shepherd/service.scm (exec-command): Add #:file-creation-mask
>>   parameter and honor it.
>>   (fork+exec-command): Add #:file-creation-mask parameter and pass it to
>>   exec-command.
>>   (make-forkexec-constructor): Add #:file-creation-mask parameter and pass it
>>   to fork+exec-command.
>> * doc/shepherd.texi (Service De- and Constructors): Adjust accordingly.
>
> I went ahead and pushed these two patches.

These patches are in Shepherd 0.8.0, which was pushed in Guix master
commit e3358a831e7d5d9e8dc614340e49ea5aeb11a7ff, so we’re done!

Ludo’.